Hi Niti,
That patch series is a good starting point, since the OVS code generally
assumes that all packets have an Ethernet header, and the patches relax
that assumption. Simon Horman just posted a rebased version of the
series here: http://openvswitch.org/pipermail/dev/2016-January/064686.html
Y
Hi,
On 10/1/15 2:38 PM, niti Rohilla wrote:
> Hi All,
>
> I tried to create a lisp tunnel on ovs stable version 2.3.2 and i am
> getting the following error:
>
> ovs-vsctl add-port br0 lisp0 -- set interface lisp0 type=lisp
> options:remote_ip=192.168.1.45 options:key=5001
> ovs-vsctl: Error detec
On 2/20/15 11:36 PM, Thomas Graf wrote:
On 02/20/15 at 10:50am, Jesse Gross wrote:
LISP can also take advantage of setup_udp_tunnel_sock() and
udp_tunnel_xmit_skb() to increase code reuse.
Signed-off-by: Jesse Gross
Lori should look this over as well but it looks like a straight
forward trans
Sorry to insist, but can you guys (Jesse/Pravin/Jarno) please look at
this and give your opinion so Thomas and I know how to proceed?
-Lori
On 01/23/2015 02:45 PM, Lori Jakab wrote:
> On 1/20/15 12:52 PM, Thomas Morin wrote:
>> Hi Jarno, Lori,
>>
>> On 12/10/2014 02:45 AM,
On 1/20/15 12:52 PM, Thomas Morin wrote:
Hi Jarno, Lori,
On 12/10/2014 02:45 AM, Jarno Rajahalme wrote:
We should add a new metadata key field OVS_KEY_ATTR_PACKET_ETHERTYPE,
that contains the ethertype of the associated packet attribute. While
this would be strictly needed only for L3 packets,
On 12/10/2014 02:45 AM, Jarno Rajahalme wrote:
>
> On Dec 9, 2014, at 11:06 AM, Lori Jakab wrote:
>
>> On 11/21/2014 02:20 AM, Jesse Gross wrote:
>>> On Thu, Nov 20, 2014 at 4:06 PM, Jarno Rajahalme
>>> wrote:
>>>> On Nov 20, 2014, at 12:18 PM,
On 11/21/2014 02:20 AM, Jesse Gross wrote:
> On Thu, Nov 20, 2014 at 4:06 PM, Jarno Rajahalme
> wrote:
>> On Nov 20, 2014, at 12:18 PM, Jesse Gross wrote:
>>
>> On Thu, Nov 20, 2014 at 10:35 AM, Jarno Rajahalme
>> wrote:
>>
>> The netlink key for flow put is serialized from struct flow, so even
On 12/08/2014 06:47 AM, Pravin Shelar wrote:
> Since the beginning OVS kernel datapath development is primarily done
> on external OVS repo. Now we have mostly synced upstream and external
> OVS. So we have decided to change this process. New process is as
> follows.
Patch series that have previou
Jesse, Jarno,
On 11/18/14 1:36 AM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 2:37 PM, Lori Jakab wrote:
On 11/18/14 12:33 AM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 1:50 PM, Lori Jakab wrote:
On 11/17/14 8:03 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote
On 11/18/14 12:33 AM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 1:50 PM, Lori Jakab wrote:
On 11/17/14 8:03 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 54510c8..8ca3469 100644
--- a
On 11/17/14 8:03 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
diff --git a/datapath/flow.c b/datapath/flow.c
index b01f7bd..3caa364 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -462,7 +462,6 @@ static int key_extract(struct sk_buff *skb, struct
sw_flow_k
On 11/17/14 8:48 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 10:46 AM, Lori Jakab wrote:
On 11/17/14 8:28 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
diff --git a/datapath/flow.c b/datapath/flow.c
index 69b13b3..b01f7bd 100644
--- a/datapath/flow.c
+++ b
On 11/17/14 8:28 PM, Jesse Gross wrote:
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
diff --git a/datapath/flow.c b/datapath/flow.c
index 69b13b3..b01f7bd 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -459,28 +459,31 @@ static int key_extract(struct sk_buff *skb, struct
sw_flow
On 11/14/14 11:02 PM, Jesse Gross wrote:
On Fri, Nov 14, 2014 at 3:51 AM, Lorand Jakab wrote:
diff --git a/datapath/datapath.c b/datapath/datapath.c
index 3607170..3ecb3cc 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -570,6 +558,23 @@ static int ovs_packet_cmd_execute(struct sk
On 11/7/14 8:50 AM, Pravin Shelar wrote:
On Thu, Nov 6, 2014 at 12:21 PM, Lori Jakab wrote:
On 11/6/14 4:06 AM, Pravin Shelar wrote:
Have you tried running GSO traffic over lisp using OVS compat GSO code
and upstream GSO code?
I haven't and I'm not sure what's the right way
On 11/6/14 7:17 PM, Pravin Shelar wrote:
On Thu, Nov 6, 2014 at 7:53 AM, Jesse Gross wrote:
On Wed, Nov 5, 2014 at 6:06 PM, Pravin Shelar wrote:
On Wed, Nov 5, 2014 at 10:19 AM, Lori Jakab wrote:
On 11/5/14 12:16 AM, Pravin Shelar wrote:
On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote
On 11/6/14 4:06 AM, Pravin Shelar wrote:
+static int push_eth(struct sk_buff *skb, const struct
ovs_action_push_eth *ethh)
+{
+ /* De-accelerate any hardware accelerated VLAN tag added to a
previous
+* Ethernet header */
+ if (unlikely(vlan_tx_tag_present(skb))) {
+
On 11/6/14 12:36 AM, Ben Pfaff wrote:
On Mon, Nov 03, 2014 at 11:36:30PM +0200, Lorand Jakab wrote:
This commit relaxes the assumption that all packets have an Ethernet
header, and adds support for layer 3 flows. For each packet received on
the Linux kernel datapath the l2 and l3 members of str
Thanks for reviewing Pravin.
On 11/5/14 12:16 AM, Pravin Shelar wrote:
On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote:
Implementation of the pop_eth and push_eth actions in the kernel, and
layer 3 flow support.
Signed-off-by: Lorand Jakab
---
datapath/actions.c| 85
Thanks for the quick turnaround Jesse. See inline.
On 11/3/14 7:46 PM, Jesse Gross wrote:
On Mon, Nov 3, 2014 at 6:31 AM, Lorand Jakab wrote:
diff --git a/datapath/flow.c b/datapath/flow.c
index a3c5d2f..fea26ae 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -458,28 +458,31 @@ static i
On 11/1/14 1:03 AM, Jesse Gross wrote:
On Thu, Oct 9, 2014 at 3:34 AM, Lori Jakab wrote:
On 9/12/14 12:26 AM, Jesse Gross wrote:
On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote:
--- a/datapath/flow_netlink.c
+++ b/datapath/flow_netlink.c
@@ -1831,6 +1831,8 @@ static int
Thomas,
I really find this work of moving the documentation to Markdown very
useful, thanks for spending time on it!
I have two suggestions about the way files are linked.
First, I would use the new file name in the link, for example
[CONTRIBUTING.md](CONTRIBUTING.md) instead of
[CONTRIBUTI
Hi Jesse,
Sorry for the long delay in replying to the thread, was busy with
OpenDaylight. See inline below:
On 9/12/14 12:26 AM, Jesse Gross wrote:
On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote:
On 8/25/14 3:33 AM, Jesse Gross wrote:
On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote
On 8/25/14 3:33 AM, Jesse Gross wrote:
On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote:
On 8/6/14 4:37 AM, Jesse Gross wrote:
Besides the fact that it would be nice to unify things, I'm not sure
that it is actually correct to pull off VLAN, MPLS, etc. tags that we
don't
On 8/2/14 4:11 AM, Jesse Gross wrote:
On Fri, Aug 1, 2014 at 3:19 PM, Lori Jakab wrote:
On 8/1/14, 3:25 AM, Jesse Gross wrote:
On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote:
On 7/31/14, 10:09 AM, Jesse Gross wrote:
On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote:
diff --git a
On 8/6/14 4:37 AM, Jesse Gross wrote:
On 8/2/14, 4:11 AM, Jesse Gross wrote:
On Fri, Aug 1, 2014 at 3:19 PM, Lori Jakab wrote:
On 8/1/14, 3:25 AM, Jesse Gross wrote:
On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote:
On 7/31/14, 10:09 AM, Jesse Gross wrote:
Going further, what happens if
Hi Jesse,
I'll be on vacation starting tomorrow, it looks like this won't be
merged for at least another two weeks.
Replies on discussion points in-line below:
On 8/2/14, 4:11 AM, Jesse Gross wrote:
On Fri, Aug 1, 2014 at 3:19 PM, Lori Jakab wrote:
On 8/1/14, 3:25 AM, Jesse G
On 8/1/14, 3:25 AM, Jesse Gross wrote:
On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote:
On 7/31/14, 10:09 AM, Jesse Gross wrote:
On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote:
diff --git a/datapath/actions.c b/datapath/actions.c
index cb26ad5..20c66f5 100644
--- a/datapath/actions.c
On 7/31/14, 10:09 AM, Jesse Gross wrote:
On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote:
Implementation of the pop_eth and push_eth actions in the kernel, and
layer 3 flow support.
Signed-off-by: Lorand Jakab
Thank you for your patience on this.
Thanks for finding the time to review i
On 7/9/14, 4:50 PM, Thomas Graf wrote:
On 06/27/14 at 04:21pm, Lorand Jakab wrote:
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index cb89e72..b5add78 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -260,6 +260,25 @@ odp_execute_actions__(void *dp, struct dpif_packet
**packets,
On 7/7/14, 7:23 PM, Ben Pfaff wrote:
On Fri, Jun 27, 2014 at 04:21:54PM +0300, Lorand Jakab wrote:
This commit relaxes the assumption that all packets have an Ethernet
header, and adds support for layer 3 flows. For each packet received on
the Linux kernel datapath the l2 and l3 members of stru
On 7/7/14, 7:03 PM, Ben Pfaff wrote:
On Fri, Jun 27, 2014 at 04:21:52PM +0300, Lorand Jakab wrote:
This series implements support for layer 3 ports, of which we have one example
so far, the LISP vport. LISP support is currently implemented with a hack, by
adding/removing the Ethernet header wi
On 7/4/14, 9:14 AM, YAMAMOTO Takashi wrote:
Suppress a gcc warning which was introduced by
commit e0b48482c16b6eaa7f14d8c7e7c6275528881b9e.
("util: create a copy of program_name")
I guess MSVC doesn't have a corresponding warning.
Signed-off-by: YAMAMOTO Takashi
Acked-by: Lorand Jakab
___
On 7/4/14, 12:51 AM, Ansis Atteka wrote:
On Thu, Jul 3, 2014 at 12:57 PM, Ben Pfaff wrote:
On Sat, Jun 28, 2014 at 02:03:15PM -0700, Ansis Atteka wrote:
From: Ansis
Commit 8a9562 ("dpif-netdev: Add DPDK netdev.") reversed sequence
in which set_program_name() and proctitle_init() functions ar
On 6/27/14, 4:25 PM, Lori Jakab wrote:
On 6/25/14, 6:58 PM, Lori Jakab wrote:
On 6/25/14, 5:19 AM, Jesse Gross wrote:
On Wed, Jun 18, 2014 at 9:45 PM, Jesse Gross wrote:
On Tue, Jun 17, 2014 at 12:21 PM, Lori Jakab
wrote:
Hi Jesse,
On 5/23/14, 2:07 AM, Jesse Gross wrote:
On Tue, May 20
On 6/25/14, 6:58 PM, Lori Jakab wrote:
On 6/25/14, 5:19 AM, Jesse Gross wrote:
On Wed, Jun 18, 2014 at 9:45 PM, Jesse Gross wrote:
On Tue, Jun 17, 2014 at 12:21 PM, Lori Jakab wrote:
Hi Jesse,
On 5/23/14, 2:07 AM, Jesse Gross wrote:
On Tue, May 20, 2014 at 9:27 PM, Lori Jakab
wrote:
On
On 6/25/14, 5:19 AM, Jesse Gross wrote:
On Wed, Jun 18, 2014 at 9:45 PM, Jesse Gross wrote:
On Tue, Jun 17, 2014 at 12:21 PM, Lori Jakab wrote:
Hi Jesse,
On 5/23/14, 2:07 AM, Jesse Gross wrote:
On Tue, May 20, 2014 at 9:27 PM, Lori Jakab wrote:
On 5/21/14, 4:10 AM, Jesse Gross wrote
Hi Jesse,
On 5/23/14, 2:07 AM, Jesse Gross wrote:
On Tue, May 20, 2014 at 9:27 PM, Lori Jakab wrote:
On 5/21/14, 4:10 AM, Jesse Gross wrote:
On Tue, May 13, 2014 at 7:02 AM, Lorand Jakab wrote:
Implementation of the pop_eth and push_eth actions in the kernel, and
layer 3 flow support
On 5/23/14, 2:07 AM, Jesse Gross wrote:
On Tue, May 20, 2014 at 9:27 PM, Lori Jakab wrote:
On 5/21/14, 4:10 AM, Jesse Gross wrote:
On Tue, May 13, 2014 at 7:02 AM, Lorand Jakab wrote:
Implementation of the pop_eth and push_eth actions in the kernel, and
layer 3 flow support.
Signed-off-by
On 5/23/14, 12:22 AM, Ben Pfaff wrote:
On Tue, May 13, 2014 at 05:02:16PM +0300, Lorand Jakab wrote:
Implementation of the pop_eth and push_eth actions in the kernel, and
layer 3 flow support.
Signed-off-by: Lorand Jakab
"sparse" complains thus:
/home/blp/ovs/_build/datapath/linux/flow_
On 5/23/14, 12:19 AM, Ben Pfaff wrote:
On Tue, May 13, 2014 at 05:02:15PM +0300, Lorand Jakab wrote:
This commit relaxes the assumption that all packets have an Ethernet
header, and adds support for layer 3 flows. For each packet received on
the Linux kernel datapath the l2 and l3 members of st
On 5/22/14, 9:45 PM, Jesse Gross wrote:
On Thu, May 22, 2014 at 11:34 AM, Ben Pfaff wrote:
On Tue, May 13, 2014 at 05:02:14PM +0300, Lorand Jakab wrote:
These actions will allow L2->L3 and L3->L2 switching, and are supposed
to be added to flows installed in the datapath transparently by
ovs-v
On 5/22/14, 9:34 PM, Ben Pfaff wrote:
On Tue, May 13, 2014 at 05:02:14PM +0300, Lorand Jakab wrote:
These actions will allow L2->L3 and L3->L2 switching, and are supposed
to be added to flows installed in the datapath transparently by
ovs-vswitchd.
Signed-off-by: Lorand Jakab
This appears to
On 5/21/14, 4:10 AM, Jesse Gross wrote:
On Tue, May 13, 2014 at 7:02 AM, Lorand Jakab wrote:
Implementation of the pop_eth and push_eth actions in the kernel, and
layer 3 flow support.
Signed-off-by: Lorand Jakab
Lori, can you take a look at the thread with Thomas Morin and see if
the outcom
On 5/19/14, 10:13 AM, YAMAMOTO Takashi wrote:
Signed-off-by: Joe Stringer
---
utilities/ovs-dev.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 97fab6c..d979afd 100755
--- a/utilities/ovs-dev.py
+++ b/utilities/ovs-de
On 5/10/14, 12:48 AM, Jesse Gross wrote:
On Fri, Apr 25, 2014 at 2:55 AM, Lori Jakab wrote:
On 4/25/14, 5:19 AM, Jesse Gross wrote:
+noethernet:
if (nla_put_be16(skb, OVS_KEY_ATTR_ETHERTYPE,
output->eth.type))
goto nla_put_failure;
Does it still make se
On 4/25/14, 5:19 AM, Jesse Gross wrote:
+noethernet:
if (nla_put_be16(skb, OVS_KEY_ATTR_ETHERTYPE,
output->eth.type))
goto nla_put_failure;
Does it still make sense to send the EtherType? It's not present in
the packet and I believe that the information is contain
On 4/16/14, 2:57 AM, Jesse Gross wrote:
On Fri, Apr 11, 2014 at 4:30 AM, Lori Jakab wrote:
On 4/11/14, 1:47 AM, Jesse Gross wrote:
On Thu, Mar 20, 2014 at 4:37 AM, Lori Jakab wrote:
On 1/6/14, 7:55 PM, Jesse Gross wrote:
On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
More
On 4/14/14, 3:00 PM, thomas.mo...@orange.com wrote:
Hi Lori,
2014-04-14, Lori Jakab:
On 4/14/14, 11:01 AM, thomas.mo...@orange.com wrote:
2014-04-11, Lori Jakab:
On 4/11/14, 4:24 PM, thomas.mo...@orange.com wrote:
The result is the following:
- an option is added to GRE tunnel port, to
On 4/14/14, 11:01 AM, thomas.mo...@orange.com wrote:
Hi Lori,
2014-04-11, Lori Jakab:
On 4/11/14, 4:24 PM, thomas.mo...@orange.com wrote:
The result is the following:
- an option is added to GRE tunnel port, to allow making them OVS l3ports
My first impression is that starting with my
patches) and you'll likely get more
feedback. I hope I'll be able to post v3 of my patches next week.
-Lori
Thank you,
-Thomas
2014-02-27, Lori Jakab:
Hi Thomas,
I'm the original contributor of the LISP tunneling code. Since it was
originally accepted, I have been working on
On 4/11/14, 1:47 AM, Jesse Gross wrote:
On Thu, Mar 20, 2014 at 4:37 AM, Lori Jakab wrote:
On 1/6/14, 7:55 PM, Jesse Gross wrote:
On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 7d193d8..8f0d5ab 100644
--- a/datapath
On 4/11/14, 11:40 AM, Thomas Graf wrote:
On 03/20/2014 12:37 PM, Lori Jakab wrote:
+static int push_eth(struct sk_buff *skb, const struct
ovs_action_push_eth *ethh)
+{
+ int err;
+
+ skb_push(skb, ETH_HLEN);
+ skb_reset_mac_header(skb);
+
+ err = set_eth_addr(skb, ðh
, but didn't investigate.
On Mon, Apr 07, 2014 at 10:50:57AM +0300, Lori Jakab wrote:
Hi,
On some of my systems the commit "0c47331 ofproto-dpif.at: Wait for
the monitor's pidfile disappears where necessary" consistently
breaks test "700: ofproto-dpif - controller&quo
Hi,
On some of my systems the commit "0c47331 ofproto-dpif.at: Wait for the
monitor's pidfile disappears where necessary" consistently breaks test
"700: ofproto-dpif - controller". Reverting the commit makes the test
pass again. This happens on a physical machine (Sandy Bridge laptop
with L
On 4/2/14, 8:59 PM, Jarno Rajahalme wrote:
[...]
diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h
index 8d1cb11..fa8a3f0 100644
--- a/lib/ofpbuf.h
+++ b/lib/ofpbuf.h
@@ -36,26 +36,46 @@ enum OVS_PACKED_ENUM ofpbuf_source {
};
/* Buffer for holding arbitrary data. An ofpbuf is automatically real
On 4/2/14, 9:09 PM, Jarno Rajahalme wrote:
On Apr 1, 2014, at 1:28 PM, Lori Jakab <mailto:loja...@cisco.com>> wrote:
On 4/1/14, 5:43 PM, Jarno Rajahalme wrote:
Sent from my iPhone
On Apr 1, 2014, at 7:27 AM, Ben Pfaff <mailto:b...@nicira.com>> wrote:
On Tue, Apr 01,
On 4/1/14, 5:43 PM, Jarno Rajahalme wrote:
Sent from my iPhone
On Apr 1, 2014, at 7:27 AM, Ben Pfaff wrote:
On Tue, Apr 01, 2014 at 03:14:16PM +0300, Lori Jakab wrote:
On 3/26/14, 2:16 AM, Ben Pfaff wrote:
On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote:
This patch
On 3/26/14, 2:16 AM, Ben Pfaff wrote:
On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote:
This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit
systems, or from 52 to 36 bytes on 32-bit systems (counting in the
'l7' removal by the previous patch). This may help contri
Hi Jesse,
I hope you had a great vacation.
Now that you're back, please take a look at suggested fixes before I
formally submit v3 of the L3 patch for review.
On 1/6/14, 7:55 PM, Jesse Gross wrote:
On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
Implementation of the pop_eth and push_
Hi Pasquale,
On 3/8/14, 2:09 PM, Pasquale Dir wrote:
Hello,
I'd need to create some java apis who would allow to interact with
openvswitch, creating bridges, adding ports, creating gre tunnels...in
short: the exact same thing ovs-vsctl does.
As c code seems fairly complex I write here to ask
Hi Thomas,
I'm the original contributor of the LISP tunneling code. Since it was
originally accepted, I have been working on a series of patches to
enable more generic support for layer 3 packets in OVS. While I was
doint it with LISP in mind, I did consider enabling IP-over-GRE at some
poi
On 12/30/13 9:28 PM, Ben Pfaff wrote:
On Tue, Dec 24, 2013 at 04:02:35PM +0200, Lorand Jakab wrote:
This commit relaxes the assumption that all packets have an Ethernet
header, and adds support for layer 3 flows. For each packet received on
the Linux kernel datapath the l2 and l3 members of str
On 12/30/13 8:56 PM, Ben Pfaff wrote:
On Mon, Dec 30, 2013 at 10:38:40AM -0800, Ben Pfaff wrote:
On Tue, Dec 24, 2013 at 04:02:34PM +0200, Lorand Jakab wrote:
These actions will allow L2->L3 and L3->L2 switching, and are supposed
to be added to flows installed in the datapath transparently by
o
On 1/6/14 6:30 PM, Jesse Gross wrote:
On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
index 5137c2f..46b3634 100644
--- a/include/linux/openvswitch.h
+++ b/include/linux/openvswitch.h
* @OVS_ACTION_ATTR_OUTPUT: Outpu
On 12/30/13 9:34 PM, Jesse Gross wrote:
On Mon, Dec 30, 2013 at 2:29 PM, Ben Pfaff wrote:
On Tue, Dec 24, 2013 at 04:02:36PM +0200, Lorand Jakab wrote:
Implementation of the pop_eth and push_eth actions in the kernel, also
layer 3 flow support. Jesse Gross provided feedback on a previous
vers
On 11/19/13 12:51 AM, Ben Pfaff wrote:
On Mon, Nov 18, 2013 at 02:45:46PM -0800, Ben Pfaff wrote:
On Mon, Nov 18, 2013 at 10:27:48PM +0200, Lorand Jakab wrote:
Add member is_layer3 to struct ofport_dpif to mark layer 3 ports. Set
it to "true" for the only layer 3 port we support for now: lisp.
On 11/18/13 9:28 PM, Ben Pfaff wrote:
On Mon, Nov 18, 2013 at 12:19:05PM +0200, Lori Jakab wrote:
On 11/16/13 1:21 AM, Ben Pfaff wrote:
On Tue, Nov 12, 2013 at 04:36:25PM +0200, Lorand Jakab wrote:
This commit relaxes the assumption that all packets have an Ethernet
header, and adds support
On 11/18/13 9:19 PM, Ben Pfaff wrote:
On Mon, Nov 18, 2013 at 11:46:26AM +0200, Lori Jakab wrote:
Thanks for the review, Ben.
On 11/16/13 12:36 AM, Ben Pfaff wrote:
On Tue, Nov 12, 2013 at 04:36:23PM +0200, Lorand Jakab wrote:
Add member is_layer3 to struct ofport_dpif to mark layer 3 ports
On 11/16/13 1:21 AM, Ben Pfaff wrote:
On Tue, Nov 12, 2013 at 04:36:25PM +0200, Lorand Jakab wrote:
This commit relaxes the assumption that all packets have an Ethernet
header, and adds support for layer 3 flows. For each packet received on
the Linux kernel datapath the l2 and l3 members of str
Thanks for the review, Ben.
On 11/16/13 12:36 AM, Ben Pfaff wrote:
On Tue, Nov 12, 2013 at 04:36:23PM +0200, Lorand Jakab wrote:
Add member is_layer3 to struct ofport_dpif to mark layer 3 ports. Set
it to "true" for the only layer 3 port we support for now: lisp.
Additionally, prevent floodin
On 10/17/13 3:23 AM, Simon Horman wrote:
On Wed, Oct 16, 2013 at 02:32:55PM +0300, Lori Jakab wrote:
On 10/16/13 1:17 PM, Simon Horman wrote:
This alters the way rx packets are accounted for by
counting them when they are processed by netdev_dummy_rx_recv(),
which seems to be a common path
Looks good to me, thanks for fixing!
On 10/16/13 7:28 PM, Ben Pfaff wrote:
Also, document how to work around it if you use an older OFTest.
Reported-by: Simon Horman
Reported-by: Lori Jakab
Signed-off-by: Ben Pfaff
---
README-OFTest|7 +++
tests/run-oftest |2 +-
2 files
On 10/16/13 1:17 PM, Simon Horman wrote:
This alters the way rx packets are accounted for by
counting them when they are processed by netdev_dummy_rx_recv(),
which seems to be a common path used by all received packets.
Previously accounting was done earlier, in netdev_dummy_receive(),
however t
Hi Ben,
On 10/16/13 1:16 PM, Simon Horman wrote:
Hi Ben,
On Tue, Oct 15, 2013 at 09:55:12AM -0700, Ben Pfaff wrote:
I see that "make check-oftest" reports 8 failures and 1 error. (I
haven't updated OFtest in ages, maybe newer versions would give
different results.) I don't have time to chase
Looks good to me.
On 9/6/13 9:16 PM, Pravin B Shelar wrote:
CC: Lori Jakab
Signed-off-by: Pravin B Shelar
Acked-by: Lorand Jakab
---
datapath/vport-lisp.c | 43 +++
1 files changed, 3 insertions(+), 40 deletions(-)
diff --git a/datapath/vport
[Reviving and older thread...]
On Jun 21, 2013, at 2:50 AM, Jesse Gross wrote:
On Mon, Jun 17, 2013 at 11:19 AM, Lori Jakab wrote:
On 6/11/13 1:09 AM, Jesse Gross wrote:
On Wed, Jun 5, 2013 at 2:56 PM, Lori Jakab wrote:
At a high level, we would introduce layer 3 (tunnel) vports, and
andling in lisp
and use ovs iptunnel_xmit() function for same.
CC: Lori Jakab
Signed-off-by: Pravin B Shelar
---
datapath/vport-lisp.c | 209 -
1 files changed, 50 insertions(+), 159 deletions(-)
diff --git a/datapath/vport-lisp.c b/datapa
On 7/30/13 1:47 AM, Pravin B Shelar wrote:
CC: Lori Jakab
Signed-off-by: Pravin B Shelar
---
datapath/vport-lisp.c | 48 ++--
1 files changed, 2 insertions(+), 46 deletions(-)
diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
index
On 7/30/13 1:47 AM, Pravin B Shelar wrote:
Generic tunnel rcv and send function are only used by lisp tunneling
module, so It make sense to move them to lisp module.
CC: Lori Jakab
Signed-off-by: Pravin B Shelar
Acked-by: Lorand Jakab
---
datapath/Modules.mk|2 -
datapath
On 6/11/13 1:09 AM, Jesse Gross wrote:
On Wed, Jun 5, 2013 at 2:56 PM, Lori Jakab wrote:
At a high level, we would introduce layer 3 (tunnel) vports, and LISP
would be such a vport. Whenever a packet that ingressed on a L2 vport
needs to egress on a L3 vport, we apply the internal pop_eth
On 6/7/13 3:18 AM, Ben Pfaff wrote:
On Thu, Jun 06, 2013 at 12:56:35AM +0300, Lori Jakab wrote:
The LISP tunneling support as of now is not yet ready for upstreaming,
for reasons outlined in this message:
http://openvswitch.org/pipermail/dev/2013-February/025459.html
One solution to the above
Hi,
The LISP tunneling support as of now is not yet ready for upstreaming,
for reasons outlined in this message:
http://openvswitch.org/pipermail/dev/2013-February/025459.html
One solution to the above issues is to make OVS less Ethernet specific,
meaning that it should accept and work with pack
Thanks for the review Jarno, will send out a revised patch.
-Lori
On 05/27/2013 01:20 PM, Rajahalme, Jarno (NSN - FI/Espoo) wrote:
>
> On May 27, 2013, at 12:35 , ext Lorand Jakab wrote:
>
>> Since commit 0ad90c8 it is possible to set tunnel destination IP address
>> in the flow. This allows c
The wording looks good to me, thanks!
On 04/15/2013 08:18 PM, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
> ---
> INSTALL.RHEL |6 ++
> INSTALL.XenServer | 13 -
> 2 files changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/INSTALL.RHEL b/INSTALL
On 04/13/2013 12:53 AM, Ben Pfaff wrote:
> On Fri, Apr 12, 2013 at 01:50:43PM -0700, Gurucharan Shetty wrote:
>> Till now, by default, we add firewall holes for
>> gre traffic. There may be users that do not use gre tunnels
>> and they may be surprised with this behavior.
>
> It would be nice to a
On 04/08/2013 11:27 PM, Gurucharan Shetty wrote:
> Bug #15518.
> Signed-off-by: Gurucharan Shetty
> ---
> rhel/etc_init.d_openvswitch |1 +
> xenserver/etc_init.d_openvswitch |1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/rhel/etc_init.d_openvswitch b/rhel/etc_init.d_open
On 02/22/13 02:10, Jesse Gross wrote:
> On Thu, Feb 21, 2013 at 1:42 AM, Lori Jakab wrote:
>> On 02/21/13 00:50, Jesse Gross wrote:
>>> On Wed, Feb 20, 2013 at 2:33 AM, Lorand Jakab wrote:
>>>> LISP is an experimental layer 3 tunneling protocol, described in R
On 02/21/13 00:50, Jesse Gross wrote:
> On Wed, Feb 20, 2013 at 2:33 AM, Lorand Jakab wrote:
>> LISP is an experimental layer 3 tunneling protocol, described in RFC
>> 6830. This patch adds support for LISP tunneling. Since LISP
>> encapsulated packets do not carry an Ethernet header, it is remo
On 02/20/13 18:26, Rajahalme, Jarno (NSN - FI/Espoo) wrote:
>
> On Feb 20, 2013, at 11:00 , ext Lorand Jakab wrote:
>
>> +static int lisp_tnl_send(struct vport *vport, struct sk_buff *skb)
>> +{
>> +int network_offset = skb_network_offset(skb);
>> +
>> +/* We only encapsulate IPv4 and IPv
On 02/18/13 14:31, Lori Jakab wrote:
> On 02/16/13 00:45, Jesse Gross wrote:
>> On Fri, Feb 15, 2013 at 10:34 AM, Lori Jakab wrote:
>>> On 02/15/13 01:32, Jesse Gross wrote:
>>>> On Wed, Feb 13, 2013 at 6:44 AM, Lorand Jakab wrote:
>>>>>
On 02/16/13 00:45, Jesse Gross wrote:
> On Fri, Feb 15, 2013 at 10:34 AM, Lori Jakab wrote:
>> On 02/15/13 01:32, Jesse Gross wrote:
>>> On Wed, Feb 13, 2013 at 6:44 AM, Lorand Jakab wrote:
>>>> diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
>&g
On 02/15/13 01:32, Jesse Gross wrote:
> On Wed, Feb 13, 2013 at 6:44 AM, Lorand Jakab wrote:
>> LISP is an experimental layer 3 tunneling protocol, described in RFC
>> 6830. This patch adds support for LISP tunneling. Since LISP
>> encapsulated packets do not carry an Ethernet header, it is remo
Hi Jagadish,
VXLAN has been accepted into the official Open vSwitch distribution, so
you should use that repository instead. Justin referred to branch-1.10
and master from there. To check out that repository, see
http://openvswitch.org/development/
-Lori
On 02/15/13 15:05, Jagadish Nadimpalli
On 01/23/13 16:01, Jarno Rajahalme wrote:
>
> On Jan 22, 2013, at 20:36 , ext Kyle Mestery wrote:
>
>> Add support to the tunneling code for a "pre_tunnel"
>> function. This allows the tunneling code to perform
>> operations on the packet before the outer IP header is
>> added.
>>
>> A tunneling
Hi Jarno,
Thanks for reviewing! Replies inline:
On 01/23/13 16:32, Jarno Rajahalme wrote:
> Please find my comments below,
>
> Jarno
>
> On Jan 22, 2013, at 20:36 , ext Kyle Mestery wrote:
>
>> From: Lorand Jakab
>>
> ...
>> +Flows on br0 are configured as follows:
>> +
>> +priority=3,d
On 12/18/12 10:40, Isaku Yamahata wrote:
> Signed-off-by: Isaku Yamahata
> ---
> datapath/datapath.c | 54
> -
> datapath/linux/Modules.mk |1 +
> datapath/linux/compat/include/net/genetlink.h | 15 ++-
> datapath/
97 matches
Mail list logo