On 7/7/14, 7:03 PM, Ben Pfaff wrote:
On Fri, Jun 27, 2014 at 04:21:52PM +0300, Lorand Jakab wrote:
This series implements support for layer 3 ports, of which we have one example
so far, the LISP vport. LISP support is currently implemented with a hack, by
adding/removing the Ethernet header within the datapath/vport-lisp.c file. By
removing the assumption that all packets/flows have Ethernet header, this
series adds generic support for layer 3 ports in OVS, and thus it is expected
that the user/kernel space API for LISP support will not change. This will
allow the upstreaming of the LISP vport, resulting in a decreased the delta
against the Linux kernel module, which is the goal that started this work. It
will also allow supporting layer 3 GRE tunnels, for which patches have been
proposed based on this work.
The patch set doesn't change the current behavior when a packet from a LISP
port is sent to a layer 2 port or the other way around, so it's not necessary
to change existing flow rules. The implementation will automatically add the
appropriate pop_eth and push_eth actions to datapath flows. This may change in
the future when OpenFlow support for these actions will be added, since
discussions on EXT-112 in the ONF showed preference for explicitly requiring
the pop_eth and push_eth actions in OpenFlow rules.
I notice that this series tends to use tabs for indentation in userspace
code, whereas it should use spaces.
Sorry about that, I have vim setup for spaces, not sure how those tabs
slipped in.
I'm looking at other issues too of course.
Thanks for reviewing.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
