Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-25 Thread Ben Pfaff
Thanks. Of course this patch needs review on the OVS side as well; that might take a few days. On Thu, Jun 25, 2015 at 11:51:57PM +, Aaron Rosen wrote: > Awesome thanks Ben! I'll update neutron tomorrow morning to work with this. > > > > On Jun 25, 2015, at 5:35 PM, Ben Pfaff wrote: > > >

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-25 Thread Aaron Rosen
Awesome thanks Ben! I'll update neutron tomorrow morning to work with this. > On Jun 25, 2015, at 5:35 PM, Ben Pfaff wrote: > > Until now, the OVN_Northbound schema has been designed to sidestep a > weakness in the OVSDB protocol when a column has a great deal of data in > it. In the current O

[ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

2015-06-25 Thread Ben Pfaff
Until now, the OVN_Northbound schema has been designed to sidestep a weakness in the OVSDB protocol when a column has a great deal of data in it. In the current OVSDB protocol, whenever a column changes, the entire new value of the column is sent to all of the clients that are monitoring that colu

Re: [ovs-dev] [PATCH] expr: Fix typo in comment.

2015-06-25 Thread Ben Pfaff
Thanks, applied. On Thu, Jun 25, 2015 at 01:40:05PM -0700, Andy Zhou wrote: > Acked-by: Andy Zhou > > On Thu, Jun 25, 2015 at 11:27 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > ovn/lib/expr.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ovn/l

Re: [ovs-dev] [PATCH] ofp-actions: Support mixing "conjunction" and "note" actions.

2015-06-25 Thread Andy Zhou
On Mon, Jun 15, 2015 at 1:58 PM, Ben Pfaff wrote: > It doesn't make sense to mix "conjunction" actions with most other kinds > of actions. That's because flows with "conjunction" actions aren't ever > actually executed, so any actions mixed up with them would never do > anything useful. "note" a

Re: [ovs-dev] [PATCH] tunneling: Don't match on source IP address for native tunnels.

2015-06-25 Thread Jesse Gross
On Wed, Jun 24, 2015 at 8:40 PM, Pravin Shelar wrote: > On Wed, Jun 24, 2015 at 2:55 PM, Jesse Gross wrote: >> When doing native tunneling, we look at packets destined to the >> local port to see if they match tunnel protocols that we should >> intercept. The criteria are IP protocol, destination

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-25 Thread Sabyasachi Sengupta
It's much easier for a script to parse a number than a date. Well, I tried to use time_msec instead of time_wall_msec() in an attempt to see how the output would look like. To me, the original proposal of printing wall clock time -- [root@rtr-29-225-196-232 ~]# ovs-appctl bfd/show por

[ovs-dev] [join ovsdb schema v2 8/8] tests: add ovsdb-tool join schema tests

2015-06-25 Thread Andy Zhou
Add unit tests for ovsdb-tools that deals with multiple schemas. Signed-off-by: Andy Zhou --- tests/ovsdb-tool.at | 153 1 file changed, 153 insertions(+) diff --git a/tests/ovsdb-tool.at b/tests/ovsdb-tool.at index 0d3219b..4a59578 100644 --

[ovs-dev] [join ovsdb schema v2 6/8] ovsdb: add logic for parsing schema file names from a string

2015-06-25 Thread Andy Zhou
Any ovsdb programs that accepts a single schema file name will be extended to accept multiple file names. This patch implements the parsing logic for future patches. Signed-off-by: Andy Zhou --- ovsdb/ovsdb.c | 38 ++ ovsdb/ovsdb.h | 2 ++ 2 files changed, 40

[ovs-dev] [join ovsdb schema v2 7/8] ovsdb-tool: add multiple schemas support

2015-06-25 Thread Andy Zhou
Allow ovsdb-tool to accept a schema-list, a list of schema files, in addition to a single schema file, for all applicable options. There is no limit on how many schemas can be joined together, but they can not have a shared schema name and they have to be compatible for joining. Compatible basical

[ovs-dev] [join ovsdb schema v2 5/8] ovsdb: enhance file interface to deal with schemas

2015-06-25 Thread Andy Zhou
When storing joined schemas into a database file, A JSON array will be store as its first record, with every individual schema as one element of the array. To maintain backward compatibility, when joined schemas contain a single schema, a single JSON object will be stored, not a JSON array with a s

[ovs-dev] [join ovsdb schema v2 2/8] ovsdb: add more multiple schemas support functions

2015-06-25 Thread Andy Zhou
Add more support functions for handling schemas as a set (shash, actually). They will be used in future patches. Signed-off-by: Andy Zhou --- ovsdb/ovsdb.c | 164 ++ ovsdb/ovsdb.h | 33 2 files changed, 197 insertions(+) diff

[ovs-dev] [join ovsdb schema v2 3/8] ovsdb: fix joined the schema name

2015-06-25 Thread Andy Zhou
The joined schema name currently is taken from any one of the schemas, (actually, it is taken from the first schema on the shash). This won't work since transactions needs to verify schema name. This patch makes the joined schema name as a comma separated string of names from the original schemas.

[ovs-dev] [join ovsdb schema v2 4/8] ovsdb: add schemas into ovsdb run time data structure

2015-06-25 Thread Andy Zhou
It turns out ovsdb in memory data structure needs to store both joined schema and the original schemas, so that it can recreate DB file laster. This patch adds 'schemas' to 'struct ovsdb' and fixes corresponding APIs for maintaining this information. Signed-off-by: Andy Zhou --- ovsdb/file.c

[ovs-dev] [join ovsdb schema v2 0/8] ovsdb-tools changes

2015-06-25 Thread Andy Zhou
OVSDB can be more flexible by supporting multiple schemas. Those multiple schemas can be taken from different releases, or on different feature sets. If the schema tables don't overlap, or for tables do overlap, but columns are not in conflict, those schemas can be joined together into single sc

[ovs-dev] [join ovsdb schema v2 1/8] ovsdb: add functions to support joining multiple schemas

2015-06-25 Thread Andy Zhou
Compatible schemas can be joined together by merging their tables and columns. Schemas are compatible if they don't contain tables or columns that are conflict in types. Signed-off-by: Andy Zhou --- ovsdb/column.c | 16 +- ovsdb/column.h | 4 +++- ovsdb/ovsdb.c | 68 +++

Re: [ovs-dev] [PATCH v2] Do not flush tx queue which is shared among CPUs since it is always flushed

2015-06-25 Thread Pravin Shelar
On Wed, Jun 17, 2015 at 3:17 AM, Gray, Mark D wrote: > > >> -Original Message- >> From: Daniele Di Proietto [mailto:diproiet...@vmware.com] >> Sent: Tuesday, June 16, 2015 6:45 PM >> To: Pravin Shelar; Wei li; Gray, Mark D >> Cc: d...@openvswitch.com >> Subject: Re: [ovs-dev] [PATCH v2] Do

Re: [ovs-dev] [PATCH 3/4] ovn-integrate: A new OVN utility script.

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 01:51:02PM -0700, Gurucharan Shetty wrote: > > I was really heading more in the direction of suggesting a name that > > mentioned docker. I'm OK with including the nics-to-bridge > > functionality. > > I think it will be true for any other container formats too (if at > al

Re: [ovs-dev] [PATCH 3/4] ovn-integrate: A new OVN utility script.

2015-06-25 Thread Gurucharan Shetty
> I was really heading more in the direction of suggesting a name that > mentioned docker. I'm OK with including the nics-to-bridge > functionality. I think it will be true for any other container formats too (if at all). And it is likely useful to setup VM based OVN solution too. ___

Re: [ovs-dev] [PATCH] expr: Fix typo in comment.

2015-06-25 Thread Andy Zhou
Acked-by: Andy Zhou On Thu, Jun 25, 2015 at 11:27 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ovn/lib/expr.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn/lib/expr.h b/ovn/lib/expr.h > index 501152e..b411e65 100644 > --- a/ovn/lib/expr.h > +++ b/ovn/l

Re: [ovs-dev] [PATCH 3/4] ovn-integrate: A new OVN utility script.

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 12:47:56PM -0700, Gurucharan Shetty wrote: > On Wed, Jun 24, 2015 at 4:47 PM, Ben Pfaff wrote: > > On Mon, Jun 22, 2015 at 02:15:49AM -0700, Gurucharan Shetty wrote: > >> Signed-off-by: Gurucharan Shetty > > > > Is this intended exclusively for use with Docker, or is it me

Re: [ovs-dev] [PATCH 3/3] Multicast Listener Discovery support

2015-06-25 Thread Flavio Leitner
On Tue, Jun 23, 2015 at 05:03:16PM -0300, Thadeu Lima de Souza Cascardo wrote: > Add support for MLDv1 and MLDv2. The behavior is not that different from > IGMP. Packets to all-hosts address and queries are always flooded, > reports go to routers, routers are added when a query is observed, and > a

Re: [ovs-dev] [PATCH 2/3] mcast-snooping: Use IPv6 address for MDB

2015-06-25 Thread Flavio Leitner
On Tue, Jun 23, 2015 at 05:03:15PM -0300, Thadeu Lima de Souza Cascardo wrote: > Use IPv6 internally for storing multicast addresses. IPv4 addresses are > translated to their IPv4-mapped equivalent. > > Signed-off-by: Thadeu Lima de Souza Cascardo > --- > lib/mcast-snooping.c | 69 > +++

Re: [ovs-dev] [RFC 4/4] Introduce an openvswitch driver for Docker networking.

2015-06-25 Thread Gurucharan Shetty
On Wed, Jun 24, 2015 at 4:48 PM, Ben Pfaff wrote: > On Mon, Jun 22, 2015 at 02:15:50AM -0700, Gurucharan Shetty wrote: >> Docker committed experimental support for multi-host >> networking yesterday. This commit adds a driver that >> works with that experimental support. Since Docker >> code is no

[ovs-dev] [PATCHv2 1/2] vlog: abstract out interface to syslog daemon

2015-06-25 Thread Ansis Atteka
This patch helps to address two issues that are present on Ubuntu 15.04 (and most likely other Linux distributions) where rsyslog daemon is configured to relay log messages from OVS to a remote log collector and syslog format being used is something other than the one defined in RFC 3164. These tw

[ovs-dev] [PATCHv2 2/2] vlog: add "vlog/list-pattern" command

2015-06-25 Thread Ansis Atteka
This patch allows to query logging format at the runtime for each destination with "vlog/list-pattern" command. Signed-Off-By: Ansis Atteka --- NEWS | 2 ++ include/openvswitch/vlog.h | 1 + lib/vlog-unixctl.man | 3 +++ lib/vlog.c | 39

Re: [ovs-dev] [PATCH 3/4] ovn-integrate: A new OVN utility script.

2015-06-25 Thread Gurucharan Shetty
On Wed, Jun 24, 2015 at 4:47 PM, Ben Pfaff wrote: > On Mon, Jun 22, 2015 at 02:15:49AM -0700, Gurucharan Shetty wrote: >> Signed-off-by: Gurucharan Shetty > > Is this intended exclusively for use with Docker, or is it meant to be > more generic? Is the documentation just the Docker installation

[ovs-dev] [PATCH] expr: Fix typo in comment.

2015-06-25 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/lib/expr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/lib/expr.h b/ovn/lib/expr.h index 501152e..b411e65 100644 --- a/ovn/lib/expr.h +++ b/ovn/lib/expr.h @@ -293,7 +293,7 @@ bool expr_relop_from_token(enum lex_type type, enum expr_rel

Re: [ovs-dev] [PATCH] dpif-netdev: log port/core affinity

2015-06-25 Thread Pravin Shelar
On Tue, Jun 9, 2015 at 7:49 AM, Mark Kavanagh wrote: > When using multiple PMDs and numerous ports, a performance gain > may be achieved in some use cases by pinning a PMD/port to a > particular (set of) core(s). > > This patch provides a summary of the switch's port/core affinities > each time th

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Reset RSS hash when receiving from a vhost device.

2015-06-25 Thread Pravin Shelar
On Wed, Jun 24, 2015 at 8:55 AM, Daniele Di Proietto wrote: > A vhost device, being a virtual interface, doesn't provide a valid RSS > hash. As a workaround we set the value to 0, which suggests the > datapath to recompute the hash in software. > > Reported-by: Dongjun > CC: Traynor, Kevin > CC

Re: [ovs-dev] [PATCH v2] Do not flush tx queue which is shared among CPUs since it is always flushed

2015-06-25 Thread Pravin Shelar
On Mon, Jun 8, 2015 at 6:13 PM, Wei li wrote: > When tx queue is shared among CPUS,the pkts always be flush in > 'netdev_dpdk_eth_send' > So it is unnecessarily for flushing in netdev_dpdk_rxq_recv > Otherwise tx will be accessed without locking > > Signed-off-by: Wei li > --- > v1->v2: fix typo

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Fix sparse and clang warnings

2015-06-25 Thread Pravin Shelar
On Wed, Jun 24, 2015 at 8:55 AM, Daniele Di Proietto wrote: > Signed-off-by: Daniele Di Proietto I pushed patch to branch-2.4 and master. Thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] tunneling: Userspace datapath support for Geneve options.

2015-06-25 Thread Jesse Gross
Currently the userspace datapath only supports Geneve in a basic mode - without options - since the rest of userspace previously didn't support options either. This enables the userspace datapath to send and receive options as well. The receive path for extracting the tunnel options isn't entirely

Re: [ovs-dev] [PATCH] bitmap: Convert single bitmap functions to 64-bit.

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 11:14:16AM -0700, Jesse Gross wrote: > On Thu, Jun 25, 2015 at 10:54 AM, Ben Pfaff wrote: > > On Thu, Jun 25, 2015 at 09:22:09AM -0700, Jesse Gross wrote: > >> Currently the functions to set, clear, and iterate over bitmaps > >> only operate over 32 bit values. If we conver

Re: [ovs-dev] [PATCH] bitmap: Convert single bitmap functions to 64-bit.

2015-06-25 Thread Jesse Gross
On Thu, Jun 25, 2015 at 10:54 AM, Ben Pfaff wrote: > On Thu, Jun 25, 2015 at 09:22:09AM -0700, Jesse Gross wrote: >> Currently the functions to set, clear, and iterate over bitmaps >> only operate over 32 bit values. If we convert them to handle >> 64 bit bitmaps, they can be used in more places.

Re: [ovs-dev] [PATCH 2/2] python: Fix issue with probes for JSONRPC connections

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 04:07:56PM +, Garg, Sumit wrote: > When opening a JSONRPC connection, the health probes > are incorrectly getting turned off for connections > that need probes. > > In other words, when stream_or_pstream_needs_probes() > return non-zero, the probes are gettting disabled

Re: [ovs-dev] [PATCH 1/2] python: Fix exceptions in IDL

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 04:07:51PM +, Garg, Sumit wrote: > Committing two fixes that address python exceptions: > > 1. A bool (has_lock) was being accessed as a function call >leading to a runtime exception. > > 2. When 'alert' was turned off on a column, the code was >erroring out wh

Re: [ovs-dev] [PATCH] [PATCH v3][branch-2.4] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 05:18:41PM +, Alin Serdean wrote: > This patch disables features which are not currently supported in the > windows datapath. > > Unfortunately we have to do it in userspace because dpif_probe_feature is > not treated accordingly in the windows the datapath. > > I open

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 09:24:20AM -0700, Jesse Gross wrote: > On Wed, Jun 24, 2015 at 7:09 PM, Ben Pfaff wrote: > > On Wed, Jun 24, 2015 at 06:34:05PM -0700, Jesse Gross wrote: > >> On Wed, Jun 24, 2015 at 3:57 PM, Ben Pfaff wrote: > >> > On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wro

Re: [ovs-dev] [PATCH] bitmap: Convert single bitmap functions to 64-bit.

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 09:22:09AM -0700, Jesse Gross wrote: > Currently the functions to set, clear, and iterate over bitmaps > only operate over 32 bit values. If we convert them to handle > 64 bit bitmaps, they can be used in more places. > > Suggested-by: Ben Pfaff > Signed-off-by: Jesse Gros

Re: [ovs-dev] [PATCH] tests: Use taskkill if tskill is not available, on Windows.

2015-06-25 Thread Ben Pfaff
Thanks! I applied this to master and branch-2.4. On Thu, Jun 25, 2015 at 04:16:14PM +, Alin Serdean wrote: > Tested with and w/o tskill > > Acked-by: Alin Gabriel Serdean > > > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ben Pfaff > Trimis: Thursda

Re: [ovs-dev] [PATCH] [PATCH v3][branch-2.4] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Nithin Raju
> On Jun 25, 2015, at 10:18 AM, Alin Serdean > wrote: > > This patch disables features which are not currently supported in the > windows datapath. > > Unfortunately we have to do it in userspace because dpif_probe_feature is > not treated accordingly in the windows the datapath. > > I opened

Re: [ovs-dev] [PATCH] [PATCH v3][branch-2.4] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Eitan Eliahu
Acked-by: Eitan Eliahu Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Thursday, June 25, 2015 10:19 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] [PATCH v3][branch-2.4] dpif_probe_feature not suported in windows dat

Re: [ovs-dev] [PATCH] INSTALL.DPDK: remove experimental statement

2015-06-25 Thread Thomas F Herbert
On 6/25/15 12:39 PM, Flavio Leitner wrote: On Tue, Jun 23, 2015 at 06:48:20PM -0700, Pravin Shelar wrote: On Tue, Jun 23, 2015 at 11:42 AM, Ben Pfaff wrote: Do you two have an opinion on this? If DPDK support is pretty solid now then it makes sense to apply this to master and backport it to b

[ovs-dev] [PATCH] [PATCH v3][branch-2.4] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Alin Serdean
This patch disables features which are not currently supported in the windows datapath. Unfortunately we have to do it in userspace because dpif_probe_feature is not treated accordingly in the windows the datapath. I opened the issue to track the feature for later implementations: https://github.

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Reset RSS hash when receiving from a vhost device.

2015-06-25 Thread Flavio Leitner
On Wed, Jun 24, 2015 at 04:55:40PM +0100, Daniele Di Proietto wrote: > A vhost device, being a virtual interface, doesn't provide a valid RSS > hash. As a workaround we set the value to 0, which suggests the > datapath to recompute the hash in software. > > Reported-by: Dongjun > CC: Traynor, Ke

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Eitan Eliahu
If it gets too involved have your user mode hack instead. Thanks Alin. Eitan -Original Message- From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] Sent: Thursday, June 25, 2015 8:38 AM To: Eitan Eliahu; Nithin Raju Cc: Ben Pfaff; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH] INSTALL.DPDK: remove experimental statement

2015-06-25 Thread Flavio Leitner
On Tue, Jun 23, 2015 at 06:48:20PM -0700, Pravin Shelar wrote: > On Tue, Jun 23, 2015 at 11:42 AM, Ben Pfaff wrote: > > Do you two have an opinion on this? If DPDK support is pretty solid now > > then it makes sense to apply this to master and backport it to > > branch-2.4. > > Personally I woul

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-25 Thread Jesse Gross
On Wed, Jun 24, 2015 at 7:09 PM, Ben Pfaff wrote: > On Wed, Jun 24, 2015 at 06:34:05PM -0700, Jesse Gross wrote: >> On Wed, Jun 24, 2015 at 3:57 PM, Ben Pfaff wrote: >> > On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wrote: >> > I like the implementation approach used in ULONG_FOR_EACH_1

[ovs-dev] [PATCH] bitmap: Convert single bitmap functions to 64-bit.

2015-06-25 Thread Jesse Gross
Currently the functions to set, clear, and iterate over bitmaps only operate over 32 bit values. If we convert them to handle 64 bit bitmaps, they can be used in more places. Suggested-by: Ben Pfaff Signed-off-by: Jesse Gross --- lib/bitmap.h | 10 +- lib/cmap.c| 10 +--

Re: [ovs-dev] [PATCH] tests: Use taskkill if tskill is not available, on Windows.

2015-06-25 Thread Alin Serdean
Tested with and w/o tskill Acked-by: Alin Gabriel Serdean -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ben Pfaff Trimis: Thursday, June 25, 2015 6:35 PM Către: dev@openvswitch.org Cc: Ben Pfaff Subiect: [ovs-dev] [PATCH] tests: Use taskkill if tskill is not

[ovs-dev] [PATCH 2/2] python: Fix issue with probes for JSONRPC connections

2015-06-25 Thread Garg, Sumit
When opening a JSONRPC connection, the health probes are incorrectly getting turned off for connections that need probes. In other words, when stream_or_pstream_needs_probes() return non-zero, the probes are gettting disabled as the probe interval is getting set to zero. This leads to incorrect be

[ovs-dev] [PATCH 1/2] python: Fix exceptions in IDL

2015-06-25 Thread Garg, Sumit
Committing two fixes that address python exceptions: 1. A bool (has_lock) was being accessed as a function call leading to a runtime exception. 2. When 'alert' was turned off on a column, the code was erroring out when value for that column was being set in a newly inserted row. This is

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 01:47:16AM +, Alin Serdean wrote: > This patch disables features which are not currently supported > in the windows datapath. > > Unfortunately we have to do it in userspace because dpif_probe_feature is > not treated accordingly in the windows the datapath. > > I open

Re: [ovs-dev] [PATCH] This reduces the user burden for running "make check".

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 03:30:34PM +, Alin Serdean wrote: > Co-authored-by: Ben Pfaff > Signed-off-by: Ben Pfaff > Signed-off-by: Alin Gabriel Serdean Thanks, applied to master and branch-2.4. ___ dev mailing list dev@openvswitch.org http://openvs

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Alin Serdean
Eitan, Ok I will add it in the datapath. Why I am considering it as a hack, because if we see it in the datapath we just reply with an error, there will be no logic behind it at the moment. But maybe it makes some sense to have it for further user. Alin. -Mesaj original- De la: Eitan

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 02:33:33PM +, Alin Serdean wrote: > I am ok with the concept and I will test it if you send a patch out. OK, here you go: http://openvswitch.org/pipermail/dev/2015-June/056859.html ___ dev mailing list dev@openvswitch.

[ovs-dev] [PATCH] tests: Use taskkill if tskill is not available, on Windows.

2015-06-25 Thread Ben Pfaff
This is not the minimal change; it "improves" the rest of the code as well. Signed-off-by: Ben Pfaff --- Needs testing. tests/ovs-macros.at | 48 +--- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/tests/ovs-macros.at b/tests/ovs-macr

[ovs-dev] [PATCH] This reduces the user burden for running "make check".

2015-06-25 Thread Alin Serdean
Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff Signed-off-by: Alin Gabriel Serdean --- m4/openvswitch.m4 | 7 +-- tests/automake.mk | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4 index f89cde0..087c7e5 100644 --- a/m4/openvsw

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-25 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 06:08:02PM -0700, Sabyasachi Sengupta wrote: > >It's a little unconventional for us to use a wall clock time for this. > >I'd be more inclined to report it as "N seconds ago" or "N ms ago". Any > >particular reason to use a wall clock time? > > I've seen that all BFD other

Re: [ovs-dev] [PATCH 0/2] ovn: Add administrative state to logical ports.

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 09:25:36AM -0400, Russell Bryant wrote: > On 06/24/2015 08:30 PM, Ben Pfaff wrote: > > On Tue, Jun 23, 2015 at 03:18:57PM -0400, Russell Bryant wrote: > >> On 06/23/2015 02:22 PM, Russell Bryant wrote: > >>> While working on OpenStack Neutron integration for OVN, I came acro

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Eitan Eliahu
Alin, We just need to add: [OVS_FLOW_ATTR_PROBE] = { .type = NLA_FLAG }, to the flow policy. This is not a hack. If it is time consuming please go ahead with the uder mode change. Thanks, Eitan -Original Message- From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] Sent:

Re: [ovs-dev] [PATCH] tests: Automatically add pthread-win32 directory to $PATH.

2015-06-25 Thread Ben Pfaff
That's fine. On Jun 25, 2015 7:42 AM, "Alin Serdean" wrote: > I'll fix it and also test it. > > Mind if I add you as co-author? > > Alin. > > -Mesaj original- > De la: Ben Pfaff [mailto:b...@nicira.com] > Trimis: Thursday, June 25, 2015 5:35 PM > Către: Alin Serdean > Cc: dev@openvswitch.

[ovs-dev] [PATCH] acinclude: Require libfuse only for DPDK with vhost-cuse.

2015-06-25 Thread Daniele Di Proietto
DPDK with vhost-user doesn't require libfuse, so we shouldn't link OVS with libfuse unless DPDK is built with vhost-cuse support. CC: Rapelly, Varun Signed-off-by: Daniele Di Proietto --- acinclude.m4 | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/acinclude.m4 b/aci

Re: [ovs-dev] [PATCH] tests: Automatically add pthread-win32 directory to $PATH.

2015-06-25 Thread Alin Serdean
I'll fix it and also test it. Mind if I add you as co-author? Alin. -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis: Thursday, June 25, 2015 5:35 PM Către: Alin Serdean Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] tests: Automatically add pthread-win32 direc

Re: [ovs-dev] [PATCH] tests: Automatically add pthread-win32 directory to $PATH.

2015-06-25 Thread Ben Pfaff
OK, I'll drop it, though if anyone else wants to pick up and fix it that would be fine too. On Thu, Jun 25, 2015 at 02:26:36PM +, Alin Serdean wrote: > I tested it and there are two problems with it: > > - PTHREAD_WIN32_DIR is not the actual location of the DLLs the actual > path would b

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-25 Thread Alin Serdean
Hi Ben, I am ok with the concept and I will test it if you send a patch out. I tried to apply the diff but it gives me: error: patch failed: tests/ovs-macros.at:37 error: tests/ovs-macros.at: patch does not apply Alin. -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis:

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Alin Serdean
Both are hacks IMO. We could respond to DPIF_FP_PROBE but I prefer to do it in userspace until we address the bigger problem in the datapath. Alin. -Mesaj original- De la: Nithin Raju [mailto:nit...@vmware.com] Trimis: Thursday, June 25, 2015 4:51 PM Către: Eitan Eliahu Cc: Ben Pfaff;

Re: [ovs-dev] [PATCH] tests: Automatically add pthread-win32 directory to $PATH.

2015-06-25 Thread Alin Serdean
I tested it and there are two problems with it: - PTHREAD_WIN32_DIR is not the actual location of the DLLs the actual path would be of the form PTHREAD_WIN32_DIR_DLL=$withval/dll/x86 - $withval/lib/x86(PTHREAD_WIN32_DIR) is of the windows form: C:/pthread/dll/x86, whi

Re: [ovs-dev] [PATCH] dpif-netdev: log port/core affinity

2015-06-25 Thread Flavio Leitner
On Tue, Jun 09, 2015 at 03:49:18PM +0100, Mark Kavanagh wrote: > When using multiple PMDs and numerous ports, a performance gain > may be achieved in some use cases by pinning a PMD/port to a > particular (set of) core(s). > > This patch provides a summary of the switch's port/core affinities > ea

Re: [ovs-dev] OVN - Pluggable Distributed DB Infrastructure for OVSDB

2015-06-25 Thread Russell Bryant
On 06/25/2015 07:21 AM, Gal Sagie wrote: > Hello All, > > Currently OVN uses centralized ovsdb-server to serve the Northbound and the > Southbound DB to all the local controllers (sitting at each of the compute > nodes). > > It is a single point of failure and probably a major bottleneck to the >

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Nithin Raju
>> On Jun 18, 2015, at 6:47 PM, Alin Serdean >> wrote: >> >> This patch disables features which are not currently supported in the >> windows datapath. >> >> Unfortunately we have to do it in userspace because dpif_probe_feature >> is not treated accordingly in the windows the datapath. >>

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Nithin Raju
> On Jun 24, 2015, at 12:57 PM, Eitan Eliahu wrote: > > > I'm wondering if we could fail this call in the datapath level by examining > the DPIF_FP_PROBE bit in the flags. > If it is too hard we can still live with user mode code change. > Thanks, > Eitan That’s a good suggestion. We can go wi

Re: [ovs-dev] [PATCH 0/2] ovn: Add administrative state to logical ports.

2015-06-25 Thread Russell Bryant
On 06/24/2015 08:30 PM, Ben Pfaff wrote: > On Tue, Jun 23, 2015 at 03:18:57PM -0400, Russell Bryant wrote: >> On 06/23/2015 02:22 PM, Russell Bryant wrote: >>> While working on OpenStack Neutron integration for OVN, I came across a >>> small >>> feature gap. The Neutron API supports setting a por

Re: [ovs-dev] [PATCH 2/2] When opening a JSONRPC connection, the health probes are incorrectly getting turned off for connections that need probes.

2015-06-25 Thread Garg, Sumit
As stated in the earlier mail, redoing & resubmitting the changes. -- Sumit Garg Extreme Networks su...@extremenetworks.com +1 (919) 595-4971 On 6/24/15, 7:41 PM, "Ben Pfaff" wrote: >On Sat, Jun 20, 2015 at 05:09:55PM -0700, Ben Pfaff wrote: >> From: Sumit Garg >> >> In other words, when

Re: [ovs-dev] [PATCH 1/2] Committing two issues:

2015-06-25 Thread Garg, Sumit
Hello Ben, no worries. Still figuring my way around git, github etc. So, please excuse by missteps (e.g. subject lines). I've redone (revert + recommit) changes to my fork with a better commit message. Will, be sending the patch (via email) & pull request (via github) shortly. Let's handle the

[ovs-dev] OVN - Pluggable Distributed DB Infrastructure for OVSDB

2015-06-25 Thread Gal Sagie
Hello All, Currently OVN uses centralized ovsdb-server to serve the Northbound and the Southbound DB to all the local controllers (sitting at each of the compute nodes). It is a single point of failure and probably a major bottleneck to the operation of OVN in scale. I know there are efforts to m

[ovs-dev] [PATCH v4] ovs-ofctl: replace-flows and diff-flows support for multiple tables

2015-06-25 Thread Shashank Shanbhag
From: Shashank Shanbhag Fix replace-flows and diff-flows to modify/diff flows in multiple tables. Add a --tables(-T) option that allows the user to specify a comma-separated list of table indexes to replace/diff. Signed-off-by: Shashank Shanbhag Acked-by: Romain Lenglet --- AUTHORS

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-25 Thread Justin Pettit
> On Jun 25, 2015, at 3:08 AM, Sabyasachi Sengupta > wrote: > > [root@rtr-29-225-196-232 ~]# ovs-appctl bfd/show > port3.4094 >Forwarding: true >Detect Multiplier: 3 >Concatenated Path Down: false >TX Interval: Approx 500ms >RX Interval: Approx