On Thu, Jun 25, 2015 at 04:07:51PM +0000, Garg, Sumit wrote: > Committing two fixes that address python exceptions: > > 1. A bool (has_lock) was being accessed as a function call > leading to a runtime exception. > > 2. When 'alert' was turned off on a column, the code was > erroring out when value for that column was being set > in a newly inserted row. This is because the row._data > was None at this time. > > An observation related to change #2 - it seems that new > rows are not initialized to defaults and that's why the > NULL error happens. > > IMO a newly inserted row should automatically get > intialized to default values. This new behavior can be > implemented as a separate improvement sometime in the > future. > > For now, I don't see an issue with adding the additional > check. This new check can continue as-is even after the > new behavior is implemented. > > Signed-off-by: Sumit Garg <su...@extremenetworks.com>
Thanks, I broke this into two commits (one for each fix) and applied them to master, branch-2.4, and branch-2.3. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
