[ovs-dev] Documentation

2014-03-27 Thread Neelakantam Gaddam
Hi All, Are there any design/implementation guide available for openvswitch userspace and kernel space components ? Please point me to any such document if available. -- Thanks & Regards Neelakantam Gaddam ___ dev mailing list dev@openvswitch.org htt

[ovs-dev] [hash.h cleanups 2/3] lib/hash.h: add hash_uint64()

2014-03-27 Thread Andy Zhou
From: Andy Zhou Add hash_uint64() and apply it when appropriate. Signed-off-by: Andy Zhou --- lib/cfm.c |2 +- lib/classifier.c |2 +- lib/hash.h|6 ++ lib/packets.c |6 ++ ofproto/ofproto.c |3 +-- 5 files changed, 11 insertions(+), 8 deletions

[ovs-dev] [hash.h cleanups 1/3] lib/hash.h: fix hash_2words

2014-03-27 Thread Andy Zhou
From: Andy Zhou Number of bytes in 2 words should be 8, instead of 4 bytes, to better follow the mhash_finish() API. It is unlikely the fix will improve the quality of hashing results. Signed-off-by: Andy Zhou --- lib/hash.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [hash.h cleanups 3/3] lib/packet.h: add hash_mac()

2014-03-27 Thread Andy Zhou
From: Andy Zhou Add hash_mac() and apply it when appropriate. Signed-off-by: Andy Zhou --- lib/hash.h |6 ++ lib/mac-learning.c |4 +--- lib/packets.h| 11 +++ ofproto/bond.c |2 +- ofproto/ofproto-dpif-xlate.c

[ovs-dev] [hash.h cleanups 0/3] hash API cleanups

2014-03-27 Thread Andy Zhou
Used some 'free time' on day 2 of 2014 hackerathon to come up with this series that improves how hash APIs are used throughout OVS. These changes are mainly aimed at improving code readability. They should not degrade the hash quality and may improve performance in some cases. But I did not attempt

Re: [ovs-dev] [PATCH] configure: making sparse happy.

2014-03-27 Thread Pritesh Kothari (pritkoth)
On Mar 27, 2014, at 4:52 PM, Ben Pfaff wrote: > On Thu, Mar 27, 2014 at 03:44:59PM -0700, Pritesh Kothari wrote: >> Sparse is unhappy because the system include path is ahead of the >> local include path. This patch fixes that and has a clean run for >> sparse. >> >> Signed-off-by: Pritesh Koth

[ovs-dev] [PATCH v4 1/2] ovsdb-idlc: Generate new *_get_for_uuid() functions.

2014-03-27 Thread Ben Pfaff
This allows a client to obtain the IDL version of a row given its UUID. It isn't normally useful, but there's a specialized use case for getting the IDL version of a row given the UUID returned by ovsdb_idl_txn_get_insert_uuid() following transaction commit. An alternative would be to generate tab

[ovs-dev] [PATCH v4 2/2] ovs-vsctl: Improve error reporting

2014-03-27 Thread Ben Pfaff
From: Andy Zhou ovs-vsctl is a command-line interface to the Open vSwitch database, and as such it just modifies the desired Open vSwitch configuration in the database. ovs-vswitchd, on the other hand, monitors the database and implements the actual configuration specified in the database. This

Re: [ovs-dev] [PATCH v3] ovs-vsctl: Improve error reporting

2014-03-27 Thread Ben Pfaff
On Thu, Mar 27, 2014 at 05:10:31PM +0100, Thomas Graf wrote: > From: Andy Zhou > > ovs-vsctl is a command-line interface to the Open vSwitch database, > and as such it just modifies the desired Open vSwitch configuration in > the database. ovs-vswitchd, on the other hand, monitors the database >

Re: [ovs-dev] [RFC 7/9] ofproto-dpif: Allow caching of xlate_actions() effects.

2014-03-27 Thread Ben Pfaff
On Fri, Mar 28, 2014 at 02:39:39PM +1300, Joe Stringer wrote: > Looking back through, there was another question I had, relating to the > below XXX comment: > > On 7 March 2014 14:20, Joe Stringer wrote: > > > > @@ -1427,6 +1498,17 @@ xlate_normal(struct xlate_ctx *ctx) > > if (ctx->xin->may

Re: [ovs-dev] [RFC 7/9] ofproto-dpif: Allow caching of xlate_actions() effects.

2014-03-27 Thread Joe Stringer
Looking back through, there was another question I had, relating to the below XXX comment: On 7 March 2014 14:20, Joe Stringer wrote: > > @@ -1427,6 +1498,17 @@ xlate_normal(struct xlate_ctx *ctx) > if (ctx->xin->may_learn) { > update_learning_table(ctx->xbridge, flow, wc, vlan, in_

Re: [ovs-dev] [PATCH 1/1] Python Logging Formatting Improvements

2014-03-27 Thread Ben Pfaff
On Thu, Mar 27, 2014 at 02:28:29PM +, Dave Tucker wrote: > The Open vSwitch daemons written in C support user-configured logging > patterns as described in ovs-appctl(8). This commit adds this capability > to the daemons written in Python. > > - Add a '__log_patterns' attribute to the Vlog cla

Re: [ovs-dev] [PATCH] configure: making sparse happy.

2014-03-27 Thread Ben Pfaff
On Thu, Mar 27, 2014 at 03:44:59PM -0700, Pritesh Kothari wrote: > Sparse is unhappy because the system include path is ahead of the > local include path. This patch fixes that and has a clean run for > sparse. > > Signed-off-by: Pritesh Kothari This reads like two mostly unrelated changes to me

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-03-27 Thread Jesse Gross
On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme wrote: > Minimize padding in sw_flow_key and move 'tp' top the main struct. > These changes simplify code when accessing the transport port numbers > and the tcp flags, and makes the sw_flow_key 8 bytes smaller on 64-bit > systems (128->120 bytes).

[ovs-dev] [PATCH] configure: making sparse happy.

2014-03-27 Thread Pritesh Kothari
Sparse is unhappy because the system include path is ahead of the local include path. This patch fixes that and has a clean run for sparse. Signed-off-by: Pritesh Kothari --- Makefile.am |4 ++-- lib/dpif-netdev.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[ovs-dev] stylizers

2014-03-27 Thread Wamser Shutty
her land? Aye, for H --- Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce que la protection avast! Antivirus est active. http://www.avast.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

[ovs-dev] Kedves "webmail fiók USER"

2014-03-27 Thread Technical Support
-- Figyelmeztető e-mail fiók frissíteni kell / Adja meg felhasználó nevét és jelszavát a megfelelő helyre (), annak érdekében, hogy újból érvényesíti a számla postafiók. Ön köteles válaszolni erre az e-mail a következő 48 hours.Failure, hogy visszatér hozzánk, a Webmail fiók lehet kikapc

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Jesse Gross
On Thu, Mar 27, 2014 at 7:05 AM, Flavio Leitner wrote: > There are two problematic situations. > > A deadlock can happen when is_percpu is false because it can get > interrupted while holding the spinlock. Then it executes > ovs_flow_stats_update() in softirq context which tries to get > the same

Re: [ovs-dev] [PATCH V2 09/10] dpif-netdev: Add DPDK netdev.

2014-03-27 Thread Ben Pfaff
On Thu, Mar 27, 2014 at 09:49:58AM -0700, Pravin Shelar wrote: > On Wed, Mar 26, 2014 at 12:22 PM, Ed Maste wrote: > > On 21 March 2014 14:03, Pravin wrote: > >> Following patch adds DPDK netdev-class to userspace datapath. Now > >> OVS can use DPDK port for IO by just configuring DPDK port and t

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Pravin Shelar
On Thu, Mar 27, 2014 at 1:01 PM, Jesse Gross wrote: > On Thu, Mar 27, 2014 at 11:40 AM, Pravin Shelar wrote: >> On Thu, Mar 27, 2014 at 11:32 AM, Jesse Gross wrote: >>> On Thu, Mar 27, 2014 at 10:44 AM, Flavio Leitner wrote: On Thu, Mar 27, 2014 at 10:37:32AM -0700, Jesse Gross wrote:

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Jesse Gross
On Thu, Mar 27, 2014 at 11:40 AM, Pravin Shelar wrote: > On Thu, Mar 27, 2014 at 11:32 AM, Jesse Gross wrote: >> On Thu, Mar 27, 2014 at 10:44 AM, Flavio Leitner wrote: >>> On Thu, Mar 27, 2014 at 10:37:32AM -0700, Jesse Gross wrote: On Thu, Mar 27, 2014 at 10:33 AM, Flavio Leitner wrote:

Re: [ovs-dev] [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

2014-03-27 Thread David Miller
From: Zoltan Kiss Date: Wed, 26 Mar 2014 22:37:45 + > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't > orphan them. Also, it doesn't handle errors, so this patch takes care of that > as well, and modify the callers accordingly. skb_tx_error() is also added to >

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Pravin Shelar
On Thu, Mar 27, 2014 at 11:32 AM, Jesse Gross wrote: > On Thu, Mar 27, 2014 at 10:44 AM, Flavio Leitner wrote: >> On Thu, Mar 27, 2014 at 10:37:32AM -0700, Jesse Gross wrote: >>> On Thu, Mar 27, 2014 at 10:33 AM, Flavio Leitner wrote: >>> > On Thu, Mar 27, 2014 at 10:19:23AM -0700, Pravin Shelar

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-27 Thread Kyle Mestery
On Thu, Mar 27, 2014 at 1:28 PM, Jesse Gross wrote: > I think it would be normally OK although there is currently a patch > pending that might make it into 3.14 and will require some support in > OVS: > > "core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle > errors" > > OK, given

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Jesse Gross
On Thu, Mar 27, 2014 at 10:44 AM, Flavio Leitner wrote: > On Thu, Mar 27, 2014 at 10:37:32AM -0700, Jesse Gross wrote: >> On Thu, Mar 27, 2014 at 10:33 AM, Flavio Leitner wrote: >> > On Thu, Mar 27, 2014 at 10:19:23AM -0700, Pravin Shelar wrote: >> >> On Thu, Mar 27, 2014 at 7:05 AM, Flavio Leitn

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-27 Thread Jesse Gross
I think it would be normally OK although there is currently a patch pending that might make it into 3.14 and will require some support in OVS: "core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors" On Thu, Mar 27, 2014 at 11:19 AM, Kyle Mestery wrote: > Pravin, one more cha

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-27 Thread Kyle Mestery
Pravin, one more change I want to make here. Since 3.14 is almost out, would you be ok if I bump this up to claim 3.14 support? I don't see any large API changes coming out between now and when 3.14 is due next week, so let me know. Otherwise, I can do another patch for 3.14 next week. Thanks, Kyl

[ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-27 Thread Kyle Mestery
Add support for building the in-tree kernel datapath for Linux kernel 3.13. There were some changes in the netlink area which required adding new compatibility code for this layer. Signed-off-by: Kyle Mestery --- v3: Correctly make genl_register_family backwards compatible. v2: Address a few com

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-27 Thread Kyle Mestery
On Thu, Mar 27, 2014 at 12:09 PM, Pravin Shelar wrote: > On Wed, Mar 26, 2014 at 4:32 PM, Kyle Mestery > wrote: > > On Tue, Mar 25, 2014 at 3:36 PM, Pravin Shelar > wrote: > >> > >> On Fri, Mar 21, 2014 at 10:41 AM, Kyle Mestery > >> wrote: > >> > Add support for building the in-tree kernel da

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Flavio Leitner
On Thu, Mar 27, 2014 at 10:37:32AM -0700, Jesse Gross wrote: > On Thu, Mar 27, 2014 at 10:33 AM, Flavio Leitner wrote: > > On Thu, Mar 27, 2014 at 10:19:23AM -0700, Pravin Shelar wrote: > >> On Thu, Mar 27, 2014 at 7:05 AM, Flavio Leitner wrote: > >> > There are two problematic situations. > >> >

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Jesse Gross
On Thu, Mar 27, 2014 at 10:33 AM, Flavio Leitner wrote: > On Thu, Mar 27, 2014 at 10:19:23AM -0700, Pravin Shelar wrote: >> On Thu, Mar 27, 2014 at 7:05 AM, Flavio Leitner wrote: >> > There are two problematic situations. >> > >> > A deadlock can happen when is_percpu is false because it can get

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Flavio Leitner
On Thu, Mar 27, 2014 at 10:19:23AM -0700, Pravin Shelar wrote: > On Thu, Mar 27, 2014 at 7:05 AM, Flavio Leitner wrote: > > There are two problematic situations. > > > > A deadlock can happen when is_percpu is false because it can get > > interrupted while holding the spinlock. Then it executes >

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Jiri Pirko
Thu, Mar 27, 2014 at 06:20:48PM CET, tg...@suug.ch wrote: >On 03/27/14 at 09:27am, Florian Fainelli wrote: >> 2014-03-27 4:02 GMT-07:00 Thomas Graf : >> > There is definitely need beyond an ndo that is capable of >> > adding flows. You mention routes. Another example would be >> > devices capable o

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Thomas Graf
On 03/27/14 at 09:27am, Florian Fainelli wrote: > 2014-03-27 4:02 GMT-07:00 Thomas Graf : > > There is definitely need beyond an ndo that is capable of > > adding flows. You mention routes. Another example would be > > devices capable of offloading iptables & nft rules. > > Those devices usually r

Re: [ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Pravin Shelar
On Thu, Mar 27, 2014 at 7:05 AM, Flavio Leitner wrote: > There are two problematic situations. > > A deadlock can happen when is_percpu is false because it can get > interrupted while holding the spinlock. Then it executes > ovs_flow_stats_update() in softirq context which tries to get > the same

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-27 Thread Pravin Shelar
On Wed, Mar 26, 2014 at 4:32 PM, Kyle Mestery wrote: > On Tue, Mar 25, 2014 at 3:36 PM, Pravin Shelar wrote: >> >> On Fri, Mar 21, 2014 at 10:41 AM, Kyle Mestery >> wrote: >> > Add support for building the in-tree kernel datapath for Linux kernel >> > 3.13. >> > There were some changes in the ne

Re: [ovs-dev] [PATCH v2] stream-tcp: Fix error message for failed TCP_NODELAY setting on Windows.

2014-03-27 Thread Gurucharan Shetty
On Thu, Mar 27, 2014 at 10:01 AM, Ben Pfaff wrote: > Reported-by: Gurucharan Shetty > Signed-off-by: Ben Pfaff Acked-by: Gurucharan Shetty > --- > v1->v2: Fix author. > > lib/stream-tcp.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/stream-tcp.c b/lib/str

Re: [ovs-dev] [PATCH v2] stream-tcp: Fix error message for failed TCP_NODELAY setting on Windows.

2014-03-27 Thread Kyle Mestery
On Thu, Mar 27, 2014 at 12:01 PM, Ben Pfaff wrote: > Reported-by: Gurucharan Shetty > Signed-off-by: Ben Pfaff > --- > v1->v2: Fix author. > > lib/stream-tcp.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/stream-tcp.c b/lib/stream-tcp.c > index 55e5818..4c

Re: [ovs-dev] [PATCH] stream-tcp: Fix error message for failed TCP_NODELAY setting on Windows.

2014-03-27 Thread Ben Pfaff
On Thu, Mar 27, 2014 at 09:58:18AM -0700, Gurucharan Shetty wrote: > On Thu, Mar 27, 2014 at 9:56 AM, Ben Pfaff wrote: > > From: Ben Pfaff > Can you change the AUTHOR here. Oops, fixed, see v2. ___ dev mailing list dev@openvswitch.org http://openvswitc

[ovs-dev] [PATCH v2] stream-tcp: Fix error message for failed TCP_NODELAY setting on Windows.

2014-03-27 Thread Ben Pfaff
Reported-by: Gurucharan Shetty Signed-off-by: Ben Pfaff --- v1->v2: Fix author. lib/stream-tcp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/stream-tcp.c b/lib/stream-tcp.c index 55e5818..4cd4e6f 100644 --- a/lib/stream-tcp.c +++ b/lib/stream-tcp.c @@ -55,9 +55

Re: [ovs-dev] [PATCH] stream-tcp: Fix error message for failed TCP_NODELAY setting on Windows.

2014-03-27 Thread Kyle Mestery
On Thu, Mar 27, 2014 at 11:56 AM, Ben Pfaff wrote: > From: Ben Pfaff > > Is this the right author? > Reported-by: Gurucharan Shetty > Signed-off-by: Ben Pfaff > --- > lib/stream-tcp.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/stream-tcp.c b/lib/strea

Re: [ovs-dev] [PATCH] stream-tcp: Fix error message for failed TCP_NODELAY setting on Windows.

2014-03-27 Thread Gurucharan Shetty
On Thu, Mar 27, 2014 at 9:56 AM, Ben Pfaff wrote: > From: Ben Pfaff Can you change the AUTHOR here. > > Reported-by: Gurucharan Shetty > Signed-off-by: Ben Pfaff Otherwise looks good to me. Thanks. > --- > lib/stream-tcp.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff

[ovs-dev] [PATCH] stream-tcp: Fix error message for failed TCP_NODELAY setting on Windows.

2014-03-27 Thread Ben Pfaff
From: Ben Pfaff Reported-by: Gurucharan Shetty Signed-off-by: Ben Pfaff --- lib/stream-tcp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/stream-tcp.c b/lib/stream-tcp.c index 55e5818..4cd4e6f 100644 --- a/lib/stream-tcp.c +++ b/lib/stream-tcp.c @@ -55,9 +55,11

Re: [ovs-dev] [PATCH V2 09/10] dpif-netdev: Add DPDK netdev.

2014-03-27 Thread Pravin Shelar
On Wed, Mar 26, 2014 at 12:22 PM, Ed Maste wrote: > On 21 March 2014 14:03, Pravin wrote: >> Following patch adds DPDK netdev-class to userspace datapath. Now >> OVS can use DPDK port for IO by just configuring DPDK port and then >> adding dpdk type port to userspace datapath. > > Intel recently

[ovs-dev] [PATCH 4/5] ofproto: Define ofproto_flow_lookup()

2014-03-27 Thread Pravin
Define ofproto flow lookup function that can be used by dpif implementation. Signed-off-by: Pravin B Shelar --- ofproto/ofproto-dpif-upcall.c | 68 + ofproto/ofproto-dpif-upcall.h |8 + ofproto/ofproto-dpif-xlate.c | 34 +

[ovs-dev] [PATCH] datapath: Add support for kernel 3.13

2014-03-27 Thread Kyle Mestery
Add support for building the in-tree kernel datapath for Linux kernel 3.13. There were some changes in the netlink area which required adding new compatibility code for this layer. Signed-off-by: Kyle Mestery --- v2: Address a few comments from Pravin. Some of those comments proved challengin

[ovs-dev] [PATCH 1/5] dpif: Introduce ofproto flow lookup function.

2014-03-27 Thread Pravin
This patch does not change any functionality. Signed-off-by: Pravin B Shelar --- lib/dpif.c |5 + lib/dpif.h | 23 +++ 2 files changed, 28 insertions(+) diff --git a/lib/dpif.c b/lib/dpif.c index 6649176..dc1e8c0 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -56,6 +5

[ovs-dev] [PATCH 3/5] dpif: Pass ofproto lookup callback data to dpif_create()

2014-03-27 Thread Pravin
dpif implementation need callback data for flow lookup. This patch does not change any functionality. Signed-off-by: Pravin B Shelar --- lib/dpif-linux.c |2 +- lib/dpif-netdev.c | 11 +++ lib/dpif-provider.h |4 +++- lib/dpif.c

[ovs-dev] [PATCH 5/5] dpif-netdev: Use ofproto_flow_lookup() callback

2014-03-27 Thread Pravin
dpif-netdev queue packet to upcall handler thread to process flow misses. This adds latency for initial flow setup. Using ofproto flow lookup method for netdev flow-table miss can be handled in same thread. Signed-off-by: Pravin B Shelar --- lib/dpif-netdev.c | 50

[ovs-dev] [PATCH 2/5] flow: Add flow_mask_unwildcard_all()

2014-03-27 Thread Pravin
This function will be used by later commit. Signed-off-by: Pravin B Shelar --- lib/dpif-netdev.c | 16 +--- lib/meta-flow.c | 20 lib/meta-flow.h |1 + 3 files changed, 22 insertions(+), 15 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netde

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Florian Fainelli
2014-03-27 4:02 GMT-07:00 Thomas Graf : > On 03/27/14 at 06:27am, Jamal Hadi Salim wrote: >> On 03/27/14 03:21, Jiri Pirko wrote: >> >Wed, Mar 26, 2014 at 10:44:31PM CET, j...@mojatatu.com wrote: >> >> >Well, I think there are 2 main models to be considered: >> >1. OSV-like model, where everything

Re: [ovs-dev] [PATCH] ovs-vsctl: Improve error reporting

2014-03-27 Thread Andy Zhou
On Thu, Mar 27, 2014 at 9:08 AM, Thomas Graf wrote: > On 03/27/2014 04:48 PM, Andy Zhou wrote: >> >> On Thu, Mar 27, 2014 at 3:36 AM, Thomas Graf wrote: >>> >>> On 03/27/2014 10:04 AM, Andy Zhou wrote: * Thomas: Some of the code and ideas are imported from your 12/11/2012

[ovs-dev] [PATCH v3] ovs-vsctl: Improve error reporting

2014-03-27 Thread Thomas Graf
From: Andy Zhou ovs-vsctl is a command-line interface to the Open vSwitch database, and as such it just modifies the desired Open vSwitch configuration in the database. ovs-vswitchd, on the other hand, monitors the database and implements the actual configuration specified in the database. This

Re: [ovs-dev] [PATCH] ovs-vsctl: Improve error reporting

2014-03-27 Thread Thomas Graf
On 03/27/2014 04:48 PM, Andy Zhou wrote: On Thu, Mar 27, 2014 at 3:36 AM, Thomas Graf wrote: On 03/27/2014 10:04 AM, Andy Zhou wrote: * Thomas: Some of the code and ideas are imported from your 12/11/2012 patch titled "ovs-vsctl: Check "ofport" column after adding a new port", and sub

Re: [ovs-dev] [PATCH] ovs-vsctl: Improve error reporting

2014-03-27 Thread Andy Zhou
On Thu, Mar 27, 2014 at 3:36 AM, Thomas Graf wrote: > On 03/27/2014 10:04 AM, Andy Zhou wrote: >> >> * Thomas: Some of the code and ideas are imported from your >>12/11/2012 patch titled "ovs-vsctl: Check "ofport" column after >>adding a new port", and subsequent mailing list discussions.

[ovs-dev] [PATCH 1/1] Python Logging Formatting Improvements

2014-03-27 Thread Dave Tucker
The Open vSwitch daemons written in C support user-configured logging patterns as described in ovs-appctl(8). This commit adds this capability to the daemons written in Python. - Add a '__log_patterns' attribute to the Vlog class - Populate this using the default patterns in ovs-appctl(8) - Add a

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread John W. Linville
On Thu, Mar 27, 2014 at 01:57:11PM +0100, Jiri Pirko wrote: > Thu, Mar 27, 2014 at 01:32:35PM CET, j...@mojatatu.com wrote: > >On 03/27/14 08:00, Thomas Graf wrote: > > > >>It seems like we reached pretty good consensus on the model. What > >>remaining issues do you see with the port model proposed

[ovs-dev] [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Flavio Leitner
There are two problematic situations. A deadlock can happen when is_percpu is false because it can get interrupted while holding the spinlock. Then it executes ovs_flow_stats_update() in softirq context which tries to get the same lock. The second sitation is that when is_percpu is true, the code

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Jiri Pirko
Thu, Mar 27, 2014 at 01:32:35PM CET, j...@mojatatu.com wrote: >On 03/27/14 08:00, Thomas Graf wrote: > >>It seems like we reached pretty good consensus on the model. What >>remaining issues do you see with the port model proposed in v2? >> > >Are we really following the same thread? >I dont see any

[ovs-dev] [PATCH net] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Flavio Leitner
There are two problematic situations. A deadlock can happen when is_percpu is false because it can get interrupted while holding the spinlock. Then it executes ovs_flow_stats_update() in softirq context which tries to get the same lock. The second sitation is that when is_percpu is true, the code

Re: [ovs-dev] [PATCH net] openvswitch: fix a possible deadlock and lockdep warning

2014-03-27 Thread Flavio Leitner
Please ignore this one. I will repost with the correct openvswitch address. Thanks On Wed, Mar 26, 2014 at 09:56:12PM -0300, Flavio Leitner wrote: > There are two problematic situations. > > A deadlock can happen when is_percpu is false because it can get > interrupted while holding the spinlock.

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Jamal Hadi Salim
On 03/27/14 08:00, Thomas Graf wrote: It seems like we reached pretty good consensus on the model. What remaining issues do you see with the port model proposed in v2? Are we really following the same thread? I dont see any rallying behind Jiri's approach from the other folks who have their o

[ovs-dev] ★ Dev, Nour a laissé un message pour toi

2014-03-27 Thread Nour
Nour a laissé un message pour toi L'expéditeur et le contenu seront visibles seulement par toi et tu peux le supprimer à tout moment. Tu peux aussi y répondre directement au travers du messenger. Pour découvrir le message, suis simplement ce lien : http://eu1.badoo.com/0378406584/in/6hmHkQTt4LE/

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Thomas Graf
On 03/27/14 at 07:17am, Jamal Hadi Salim wrote: > On 03/27/14 07:02, Thomas Graf wrote: > >But wouldn't you want to introduce an additional ndo to > >cover these? > > We could - I just find it distracting at the current thread > of discussion (the openwrt folks for example dont need any > or most

Re: [ovs-dev] [patch net-next RFC v2 4/6] net: introduce switchdev API

2014-03-27 Thread Jiri Pirko
Thu, Mar 27, 2014 at 12:23:39PM CET, tg...@suug.ch wrote: >On 03/26/14 at 05:31pm, Jiri Pirko wrote: >> switchdev API is designed to allow kernel support for various switch >> chips. >> >> It is the responsibility of a driver to create netdevice instances which >> represents every port and for the

Re: [ovs-dev] [patch net-next RFC v2 4/6] net: introduce switchdev API

2014-03-27 Thread Thomas Graf
On 03/26/14 at 05:31pm, Jiri Pirko wrote: > switchdev API is designed to allow kernel support for various switch > chips. > > It is the responsibility of a driver to create netdevice instances which > represents every port and for the switch master itself. Driver uses > swdev_register and swportde

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Jamal Hadi Salim
On 03/27/14 07:02, Thomas Graf wrote: On 03/27/14 at 06:27am, Jamal Hadi Salim wrote: There is definitely need beyond an ndo that is capable of adding flows. You mention routes. Another example would be devices capable of offloading iptables & nft rules. nod. But wouldn't you want to intr

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Thomas Graf
On 03/27/14 at 06:27am, Jamal Hadi Salim wrote: > On 03/27/14 03:21, Jiri Pirko wrote: > >Wed, Mar 26, 2014 at 10:44:31PM CET, j...@mojatatu.com wrote: > > >Well, I think there are 2 main models to be considered: > >1. OSV-like model, where everything is flows and that is the OneWay(tm) > >mod

Re: [ovs-dev] [PATCH] ovs-vsctl: Improve error reporting

2014-03-27 Thread Thomas Graf
On 03/27/2014 10:04 AM, Andy Zhou wrote: * Thomas: Some of the code and ideas are imported from your 12/11/2012 patch titled "ovs-vsctl: Check "ofport" column after adding a new port", and subsequent mailing list discussions. Please feel free to review, fix and enhance the patch as yo

Re: [ovs-dev] [patch net-next RFC v2 2/6] skbuff: add "missed_flow" flag

2014-03-27 Thread Jiri Pirko
Thu, Mar 27, 2014 at 11:31:42AM CET, nicolas.dich...@6wind.com wrote: >Le 26/03/2014 17:31, Jiri Pirko a écrit : >>This flag sets incoming switch device in order to let know that the flow >>which the skb is part of is missed. Listener may react to it >>appropriately, >> >>Signed-off-by: Jiri Pirko

Re: [ovs-dev] [patch net-next RFC v2 2/6] skbuff: add "missed_flow" flag

2014-03-27 Thread Nicolas Dichtel
Le 26/03/2014 17:31, Jiri Pirko a écrit : This flag sets incoming switch device in order to let know that the flow which the skb is part of is missed. Listener may react to it appropriately, Signed-off-by: Jiri Pirko --- include/linux/filter.h | 1 + include/linux/skbuff.h | 13

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Jamal Hadi Salim
On 03/27/14 03:21, Jiri Pirko wrote: Wed, Mar 26, 2014 at 10:44:31PM CET, j...@mojatatu.com wrote: Well, I think there are 2 main models to be considered: 1. OSV-like model, where everything is flows and that is the OneWay(tm) mode you mentioned :) 2. clasic switch setting-like model where

[ovs-dev] [PATCH v2] ovs-vsctl: Improve error reporting

2014-03-27 Thread Thomas Graf
From: Andy Zhou ovs-vsctl is a command-line interface to the Open vSwitch database, and as such it just modifies the desired Open vSwitch configuration in the database. ovs-vswitchd, on the other hand, monitors the database and implements the actual configuration specified in the database. This

[ovs-dev] [PATCH] ovs-vsctl: Improve error reporting

2014-03-27 Thread Andy Zhou
ovs-vsctl is a command-line interface to the Open vSwitch database, and as such it just modifies the desired Open vSwitch configuration in the database. ovs-vswitchd, on the other hand, monitors the database and implements the actual configuration specified in the database. This can lead to surpri

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Jiri Pirko
Wed, Mar 26, 2014 at 10:57:09PM CET, f.faine...@gmail.com wrote: >2014-03-26 14:44 GMT-07:00 Jamal Hadi Salim : >> Jiri, >> >> The flow extensions may be distracting - note there are many >> tables (L3, L2, etc) in such chips not just ACLs. And there's likely no >> OneWay(tm) to add a flow. My view

Re: [ovs-dev] [patch net-next RFC v2 0/6] introduce infrastructure for support of switch chip datapath

2014-03-27 Thread Jiri Pirko
Wed, Mar 26, 2014 at 10:44:31PM CET, j...@mojatatu.com wrote: >Jiri, > >The flow extensions may be distracting - note there are many >tables (L3, L2, etc) in such chips not just ACLs. And there's likely no >OneWay(tm) to add a flow. My view is probably to solve or reach an >agreement on the ports.