On Mar 27, 2014, at 4:52 PM, Ben Pfaff <b...@nicira.com> wrote:

> On Thu, Mar 27, 2014 at 03:44:59PM -0700, Pritesh Kothari wrote:
>> Sparse is unhappy because the system include path is ahead of the
>> local include path. This patch fixes that and has a clean run for
>> sparse.
>> 
>> Signed-off-by: Pritesh Kothari <pritesh.koth...@cisco.com>
> 
> This reads like two mostly unrelated changes to me.  The first fixes
> problems because it makes sure that include/ precedes /usr/include in
> the #include path, so that include/linux/types.h and
> include/linux/openvswitch.h take precedence over the similar files in
> /usr/include/linux.  The second works around a bug in sparse (and it
> would be nice to mention the error message that sparse gives).  Would
> you mind breaking it up into two commits?

sure will break this into two patches and will send it.

Regards,
Pritesh

> 
> Thanks,
> 
> Ben.

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to