On 03/27/2014 10:04 AM, Andy Zhou wrote:
* Thomas: Some of the code and ideas are imported from your 12/11/2012 patch titled "ovs-vsctl: Check "ofport" column after adding a new port", and subsequent mailing list discussions. Please feel free to review, fix and enhance the patch as you see fit. More testing will is definitly needed. If make sense, we can add more unit test cases. The ovs-vsctl manpage needs to be updated. Please re-post the patch as v2 when you are done with your changes.
This looks excellent. I sent a V2 with a slightly improved error message. We might considering renaming 'iface' to object as we add additional status columns for other mutable objects that can fail. Also, another idea that we can consider is coming up with additional status in 'ovs-vsctl show' and check for ofport -1 and indicate that the port has not been set up correctly. What do you think? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
