Re: Apache 2.0 License headers in source files

2020-03-26 Thread Justin Mclean
Hi, > For the Sony contributions I will change the license in all contributed > files as soon as I get clearance from our department They would need to submit a SGA to the ASF for this to happen. Thanks, Justin

Re: Apache 2.0 License headers in source files

2020-03-26 Thread Alin Jerpelea
Hi all, I think that we as mainainers should look at all code that we know and involves us and do the change area by area For the Sony contributions I will change the license in all contributed files as soon as I get clearance from our department Regards Alin On Sat, Mar 21, 2020 at 1:24 AM Ada

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Adam Feuer
Thanks Justin. I think Brennan is volunteering to be release manager and get the next one out, as long as we can start a license clearing process and make things a little better (become more Apache-like :) ) each release. Here's what Brennan and I are planning for this weekend: 1. We're going t

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Justin Mclean
Hi, INAL but the copyright notice in the header is just a claim and may not reflect who actually has copyright. It doesn’t mean that that person or company owns the copyright on the entire file. With a company it’s usually easier as employment contracts say the company owns the copyright of wor

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Adam Feuer
For the license clearing part, I think the next piece of work to do is license clearing for all the files under sched/ as a test of this process: https://cwiki.apache.org/confluence/display/NUTTX/License+Clearing As noted in a previous email, there are: - 285 total files - 114 files have o

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Brennan Ashton
On Fri, Mar 20, 2020, 8:19 AM Gregory Nutt wrote: > > We CANNOT just go and update the headers on files unless Greg is the > >> only > author and all other non trivial contributors have signed some form of > CLA. I would feel very uncomfortable signing off on a release > without a

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Gregory Nutt
We CANNOT just go and update the headers on files unless Greg is the only author and all other non trivial contributors have signed some form of CLA. I would feel very uncomfortable signing off on a release without a review of these files that got changed, disclaimer or not. Is it enough th

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Nathan Hartman
On Fri, Mar 20, 2020 at 10:37 AM Brennan Ashton wrote: > On Fri, Mar 20, 2020, 7:29 AM Nathan Hartman > wrote: > > I'd like to nudge (or pehaps push and shove) Apache NuttX toward > > making our first release as an Apache podling. Along those lines I'd > > like to revive this conversation... > >

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Brennan Ashton
On Fri, Mar 20, 2020, 8:01 AM Gregory Nutt wrote: > > >> We CANNOT just go and update the headers on files unless Greg is the > only > >> author and all other non trivial contributors have signed some form of > >> CLA. I would feel very uncomfortable signing off on a release without a > >> revie

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Gregory Nutt
We CANNOT just go and update the headers on files unless Greg is the only author and all other non trivial contributors have signed some form of CLA. I would feel very uncomfortable signing off on a release without a review of these files that got changed, disclaimer or not. Is it enough tha

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Xiang Xiao
On Fri, Mar 20, 2020 at 10:46 PM Gregory Nutt wrote: > > > > I'd like to nudge (or pehaps push and shove) Apache NuttX toward > > making our first release as an Apache podling. > The last release, 8.2, was from mid-November 2019. Releases had been > been made religiously every two months for year

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Xiang Xiao
On Fri, Mar 20, 2020 at 10:37 PM Brennan Ashton wrote: > > On Fri, Mar 20, 2020, 7:29 AM Nathan Hartman > wrote: > > > On Sat, Mar 7, 2020 at 9:45 PM Brennan Ashton > > wrote: > > > Adam if you look back I have a hosted instance of it running for the > > > project, no sense in duplicating the wo

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Gregory Nutt
I'd like to nudge (or pehaps push and shove) Apache NuttX toward making our first release as an Apache podling. The last release, 8.2, was from mid-November 2019.  Releases had been been made religiously every two months for years up until 8.2. We are approaching 6 months with no releases.  I

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Brennan Ashton
On Fri, Mar 20, 2020, 7:29 AM Nathan Hartman wrote: > On Sat, Mar 7, 2020 at 9:45 PM Brennan Ashton > wrote: > > Adam if you look back I have a hosted instance of it running for the > > project, no sense in duplicating the work. I'm happy to provide you an > > account. The nice thing about using

Re: Apache 2.0 License headers in source files

2020-03-20 Thread Nathan Hartman
On Sat, Mar 7, 2020 at 9:45 PM Brennan Ashton wrote: > Adam if you look back I have a hosted instance of it running for the > project, no sense in duplicating the work. I'm happy to provide you an > account. The nice thing about using this is that the reports can be shared > publicly and we can us

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Adam Feuer
Thanks Justin. I really appreciate the links to the presentations and docs. I'll check them out. :) -adam On Sat, Mar 7, 2020 at 8:28 PM Justin Mclean wrote: > Hi. > > I wold also read [1][2]. I have also given talks at ApacheCon on this, see > [3][4] for examples. Both [3] and I think [4] pred

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Justin Mclean
Hi. I wold also read [1][2]. I have also given talks at ApacheCon on this, see [3][4] for examples. Both [3] and I think [4] predate the work in progress disclaimer, which makes it easier for you. Thanks, Justin 1. https://www.apache.org/legal/resolved.html 2. http://www.apache.org/dev/licensi

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Adam Feuer
Justin, Thank you for the pointer to Brennan's email. I'll look more RAT once I understand more about what needs to be done with the licenses. cheers adam On Sat, Mar 7, 2020 at 7:13 PM Justin Mclean wrote: > Hi, > > > I tried using the mailing list search link you provided, but couldn't > fin

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Adam Feuer
Brennan, Cool, thanks, I would like a login to the fossology server. I also don't exactly understand what needs to be done with the fossology reports... is there a wiki page or something that documents the process we need to follow? cheers adam On Sat, Mar 7, 2020 at 6:45 PM Brennan Ashton wrot

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Justin Mclean
Hi, > I tried using the mailing list search link you provided, but couldn't find > any previous discussions. It defaults to 1 month old, try change to greater than 0 days or up the months to 4. Use advanced search and type “license" into the subject line. One of the first hits is [1]. Brennan h

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Brennan Ashton
Adam if you look back I have a hosted instance of it running for the project, no sense in duplicating the work. I'm happy to provide you an account. The nice thing about using this is that the reports can be shared publicly and we can use the proper flow of working through the identified license an

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Adam Feuer
Thanks Justin. I tried using the mailing list search link you provided, but couldn't find any previous discussions. (That Pony mailing list search tool is hard to use.) I also searched the archives with Google and only came up with a couple of messages from Greg saying that new files should have t

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Justin Mclean
Hi, > Does Apache have a recommended way to use the Fossology tool as part of a > project? In general no but your setup is complex. > Or how a podling should use it? Generally they use RAT but that is defined for simpler situations. [1] It still good idea too use it as part of your release che

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Justin Mclean
HI, Rather than having this discussion yet again, please look back through the archives [1] and see what has already been said on this subject (just search for license). Apache also has tools to help you with this, although given the complexity of what you have they may be of limited use. Than

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Adam Feuer
Justin, Ok, I installed Fossology on my personal workstation, and I verified the instance works and can scan the github.com/apache/incubator-nuttx repo. I am not sure how to use it or what the process of "clearing" software licenses is. Does Apache have a recommended way to use the Fossology tool

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Adam Feuer
Justin, I installed a Fossology instance right now using Docker (the docker-compose version) and am running it against nuttx source code. I have never used fossology, but I'll post the results to the list if I can get an intelligible report out of it. :) cheers adam On Sat, Mar 7, 2020 at 5:27 A

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Justin Mclean
HI, > Brennan has made the initial report here: > https://fossology.brennanashton.com/repo/?mod=browse&show=quick&folder=2 > We can run Adam's tools and fossology iteratively utils all copyright > issue get resolved. Adam tool as it currently is will induce issues that will be harder to detect d

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Adam Feuer
Hi Greg, I'm sorry for introducing the errors. I'm glad we found them even after the merge. Re: 1 and 2, if we want to keep using the tool, I can fix those errors. cheers adam On Sat, Mar 7, 2020 at 3:45 AM Gregory Nutt wrote: > I just reviewed the changes that your tool made via PR 449. The

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Xiang Xiao
On Sat, Mar 7, 2020 at 9:27 PM Justin Mclean wrote: > > Hi, > > > For now, I think I think that you could just find all files that contain my > > Copyright (grep -rl "Gregory Nutt" *), and then make sure the word > > Copyright appears only once in the file (count=`grep Copyright $file1`; if > >

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Justin Mclean
Hi, > For now, I think I think that you could just find all files that contain my > Copyright (grep -rl "Gregory Nutt" *), and then make sure the word Copyright > appears only once in the file (count=`grep Copyright $file1`; if [ $count -eq > 1 ]; then …) I would take care with this, copyright

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Gregory Nutt
2.Add an option to change the license for a particular author For now, I think I think that you could just find all files that contain my Copyright (grep -rl "Gregory Nutt" *), and then make sure the word Copyright appears only once in the file (count=`grep Copyright $file1`; if [ $count -e

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Xiang Xiao
We are in apache incubation phase more than 3 months, but it is very sad that we don't have any real progress in the copyright cleanup process. Adam's tools is a good start point, at least if we: 1.Fix the issue metioned by Greg 2.Add an option to change the license for a particular author Then, we

Re: Apache 2.0 License headers in source files

2020-03-07 Thread Gregory Nutt
I just reviewed the changes that your tool made via PR 449.  They are bad and introduce errors into the program.  I have submitted PR469 to revert them. You tool is not mature enough and has not had sufficent review. Here are at least unacceptable errors introduced by the tool: 1. The to

Re: Apache 2.0 License headers in source files

2020-03-06 Thread Adam Feuer
Thanks Greg and Justin. I read the page that Justin linked to— that was helpful. cheers adam On Fri, Mar 6, 2020 at 7:30 PM Justin Mclean wrote: > Hi, > > Your cannot change the license header without the owners permission and > it’s ASF policy to not change any copyright notices without permis

Re: Apache 2.0 License headers in source files

2020-03-06 Thread Justin Mclean
Hi, Your cannot change the license header without the owners permission and it’s ASF policy to not change any copyright notices without permission. Greg has given his permission via a software grant but there is still a large amount of 3rd party code in the repo.. Is some cases existing files d

Re: Apache 2.0 License headers in source files

2020-03-06 Thread Gregory Nutt
We have to be careful with copyrights on the files.  I have provided a software grant to the ASF and have agreed to change the license to Apache 2.0 for all of the files for which I am the sole copyright holder.  So I think that those code be changed (provided that there are no other caveats in

Apache 2.0 License headers in source files

2020-03-06 Thread Adam Feuer
Hi, To comply with NuttX coding style in a recent PR, I modified a file license header tool to easily replace license headers in NuttX code. Here's the PR I used it on: https://github.com/apache/incubator-nuttx/pull/449 Here's the tool, the modifications are currently on this branch: https://g