Hi Greg, I'm sorry for introducing the errors. I'm glad we found them even after the merge.
Re: 1 and 2, if we want to keep using the tool, I can fix those errors. cheers adam On Sat, Mar 7, 2020 at 3:45 AM Gregory Nutt <spudan...@gmail.com> wrote: > I just reviewed the changes that your tool made via PR 449. They are > bad and introduce errors into the program. I have submitted PR469 to > revert them. > > You tool is not mature enough and has not had sufficent review. Here are > at least unacceptable errors introduced by the tool: > > 1. > > The tools changes alter the width of the initial block comment. That > will cause nxstyle failures on most of the files. nxstyle will > verify that the width of all block comments may differ from file to > file; nxstyle will assure that the block comments are the same width > throughout the file. Changing the with the header block comment > will introduce nxstyle feils. > > 2. > > The third line of the file header is an (optional) short description > of content of the the file. Your tool erroneously removes that line. > > Automated header file changes can screw up a lot of files, very > quickly. We need to be more careful! > > -- Adam Feuer <a...@starcat.io>
