We are in apache incubation phase more than 3 months, but it is very sad that we don't have any real progress in the copyright cleanup process. Adam's tools is a good start point, at least if we: 1.Fix the issue metioned by Greg 2.Add an option to change the license for a particular author Then, we can: 1.Change source code that we have got the permission to Apache license 2.Contact the rest author give us the permission to change the copyright 3.Keep the rest source code license as is if we can't get the author's permission 4.Document the license status information in the related document Of course, we need improve checkpatch.sh to ensure that all new files have Apache license too.
Thanks Xiang On Sat, Mar 7, 2020 at 7:45 PM Gregory Nutt <spudan...@gmail.com> wrote: > > I just reviewed the changes that your tool made via PR 449. They are > bad and introduce errors into the program. I have submitted PR469 to > revert them. > > You tool is not mature enough and has not had sufficent review. Here are > at least unacceptable errors introduced by the tool: > > 1. > > The tools changes alter the width of the initial block comment. That > will cause nxstyle failures on most of the files. nxstyle will > verify that the width of all block comments may differ from file to > file; nxstyle will assure that the block comments are the same width > throughout the file. Changing the with the header block comment > will introduce nxstyle feils. > > 2. > > The third line of the file header is an (optional) short description > of content of the the file. Your tool erroneously removes that line. > > Automated header file changes can screw up a lot of files, very > quickly. We need to be more careful! >
