For the license clearing part, I think the next piece of work to do is license clearing for all the files under sched/ as a test of this process:
https://cwiki.apache.org/confluence/display/NUTTX/License+Clearing As noted in a previous email, there are: - 285 total files - 114 files have only commits from people listed as NuttX committers - 171 files have commits from a mix of NuttX committers and non-committers This should take a few hours to go through the committer-only files and make sure there's no other copyrights in them. Once they're cleared, we can generate a CSV report of cleared files, then run the licenseheader script to update the headers, and submit a license-header-only PR. I fixed the licenseheader.py tool to preseve file description if present. I'm willing to spend a couple of hours on it this weekend. If Brennan is also, we should be able to have that PR ready to review Monday. Once it's accepted, we will have done an end-to-end run-through of the easy path. Is that enough progress for a release? Then we can run the same process on the hard path, the one with committers and non-committers, and send emails to get ICLAs from the contributors. Once we have done that, I would try this on one other area (maybe fs? it has 178 C files). Then try to do everything remaining, targeting the contributors who have committed the most code... but as Brennan says, we can do that process in future releases. -adam On Fri, Mar 20, 2020 at 8:29 AM Brennan Ashton <bash...@brennanashton.com> wrote: > On Fri, Mar 20, 2020, 8:19 AM Gregory Nutt <spudan...@gmail.com> wrote: > > > > > >>>> We CANNOT just go and update the headers on files unless Greg is the > > >> only > > >>>> author and all other non trivial contributors have signed some form > of > > >>>> CLA. I would feel very uncomfortable signing off on a release > > without a > > >>>> review of these files that got changed, disclaimer or not. > > >>>> > > >>> Is it enough that if the following criteria meet: > > >>> 1.The file is BSD license > > >>> 2.The file is created by Greg > > >>> 3.The file state that Greg is one and only one owner > > >>> Then we can convert it's license to Apache. > > >> This was stated by a mentor in the past. So, based on that, yes, I > > >> believe that that is all that is required. > > > > > > This is not accurate based on what Justin has said and goes against > what > > I > > > know about OSS licensing. This is exactly why we have CLAs, the > > copyright > > > header does not give you rights to my contribution. > > > > > > I would love to be wrong, so if a mentor can comment on this please > > correct > > > me. > > > > There are these comments from Justin Mclean in this mailing list in > > regard to PRs. I won't try to track all of these down. Here is one > > from https://github.com/apache/incubator-nuttx/pull/528 > > > > HI, > > > > The word COPYRIGHT will appear in the BSD license, but not other > > form of the word copyright should appear in the file. I think if > > there is only one Copyright and the name matches, we can change the > > license > > > > I’m not sure this a valid assumption, it is for BSD files copyright > > Gregory Nutt but for for 3rd party files with a single copyright > > please do not change these. Also it not considering the case where a > > BSD license header may of incorrectly been placed on a file. This is > > because ASF policy is slightly different to how the project has > > previously treated 3rd party files. As I said before I would > > strongly recommend not using a script like this to replace the > > headers. Thanks, Justin > > > > But there are probably a dozen others. > > > > The effort to change all of my BSD-3 headers to Apache has been going on > > a very low level since January or February. Perhaps a few hundred > > (probably fewer) have been changed change based on guidance from our > > mentors which we are trying to follow with 100% precision. We have > > backed away that somewhat in the past couple of weeks since following > > our mentor's guidance is apparently causing bad feelings. > > > > Greg > > > > See the three comments here: > https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597485223 > > Which I believe is also in agreement with Adams understanding is as well. > > It is going to be a long path if this is the case but I think if we setup a > process and work through the difference subsystems (Adam has suggested the > scheduler) methodically it won't be too bad. I would just like to see us do > even one little bit as part of this release and call it progress in the > right direction. > > > As for stopping PRs I think long as people has ICLAs or are minor bug > fixes, it's fine but we should avoid changing headers except on new files. > > --Brennan > > > > -- Adam Feuer <a...@starcat.io>
