Re: [ANNOUNCE] New committer: Damian Guy

Well deserved. Congratulations Damian! On Fri, Jun 9, 2017 at 1:34 PM Guozhang Wang wrote: > Hello all, > > > The PMC of Apache Kafka is pleased to announce that we have invited Damian > Guy as a committer to the project. > > Damian has made tremendous contributions to Kafka. He has not only > c

Re: [ANNOUNCE] New Kafka PMC member Ismael Juma

Very well deserved. Congratulations Ismael! On Mon, Jul 10, 2017 at 6:33 AM Viktor Somogyi wrote: > Congrats Ismael :) > > On Fri, Jul 7, 2017 at 6:59 PM, Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > Congratulations Ismael! > > > > > > On Fri, Jul 7, 2017 at 8:26 AM Eno There

Re: [ANNOUNCE] New Kafka PMC member Jason Gustafson

Congratulations Jason! Very well deserved. On Tue, Jul 11, 2017 at 10:48 PM Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > Great news. Congratulations Jason! > > --Vahid > > > > From: Guozhang Wang > To: "dev@kafka.apache.org" > Date: 07/11/2017 10:32 PM > Subject:[ANNOU

Re: [DISCUSS] 2017 October release planning and release version

+1 on 1.0. It's about time :) On Thu, Jul 20, 2017 at 5:11 PM Ewen Cheslack-Postava wrote: > Ack on the deprecation, as long as we actually give people the window. I > guess we're not doing a good job of communicating what that period is > anyway, so we can play a bit fast and loose. > > -Ewen >

Re: [VOTE] 0.10.0.0 RC6

+1 (binding). Verified the quickstart. On Sat, May 21, 2016 at 9:22 AM, Ismael Juma wrote: > +1 (non-binding). > > Verified source and binary artifacts, ran ./gradlew testAll with JDK 7u80, > quick start on source artifact and Scala 2.11 binary artifact. And the > system tests passed on the 0.10

Re: [DISCUSS] KIP-63: Unify store and downstream caching in streams

I'm in favor of a global config that is then evenly divided amongst the threads of a Kafka Streams instance. On Mon, Jun 13, 2016 at 6:23 PM, Guozhang Wang wrote: > Although this KIP is not mainly for memory management of Kafka Streams, > since it touches on quite some part of it I think it is g

Re: [VOTE] KIP-67: Queryable state for Kafka Streams

Few thoughts that became apparent after observing example code of what an application architecture and code might look like with these changes. Apologize for the late realization hence. 1. "user.endpoint" will be very differently defined for respective applications. I don't think Kafka Streams sho

Re: [VOTE] KIP-67: Queryable state for Kafka Streams

; > >>> I agree with Neha that Kafka Streams can provide the bare minimum APIs > >> just > >>> for host/port, and user's implemented layer can provide URL / proxy > >> address > >>> they want to build on top of it. > >>> >

Re: [VOTE] 0.10.0.1 RC2

+1 (binding) On Fri, Aug 5, 2016 at 12:29 PM, Grant Henke wrote: > +1 (non-binding) > > On Fri, Aug 5, 2016 at 2:04 PM, Dana Powers wrote: > > > passed kafka-python integration tests, +1 > > > > -Dana > > > > > > On Fri, Aug 5, 2016 at 9:35 AM, Tom Crayford > wrote: > > > Heroku has tested thi

Re: [VOTE] KIP-15 add a close with timeout to new producer

> > We have agreed that we will have an error log to inform user about this > mis-usage. The options differ in the way how we can force user to take a > look at that error log. Since we have to detect the problem in order to log an appropriate error message, we have a way to tell if the user is d

Re: Plan of Controlled Shutdown

Removed the mention of the controlled shutdown tool from the wiki since we don't support it anymore - https://cwiki.apache.org/confluence/display/KAFKA/Replication+tools#Replicationtools-1.ControlledShutdown On Wed, Mar 25, 2015 at 3:07 PM, Guozhang Wang wrote: > Mingjie, > > Controlled shutdown

Re: [DISCUSS] KIP-11- Authorization design for kafka security

Parth, We can make some 15 mins or so to discuss this at the next KIP hangout. Thanks, Neha On Wed, Mar 25, 2015 at 1:07 PM, Parth Brahmbhatt < pbrahmbh...@hortonworks.com> wrote: > Hi all, > > I have modified the KIP to reflect the recent change request from the > reviewers. I have been workin

Re: Metrics package discussion

Aditya, If we are doing a deep dive, one of the things to investigate would be memory/GC performance. IIRC, when I was looking into codahale at LinkedIn, I remember it having quite a few memory management and GC issues while using histograms. In comparison, histograms in the new metrics package ar

Re: [DISCUSSION] Keep docs updated per jira

> > Much much easier to do this if the docs are in git and can be reviewed and > committed / reverted with the code (transactions makes synchronization > easier...). Huge +1. On Thu, Mar 26, 2015 at 6:54 PM, Joel Koshy wrote: > +1 > > It is indeed too easy to forget and realize only much later

Re: [VOTE] KIP-15 Add a close method with timeout to new producer

+1 Thanks Becket! On Fri, Mar 27, 2015 at 1:19 PM, Jay Kreps wrote: > +1 > > Thanks for your patience Jiangjie! > > -Jay > > On Fri, Mar 27, 2015 at 11:48 AM, Jiangjie Qin > wrote: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+method+with+a+timeout+in+the+p

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review78166 --- Ship it! Ship It! - Neha Narkhede On March 27, 2015, 6:58 p.m

Re: Review Request 32519: Patch for KAFKA-2050

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32519/#review78167 --- Ship it! Ship It! - Neha Narkhede On March 26, 2015, 2:36 a.m

Re: jira backlogs

To clarify, reviewers don't have to be committers. If as a non-committer reviewer, you feel that the patch is ready for commit, feel free to ping/tag one of the committers. This

Re: jira backlogs

t; visibility. > > We can do both of course, but I think apache infra already has > what is needed for this. > > Thanks, > > Joel > > On Wed, Apr 08, 2015 at 09:07:00AM -0700, Neha Narkhede wrote: > > The other suggestion I'd like to make involves writing a simple

Re: Please add me to the contributor list

Hi Vijay, Thanks for your interest in contributing to Kafka. Here is a link to some newbie JIRAs that you can start looking into. You can follow instructions to contr

Re: Review Request 32781: Patch for KAFKA-2087

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32781/#review80733 --- Ship it! Ship It! - Neha Narkhede On April 2, 2015, 5:29 p.m

Re: Review Request 33027: Fix timing issue in DelayedOperationTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33027/#review80742 --- Ship it! Ship It! - Neha Narkhede On April 9, 2015, 6:04 p.m

Re: [DISCUSS] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1. I've tried this on Linux and it helps reduce the spikes in append (and hence producer) latency for high throughput writes. I am not entirely sure why but my suspicion is that in the absence of preallocation, you see spikes writes need to happen faster than the time it takes Linux to allocate th

Re: Should 0.8.3 consumers correctly function with 0.8.2 brokers?

My understanding is that ideally the 0.8.3 consumer should work with an 0.8.2 broker if the offset commit config was set to "zookeeper". The only thing that might not work is offset commit to Kafka, which makes sense since the 0.8.2 broker does not support Kafka based offset management. If we bro

Re: Should 0.8.3 consumers correctly function with 0.8.2 brokers?

commit.downgrade" type option, or supporting > the > > old protocol with the new consumer at all, makes much sense. You'd end up > > with some weird hybrid of simple and high-level consumers -- you could > use > > offset storage, but you'd have to manage rebalancing

Re: Review Request 33410: Patch for KAFKA-2034

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33410/#review81600 --- Ship it! Ship It! - Neha Narkhede On April 21, 2015, 9 p.m

Re: Review Request 33342: Patch for KAFKA-2122

/ControllerChannelManager.scala <https://reviews.apache.org/r/33342/#comment132041> Given your latest change, this comment is incorrect. I will take it out during the merge to save time. - Neha Narkhede On April 19, 2015, 7:44 p.m., Sriharsha Chintalapani

Re: Review Request 30196: Patch for KAFKA-1886

> On Feb. 7, 2015, 4:22 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 295 > > <https://reviews.apache.org/r/30196/diff/2/?file=844610#file844610line295> > > > > Why do you need the sleep here? We

Re: Review Request 30801: Patch for KAFKA-1758

int to 0). - Neha Narkhede On Feb. 9, 2015, 6:37 p.m., Manikumar Reddy O wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 33421: Patch for KAFKA-2114

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33421/#review81634 --- Ship it! Ship It! - Neha Narkhede On April 22, 2015, 12:10 a.m

Re: [DISCUSS] Using GitHub Pull Requests for contributions and code review

Thanks a bunch for taking this up, Ismael! +1, I think it will be much more convenient to sunset RB and move to github. Especially looking forward to the CIs on PRs and also the merge script. Alas, my wonderful patch-review script will be retired :-) On Thu, Apr 30, 2015 at 6:12 AM, Ismael Juma

Re: [DISCUSS] KIP-21 Configuration Management

Thanks for starting this discussion, Aditya. Few questions/comments 1. If you change the default values like it's mentioned in the KIP, do you also overwrite the local config file as part of updating the default value? If not, where does the admin look to find the default values, ZK or local Kafka

Re: [KIP-DISCUSSION] KIP-22 Expose a Partitioner interface in the new producer

I'd pick option A too. Rest LGTM. +1 On Mon, May 4, 2015 at 10:03 AM, Gianmarco De Francisci Morales < g...@apache.org> wrote: > Thanks Harsha, > > I think you addressed all the points raised so far. > LGTM +1. > > Cheers, > > -- > Gianmarco > > On 4 May 2015 at 03:57, Harsha wrote: > > > Thanks

Re: Review Request 33760: Patch for KAFKA-2121

/Serializer.java <https://reviews.apache.org/r/33760/#comment133134> This and also the Deserializer should extend Configurable too right? - Neha Narkhede On May 1, 2015, 10:42 p.m., Steven Wu wrote: > > --- > This is a

Re: Review Request 33729: Patch for KAFKA-2161

discussion on RAT? - Neha Narkhede On April 30, 2015, 6:46 p.m., Ewen Cheslack-Postava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33645: Patch for KAFKA-2153

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/#review82406 --- Ship it! Ship It! - Neha Narkhede On April 28, 2015, 11:04 p.m

Re: Review Request 30196: Patch for KAFKA-1886

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/#review82408 --- Ship it! Ship It! - Neha Narkhede On April 28, 2015, 5:28 p.m

Re: [DISCUSS] KIP-21 Configuration Management

re run. Having > a ConfigChangeRequest (or similar) is nice to have but having a new API and > sending requests to controller also change how we do topic based > configuration currently. I was hoping to keep this KIP as minimal as > possible and provide a means to represent and modify cl

Re: [DISCUSS] KIP-21 Configuration Management

Make sure that traditional deployment tools (Puppet, > > Chef, > > > > etc) > > > > > > are > > > > > > > > > still > > > > > > > > > > > capable of managing Kafka configuration. > > > > > > > > > > > > &

Re: Next is 0.8.3 or is it 0.9?

The next version will be 0.8.3. On Sun, May 17, 2015 at 9:55 PM, Jaikiran Pai wrote: > Hello everyone, > > What is the next planned version of Kafka going to be? I vaguely remember > reading in some mail that it will be 0.9 and "trunk" is where it would be > released from. I was just updating my

Re: jira backlogs

ately > >> in newer versions if there are more than a certain number of issues in > >> the list it will give you a link to the jira search. We could split > >> the table up by reviewer which may be better for visibility and peer > >> pressure as well :) > >&

Re: Kafka KIP hangout May 26

Thanks for sending out the KIP notes, Ashish! On Tue, May 26, 2015 at 11:51 AM, Ashish Singh wrote: > Below are my notes. Feel free to add/ modify the content. > Kafka KIP discussion (May 26, 2015) KIP-12 (sasl/ssl authentication): > status check > > Not much discussion this time. > KIP-21 (conf

Re: KIP Wiki

+1. Thanks Aditya! On Mon, Jun 1, 2015 at 7:34 PM, Mayuresh Gharat wrote: > +1. > > Thanks, > > Mayuresh > > On Mon, Jun 1, 2015 at 6:51 PM, Joe Stein wrote: > > > We should probably have some release/vXYZ section so that over time we > can > > keep track of what KIP where approved for what rel

Re: [ANNOUNCE] New committer: Jiangjie (Becket) Qin

Congratulations, Becket! Well done. On Wed, Nov 2, 2016 at 1:34 PM Eno Thereska wrote: > Congrats! > Eno > > > On 1 Nov 2016, at 05:57, Harsha Chintalapani wrote: > > > > Congrats Becket! > > -Harsha > > > > On Mon, Oct 31, 2016 at 2:13 PM Rajini Sivaram < > rajinisiva...@googlemail.com> > > wr

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

Super useful, thanks Rajini. +1 On Tue, Nov 29, 2016 at 8:11 AM Rajini Sivaram wrote: > I have added this to the KIP. > > Thanks, > > Rajini > > On Tue, Nov 29, 2016 at 12:14 PM, Ismael Juma wrote: > > > One more thing: we are using the PASSWORD config type to avoid exposing > > passwords. This

Re: [DISCUSS] KIP-95: Incremental Batch Processing for Kafka Streams

Thanks for initiating this. I think this is a good first step towards unifying batch and stream processing in Kafka. I understood this capability to be simple yet very useful; it allows a Streams program to process a log, in batch, in arbitrary windows defined by the difference between the HW and

Re: [DISCUSS] KIP-96 - Add per partition metrics for in-sync and assigned replica count

This seems useful, +1 On Tue, Nov 29, 2016 at 5:39 AM Ismael Juma wrote: > Hi Xavier, > > Thanks for the KIP. Sounds good to me. > > Ismael > > On Tue, Nov 29, 2016 at 12:40 AM, Xavier Léauté > wrote: > > > Hi, > > > > I created KIP-96 to propose per partition in-sync / assigned replica > > met

Re: [VOTE] KIP-96 - Add per partition metrics for in-sync and replica count

+1 (binding) On Wed, Nov 30, 2016 at 1:43 PM Eno Thereska wrote: > +1 (non binding) > > > On 30 Nov 2016, at 21:34, Xavier Léauté wrote: > > > > Based on the feedback KIP-96 seems pretty uncontroversial, so I'd like to > > initiate a vote on it. > > > > > https://cwiki.apache.org/confluence/dis

Re: [DISCUSS] KIP-98: Exactly Once Delivery and Transactional Messaging

Thanks for initiating this KIP! I think it is well written and I'm excited to see the first step towards adding an important feature in Kafka. I had a few initial thoughts on the KIP, mostly not as deeply thought through than what you've done - 1. Perhaps you’ve thought about how this would work

Re: Improvements to Jenkins pull request builder

Nice! Thanks Ismael. On Thu, Dec 8, 2016 at 10:47 AM Damian Guy wrote: > Cool - thanks Ismael! > > On Thu, 8 Dec 2016 at 18:22 Guozhang Wang wrote: > > > Thanks Ismael, this is sper helpful! > > > > > > Guozhang > > > > On Thu, Dec 8, 2016 at 5:24 AM, Ismael Juma wrote: > > > > > Hi ev

Re: [VOTE]: KIP-97: The client compatibility KIP

+1 (binding) On Thu, Dec 8, 2016 at 10:00 AM Guozhang Wang wrote: > +1 (binding) > > On Thu, Dec 8, 2016 at 9:39 AM, Sriram Subramanian > wrote: > > > +1 (binding) > > > > On Thu, Dec 8, 2016 at 5:42 AM, Ismael Juma wrote: > > > > > Thanks for the KIP Colin, +1 (binding) from me. > > > > > > I

Re: [DISCUSS] KIP-101: Alter Replication Protocol to use Leader Generation rather than High Watermark for Truncation

Good to see this KIP being proposed. Back when I added the epoch to the replication protocol, we discussed adding it to the log due to the failure scenarios listed in the KIP but I failed to convince people that it was worth the effort needed to upgrade the cluster (especially after we asked people

Re: [DISCUSS] KIP-98: Exactly Once Delivery and Transactional Messaging

Apurva and Jason -- appreciate the detailed explanation, thank you! Jason - > In many applications, there is already a natural identifier which is already used to divide the workload. For example, in Kafka Streams and Kafka Connect, we have a taskId. For applications where there is no natural ID,

Re: [VOTE] KIP-100 - Relax Type constraints in Kafka Streams API

+1 (binding) On Mon, Dec 12, 2016 at 11:41 AM Guozhang Wang wrote: > +1 (binding) Thanks Xavier for the proposal ! > > I think the source compatibility should be very rare as of now. > > On Mon, Dec 12, 2016 at 8:20 AM, Eno Thereska > wrote: > > > +1 (non-binding) > > > > > On 12 Dec 2016, at 1

Re: [DISCUSS] KIP-90 Remove zkClient dependency from Streams

Makes sense :) On Tue, Dec 13, 2016 at 5:50 PM Jay Kreps wrote: > Ha, least controversial KIP ever. :-) > > -Jay > > On Tue, Dec 13, 2016 at 10:39 AM, Hojjat Jafarpour > wrote: > > > Hi all, > > > > The following is a KIP for removing zkClient dependency from Streams. > > Please check out the K

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

Big +1. On Tue, Jan 3, 2017 at 11:22 AM Tom Crayford wrote: > +1. We've been running it in production for a long time and it's the right > default. > > On Tue, Jan 3, 2017 at 7:17 PM, Ismael Juma wrote: > > > Thanks for the KIP, +1 from me. > > > > Ismael > > > > On 3 Jan 2017 6:54 pm, "Ben Sto

Re: [DISCUSS] Dormant/Inactive KIPs

+1. This is a good idea as we have a lot of KIPs in flight. On Tue, Dec 13, 2016 at 3:53 AM Ismael Juma wrote: > Hi all, > > A while back Grant proposed moving inactive/dormant KIPs to a separate > table in the wiki. I think this is a good idea as it will make it easier > for people to see the K

Re: [VOTE] KIP-99: Add Global Tables to Kafka Streams

+1 (binding) On Tue, Jan 3, 2017 at 11:40 AM Ewen Cheslack-Postava wrote: > +1 > > -Ewen > > On Tue, Jan 3, 2017 at 11:16 AM, Gwen Shapira wrote: > > > +1 > > > > I'm glad this super-common use-case will become more performant now. > > > > On Mon, Dec 12, 2016 at 3:45 AM, Damian Guy > wrote: >

Re: [VOTE] 0.10.2.1 RC1

+1 (binding). Verified signatures, ran quickstart and tests. On Fri, Apr 14, 2017 at 3:45 PM Gwen Shapira wrote: > Verified my own signatures, ran quickstart and created few Connectors. > > +1 (binding) > > > On Wed, Apr 12, 2017 at 5:25 PM, Gwen Shapira wrote: > > Hello Kafka users, developers

Re: [DISCUSS] 0.8.2-beta2 release

Joe, Thanks for starting the discussion. It may be ok to do an RC and probably two weeks later, cut the final. After releasing the RC, we can help spread the word and have people try out the new API, which is probably our main concern. -Neha On Mon, Jan 12, 2015 at 8:42 AM, Jun Rao wrote: > Hi

Re: Review Request 23702: Patch for KAFKA-1070

> On Jan. 9, 2015, 11:39 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/BrokerMetadataFileHandler.scala, line 48 > > <https://reviews.apache.org/r/23702/diff/8-9/?file=776402#file776402line48> > > > > Does java serialization for the Pr

Re: Review Request 23702: Patch for KAFKA-1070

> On Jan. 9, 2015, 11:39 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/BrokerMetadataFileHandler.scala, line 48 > > <https://reviews.apache.org/r/23702/diff/8-9/?file=776402#file776402line48> > > > > Does java serialization for the Pr

Re: Review Request 23702: Patch for KAFKA-1070

/BrokerMetadataCheckpoint.scala <https://reviews.apache.org/r/23702/#comment111797> Minor nit which I can address during checkin: According to our coding convention, there should be a space after the , here. - Neha Narkhede On Jan. 12, 2015, 6:46 p.m., Sriharsha Chintalapani

Re: Review Request 29210: Patch for KAFKA-1819

> On Jan. 12, 2015, 10:53 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala, line 68 > > > > > > Actually, now that you have the check above in DeleteTopicTest, do you > > t

Re: Review Request 29756: Patch for KAFKA-1854

> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote: > > kafka-patch-review.py, line 20 > > <https://reviews.apache.org/r/29756/diff/4/?file=814310#file814310line20> > > > > I got the following error on this patch > > > > nnarkhed-mn1:ka

Re: Review Request 29756: Patch for KAFKA-1854

> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote: > > kafka-patch-review.py, line 20 > > <https://reviews.apache.org/r/29756/diff/4/?file=814310#file814310line20> > > > > I got the following error on this patch > > > > nnarkhed-mn1:ka

Re: Review Request 29831: Patch for KAFKA-1476

t; It is better to rename this to DeleteConsumerGroupTest - Neha Narkhede On Jan. 13, 2015, 12:31 a.m., Onur Karaman wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 29854: Patch for KAFKA-1854

/browse/KAFKA-1854 Repository: kafka Description --- test Diffs - kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38 Diff: https://reviews.apache.org/r/29854/diff/ Testing --- Thanks, Neha Narkhede

Re: Review Request 29756: Patch for KAKFA-1854

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/#review67884 --- Ship it! Ship It! - Neha Narkhede On Jan. 13, 2015, 5:43 a.m

Re: Review Request 29831: Patch for KAFKA-1476

> On Jan. 13, 2015, 5:36 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, line 46 > > <https://reviews.apache.org/r/29831/diff/3/?file=818442#file818442line46> > > > > --delete is sufficient. Same for the name of t

Re: Review Request 29831: Patch for KAFKA-1476

> On Jan. 13, 2015, 5:36 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, line 46 > > <https://reviews.apache.org/r/29831/diff/3/?file=818442#file818442line46> > > > > --delete is sufficient. Same for the name of t

Re: Review Request 29952: Patch for kafka-1864

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29952/#review68437 --- Ship it! Ship It! - Neha Narkhede On Jan. 16, 2015, 12:52 a.m

Re: [kafka-clients] Re: Heads up: KAFKA-1697 - remove code related to ack>1 on the broker

Gwen, KIP write-up looks good. According to the rest of the KIP process proposal, would you like to start a DISCUSS/VOTE thread for it? Thanks, Neha On Fri, Jan 16, 2015 at 9:37 AM, Ewen Cheslack-Postava wrote: > Gwen -- KIP write up looks good. Deprecation schedule probably needs to be > more

Re: Review Request 29203: Patch for KAFKA-1823

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29203/#review68442 --- Ship it! Ship It! - Neha Narkhede On Dec. 18, 2014, 11:42 a.m

Re: Review Request 29831: Patch for KAFKA-1476

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29831/#review68448 --- - Neha Narkhede On Jan. 15, 2015, 10:30 p.m., Onur Karaman wrote

Re: Review Request 29831: Patch for KAFKA-1476

this tool? - Neha Narkhede On Jan. 22, 2015, 10:32 a.m., Onur Karaman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [DISCUSS] KIP-8 - Decommission a broker

Hi Joe, Thanks for starting a KIP for this change. This feature is trivial once we agree on KIP-6 since that feature figures out an ideal replica placement. Decomission broker is just one

Re: [DISCUSS] KIP-6 - New reassignment partition logic for re-balancing

Hey Joe, 1. Could you add details to the Public Interface section of the KIP? This should include the proposed changes to the partition reassignment tool. Also, maybe the new option can be named --rebalance instead of --re-balance? 2. It makes sense to list --decommission-broker as part of this KI

Re: Review Request 29831: Patch for KAFKA-1476

or deleting a consumer group's offset information is if there are no live consumers in that group anymore. If so, --force-delete would mean deleting even if that is not true. This is pretty disruptive and I can't think of any case where this action will be useful. Tho

Re: Review Request 30199: Patch for KAFKA-1890

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/#review69405 --- Ship it! Ship It! - Neha Narkhede On Jan. 23, 2015, 3:57 a.m

Re: Cannot stop Kafka server if zookeeper is shutdown first

For a clean shutdown, the broker tries to talk to the controller and also issues reads to zookeeper. Possibly that is where it tries to reconnect to zk. It will help to look at the thread dump. Thanks Neha On Fri, Jan 23, 2015 at 8:53 PM, Jaikiran Pai wrote: > I was just playing around with the

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

I think there is some value in investigating if we can go back to the simple mirror maker design, as Jay points out. Here you have N threads, each has a consumer and a producer. The reason why we had to move away from that was a combination of the difference in throughput between the consumer and

Re: [kafka-clients] Re: [VOTE] 0.8.2.0 Candidate 2 (with the correct links)

+1 (binding) Verified keys, quick start, unit tests. On Sat, Jan 24, 2015 at 4:26 PM, Joe Stein wrote: > That makes sense, thanks! > > On Sat, Jan 24, 2015 at 7:00 PM, Jay Kreps wrote: > > > But I think the flaw in trying to guess what kind of serializer they will > > use is when we get it wron

Re: Review Request 29831: Patch for KAFKA-1476

> On Jan. 23, 2015, 4:47 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, line 259 > > <https://reviews.apache.org/r/29831/diff/6/?file=829769#file829769line259> > > > > => If set along with --delete >

Re: Review Request 30196: Patch for KAFKA-1886

<https://reviews.apache.org/r/30196/#comment114287> what is the purpose of this sleep? - Neha Narkhede On Jan. 22, 2015, 10:35 p.m., Aditya Auradkar wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 29840: Patch for KAFKA-1818

tps://reviews.apache.org/r/29840/#comment114288> minor formatting nit: Need to include a space after flatMap - Neha Narkhede On Jan. 17, 2015, 3:32 p.m., Eric Olander wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

<https://reviews.apache.org/r/28108/#comment114290> typo: zkConnectWithInvaidRoot - Neha Narkhede On Dec. 11, 2014, 6:16 a.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 30084: Patch for KAFKA-1866

, hopefully that test would fail if we forget to add the new metrics to this removeMetrics() API - Neha Narkhede On Jan. 20, 2015, 7:55 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 30073: Patch for KAFKA-1109

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30073/#review69585 --- Ship it! Ship It! - Neha Narkhede On Jan. 20, 2015, 12:07 p.m

Re: Review Request 30062: Patch for KAFKA-1883

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30062/#review69586 --- Ship it! Ship It! - Neha Narkhede On Jan. 20, 2015, 3:40 a.m

Re: Review Request 30078: Patch for KAFKA-1885

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69588 --- Ship it! Ship It! - Neha Narkhede On Jan. 24, 2015, 11:52 a.m

Re: Cannot stop Kafka server if zookeeper is shutdown first

; > at kafka.utils.Utils$.swallow(Utils.scala:45) > > at kafka.server.KafkaServer.shutdown(KafkaServer.scala:269) > > at kafka.server.KafkaServerStartable.shutdown( > > KafkaServerStartable.scala:42) > > at kafka.Kafka$$anon$1.run(Kafka.scala:42) > > &

Re: [VOTE] 0.8.2.0 Candidate 3

+1 (binding). Verified quickstart and unit tests ran ok. On Sun, Feb 1, 2015 at 9:11 AM, Steven Wu wrote: > In Netflix, we have been using route53 DNS name as bootstrap servers in AWS > env. Basically, when a kafka broker start, we add it to route53 DNS name > for the cluster. this is like the V

Re: Review Request 29831: Patch for KAFKA-1476

://reviews.apache.org/r/29831/#comment115796> verifyTopicDeletion is duplicated across 2 tests now. It is useful to refactor it into maybe TestUtils? - Neha Narkhede On Jan. 30, 2015, 7:10 p.m., Onur Karaman wrote: > >

Re: Review Request 30403: Patch for KAFKA-1906

+1 on including a reasonable default for log.dirs that points to data/ in the installation directory. This is followed by some other systems and is probably a little better compared to /tmp. Also, I actually think we should default to production ready settings for most configs, at least those rela

Re: [kafka-clients] Re: [VOTE] 0.8.2.0 Candidate 3

Great! Thanks Jun for helping with the release and everyone involved for your contributions. On Mon, Feb 2, 2015 at 1:32 PM, Joe Stein wrote: > Huzzah! > > Thanks Jun for preparing the release candidates and getting this out to the > community. > > - Joe Stein > > On Mon, Feb 2, 2015 at 2:27 PM,

Re: [DISCUSS] KIPs

Sounds good. On Thu, Feb 5, 2015 at 2:35 PM, Jay Kreps wrote: > None on my part. > > -Jay > > On Thu, Feb 5, 2015 at 11:50 AM, Joel Koshy wrote: > > > One amendment I would like to bring up for consideration wrt the KIP > > process (before we formally include it in our by-laws) is to not > > re

Re: [jira] [Created] (AURORA-985) Move Aurora website source to subdirectory of git repo

+1 from me too. I've seen the best way to keep docs in sync with the code is to have contributors submit changes to both as part of the same patch. Otherwise we keep playing catchup with the changing codebase. On Fri, Feb 6, 2015 at 9:07 AM, Gwen Shapira wrote: > strong +1 > > In addition to kee

Re: Review Request 30196: Patch for KAFKA-1886

<https://reviews.apache.org/r/30196/#comment117311> Why do you need the sleep here? We try to avoid blindly sleeping in Kafka tests since it almost always leads to transient test failures. Consider using TestUtils.waitUntilTrue(). - Neha Narkhede On Feb. 2, 2015, 9:57 p.m.,

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

Jiangjie Qin > >> >> >> >> > > >> >> >wrote: > >> >> > > >> >> >> I’ve updated the KIP page. Feedbacks are welcome. > >> >> >> > >> >> >> Regarding the simple

  1   2   3   4   5   6   7   8   9   10   >