----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30084/#review69584 -----------------------------------------------------------
Can we add a test for this? If we add more metrics in the future, hopefully that test would fail if we forget to add the new metrics to this removeMetrics() API - Neha Narkhede On Jan. 20, 2015, 7:55 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30084/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 7:55 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1866 > https://issues.apache.org/jira/browse/KAFKA-1866 > > > Repository: kafka > > > Description > ------- > > KAFKA-1866. LogStartOffset gauge throws exceptions after log.delete(). > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 846023bb98d0fa0603016466360c97071ac935ea > > Diff: https://reviews.apache.org/r/30084/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
