----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/#review71556 -----------------------------------------------------------
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala <https://reviews.apache.org/r/30196/#comment117311> Why do you need the sleep here? We try to avoid blindly sleeping in Kafka tests since it almost always leads to transient test failures. Consider using TestUtils.waitUntilTrue(). - Neha Narkhede On Feb. 2, 2015, 9:57 p.m., Aditya Auradkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30196/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 9:57 p.m.) > > > Review request for kafka and Joel Koshy. > > > Bugs: KAFKA-1886 > https://issues.apache.org/jira/browse/KAFKA-1886 > > > Repository: kafka > > > Description > ------- > > Fixing KAFKA-1886. SimpleConsumer should not swallow > ClosedByInterruptException > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > cbef84ac76e62768981f74e71d451f2bda995275 > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala > aeb7a19acaefabcc161c2ee6144a56d9a8999a81 > > Diff: https://reviews.apache.org/r/30196/diff/ > > > Testing > ------- > > Added an integration test to PrimitiveAPITest.scala. > > > Thanks, > > Aditya Auradkar > >
