-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30801/#review81622
-----------------------------------------------------------



core/src/main/scala/kafka/log/LogManager.scala
<https://reviews.apache.org/r/30801/#comment132061>

    Is there a reason we are limiting this to only NumberFormatException? Seems 
like a fix that applies to all errors. 
    
    Also, worth changing the error message to a more generic statement about 
the problem and the fix (resetting the recovery checkpoint to 0).


- Neha Narkhede


On Feb. 9, 2015, 6:37 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30801/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 6:37 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1758
>     https://issues.apache.org/jira/browse/KAFKA-1758
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> handled NumberFormatException while reading recovery-point-offset-checkpoint 
> file
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/log/LogManager.scala 
> 47d250af62c1aa53d11204a332d0684fb4217c8d 
> 
> Diff: https://reviews.apache.org/r/30801/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Reply via email to