----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/#review69582 -----------------------------------------------------------
Sorry for the late review. Can check this in once you get a chance to address these review suggestions. core/src/main/scala/kafka/utils/ZkUtils.scala <https://reviews.apache.org/r/28108/#comment114289> what is the purpose of this return statement? Seems inconsistent with the coding convention core/src/test/scala/unit/kafka/zk/ZKPathTest.scala <https://reviews.apache.org/r/28108/#comment114290> typo: zkConnectWithInvaidRoot - Neha Narkhede On Dec. 11, 2014, 6:16 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28108/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 6:16 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1664 > https://issues.apache.org/jira/browse/KAFKA-1664 > > > Repository: kafka > > > Description > ------- > > KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root > chroot > > > Diffs > ----- > > core/src/main/scala/kafka/utils/ZkUtils.scala > 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd > core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/28108/diff/ > > > Testing > ------- > > Tested with and without the fix. > > > Thanks, > > Ashish Singh > >
