Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review96003 --- Ship it! Ship It! - Joel Koshy On Aug. 20, 2015, 7:08 a.m., Mani

Re: Review Request 35867: Patch for KAFKA-1901

> On Aug. 20, 2015, 2:03 a.m., Joel Koshy wrote: > > build.gradle, line 389 > > > > > > This gives an error in detached mode (i.e., not on any branch). Updated code to handle detached mode. thanks for the review.

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- (Updated Aug. 20, 2015, 7:08 a.m.) Review request for kafka. Bugs: KAFKA-1901

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review95902 --- Can you rebase? build.gradle (line 389)

Re: Review Request 35867: Patch for KAFKA-1901

> On July 21, 2015, 1:58 p.m., Ismael Juma wrote: > > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java, > > line 27 > > > > > > Why isn't this "unknown" like `version`? > > Manikumar Reddy O wr

Re: Review Request 35867: Patch for KAFKA-1901

> On July 21, 2015, 1:58 p.m., Ismael Juma wrote: > > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java, > > line 27 > > > > > > Why isn't this "unknown" like `version`? yes we can set "unknown"

Re: Review Request 35867: Patch for KAFKA-1901

> On July 17, 2015, 4:25 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java, > > line 56 > > > > > > "given `prefix` string and further qualifies the associated AppInfo

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- (Updated Aug. 9, 2015, 9:37 a.m.) Review request for kafka. Bugs: KAFKA-1901

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92404 --- build.gradle (line 388)

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92078 --- clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.j

Re: Review Request 35867: Patch for KAFKA-1901

> On July 14, 2015, 1:59 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/common/AppInfo.scala, line 27 > > > > > > Per the comment in the previous diff, I think this can go now right? > > i.e., kafka server dep

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- (Updated July 14, 2015, 12:32 p.m.) Review request for kafka. Bugs: KAFKA-190

Re: Review Request 35867: Patch for KAFKA-1901

> On June 25, 2015, 7:01 p.m., Joel Koshy wrote: > > build.gradle, line 386 > > > > > > I was originally interested in this because it would be a quick way to > > determine what version someone is running/testing with

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review91574 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- (Updated July 10, 2015, 11:15 a.m.) Review request for kafka. Bugs: KAFKA-190

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- (Updated June 26, 2015, 7:49 a.m.) Review request for kafka. Bugs: KAFKA-1901

Re: Review Request 35867: Patch for KAFKA-1901

> On June 25, 2015, 7:01 p.m., Joel Koshy wrote: > > build.gradle, line 57 > > > > > > Why was this change made? This is related to followup patch of KAFKA-2199. Will remove after KAFKA-2199 checkin. > On June 25, 2

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89379 --- build.gradle (line 57)

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89366 --- Ship it! Thanks for doing this, it all looks good from here - Jaso

Re: Review Request 35867: Patch for KAFKA-1901

> On June 25, 2015, 3:33 p.m., Jason Rosenberg wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java, > > line 58 > > > > > > what's the reason for this change? This change is for new java

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89364 --- clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.j

Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- Review request for kafka. Bugs: KAFKA-1901 https://issues.apache.org/jira/b