> On June 25, 2015, 3:33 p.m., Jason Rosenberg wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java, > > line 58 > > <https://reviews.apache.org/r/35867/diff/1/?file=991945#file991945line58> > > > > what's the reason for this change?
This change is for new java clients. Currently new java clients uses kafka metrics and support only JMX reporting. In this change, I am passing clientId to JmxReporter. This will help use to create separate MBean for each client. And each MBean will have version and commitId attributes. Example MBean: kafka.producer:type=AppInfo,client-id=producer1 kafka.producer:type=AppInfo,client-id=producer2 kafka.consumer:type=AppInfo,client-id=consumer1 kafka.consumer:type=AppInfo,client-id=conusmer2 - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89364 ----------------------------------------------------------- On June 25, 2015, 10:11 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35867/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 10:11 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1901 > https://issues.apache.org/jira/browse/KAFKA-1901 > > > Repository: kafka > > > Description > ------- > > generated a properties file (kafka-version.properties) with version, > git-commitId in it. This props file is used to create AppInfo MBean. > > > Diffs > ----- > > build.gradle 30d1cf2f1ff9ed3f86a060da8099bb0774b4cf91 > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > 9be8fbc648369ad9db1a7eea94bc1b9edbfdbfd7 > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 5671a3fbeea8cb9a9ffeeb41aa1b132b92c0cae8 > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java > 6b9590c418aedd2727544c5dd23c017b4b72467a > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java > PRE-CREATION > clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java > 07b1b60d3a9cb1a399a2fe95b87229f64f539f3b > clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java > 544e120594de78c43581a980b1e4087b4fb98ccb > core/src/main/scala/kafka/common/AppInfo.scala > d642ca555f83c41451d4fcaa5c01a1f86eff0a1c > > Diff: https://reviews.apache.org/r/35867/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
