> On July 21, 2015, 1:58 p.m., Ismael Juma wrote: > > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java, > > line 27 > > <https://reviews.apache.org/r/35867/diff/4/?file=1011317#file1011317line27> > > > > Why isn't this "unknown" like `version`? > > Manikumar Reddy O wrote: > yes we can set "unknown" here. Joel suggested to use 00000000 as the > unknown commit ID. Joel, can we change this?
Sure - I originally thought we could make the fingerprint == the numeric value associated with the leading bytes. That would have made it easy to just take the fingerprint -> convert to hex and get the git hash prefix. However, I think we can just drop the fingerprint altogether for now. - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92404 ----------------------------------------------------------- On Aug. 9, 2015, 9:37 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35867/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 9:37 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1901 > https://issues.apache.org/jira/browse/KAFKA-1901 > > > Repository: kafka > > > Description > ------- > > Addresing Joel's comments > > > Diffs > ----- > > build.gradle 1b67e628c2fca897177c12b6afad9a8700fffd1f > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > ed99e9bdf7c4ea7a6d4555d4488cf8ed0b80641b > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 03b8dd23df63a8d8a117f02eabcce4a2d48c44f7 > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java > PRE-CREATION > core/src/main/scala/kafka/common/AppInfo.scala > d642ca555f83c41451d4fcaa5c01a1f86eff0a1c > core/src/main/scala/kafka/server/KafkaServer.scala > 84d4730ac634f9a5bf12a656e422fea03ad72da8 > core/src/main/scala/kafka/server/KafkaServerStartable.scala > 1c1b75b4137a8b233b61739018e9cebcc3a34343 > > Diff: https://reviews.apache.org/r/35867/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
