----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review91574 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java (line 207) <https://reviews.apache.org/r/35867/#comment145018> `jmxPrefix, clientId` clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java (line 152) <https://reviews.apache.org/r/35867/#comment145010> `log.warn("error...", e)` - also, whitespace before `"` clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java (line 164) <https://reviews.apache.org/r/35867/#comment145011> same clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java (line 246) <https://reviews.apache.org/r/35867/#comment145023> In https://issues.apache.org/jira/browse/KAFKA-1901?focusedCommentId=14294803&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14294803 I was wondering if we could have a commit fingerprint - i.e., the long value of the most-significant eight bytes of the commit modulo 10k or something like that. This would make is convenient to register as a measurable `KafkaMetric` that people can then use in their deployment monitoring. i.e., instantly look at a graph and say whether all brokers/clients are running the same version or not. clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java (line 27) <https://reviews.apache.org/r/35867/#comment145019> (For consistency) should we make this 40-char wide as is a standard commit id? Or we can just go with a eight-char or 16-char wide id for both this and the actual commit id. clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java (line 33) <https://reviews.apache.org/r/35867/#comment145020> should probably reference the above constants (ln 26, 27) here instead of hardcoding again. core/src/main/scala/kafka/common/AppInfo.scala (line 24) <https://reviews.apache.org/r/35867/#comment145021> Per the comment in the previous diff, I think this can go now right? i.e., kafka server depends on clients so if you browse mbeans you will see two app-infos registered (under `kafka.server` and `kafka.common`) which is weird. The server will also expose app-info via the clients package since it already uses kafka metrics and the associated jmx reporter. - Joel Koshy On July 10, 2015, 11:15 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35867/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 11:15 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1901 > https://issues.apache.org/jira/browse/KAFKA-1901 > > > Repository: kafka > > > Description > ------- > > patch after rebase > > > Diffs > ----- > > build.gradle d86f1a8b25197d53f11e16c54a6854487e175649 > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > 7aa076084c894bb8f47b9df2c086475b06f47060 > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 03b8dd23df63a8d8a117f02eabcce4a2d48c44f7 > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java > 6b9590c418aedd2727544c5dd23c017b4b72467a > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java > PRE-CREATION > clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java > 07b1b60d3a9cb1a399a2fe95b87229f64f539f3b > clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java > 544e120594de78c43581a980b1e4087b4fb98ccb > core/src/main/scala/kafka/common/AppInfo.scala > d642ca555f83c41451d4fcaa5c01a1f86eff0a1c > core/src/main/scala/kafka/server/KafkaServer.scala > 18917bc4464b9403b16d85d20c3fd4c24893d1d3 > > Diff: https://reviews.apache.org/r/35867/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
