> On June 25, 2015, 7:01 p.m., Joel Koshy wrote: > > build.gradle, line 386 > > <https://reviews.apache.org/r/35867/diff/1/?file=991942#file991942line386> > > > > I was originally interested in this because it would be a quick way to > > determine what version someone is running/testing with. However, it is > > obviously not foolproof since you could have local changes that are > > staged/unstaged but not committed. > > > > This is probably good enough, but can you think about whether it is > > possible to easily add a "tainted" boolean field? i.e., if there are any > > additional source files that are untracked or staged but not committed? > > Manikumar Reddy O wrote: > It should be posible with some git commands. But do we really need this? > most of us will be running stable release or some trunk point.
It may be of marginal use, but the obvious advantage is if someone reports some Kafka issue and _happens_ to be doing some local testing on a stable release along with some untracked changes. - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review89379 ----------------------------------------------------------- On July 10, 2015, 11:15 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35867/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 11:15 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1901 > https://issues.apache.org/jira/browse/KAFKA-1901 > > > Repository: kafka > > > Description > ------- > > patch after rebase > > > Diffs > ----- > > build.gradle d86f1a8b25197d53f11e16c54a6854487e175649 > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > 7aa076084c894bb8f47b9df2c086475b06f47060 > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 03b8dd23df63a8d8a117f02eabcce4a2d48c44f7 > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java > 6b9590c418aedd2727544c5dd23c017b4b72467a > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java > PRE-CREATION > clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java > 07b1b60d3a9cb1a399a2fe95b87229f64f539f3b > clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java > 544e120594de78c43581a980b1e4087b4fb98ccb > core/src/main/scala/kafka/common/AppInfo.scala > d642ca555f83c41451d4fcaa5c01a1f86eff0a1c > core/src/main/scala/kafka/server/KafkaServer.scala > 18917bc4464b9403b16d85d20c3fd4c24893d1d3 > > Diff: https://reviews.apache.org/r/35867/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
