----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92404 -----------------------------------------------------------
build.gradle (line 388) <https://reviews.apache.org/r/35867/#comment146572> Would it not be better to leave this value unset if we can't figure it out? clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java (line 27) <https://reviews.apache.org/r/35867/#comment146573> Why isn't this "unknown" like `version`? - Ismael Juma On July 14, 2015, 12:32 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35867/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 12:32 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1901 > https://issues.apache.org/jira/browse/KAFKA-1901 > > > Repository: kafka > > > Description > ------- > > Addresing Joel's comments > > > Diffs > ----- > > build.gradle d86f1a8b25197d53f11e16c54a6854487e175649 > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > b4e8f7f0dceefaf94a3495f39f5783cce5ceb25f > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 03b8dd23df63a8d8a117f02eabcce4a2d48c44f7 > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java > 6b9590c418aedd2727544c5dd23c017b4b72467a > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java > PRE-CREATION > clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java > 07b1b60d3a9cb1a399a2fe95b87229f64f539f3b > clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java > 544e120594de78c43581a980b1e4087b4fb98ccb > core/src/main/scala/kafka/common/AppInfo.scala > d642ca555f83c41451d4fcaa5c01a1f86eff0a1c > core/src/main/scala/kafka/server/KafkaServer.scala > 18917bc4464b9403b16d85d20c3fd4c24893d1d3 > core/src/main/scala/kafka/server/KafkaServerStartable.scala > 1c1b75b4137a8b233b61739018e9cebcc3a34343 > > Diff: https://reviews.apache.org/r/35867/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
