[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977681#comment-13977681 ] Jun Rao commented on KAFKA-1359: Thanks for the followup patch. +1 and committed to trunk.

Re: Review Request 20529: Follow-up KAFKA-1359: incorporate Neha's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20529/#review41101 --- Ship it! Ship It! - Jun Rao On April 21, 2014, 11:33 p.m., Guozh

Re: Review Request 20529: Follow-up KAFKA-1359: incorporate Neha's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20529/#review41099 --- Ship it! Ship It! - Jun Rao On April 21, 2014, 11:33 p.m., Guozh

Jenkins build is back to normal : Kafka-trunk #170

See

[jira] [Resolved] (KAFKA-1410) MetadataCache cleanup

[ https://issues.apache.org/jira/browse/KAFKA-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1410. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the reviews. Committed to trunk. > MetadataCache

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

> On April 22, 2014, 10 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, lines > > 114-116 > > > > > > For this particular test, resending in the producer could introduce

[VOTE] Apache Kafka 0.8.1.1 Release Candidate 1

This is the first candidate for release of Apache Kafka 0.8.1.1 Release Notes for the 0.8.1.1 release https://people.apache.org/~joestein/kafka-0.8.1.1-candidate1/RELEASE_NOTES.html *** Please download, test and vote by Friday, April 25th, 4pm PT Kafka's KEYS file containing PGP keys we use to s

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41070 --- core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scal

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review41071 --- Ship it! - Joel Koshy On April 22, 2014, 8:51 p.m., Jun Rao wrote

[jira] [Commented] (KAFKA-1383) transient unit test failure in SocketServerTest

[ https://issues.apache.org/jira/browse/KAFKA-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977463#comment-13977463 ] Jun Rao commented on KAFKA-1383: This seems to be a different issue. Not sure what the cau

[jira] [Assigned] (KAFKA-1409) oversized messages can slow down the brokers

[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-1409: Assignee: Guozhang Wang > oversized messages can slow down the brokers > --

[jira] [Commented] (KAFKA-1383) transient unit test failure in SocketServerTest

[ https://issues.apache.org/jira/browse/KAFKA-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977459#comment-13977459 ] Guozhang Wang commented on KAFKA-1383: -- [~junrao] Is this fixed by KAFKA-1400 or a di

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review41067 --- Ship it! Ship It! - Timothy Chen On April 22, 2014, 8:51 p.m., J

[jira] [Resolved] (KAFKA-1411) remove unused test cases

[ https://issues.apache.org/jira/browse/KAFKA-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1411. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the review. Committed to trunk. > remove unused t

Re: Review Request 20540: Patch for KAFKA-1410

> On April 22, 2014, 12:07 a.m., Guozhang Wang wrote: > > This patch is much larger than it is claimed to be :) Any rebasing missed > > here? It picked up the remaining followup change in kafka-1356: basically moving the locking/live broker list inside MetadataCache. - Jun

Re: Review Request 20540: Patch for KAFKA-1410

> On April 22, 2014, 6:26 p.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 713 > > > > > > Do we no longer need to check for offset management topic? Good catch. Fixed. - Jun --

[jira] [Updated] (KAFKA-1410) MetadataCache cleanup

[ https://issues.apache.org/jira/browse/KAFKA-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1410: --- Attachment: KAFKA-1410_2014-04-22_13:51:26.patch > MetadataCache cleanup > - > >

[jira] [Commented] (KAFKA-1410) MetadataCache cleanup

[ https://issues.apache.org/jira/browse/KAFKA-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977395#comment-13977395 ] Jun Rao commented on KAFKA-1410: Updated reviewboard https://reviews.apache.org/r/20540/

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/ --- (Updated April 22, 2014, 8:51 p.m.) Review request for kafka. Bugs: KAFKA-141

Re: Review Request 20541: Patch for KAFKA-1411

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/#review41060 --- Ship it! Ship It! - Guozhang Wang On April 21, 2014, 11:34 p.m.,

Re: Review Request 20541: Patch for KAFKA-1411

> On April 22, 2014, 12:09 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 97 > > > > > > codec should be "1" The old producer supports both "1" and "gizp". - Ju

[jira] [Resolved] (KAFKA-1413) bump kafka version to 0.8.1.1 in gradle.properties

[ https://issues.apache.org/jira/browse/KAFKA-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein resolved KAFKA-1413. -- Resolution: Fixed > bump kafka version to 0.8.1.1 in gradle.properties > --

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review41039 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 20560: Patch for KAFKA-1413

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20560/#review41041 --- Ship it! Ship It! - Joel Koshy On April 22, 2014, 6:23 p.m., Joe

[jira] [Commented] (KAFKA-1413) bump kafka version to 0.8.1.1 in gradle.properties

[ https://issues.apache.org/jira/browse/KAFKA-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977161#comment-13977161 ] Joe Stein commented on KAFKA-1413: -- Created reviewboard https://reviews.apache.org/r/2056

[jira] [Updated] (KAFKA-1413) bump kafka version to 0.8.1.1 in gradle.properties

[ https://issues.apache.org/jira/browse/KAFKA-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1413: - Attachment: KAFKA-1413.patch > bump kafka version to 0.8.1.1 in gradle.properties > -

Review Request 20560: Patch for KAFKA-1413

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20560/ --- Review request for kafka. Bugs: KAFKA-1413 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1413) bump kafka version to 0.8.1.1 in gradle.properties

Joe Stein created KAFKA-1413: Summary: bump kafka version to 0.8.1.1 in gradle.properties Key: KAFKA-1413 URL: https://issues.apache.org/jira/browse/KAFKA-1413 Project: Kafka Issue Type: Task

[jira] [Commented] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977105#comment-13977105 ] Guozhang Wang commented on KAFKA-1395: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1395: - Attachment: KAFKA-1395_2014-04-22_10:43:54.patch > fix unit tests in AutoOffsetResetTest > --

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 22, 2014, 5:43 p.m.) Review request for kafka. Summary (update

[jira] [Commented] (KAFKA-1412) transient unit test failure in ProducerSendTest.testAutoCreateTopic

[ https://issues.apache.org/jira/browse/KAFKA-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977083#comment-13977083 ] Guozhang Wang commented on KAFKA-1412: -- I think this is a duplicate of KAFKA-1395. My

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

> On April 21, 2014, 10:11 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, line > > 122 > > > > > > Is this check for metadata propagation actually required? It see

[jira] [Commented] (KAFKA-1412) transient unit test failure in ProducerSendTest.testAutoCreateTopic

[ https://issues.apache.org/jira/browse/KAFKA-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977039#comment-13977039 ] Jun Rao commented on KAFKA-1412: The issue seems to be there is no resend in the test. We

[jira] [Created] (KAFKA-1412) transient unit test failure in ProducerSendTest.testAutoCreateTopic

Jun Rao created KAFKA-1412: -- Summary: transient unit test failure in ProducerSendTest.testAutoCreateTopic Key: KAFKA-1412 URL: https://issues.apache.org/jira/browse/KAFKA-1412 Project: Kafka Issue

[jira] [Commented] (KAFKA-1410) MetadataCache cleanup

[ https://issues.apache.org/jira/browse/KAFKA-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977024#comment-13977024 ] Jun Rao commented on KAFKA-1410: Updated reviewboard https://reviews.apache.org/r/20540/

[jira] [Updated] (KAFKA-1410) MetadataCache cleanup

[ https://issues.apache.org/jira/browse/KAFKA-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1410: --- Attachment: KAFKA-1410_2014-04-22_09:37:36.patch > MetadataCache cleanup > - > >

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/ --- (Updated April 22, 2014, 4:37 p.m.) Review request for kafka. Bugs: KAFKA-141

treating unit tests as code

Recently, we have seen multiple transient unit test failures. While fixing those issues, I realized that one of the problems that led to this situation is that we haven't been treating unit tests in the same way as the rest of the code. I found myself guilty of this too. When reviewing patches, I t

[jira] [Commented] (KAFKA-1408) Kafk broker can not stop itself normaly after problems with connection to ZK

[ https://issues.apache.org/jira/browse/KAFKA-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976890#comment-13976890 ] Dmitry Bugaychenko commented on KAFKA-1408: --- Found this patch in the reviosion h

[jira] [Commented] (KAFKA-1408) Kafk broker can not stop itself normaly after problems with connection to ZK

[ https://issues.apache.org/jira/browse/KAFKA-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976873#comment-13976873 ] Jun Rao commented on KAFKA-1408: We are in the process of preparing the 0.8.1.1 release.

[jira] [Commented] (KAFKA-1407) Broker can not return to ISR because of BadVersionException

[ https://issues.apache.org/jira/browse/KAFKA-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976868#comment-13976868 ] Jun Rao commented on KAFKA-1407: The deadlock is supposed to be fixed in the latest 0.8.1

[jira] [Commented] (KAFKA-1408) Kafk broker can not stop itself normaly after problems with connection to ZK

[ https://issues.apache.org/jira/browse/KAFKA-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976605#comment-13976605 ] Dmitry Bugaychenko commented on KAFKA-1408: --- We are using artefact from maven:

[jira] [Commented] (KAFKA-1407) Broker can not return to ISR because of BadVersionException

[ https://issues.apache.org/jira/browse/KAFKA-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976597#comment-13976597 ] Dmitry Bugaychenko commented on KAFKA-1407: --- Checked out the logs in more detail

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976538#comment-13976538 ] Michael Noll commented on KAFKA-1380: - Many thanks everyone for cutting this hot fix r