> On April 22, 2014, 10 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, lines > > 114-116 > > <https://reviews.apache.org/r/20380/diff/3/?file=564586#file564586line114> > > > > For this particular test, resending in the producer could introduce > > duplicates and the test is sensitive to # of duplicates. So, we probably > > have to create the topic before hand using TestUtils.createTopic().
Great point. Will go through all the modified tests once again to check any other issues. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41070 ----------------------------------------------------------- On April 22, 2014, 5:43 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20380/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 5:43 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1395 > https://issues.apache.org/jira/browse/KAFKA-1395 > > > Repository: kafka > > > Description > ------- > > Incoporate Neha's comments > > > remove waitUntilLeaderIsElectedOrChanged > > > KAFKA-1395.v1 > > > Diffs > ----- > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala > 1415773dc34d2111eb923eee812b6dc89a353441 > core/src/test/scala/unit/kafka/integration/FetcherTest.scala > 9e1a3b76fe118737172debb6e530e6c8863f671e > > core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala > 731ee59e67e302f4cb1da12b1d4ae7ff59010aea > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > 1bf9462387897e5ad90530a35341a7320993ab29 > > core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala > 16e716440099d62198af3bbadaf5b7d7bc496735 > core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala > ddb24029570329ff9528ea509528b85a5852dab4 > core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala > 5305167abf2b2a10ba91d6897f23e70466fefeba > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > 1651822f60883e3bb17c75c9b0353ffff00bbd6c > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 4bd59645635cb693de3a638e58ef19363eb742e5 > > Diff: https://reviews.apache.org/r/20380/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
