[ https://issues.apache.org/jira/browse/KAFKA-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao resolved KAFKA-1410. ---------------------------- Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the reviews. Committed to trunk. > MetadataCache cleanup > --------------------- > > Key: KAFKA-1410 > URL: https://issues.apache.org/jira/browse/KAFKA-1410 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 0.8.2 > Reporter: Jun Rao > Assignee: Jun Rao > Fix For: 0.8.2 > > Attachments: KAFKA-1410.patch, KAFKA-1410_2014-04-22_09:37:36.patch, > KAFKA-1410_2014-04-22_13:51:26.patch > > > There are a few remaining cleanup items from KAFKA-1356 for trunk. > 1. There is no need to call ensureTopicExists(). A consistent check would > require holding the read lock of metadata cache on every fetch/producer > request, which means a metadata update could block all fetch/producer > requests. Also, this call is just an optimization. When leaderAndIsrRequest > is propagated after a topic deletion, fetch/producer requests will be > rejected by the ReplicaManager. > 2. The update of the controller epoc when handling metadata request needs to > be done inside the replicaStateChangeLock. -- This message was sent by Atlassian JIRA (v6.2#6252)