> On April 21, 2014, 10:11 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, line > > 122 > > <https://reviews.apache.org/r/20380/diff/2/?file=560977#file560977line122> > > > > Is this check for metadata propagation actually required? It seems to > > me that any test that produces and then consumes data should use acks= -1 > > which will wait until the data is committed. This will suffice for the test > > to pass.
acks = -1 itself is not sufficient, we also need to make sure producer.type = sync. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review40972 ----------------------------------------------------------- On April 16, 2014, 5:11 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20380/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 5:11 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1395 > https://issues.apache.org/jira/browse/KAFKA-1395 > > > Repository: kafka > > > Description > ------- > > remove waitUntilLeaderIsElectedOrChanged > > > KAFKA-1395.v1 > > > Diffs > ----- > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala > 1415773dc34d2111eb923eee812b6dc89a353441 > > Diff: https://reviews.apache.org/r/20380/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
