----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/#review41060 -----------------------------------------------------------
Ship it! Ship It! - Guozhang Wang On April 21, 2014, 11:34 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20541/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 11:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1411 > https://issues.apache.org/jira/browse/KAFKA-1411 > > > Repository: kafka > > > Description > ------- > > 1. Remove LazyInitProducerTest since the tests there are redundant from those > in PrimitiveApiTest. 2. Remove AsyncProducerTest.testBrokerListAndAsync() > since it returns immediately. There are other tests that cover the same > functionality. 3. PrimitiveApiTest: The compression property wasn't set > properly. Also, there is no need to test compression with other combinations > such as encoder/multi-fetch. > > > Diffs > ----- > > core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala > c3c7631659fbd9265e45aa810d32faafe9aed1d1 > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala > a062f68c7f6b285fb0c63cec238882c9bc7ee246 > core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala > 18e355501808c00b610da8346e0dd1898d5b9301 > > Diff: https://reviews.apache.org/r/20541/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
