[dpdk-dev] [PATCH v2 03/12] examples/l2fwd: move globally accessed vars to common header

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_common.h | 26 ++ examples/l2fwd/main.c | 41 + 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/examples/l2fwd

[dpdk-dev] [PATCH v2 04/12] examples/l2fwd: move dataplane code to new file

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * Merged checkpatch fix patches v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/Makefile | 1 + examples/l2fwd/l2fwd_worker.c | 233 ++ examples/l2fwd/l2fwd_worker.h | 10 ++ e

[dpdk-dev] [PATCH v2 05/12] examples/l2fwd: remove unused header includes

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_worker.c | 12 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 663c505..ad5468a 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b

[dpdk-dev] [PATCH v2 06/12] examples/l2fwd: move drain buffers to new function

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/

[dpdk-dev] [PATCH v2 07/12] examples/l2fwd: optimize check for master core

2018-07-10 Thread Anoob Joseph
Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) dif

[dpdk-dev] [PATCH v2 08/12] examples/l2fwd: move periodic tasks to new function

2018-07-10 Thread Anoob Joseph
Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 83 --- examples/l2fwd

[dpdk-dev] [PATCH v2 12/12] examples/l2fwd: improvements to the usage print

2018-07-10 Thread Anoob Joseph
Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd/main.c b

[dpdk-dev] [PATCH v2 11/12] examples/l2fwd: use fprint instead of printf for usage print

2018-07-10 Thread Anoob Joseph
Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c

[dpdk-dev] [PATCH v2 10/12] examples/l2fwd: move pkt send code to a new function

2018-07-10 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_wo

[dpdk-dev] [PATCH v2 09/12] examples/l2fwd: skip timer updates for non master cores

2018-07-10 Thread Anoob Joseph
The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_worker.c | 21 + 1 file changed, 13 insertions(+), 8

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-01 Thread Joseph, Anoob
Hi Thomas, On 26-07-2018 22:27, Thomas Monjalon wrote: External Email Anoob Joseph (12): examples/l2fwd: move macro definitions to common header examples/l2fwd: move structure definitions to common header examples/l2fwd: move globally accessed vars to common header examples/l2fwd

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-13 Thread Joseph, Anoob
Hi Bruce, Pablo, If there are no more issues about the approach, can you review the patches and give the feedback? Please do note that this series doesn't add any event mode specific code. That will come as a different patch series after incorporating Jerin's comments. Thanks, Anoob On 02-

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-13 Thread Joseph, Anoob
p as l2fwd? Thanks, Anoob On 13-08-2018 14:57, Bruce Richardson wrote: External Email On Mon, Aug 13, 2018 at 12:52:19PM +0530, Joseph, Anoob wrote: Hi Bruce, Pablo, If there are no more issues about the approach, can you review the patches and give the feedback? Please do note that this series doesn

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-18 Thread Joseph, Anoob
Hi Bruce, On 14-08-2018 16:03, Bruce Richardson wrote: External Email On Mon, Aug 13, 2018 at 09:29:01PM +0530, Joseph, Anoob wrote: Hi Bruce, The reason why l2fwd was chosen was to allow everyone to chip in their ideas while preparing the framework. This framework would be extended to other

Re: [dpdk-dev] [PATCH v4 1/5] lib/ethdev: support for inline IPsec events

2018-04-19 Thread Anoob Joseph
Hi Thomas, Are these changes fine? Can you review the changes and let me know if you have more comments. Thanks, Anoob On 11/04/18 12:10, Anoob Joseph wrote: Adding support for IPsec events in rte_eth_event framework. In inline IPsec offload, the per packet protocol defined variables

[dpdk-dev] [PATCH] lib/ethdev: moving IPsec event enum to the end

2018-04-23 Thread Anoob Joseph
Adding new entry in the middle could break ABI compatibility. So moving it to the end. Fixes: 714e05f33171 ("ethdev: support for inline IPsec events") Signed-off-by: Anoob Joseph --- lib/librte_ether/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-03 Thread Joseph, Anoob
Hi Konstantin, Few comments. Please see inline. Thanks, Anoob On 24-08-2018 22:23, Konstantin Ananyev wrote: External Email This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path processing. The library is s

[dpdk-dev] [PATCH v2 00/33] Adding Cavium's OcteonTX crypto PMD

2018-09-03 Thread Anoob Joseph
Ankur Dwivedi (5): config: add Cavium OcteonTX crypto PMD skeleton common/cpt: add common logging support crypto/octeontx: add PCI probe and remove crypto/octeontx: add register addresses test: adds validation test Anoob Joseph (5): common/cpt: add common code for init routine

[dpdk-dev] [PATCH v2 02/33] common/cpt: add common logging support

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi Add common logging macros Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common

[dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi Adding basic PCI probe/remove functions for OcteonTX crypto device. Initialization function for logging is also added. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman

[dpdk-dev] [PATCH v2 05/33] common/cpt: add common code for init routine

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph Adding code identified common for OcteonTX family crypto devices. This patch is adding the code required by the structures and code path of init routine. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram

[dpdk-dev] [PATCH v2 08/33] crypto/octeontx: add hardware register access for misc poll

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph Adding hardware register accesses required for misc poll Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree

[dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi This adds Makefile, meson.build and config file options. Also adds the version map files and maintainers file to claim responsibility. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by

[dpdk-dev] [PATCH v2 04/33] crypto/octeontx: add register addresses

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx

[dpdk-dev] [PATCH v2 07/33] common/cpt: add hardware register defines

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_hw_types.h | 517

[dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR This patch adds the symmetric algorithms capabilities supported by octeontx crypto hardware. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by

[dpdk-dev] [PATCH v2 06/33] crypto/octeontx: add hardware init routine

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph Adding hardware init routine for OcteonTX crypto device. A place holder is added for misc polling routine. That will be added in the further patches. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram

[dpdk-dev] [PATCH v2 10/33] common/cpt: add PMD ops helper functions

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR Adding pmd ops helper functions. Control path accessed APIs would be added as helper functions. Adding microcode defined macros etc as dependencies to the helper functions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by

[dpdk-dev] [PATCH v2 11/33] crypto/octeontx: add global resource init

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR Adding initialization of global resources. This will be saved as metadata in cptvf and would be used by common code. Exit path for failure case is also added along with the new routines. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR

[dpdk-dev] [PATCH v2 15/33] crypto/octeontx: add queue pair functions

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding queue pair setup and release functions Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj

[dpdk-dev] [PATCH v2 17/33] crypto/octeontx: add session management ops

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding routines for session configure, session clear and get session size ops. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian

[dpdk-dev] [PATCH v2 14/33] common/cpt: add common macros for queue pair ops

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding common macros required by queue pair op functions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by

[dpdk-dev] [PATCH v2 16/33] common/cpt: add common code required for session management

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding common code required for session configure, session clear and get session size ops routines Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by

[dpdk-dev] [PATCH v2 18/33] common/cpt: add common code for fill session data

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding common code required for filling session data for AEAD, cipher & auth sessions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-of

[dpdk-dev] [PATCH v2 13/33] crypto/octeontx: add basic dev ops

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR Adding the following dev ops, - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get - stats_get - stats_reset Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman

[dpdk-dev] [PATCH v2 12/33] crypto/octeontx: add mailbox routines

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR Adding mailbox routines to interact with the pf driver Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree

[dpdk-dev] [PATCH v2 23/33] common/cpt: add crypo op enqueue request manager framework

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding crypto enqueue op request manager framework. This routine won't submit to the hardware yet. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signe

[dpdk-dev] [PATCH v2 21/33] common/cpt: add microcode interface for encryption

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding microcode interface additions for supporting encryption. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed

[dpdk-dev] [PATCH v2 20/33] common/cpt: add common defines for microcode

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt

[dpdk-dev] [PATCH v2 22/33] common/cpt: add microcode interface for decryption

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding microcode interface additions for supporting decryption. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed

[dpdk-dev] [PATCH v2 24/33] common/cpt: add support for zuc and snow3g

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting ZUC and SNOW3G. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by

[dpdk-dev] [PATCH v2 19/33] crypto/octeontx: add supported sessions

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding AEAD, cipher & auth sessions support. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Teja

[dpdk-dev] [PATCH v2 25/33] common/cpt: add support for kasumi

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting kasumi. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree

[dpdk-dev] [PATCH v2 26/33] common/cpt: add support for hash

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting verify and authentication Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S

[dpdk-dev] [PATCH v2 27/33] crypto/octeontx: add routines to prepare instructions

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Adding hardware specific routines which prepare cpt instructions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed

[dpdk-dev] [PATCH v2 29/33] crypto/octeontx: add enqueue burst op

2018-09-03 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx

[dpdk-dev] [PATCH v2 28/33] common/cpt: add common code for enqueuing cpt instruction

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_common.h

[dpdk-dev] [PATCH v2 30/33] common/cpt: add common code for cpt dequeue

2018-09-03 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_common.h

[dpdk-dev] [PATCH v2 31/33] crypto/octeontx: add dequeue burst op

2018-09-03 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx

[dpdk-dev] [PATCH v2 32/33] test: adds validation test

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi This patch adds validation tests for octeontx crypto device. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by

[dpdk-dev] [PATCH v2 33/33] doc: adds doc file

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph This patch adds the features file and the document containing help to compile and use octeontx crypto. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by

[dpdk-dev] [PATCH] examples/ipsec-secgw: increase the number of dev mappings

2018-09-05 Thread Anoob Joseph
Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index b45b87b..ae76e67 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-05 Thread Joseph, Anoob
Hi Konstantin, Please see inline. On 03-09-2018 23:51, Ananyev, Konstantin wrote: External Email Hi Anoob, Hi Konstantin, Few comments. Please see inline. Thanks, Anoob On 24-08-2018 22:23, Konstantin Ananyev wrote: External Email This RFC introduces a new library within DPDK: librte_

[dpdk-dev] [PATCH v1] examples/ipsec-secgw: increase the number of dev mappings

2018-09-05 Thread Anoob Joseph
: Anoob Joseph --- v1: * Fixed typo in description examples/ipsec-secgw/ipsec-secgw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index b45b87b..ce5365a 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b

Re: [dpdk-dev] [PATCH 1/3] security: support pdcp protocol

2018-09-05 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 28-08-2018 18:31, akhil.go...@nxp.com wrote: External Email From: Akhil Goyal Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- doc/guides/prog_guide/rte_security.rst | 90 -- lib/librte_security/rte_secur

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix wrong session size

2018-09-06 Thread Anoob Joseph
urity offload") Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti --- examples/ipsec-secgw/ipsec-secgw.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index b45b87b..47ac26a 100644 ---

[dpdk-dev] [PATCH] app/test-crypto-perf: fix double allocation of memory

2018-09-09 Thread Anoob Joseph
yptodev: move IV parameters to session") Signed-off-by: Akash Saxena Signed-off-by: Anoob Joseph --- app/test-crypto-perf/cperf_test_vectors.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_vectors.c b/app/test-cry

[dpdk-dev] [PATCH v1] app/test-crypto-perf: fix double allocation of memory

2018-09-10 Thread Anoob Joseph
yptodev: move IV parameters to session") Signed-off-by: Akash Saxena Signed-off-by: Anoob Joseph --- v1: * Fixed typo app/test-crypto-perf/cperf_test_vectors.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/app/test-crypto-perf/cperf_tes

Re: [dpdk-dev] [PATCH v2 00/33] Adding Cavium's OcteonTX crypto PMD

2018-09-14 Thread Joseph, Anoob
Hi Akhil, Pablo, Did you get a chance to look at the patches? Anoob On 04-09-2018 09:28, Anoob Joseph wrote: Ankur Dwivedi (5): config: add Cavium OcteonTX crypto PMD skeleton common/cpt: add common logging support crypto/octeontx: add PCI probe and remove crypto/octeontx: add

[dpdk-dev] [PATCH 0/3] fix test vector checks

2018-09-14 Thread Anoob Joseph
Multiple fixes to the test vector checks. Anoob Joseph (3): app/test-crypto-perf: add checks for AEAD key app/test-crypto-perf: fix check for auth key app/test-crypto-perf: fix check for cipher IV app/test-crypto-perf/main.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions

[dpdk-dev] [PATCH 1/3] app/test-crypto-perf: add checks for AEAD key

2018-09-14 Thread Anoob Joseph
Adding validation checks for AEAD key. Signed-off-by: Akash Saxena Signed-off-by: Anoob Joseph --- app/test-crypto-perf/main.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 5c7dadb..c9f99a7 100644 --- a/app/test-crypto

[dpdk-dev] [PATCH 2/3] app/test-crypto-perf: fix check for auth key

2018-09-14 Thread Anoob Joseph
Authentication key is not required for all algorithms. Making sure the null check is done only when 'auth_key_sz' is non-zero. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma --- app/tes

[dpdk-dev] [PATCH 3/3] app/test-crypto-perf: fix check for cipher IV

2018-09-14 Thread Anoob Joseph
IV is not required for all ciphers. Making sure the null check is done only when 'cipher_iv_sz' is non-zero. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Akash Saxena Signed-off-by: Anoob Joseph --- app/test-crypto-perf/mai

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-15 Thread Joseph, Anoob
Hi Konstantin See inline. Thanks, Anoob On 12-09-2018 23:39, Ananyev, Konstantin wrote: External Email Hi Anoob, Hi Konstantin, Please see inline. This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-16 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 14-09-2018 17:41, Akhil Goyal wrote: External Email Hi Anoob, On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Ankur Dwivedi This adds Makefile, meson.build and config file options. Also adds the version map files and maintainers file to claim

Re: [dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove

2018-09-16 Thread Joseph, Anoob
Hi Akhil, See inline. Thanks, Anoob On 14-09-2018 18:09, Akhil Goyal wrote: External Email On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Ankur Dwivedi Adding basic PCI probe/remove functions for OcteonTX crypto device. Initialization function for logging is also added. Signed-off-by

Re: [dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 16:04, Akhil Goyal wrote: External Email +static struct rte_pci_driver otx_cryptodev_pmd = { + .id_table = pci_id_cpt_table, + .drv_flags = RTE_PCI_DRV_NEED_MAPPING, + .probe = otx_cpt_pci_probe, + .remove = otx_cpt_pci_re

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related changes in the 3/33 patch as the code is actually added in that and here the code is not getting compiled here. So the changes in the following files has to be moved t

Re: [dpdk-dev] [PATCH v2 05/33] common/cpt: add common code for init routine

2018-09-17 Thread Joseph, Anoob
Hi Thomas, On 17-09-2018 17:16, Thomas Monjalon wrote: External Email 17/09/2018 12:45, Akhil Goyal: On 9/4/2018 9:28 AM, Anoob Joseph wrote: +struct pending_queue { + uint16_t enq_tail; + uint16_t deq_head; + uint16_t soft_qlen; + /**< Software expected queue len

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 17:31, Akhil Goyal wrote: External Email diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c index d25f9c1..cc0030e 100644 --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c +++ b/drivers/crypto/octeontx/otx_cryptodev_o

Re: [dpdk-dev] [PATCH v2 07/33] common/cpt: add hardware register defines

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 16:48, Akhil Goyal wrote: External Email +typedef union cpt_res_s { + uint64_t u[2]; + struct cpt_res_s_8s { +#if (RTE_BYTE_ORDER == RTE_BIG_ENDIAN) /* Word 0 - Big Endian */ + uint64_t reserved_17_63    : 47; + uint64_t doneint 

Re: [dpdk-dev] [PATCH v2 10/33] common/cpt: add PMD ops helper functions

2018-09-17 Thread Joseph, Anoob
HI Akhil, On 17-09-2018 18:17, Akhil Goyal wrote: External Email On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Murthy NSSR Adding pmd ops helper functions. Control path accessed APIs would be added as helper functions. Adding microcode defined macros etc as dependencies to the helper

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 17:50, Akhil Goyal wrote: External Email On 9/17/2018 5:12 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related changes in the 3/33 patch as the code is actually added in

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-17 Thread Joseph, Anoob
Hi Konstantin, On 17-09-2018 16:06, Ananyev, Konstantin wrote: External Email Hi Anoob, Hi Konstantin, Please see inline. This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path processing. The library is s

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Thomas, On 17-09-2018 20:06, Thomas Monjalon wrote: External Email 17/09/2018 16:13, Joseph, Anoob: On 17-09-2018 17:50, Akhil Goyal wrote: On 9/17/2018 5:12 PM, Joseph, Anoob wrote: On 17-09-2018 16:07, Akhil Goyal wrote: I think it would be better to squash the makefile related

[dpdk-dev] [PATCH] doc: update feature support for cryptodevs

2018-09-20 Thread Anoob Joseph
Adding 3DES-ECB & AES-XTS to the list of ciphers supported Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/features/default.ini | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/cryptodevs/features/default.ini b/doc/guides/cryptodevs/features/default.ini index 92a

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-09-24 Thread Joseph, Anoob
on to a header and include it from the .c file. I believe, the QAT approach was to avoid variable definition in the header. What do you think would be a better approach here? Thanks, Anoob On 17-09-2018 18:05, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 17:31, Akhil Goyal wrote: External

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix wrong session size

2018-09-25 Thread Joseph, Anoob
Hi Akhil, Radu, Can you please review this patch and let me know your thoughts? Anoob On 07-09-2018 11:25, Anoob Joseph wrote: Crypto devices, which support lookaside protocol, exposes security session size in addition to the crypto private symmetric session data size. For applications using

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-09-28 Thread Joseph, Anoob
Hi Fiona, Did you get a chance to look at this? Thanks, Anoob On 24-09-2018 17:06, Joseph, Anoob wrote: Hi Fiona, Can you please comment on this? We are adding all capabilities of octeontx-crypto PMD as a macro in otx_cryptodev_capabilites.h file and then we are using it from

[dpdk-dev] [PATCH] crypto/armv8: fix HMAC supported digest sizes

2018-05-29 Thread Anoob Joseph
For HMAC algorithms (SHAx-HMAC), the supported digest sizes are not a fixed value, but a range between 1 and the maximum digest size for those algorithms. Fixes: 0f89def76127 ("crypto/armv8: fix HMAC supported key sizes") Cc: sta...@dpdk.org Signed-off-by: Anoob Joseph Signed-off-

[dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT) driver

2018-06-08 Thread Anoob Joseph
Ankur Dwivedi (4): crypto/cpt/base: add hardware enq/deq API for CPT crypto/cpt/base: add sym crypto session init API for CPT crypto/cpt/base: add sym crypto request prepare for CPT crypto/cpt: build with meson Murthy NSSR (3): crypto/cpt/base: add request prepare API for ZUC and SNOW3G

[dpdk-dev] [PATCH 03/16] crypto/cpt/base: add hardware initialization API for CPT

2018-06-08 Thread Anoob Joseph
From: Nithin Dabilpuram Adds hardware device initialization specific api for Cavium CPT device. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian Srinivasan --- drivers/crypto/cpt/

[dpdk-dev] [PATCH 01/16] config: add Cavium CPT PMD skeleton

2018-06-08 Thread Anoob Joseph
From: Nithin Dabilpuram Add makefile and config file options. Also add version map file and maintainers file to claim responsibility. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian

[dpdk-dev] [PATCH 02/16] crypto/cpt/base: add hardware definitions Cavium CPT

2018-06-08 Thread Anoob Joseph
From: Nithin Dabilpuram Adds hardware specific definitions for Cavium CPT device. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian Srinivasan --- drivers/crypto/cpt/base/cpt_hw_ty

[dpdk-dev] [PATCH 04/16] crypto/cpt/base: add hardware enq/deq API for CPT

2018-06-08 Thread Anoob Joseph
From: Ankur Dwivedi Adds hardware enqueue/dequeue API of instructions to a queue pair for Cavium CPT device. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian Srinivasan --- driver

[dpdk-dev] [PATCH 05/16] crypto/cpt/base: add sym crypto session init API for CPT

2018-06-08 Thread Anoob Joseph
From: Ankur Dwivedi Adds symmetric crypto session init API dependent on hardware/microcode. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian Srinivasan --- drivers/crypto/cpt/base

[dpdk-dev] [PATCH 06/16] crypto/cpt/base: add sym crypto request prepare for CPT

2018-06-08 Thread Anoob Joseph
From: Ankur Dwivedi These functions help in preparing symmetric crypto requests for the supported cipher/auth/aead. This includes all supported algos except Kasumi, Snow3G, Zuc, HMAC_ONLY and HASH_ONLY cases. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpu

[dpdk-dev] [PATCH 07/16] crypto/cpt/base: add request prepare API for ZUC and SNOW3G

2018-06-08 Thread Anoob Joseph
From: Murthy NSSR These functions help in preparing symmetric crypto requests for the ZUC, SNOW3G algorithms of both cipher and auth but not cipher+auth in single xform. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayarama

[dpdk-dev] [PATCH 08/16] crypto/cpt/base: add request prepare API for Kasumi

2018-06-08 Thread Anoob Joseph
From: Murthy NSSR These functions help in preparing symmetric crypto request for Kasumi of both cipher and auth but not cipher+auth in single xform. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Sri

[dpdk-dev] [PATCH 09/16] crypto/cpt/base: add prepare request API for HASH and HMAC

2018-06-08 Thread Anoob Joseph
From: Murthy NSSR These functions help in preparing symmetric crypto requests for HMAC only or HMAC only cases. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian Srinivasan --- dri

[dpdk-dev] [PATCH 11/16] crypto/cpt: add the basic device callback functions

2018-06-08 Thread Anoob Joseph
From: Srisivasubramanian Srinivasan This patch addresses the following: 1. Adds the basic device operation functions for the cpt vf. 2. The probe/remove functions are staic so no need to declare in the header file. 3. Removing extra declaration for cpt_dev_periodic_alarm_stop in the header file.

[dpdk-dev] [PATCH 10/16] crypto/cpt: add driver initializations

2018-06-08 Thread Anoob Joseph
From: Srisivasubramanian Srinivasan Introduce driver initialization and enable build infrastructure. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian Srinivasan --- drivers/crypto

[dpdk-dev] [PATCH 13/16] crypto/cpt: adds the session related function callbacks

2018-06-08 Thread Anoob Joseph
From: Ragothaman Jayaraman This patch adds the session callbacks functions. The cipher keys, auth keys and aead keys are set during the session configure. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-b

[dpdk-dev] [PATCH 12/16] crypto/cpt: adds some more callback functions for CPT

2018-06-08 Thread Anoob Joseph
From: Srisivasubramanian Srinivasan This patch does the following: 1. Adds the stats callback functions for the cpt vf. 2. Adds the queue pair setup and queue pair release callback functions for cpt vf. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram S

[dpdk-dev] [PATCH 14/16] crypto/cpt: adds the enqueue and dequeue callbacks

2018-06-08 Thread Anoob Joseph
From: Ragothaman Jayaraman The functions present in cpt_request_mgr.c manages the work of enqueing/dequeing the request/response to/from cpt hardware unit. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-

[dpdk-dev] [PATCH 15/16] doc: add Cavium's CPT guide

2018-06-08 Thread Anoob Joseph
From: Ragothaman Jayaraman The guide contains information about packages needed to compile the CPT PMD. It also contains the compilation steps and how to execute an examples application. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ra

[dpdk-dev] [PATCH 16/16] crypto/cpt: build with meson

2018-06-08 Thread Anoob Joseph
From: Ankur Dwivedi Adding the meson.build file for the CPT PMD. Signed-off-by: Ankur Dwivedi Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian Srinivasan --- drivers/crypto/cpt/meson.build | 16 ++

[dpdk-dev] [PATCH 02/15] examples/l2fwd: move macro definitions to common header

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_common.h | 18 ++ examples/l2fwd/main.c | 16 ++-- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h index 15059f4..fe354cf 100644

[dpdk-dev] [PATCH 01/15] examples/l2fwd: add new header to move common code

2018-06-08 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- examples/l2fwd/l2fwd_common.h | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 examples/l2fwd/l2fwd_common.h diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h new file mode 100644 index 000..15059f4 --- /dev/null +++ b

[dpdk-dev] [PATCH 00/15] preparing l2fwd for eventmode additions

2018-06-08 Thread Anoob Joseph
This patchset modularizes l2fwd application to prepare it for eventmode additions. This patchset doesn't change the code flow or logic, except for few minor improvements. Some of the newly added functions are used in just one place, but is added for efficient usage with eventmode. Anoob J

<    7   8   9   10   11   12   13   14   15   16   >