Hi Thomas,
On 17-09-2018 20:06, Thomas Monjalon wrote:
External Email
17/09/2018 16:13, Joseph, Anoob:
On 17-09-2018 17:50, Akhil Goyal wrote:
On 9/17/2018 5:12 PM, Joseph, Anoob wrote:
On 17-09-2018 16:07, Akhil Goyal wrote:
I think it would be better to squash the makefile related changes in
the 3/33 patch as the code
is actually added in that and here the code is not getting compiled
here.
So the changes in the following files has to be moved to patch 3/33?
drivers/crypto/Makefile
drivers/crypto/meson.build
drivers/crypto/octeontx/Makefile
drivers/crypto/octeontx/meson.build
mk/rte.app.mk
I think this patch will just have MAINTAINER edit (even that might be
required to be moved to 3/33?) & changes to config/common_base, after
that. Is that fine?
In my opinion, you do not need this patch as separate one.
config/common_base can also be added in the 3/33.
In that case 02/33 patch would become the first patch right? The same
problem would be there too, I guess. The macros added in that patch gets
used only in 03/33 patch. Is that fine?
I think that would be fine. Better to have a 03/33 patch before 02/33
if it doesn't have dependencies.
03/33 patch is dependent on 02/33 patch. Shall I proceed with merging
01/33 to 03/33 and make 02/33 the first patch?
You should start by introducing common code directory.
Then you introduce the PMD directory with minimal code in it.
Understood.
Question: what means "cpt"?
Why it is not an "octeontx" common directory?
CPT is the cryptographic engine in OcteonTX family. This dir will have
the common code that will be shared between octeontx and other
processors with similar engine. The directory "common/octeontx" is for
common code shared by different components of the same chip(octeontx).
Here it's the code for same engine across multiple platforms.
Anoob
