v2:
- Fix typo in the commit message
---
Dharmik Thakkar (1):
lib/mempool: make stats macro generic
Joyce Kong (1):
lib/mempool: distinguish debug counters from cache and pool
lib/librte_mempool/rte_mempool.c | 24 +++
lib/librte_mempool/rte_mempool.h | 71
Make __MEMPOOL_STAT_ADD macro more generic and delete
__MEMPOOL_CONTIG_BLOCKS_STAT_ADD macro
Suggested-by: Olivier Matz
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
lib/librte_mempool/rte_mempool.h | 34 +++-
1
From: Joyce Kong
If cache is enabled, objects will be retrieved/put from/to cache,
subsequently from/to the common pool. Now the debug stats calculate
the objects retrieved/put from/to cache and pool together, it is
better to distinguish them.
Signed-off-by: Joyce Kong
Signed-off-by: Dharmik
Hi Olivier,
Apologies for the delayed response!
I’m stepping in since Joyce is on vacation.
I have updated the patch with the required changes.
Thank you!
> On Apr 7, 2021, at 9:28 AM, Olivier Matz wrote:
Hi Olivier,
Thank you for your comments!
> On Apr 21, 2021, at 11:29 AM, Olivier Matz wrote:
>
> Hi Dharmik,
>
> Please see some comments below.
>
> On Mon, Apr 19, 2021 at 07:08:00PM -0500, Dharmik Thakkar wrote:
>> From: Joyce Kong
>>
>> If cache is
bulk counters
v2:
- Fix typo in the commit message
---
Dharmik Thakkar (1):
lib/mempool: make stats macro generic
Joyce Kong (1):
lib/mempool: distinguish debug counters from cache and pool
lib/mempool/rte_mempool.c | 16 ++
lib/mempool/rte_mempool.h | 67
From: Joyce Kong
If cache is enabled, objects will be retrieved/put from/to cache,
subsequently from/to the common pool. Now the debug stats calculate
the objects retrieved/put from/to cache and pool together, it is
better to distinguish them.
Signed-off-by: Joyce Kong
Signed-off-by: Dharmik
Make __MEMPOOL_STAT_ADD macro more generic and delete
__MEMPOOL_CONTIG_BLOCKS_STAT_ADD macro
Suggested-by: Olivier Matz
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
Acked-by: Olivier Matz
---
lib/mempool/rte_mempool.h | 34
+Honnappa
> On Apr 22, 2021, at 8:29 PM, Dharmik Thakkar wrote:
>
> From: Joyce Kong
>
> If cache is enabled, objects will be retrieved/put from/to cache,
> subsequently from/to the common pool. Now the debug stats calculate
> the objects retrieved/put from/to cache and
ro generic
- Remove other stat add/subtract macros
- Rename counters for better understanding
- Add put/get cache bulk counters
v2:
- Fix typo in the commit message
---
Dharmik Thakkar (1):
mempool: make stats macro generic
Joyce Kong (1):
mempool: distinguish debug counters from cache and
Make __MEMPOOL_STAT_ADD macro more generic and delete
__MEMPOOL_CONTIG_BLOCKS_STAT_ADD macro
Suggested-by: Olivier Matz
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
Acked-by: Olivier Matz
---
lib/mempool/rte_mempool.h | 34
From: Joyce Kong
If cache is enabled, objects will be retrieved/put from/to cache,
subsequently from/to the common pool. Now the debug stats calculate
the objects retrieved/put from/to cache and pool together, it is
better to distinguish them.
Signed-off-by: Joyce Kong
Signed-off-by: Dharmik
_bulk=32 n_keep=32 :
> 1262052966.00/1007039283.00/-20.21
> cache=512 cores=2 n_get_bulk=32 n_put_bulk=32 n_keep=128 :
> 1517853081.00/1230818508.00/-18.91
> cache=512 cores=8 n_get_bulk=32 n_put_bulk=32 n_keep=32
> :5054529533.00/4028052273.00/-20.31
> cache=512
gt;>> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
>>>>> Sent: Friday, 7 January 2022 12.16
>>>>>
>>>>> On Sat, Dec 25, 2021 at 01:16:03AM +0100, Morten Brørup wrote:
>>>>>>> From: Dharmik Thakkar [mailto:dha
ing
---
Dharmik Thakkar (1):
mempool: implement index-based per core cache
lib/mempool/rte_mempool.h | 150 +-
lib/mempool/rte_mempool_ops_default.c | 7 ++
2 files changed, 156 insertions(+), 1 deletion(-)
--
2.17.1
cache
L3Fwd performance testing reveals minor improvements in the cache
performance (L1 and L2 misses reduced by 0.60%)
with no change in throughput
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
lib/mempool/rte_mempool.h | 150
Hi Konstatin,
> On Jan 13, 2022, at 4:37 AM, Ananyev, Konstantin
> wrote:
>
>
> Hi Dharmik,
>
>>>
Current mempool per core cache implementation stores pointers to mbufs
On 64b architectures, each pointer consumes 8B
This patch replaces it with index-based implementation,
Since atomic operations have been adopted in DPDK now[1],
change rte_atomicNN_xxx APIs to compiler's atomic built-ins
in examples module[2].
[1] https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model/
[2] https://doc.dpdk.org/guides/rel_notes/deprecation.html
v3:
Keep rte_atomic.
From: Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins
for global_exit_flag sync.
Signed-off-by: Joyce Kong
Reviewed-by: Ruifeng Wang
---
examples/bbdev_app/main.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/examples/bbdev_app/main.c b/ex
From: Joyce Kong
Convert rte_atomic32_test_and_set usage to compiler atomic
CAS operation for display_stats sync.
Signed-off-by: Joyce Kong
Reviewed-by: Ruifeng Wang
---
examples/multi_process/client_server_mp/mp_server/main.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff
From: Joyce Kong
Convert rte_atomic usages to compiler atomic builit-ins
for kni_stop and kni_pause sync.
Signed-off-by: Joyce Kong
Reviewed-by: Ruifeng Wang
---
examples/kni/main.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/examples/kni/
From: Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins
for thread sync.
Signed-off-by: Joyce Kong
Reviewed-by: Ruifeng Wang
---
examples/performance-thread/common/lthread.c | 10 +++---
.../performance-thread/common/lthread_diag.h | 10 +++---
.../performance-thread/common/
From: Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins
for stats_read_pending sync in l2fwd_jobstats module.
Signed-off-by: Joyce Kong
Reviewed-by: Ruifeng Wang
---
examples/l2fwd-jobstats/main.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/
From: Joyce Kong
Convert rte_atomic32_cmpset to compiler atomic CAS
operation for channel status sync.
Signed-off-by: Joyce Kong
Reviewed-by: Ruifeng Wang
---
examples/vm_power_manager/channel_monitor.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/examples/v
From: Joyce Kong
Convert rte_atomic32_test_and_set to compiler CAS atomic
operation for display_stats sync.
Signed-off-by: Joyce Kong
Reviewed-by: Ruifeng Wang
---
examples/server_node_efd/server/main.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/server
From: Joyce Kong
Remove the unnecessary header file rte_atomic.h
included in example module.
Signed-off-by: Joyce Kong
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
examples/bond/main.c | 1 -
examples/ip_fragmentation/main.c
From: Joyce Kong
In stack module, remove the header file rte_atomic.h
as it is not being used.
Signed-off-by: Joyce Kong
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
v2:
Change commit message (Olivier)
---
app/test/test_stack.c | 1 -
lib/stack/rte_stack.c | 1 -
lib
towards examples dir.
Another recently upstreamed patch series [1] also reported a similar CI failure.
Thus, this looks like a common CI issue.
[1]
https://lab.dpdk.org/results/dashboard/patchsets/19456/
> On Oct 13, 2021, at 1:54 PM, Dharmik Thakkar wrote:
>
> From: Joyce Kong
>
Hi,
Thank you everyone for the comments! I am currently working on making the
global pool ring’s implementation as index based.
Once done, I will send a patch for community review. I will also make it as a
compile time option.
> On Oct 31, 2021, at 3:14 AM, Morten Brørup wrote:
>
>> From: Mor
> On Nov 3, 2021, at 10:52 AM, Morten Brørup wrote:
>
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dharmik Thakkar
>> Sent: Wednesday, 3 November 2021 16.13
>>
>> Hi,
>>
>> Thank you everyone for the comments! I am currently w
Convert rte_atomic usages to compiler atomic built-ins
for stats sync
Signed-off-by: Dharmik Thakkar
Reviewed-by: Joyce Kong
Reviewed-by: Ruifeng Wang
---
app/test/test_hash_multiwriter.c | 19
app/test/test_hash_readwrite.c | 80 +++-
2 files changed
Hi,
Kathleen has submitted an RFC patch [1] in this regard. We’d appreciate your
comments.
[1]
https://patches.dpdk.org/project/dpdk/patch/20210430213747.41530-2-kathleen.cape...@arm.com/
Thank you!
> On Apr 30, 2021, at 4:28 AM, Ananyev, Konstantin
> wrote:
>
>>
>>
>> On Thu, Apr 29, 2021
cache
L3Fwd performance testing reveals minor improvements in the cache
performance (L1 and L2 misses reduced by 0.60%)
with no change in throughput
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
lib/mempool/rte_mempool.h | 114
red
Dharmik Thakkar (1):
mempool: implement index-based per core cache
lib/mempool/rte_mempool.h | 114 +-
lib/mempool/rte_mempool_ops_default.c | 7 ++
2 files changed, 119 insertions(+), 2 deletions(-)
--
2.25.1
: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Acked-by: Konstantin Ananyev
Acked-by: Chengwen Feng
---
v12:
* Fix CI compilation issues on [patch 2/2] in the series
v11:
* Changed patch description and version to 23.07
v10:
* Added mempool test cases with zero-copy API's
v9:
* Also set rte_err
From: Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD.
On Ampere Altra server, l3fwd single core's performance improves by 5%
with the new API
Signed-off-by: Kamalakshitha Aligeri
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: F
Update guide with instructions to run on Aarch64 based Ampere Altra
platform
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
v2:
- Update driver guide with instructions to run on aarch64 instead
of release notes.
---
.mailmap | 2 +-
doc/guides/cryptodevs
Update guide with instructions to run on Aarch64 based Ampere Altra
platform
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
v3:
- Fix duplicate target warning by using anonymous reference
v2:
- Update driver guide with instructions to run on aarch64 instead
---
.mailmap
Update release notes with added support for QAT on Ampere Altra.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
doc/guides/rel_notes/release_23_07.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes
d-off-by: Dharmik Thakkar
---
drivers/mempool/ring/rte_mempool_ring.c | 2 +-
lib/mempool/rte_mempool.c | 8 +++
lib/mempool/rte_mempool.h | 74 ++---
3 files changed, 74 insertions(+), 10 deletions(-)
diff --git a/drivers/mempool
Hi,
Apologies for the delayed response!
> On Mar 10, 2021, at 9:10 AM, Stephen Hemminger
> wrote:
>
> On Wed, 10 Mar 2021 12:10:01 +0100
> Thomas Monjalon wrote:
>
>> 10/03/2021 12:04, Dharmik Thakkar:
>>> Enable volatile considered harmful warning sin
Enable volatile considered harmful warning since use of volatile
is suspect.
Suggested-by: Stephen Hemminger
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b
Hi,
Thank you for the comments!
Based on the suggestions, I tested the patch for single core L3Fwd performance
with increased number of routes/flows (maximum 8K) to increase cache footprint.
However, I don’t see much improvement with the patch.
> On Jan 21, 2022, at 5:25 AM, Ananyev, Konstantin
Hi Yipeng,
I have addressed the comments. Can you please take a look?
Thank you!
> On Oct 21, 2020, at 5:50 PM, Dharmik Thakkar wrote:
>
> Currently, users have to use external RCU mechanisms to free resources
> when using lock free hash algorithm.
>
> Integrate RCU QSBR
> On Oct 24, 2020, at 4:09 AM, David Marchand wrote:
>
> On Thu, Oct 22, 2020 at 12:51 AM Dharmik Thakkar
> wrote:
>>
>> Integrate RCU QSBR to make it easier for the applications to use lock
>> free algorithm.
>>
>> Resource reclamation implementa
> On Oct 22, 2020, at 4:25 PM, Honnappa Nagarahalli
> wrote:
>
> + Dharmik
>
>> -Original Message-
>> From: Thomas Monjalon
>> Sent: Thursday, October 22, 2020 4:18 PM
>> To: Ruifeng Wang
>> Cc: dev@dpdk.org; akhil.go...@nxp.com; Honnappa Nagarahalli
>> ; nd
>> Subject: Re: [dpdk-
ries + 1;
>
> if (h == NULL || cfg == NULL || cfg->v == NULL) {
> rte_errno = EINVAL;
> return 1;
> }
>
> +const uint32_t total_entries = h->use_local_cache ?
> +h->entries + (RTE_MAX_LCORE - 1) * (LCORE_CACHE_SIZE - 1) + 1
> +: h->entries + 1;
> +
> if
Apologies for the disclaimer!
> On Oct 27, 2020, at 9:59 AM, Dharmik Thakkar wrote:
>
> Hi Yunjian,
>
> Thank you for fixing the issue!
>
>> On Oct 27, 2020, at 7:51 AM, wangyunjian wrote:
>>
>> From: Yunjian Wang
>>
>> Coverity flags that
Hi Zhou,
Although, I see that a few of the configuration options are checking for
’test_done’, I am wondering if it is truly required.
Since, as per the documentation guidelines:
'Configuration changes only become active when forwarding is started/restarted.’
> On Oct 27, 2020, at 1:42 AM, Zhou
Fix incorrect calculations for LPM adds, LPM deletes,
and average cycles in RCU QSBR perf tests
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
Remove redundant error checking for reader threads
since they never return error.
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_p
Return error if Add/Delete fail in multiwriter perf test
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_perf.c | 4
1 file
Avoid code duplication by combining single and multi threaded tests
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_perf.c | 338 +--
1 file changed, 73 insertions(+), 265 deletions(-)
diff --git a/app/test/test_lpm_perf.c b
nfo**:
> ``rx_err_drop_offload_capa:RTE_DEV_RX_ERR_PKT_DROP_OFFLOAD_L4_CSUM``.
> +
> +
> +.. _nic_features_all_rx_error_packet_drop:
> +
> +All/any Error Packet drop on Rx
> +---
> +
> +Supports dropping of packets having any of the errors like L1 FSC, L3/L4
> Checksum on Rx.
s/FSC/FCS
> +
> +* **[uses] user config**: ``dev_conf.err_pkt_drop_conf.all``.
> +* **[provides] rte_eth_dev_info**:
> ``rx_err_drop_offload_capa:RTE_DEV_RX_ERR_PKT_DROP_OFFLOAD_ALL``.
> +
> +
> .. _nic_features_packet_type_parsing:
>
> Packet type parsing
> diff --git a/doc/guides/testpmd_app_ug/run_app.rst
> b/doc/guides/testpmd_app_ug/run_app.rst
> index e2539f693..20f2f8083 100644
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -213,6 +213,10 @@ The command line options are:
>
> Enable hardware QINQ strip.
>
> +* ``--enable-hw-drop-err-all``
> +
> +Enable hardware packet drop for any error packets
> +
> * ``--enable-drop-en``
>
> Enable per-queue packet drop for packets with no descriptors.
> —
> 2.17.1
>
Reviewed-by: Dharmik Thakkar
> On Nov 2, 2020, at 9:11 AM, Bruce Richardson
> wrote:
>
> On Thu, Oct 29, 2020 at 10:36:31AM -0500, Dharmik Thakkar wrote:
>> Fix incorrect calculations for LPM adds, LPM deletes,
>> and average cycles in RCU QSBR perf tests
>>
>
> To help review thi
> On Nov 2, 2020, at 11:17 AM, Medvedkin, Vladimir
> wrote:
>
> Hi Dharmik,
>
> Thanks for the patches, see comments inlined
>
>
> On 29/10/2020 15:36, Dharmik Thakkar wrote:
>> Avoid code duplication by combining single and multi threaded tests
- Replace hard coded values with an enum
- Remove lock acquire/release for single writer
Dharmik Thakkar (4):
test/lpm: fix cycle calculation in rcu qsbr perf
test/lpm: return error on failure in rcu qsbr perf
test/lpm: remove error checking in rcu qsbr perf
test/lpm: avoid code duplication in
Avoid code duplication by combining single and multi threaded tests
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_perf.c | 362 ++-
1 file changed, 91 insertions(+), 271 deletions(-)
diff --git a/app/test/test_lpm_perf.c b
Return error if Add/Delete fail in multiwriter perf test
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_perf.c | 4
1 file
Remove redundant error checking for reader threads
since they never return error.
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_p
ance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_perf.c | 45 ++--
1 file changed, 16 insertions(+), 29 deletions(-)
diff --git a/app/test/test_lpm_perf.c b/app/
> On Nov 2, 2020, at 10:21 PM, Honnappa Nagarahalli
> wrote:
>
>
>>
>> Avoid code duplication by combining single and multi threaded tests
>>
>> Signed-off-by: Dharmik Thakkar
>> Reviewed-by: Ruifeng Wang
> On Nov 2, 2020, at 7:28 PM, Honnappa Nagarahalli
> wrote:
>
>
>
>>
>> Return error if Add/Delete fail in multiwriter perf test
>>
>> Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
>> Cc: honnappa.nagaraha...@arm.c
;> Cc: honnappa.nagaraha...@arm.com
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Dharmik Thakkar
>> Reviewed-by: Ruifeng Wang
>> ---
>> app/test/test_lpm_perf.c | 21 -
>> 1 file changed, 8 insertions(+), 13 deletions(-)
>>
>> d
tement
v2:
- Add more details about the fix to the commit message
- Replace hard coded values with an enum
- Remove lock acquire/release for single writer
Dharmik Thakkar (4):
test/lpm: fix cycle calculation in rcu qsbr perf
test/lpm: return error on failure in rcu qsbr perf
test/lpm: re
Return error if Add/Delete fail in multiwriter perf test
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_perf.c | 6 ++
1 file
Avoid code duplication by combining single and multi threaded tests
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_perf.c | 359 ++-
1 file changed, 89 insertions(+), 270 deletions(-)
diff --git a/app/test/test_lpm_perf.c b
ance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
app/test/test_lpm_perf.c | 45 ++--
1 file changed, 16 insertions(+), 29 deletions(-)
diff --git a/
Remove redundant error checking for reader threads
since they never return error.
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
---
app/test/test_lpm_p
I am attempting to test the patch on an Arm machine, but it failed to apply.
I’m getting the following error:
error: patch failed: test/test/test_hash_perf.c:18
error: test/test/test_hash_perf.c: patch does not apply
Patch failed at 0003 test/hash: implement extendable bucket hash test
> On Oct
implement extendable bucket hash test
> hash: use partial-key hashing
>
> lib/librte_hash/rte_cuckoo_hash.c | 585 ++++------
> lib/librte_hash/rte_cuckoo_hash.h | 11 +-
> lib/librte_hash/rte_hash.h| 8 +-
> test/test/test_hash.c | 159 ++-
> test/test/test_hash_perf.c| 114 ++--
> 5 files changed, 683 insertions(+), 194 deletions(-)
>
> --
> 2.7.4
>
Acked-by: Dharmik Thakkar
ucket hash test
> hash: use partial-key hashing
>
> lib/librte_hash/rte_cuckoo_hash.c | 580 ++++--
> lib/librte_hash/rte_cuckoo_hash.h | 11 +-
> lib/librte_hash/rte_hash.h| 8 +-
> test/test/test_hash.c | 159 ++-
> test/test/test_hash_perf.c| 114 ++--
> 5 files changed, 677 insertions(+), 195 deletions(-)
>
> --
> 2.7.4
>
Acked-by: Dharmik Thakkar
> On Oct 26, 2018, at 3:24 PM, Thomas Monjalon wrote:
>
> +Cc Yipeng
>
> 18/09/2018 21:22, Dharmik Thakkar:
>> Enable print_key_info() function compilation always.
>
> Please see my first comment: you need to show the compilation error
> in this message. Otherwi
nings being treated as errors'
Fixes: af75078fece36 ("first public release")
Cc: sta...@dpdk.org
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
---
v3:
* Add compilation error message
---
v2:
* Fix checkpatc
> On Oct 26, 2018, at 4:05 PM, Wang, Yipeng1 wrote:
>
>> -Original Message-
>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
>> Sent: Friday, October 26, 2018 1:25 PM
>> To: Dharmik Thakkar
>> Cc: Richardson, Bruce ; De Lara Guarch, Pablo
>
Reset 'iter' and 'tbl_rw_test_param.found' on each iteration
to give correct result for lost and duplicated keys.
Fixes: 0eb3726ebcf14 ("test/hash: add test for read/write concurrency")
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
---
test/test/test_hash
Need to set hash log type to debug to print debug information, using
following eal parameter: --log-type=hash,8
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by: Phil Yang
---
test/test/test_hash.c | 3 +--
1
This patch enables compilation of print_key_info() always using
log-level based approach instead of a macro. Need to set efd log type
to debug to print debug information, using the following eal parameter:
--log-type=efd,8
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by
code always. Log levels can be
set using eal parameters.
Dharmik Thakkar (3):
test/hash: replace macro with log-level approach
test/efd: enable unit test compilation always
test/timer: enable unit test compilation always
test/test/test_efd.c| 24
test/test
This patch replaces macro with log-level based approach to print debug
information. Need to set timer log type to debug using the following
eal parameter: --log-level=timer,8
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Enable print_key_info() function compilation always.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Suggested-by: Honnappa Nagarahalli
---
test/test/test_hash.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git
Enable print_key_info() function compilation always.
Fixes: af75078fece36 ("first public release")
Cc: sta...@dpdk.org
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
---
v2:
* Fix checkpatch coding style i
Thank you Ferruh and Yipeng! I will make the recommended changes and update the
version.
> On Jan 12, 2019, at 12:07 AM, Wang, Yipeng1 wrote:
>
> Thanks for the bug fix! Nice catch!
>
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Friday, January 1
ad/write concurrency")
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ferruh Yigit
Reviewed-by: Yipeng Wang
--
v2:
* Update commit message
* Change 'found' array type to uint8_t
* Restore declaration of 'iter' to the start
---
test/test/test_has
code always. Log levels can be
set using eal parameters.
Dharmik Thakkar (3):
test/hash: replace macro with log-level approach
test/efd: enable unit test compilation always
test/timer: enable unit test compilation always
test/test/test_efd.c| 24
test/test
This patch replaces macro with log-level based approach to print debug
information. Need to set timer log type to debug using the following
eal parameter: --log-level=timer,8
Change-Id: I31e660e31b556ccade314a948226f0f076231a15
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Need to set hash log type to debug to print debug information, using
following eal parameter: --log-type=hash,8
Change-Id: I19c56d6e79c0b6d5c20284be3576a80e6bcca920
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by
Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by: Phil Yang
Reviewed-by: Ferruh Yigit
---
v2:
* Add Reviewed-by tag
---
test/test/test_efd.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git
code always. Log levels can be
set using eal parameters.
Dharmik Thakkar (3):
test/hash: replace macro with log-level approach
test/efd: enable unit test compilation always
test/timer: enable unit test compilation always
test/test/test_efd.c| 24
test/test
Need to set hash log type to debug to print debug information, using
following eal parameter: --log-type=hash,8
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by: Phil Yang
Reviewed-by: Ferruh Yigit
---
v3
This patch replaces macro with log-level based approach to print debug
information. Need to set timer log type to debug using the following
eal parameter: --log-level=timer,8
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
This patch enables compilation of print_key_info() always using
log-level based approach instead of a macro. Need to set efd log type
to debug to print debug information, using the following eal parameter:
--log-type=efd,8
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by
code always. Log levels can be
set using eal parameters.
Dharmik Thakkar (3):
test/hash: replace macro with log-level approach
test/efd: enable unit test compilation always
test/timer: enable unit test compilation always
test/test/test_efd.c| 24 +++-
test/test
This patch enables compilation of print_key_info() always using
log-level based approach instead of a macro. Need to set efd log type
to debug to print debug information, using the following eal parameter:
--log-level=test.efd:debug
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
This patch replaces macro with log-level based approach to print debug
information. Need to set timer log type to debug using the following
eal parameter: --log-level=test.timer:debug
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by
Need to set hash log type to debug to print debug information, using
following eal parameter: --log-level=test.hash:debug
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by: Phil Yang
Reviewed-by: Ferruh Yigit
> On Feb 20, 2019, at 5:08 PM, Stephen Hemminger
> wrote:
>
> On Wed, 20 Feb 2019 17:00:20 -0600
> Dharmik Thakkar wrote:
>
>> Currently, in test code, for printing extra information,
>> compilation time options are used. This approach does not compile the
>
This patch series:
- Enables lock-free read-write concurrency support for extendable
bucket feature.
- Adds lock-free read-write concurrency tests for ext bkt
Dharmik Thakkar (2):
hash: add lock free support for extendable bucket
test/hash: lock-free rw concurrency test ext bkt
app/test
This patch enables lock-free read-write concurrency support for
extendable bucket feature.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
---
doc/guides/prog_guide/hash_lib.rst | 3 +-
lib/librte_hash/rte_cuckoo_hash.c | 150 +++--
lib/librte_hash
Add unit test to check for hash lookup and bulk-lookup perf.
Test with lock-free enabled and with lock-free disabled.
Test include:
- hash lookup on keys in ext bkt,
hash delete causing key-shifts of keys from ext bkt to secondary bkt
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik
1 - 100 of 263 matches
Mail list logo
