Hi, I am seeing the following CI failures on this series: a) 1.3% nic_single_core_perf degradation with Mellanox ConnectX-4 Lx 40000 Mbps. b) dpdk_unit_test failure with RHEL 7 VM due to red_autotest failure.
These issues are not related to the patch series since the patches are only targeted towards examples dir. Another recently upstreamed patch series [1] also reported a similar CI failure. Thus, this looks like a common CI issue. [1] https://lab.dpdk.org/results/dashboard/patchsets/19456/ > On Oct 13, 2021, at 1:54 PM, Dharmik Thakkar <dharmik.thak...@arm.com> wrote: > > From: Joyce Kong <joyce.k...@arm.com> > > Remove the unnecessary header file rte_atomic.h > included in example module. > > Signed-off-by: Joyce Kong <joyce.k...@arm.com> > Signed-off-by: Dharmik Thakkar <dharmik.thak...@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > --- > examples/bond/main.c | 1 - > examples/ip_fragmentation/main.c | 1 - > examples/ip_reassembly/main.c | 1 - > examples/ipsec-secgw/ipsec-secgw.c | 1 - > examples/ipv4_multicast/main.c | 1 - > examples/l2fwd-crypto/main.c | 1 - > examples/l2fwd-event/l2fwd_common.h | 1 - > examples/l2fwd-event/l2fwd_event.c | 1 - > examples/l2fwd-keepalive/main.c | 1 - > examples/l2fwd/main.c | 1 - > examples/l3fwd-acl/main.c | 1 - > examples/l3fwd-power/main.c | 1 - > examples/l3fwd/main.c | 1 - > examples/link_status_interrupt/main.c | 1 - > examples/multi_process/client_server_mp/mp_client/client.c | 1 - > examples/multi_process/client_server_mp/mp_server/init.c | 1 - > examples/multi_process/simple_mp/main.c | 1 - > examples/multi_process/simple_mp/mp_commands.c | 1 - > examples/multi_process/symmetric_mp/main.c | 1 - > examples/server_node_efd/node/node.c | 1 - > examples/server_node_efd/server/init.c | 1 - > examples/vhost_blk/blk.c | 1 - > examples/vm_power_manager/channel_manager.c | 1 - > examples/vm_power_manager/channel_manager.h | 1 - > examples/vmdq/main.c | 1 - > examples/vmdq_dcb/main.c | 1 - > 26 files changed, 26 deletions(-) > > diff --git a/examples/bond/main.c b/examples/bond/main.c > index 7adaa93cad5c..ed39b7237fbb 100644 > --- a/examples/bond/main.c > +++ b/examples/bond/main.c > @@ -24,7 +24,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/ip_fragmentation/main.c > b/examples/ip_fragmentation/main.c > index a7f40970f27f..cc338f4269b0 100644 > --- a/examples/ip_fragmentation/main.c > +++ b/examples/ip_fragmentation/main.c > @@ -21,7 +21,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c > index d611c7d01609..f513e2f87937 100644 > --- a/examples/ip_reassembly/main.c > +++ b/examples/ip_reassembly/main.c > @@ -22,7 +22,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/ipsec-secgw/ipsec-secgw.c > b/examples/ipsec-secgw/ipsec-secgw.c > index 7b01872c6f9f..393e30d78063 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.c > +++ b/examples/ipsec-secgw/ipsec-secgw.c > @@ -24,7 +24,6 @@ > #include <rte_log.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c > index d10de30ddbae..818843c8b6c8 100644 > --- a/examples/ipv4_multicast/main.c > +++ b/examples/ipv4_multicast/main.c > @@ -20,7 +20,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c > index c2ffbdd50636..83bbea89c703 100644 > --- a/examples/l2fwd-crypto/main.c > +++ b/examples/l2fwd-crypto/main.c > @@ -20,7 +20,6 @@ > #include <unistd.h> > > #include <rte_string_fns.h> > -#include <rte_atomic.h> > #include <rte_branch_prediction.h> > #include <rte_common.h> > #include <rte_cryptodev.h> > diff --git a/examples/l2fwd-event/l2fwd_common.h > b/examples/l2fwd-event/l2fwd_common.h > index cecbd9b70e31..ad453b4dc983 100644 > --- a/examples/l2fwd-event/l2fwd_common.h > +++ b/examples/l2fwd-event/l2fwd_common.h > @@ -27,7 +27,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/l2fwd-event/l2fwd_event.c > b/examples/l2fwd-event/l2fwd_event.c > index 7ba5311d6688..acfacfa4fb34 100644 > --- a/examples/l2fwd-event/l2fwd_event.c > +++ b/examples/l2fwd-event/l2fwd_event.c > @@ -5,7 +5,6 @@ > #include <stdbool.h> > #include <getopt.h> > > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_ethdev.h> > #include <rte_eventdev.h> > diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c > index 07271affb4a9..af59d51b3ec4 100644 > --- a/examples/l2fwd-keepalive/main.c > +++ b/examples/l2fwd-keepalive/main.c > @@ -24,7 +24,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c > index f3deeba0a665..8feb50e0f542 100644 > --- a/examples/l2fwd/main.c > +++ b/examples/l2fwd/main.c > @@ -24,7 +24,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c > index 60545f305934..add5e3c7c459 100644 > --- a/examples/l3fwd-acl/main.c > +++ b/examples/l3fwd-acl/main.c > @@ -20,7 +20,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index 73a3ab5bc0eb..be0d4f161685 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -24,7 +24,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index 00ac267af1dd..518fefe90b90 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -24,7 +24,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/link_status_interrupt/main.c > b/examples/link_status_interrupt/main.c > index e4542df11f87..ce8ae059d789 100644 > --- a/examples/link_status_interrupt/main.c > +++ b/examples/link_status_interrupt/main.c > @@ -22,7 +22,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/multi_process/client_server_mp/mp_client/client.c > b/examples/multi_process/client_server_mp/mp_client/client.c > index 6d4c2468164f..087c38ef73c8 100644 > --- a/examples/multi_process/client_server_mp/mp_client/client.c > +++ b/examples/multi_process/client_server_mp/mp_client/client.c > @@ -17,7 +17,6 @@ > #include <rte_memory.h> > #include <rte_memzone.h> > #include <rte_eal.h> > -#include <rte_atomic.h> > #include <rte_branch_prediction.h> > #include <rte_log.h> > #include <rte_per_lcore.h> > diff --git a/examples/multi_process/client_server_mp/mp_server/init.c > b/examples/multi_process/client_server_mp/mp_server/init.c > index 1ad71ca7ec5f..be669c2bcc06 100644 > --- a/examples/multi_process/client_server_mp/mp_server/init.c > +++ b/examples/multi_process/client_server_mp/mp_server/init.c > @@ -15,7 +15,6 @@ > #include <rte_memzone.h> > #include <rte_eal.h> > #include <rte_byteorder.h> > -#include <rte_atomic.h> > #include <rte_launch.h> > #include <rte_per_lcore.h> > #include <rte_lcore.h> > diff --git a/examples/multi_process/simple_mp/main.c > b/examples/multi_process/simple_mp/main.c > index df996f0f84e1..5df2a3900012 100644 > --- a/examples/multi_process/simple_mp/main.c > +++ b/examples/multi_process/simple_mp/main.c > @@ -30,7 +30,6 @@ > #include <rte_per_lcore.h> > #include <rte_lcore.h> > #include <rte_debug.h> > -#include <rte_atomic.h> > #include <rte_branch_prediction.h> > #include <rte_ring.h> > #include <rte_log.h> > diff --git a/examples/multi_process/simple_mp/mp_commands.c > b/examples/multi_process/simple_mp/mp_commands.c > index 311d0fe77538..a5f91b00be36 100644 > --- a/examples/multi_process/simple_mp/mp_commands.c > +++ b/examples/multi_process/simple_mp/mp_commands.c > @@ -14,7 +14,6 @@ > #include <rte_common.h> > #include <rte_memory.h> > #include <rte_eal.h> > -#include <rte_atomic.h> > #include <rte_branch_prediction.h> > #include <rte_launch.h> > #include <rte_log.h> > diff --git a/examples/multi_process/symmetric_mp/main.c > b/examples/multi_process/symmetric_mp/main.c > index 01dc3acf34d5..a66328ba0caf 100644 > --- a/examples/multi_process/symmetric_mp/main.c > +++ b/examples/multi_process/symmetric_mp/main.c > @@ -31,7 +31,6 @@ > #include <rte_eal.h> > #include <rte_per_lcore.h> > #include <rte_lcore.h> > -#include <rte_atomic.h> > #include <rte_branch_prediction.h> > #include <rte_debug.h> > #include <rte_interrupts.h> > diff --git a/examples/server_node_efd/node/node.c > b/examples/server_node_efd/node/node.c > index 4580a44e3e5d..ba1c7e515326 100644 > --- a/examples/server_node_efd/node/node.c > +++ b/examples/server_node_efd/node/node.c > @@ -17,7 +17,6 @@ > #include <rte_memory.h> > #include <rte_memzone.h> > #include <rte_eal.h> > -#include <rte_atomic.h> > #include <rte_branch_prediction.h> > #include <rte_log.h> > #include <rte_per_lcore.h> > diff --git a/examples/server_node_efd/server/init.c > b/examples/server_node_efd/server/init.c > index 9ebd88bac20e..a19934dbe0c8 100644 > --- a/examples/server_node_efd/server/init.c > +++ b/examples/server_node_efd/server/init.c > @@ -15,7 +15,6 @@ > #include <rte_memzone.h> > #include <rte_eal.h> > #include <rte_byteorder.h> > -#include <rte_atomic.h> > #include <rte_launch.h> > #include <rte_per_lcore.h> > #include <rte_lcore.h> > diff --git a/examples/vhost_blk/blk.c b/examples/vhost_blk/blk.c > index f8c8549b3acc..d082ab3c94e5 100644 > --- a/examples/vhost_blk/blk.c > +++ b/examples/vhost_blk/blk.c > @@ -15,7 +15,6 @@ > #include <string.h> > #include <stddef.h> > > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_log.h> > #include <rte_malloc.h> > diff --git a/examples/vm_power_manager/channel_manager.c > b/examples/vm_power_manager/channel_manager.c > index fe915678541e..838465ab4b18 100644 > --- a/examples/vm_power_manager/channel_manager.c > +++ b/examples/vm_power_manager/channel_manager.c > @@ -21,7 +21,6 @@ > #include <rte_memory.h> > #include <rte_mempool.h> > #include <rte_log.h> > -#include <rte_atomic.h> > #include <rte_spinlock.h> > > #include <libvirt/libvirt.h> > diff --git a/examples/vm_power_manager/channel_manager.h > b/examples/vm_power_manager/channel_manager.h > index e55376fcdbb1..7038e9d83bb8 100644 > --- a/examples/vm_power_manager/channel_manager.h > +++ b/examples/vm_power_manager/channel_manager.h > @@ -11,7 +11,6 @@ extern "C" { > > #include <linux/limits.h> > #include <linux/un.h> > -#include <rte_atomic.h> > #include <stdbool.h> > > /* Maximum name length including '\0' terminator */ > diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c > index ee7f4324e141..85996bf864b7 100644 > --- a/examples/vmdq/main.c > +++ b/examples/vmdq/main.c > @@ -20,7 +20,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > diff --git a/examples/vmdq_dcb/main.c b/examples/vmdq_dcb/main.c > index 14c20e6a8b26..be0179fdeaf0 100644 > --- a/examples/vmdq_dcb/main.c > +++ b/examples/vmdq_dcb/main.c > @@ -20,7 +20,6 @@ > #include <rte_memcpy.h> > #include <rte_eal.h> > #include <rte_launch.h> > -#include <rte_atomic.h> > #include <rte_cycles.h> > #include <rte_prefetch.h> > #include <rte_lcore.h> > -- > 2.25.1 >
