Re: [dpdk-dev] [PATCH] net/mlx5/windows: fix link speed calculation

2021-04-06 Thread Tal Shnaiderman
> Subject: Re: [PATCH] net/mlx5/windows: fix link speed calculation > > External email: Use caution opening links or attachments > > > There is no previous commit with net/mlx5/windows as title prefix. > In general, there is "on Windows" at the end of the title. > This way we can have the same f

[dpdk-dev] [PATCH v2] net/mlx5: fix link speed calculation on Windows

2021-04-06 Thread Tal Shnaiderman
In Windows DevX returns the rate of the current link speed in bit/s, this rate was converted to Mibit/s instead of the Mbit/s rate expected by DPDK resulting in wrong link speed reporting. Fixes: 6fbd73709ee4be32 ("net/mlx5: support link update on Windows") Cc: sta...@dpdk.org Signed-off-by: Tal

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-06 Thread Jerin Jacob
On Mon, Apr 5, 2021 at 11:35 PM Ori Kam wrote: > > Currently, DPDK application can offload the checksum check, > and report it in the mbuf. > > However, as more and more applications are offloading some or all > logic and action to the HW, there is a need to check the packet > integrity so the rig

[dpdk-dev] [PATCH v1 1/1] test/power: fix several bugs in cpufreq autotest

2021-04-06 Thread Richael Zhuang
1. Sleep for 1s before checking the newly updated value from "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because for some systems it may not be effective immediately. 2. The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what we set. For example, we write "24

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link speed calculation on Windows

2021-04-06 Thread Matan Azrad
From: Tal Shnaiderman > In Windows DevX returns the rate of the current link speed in bit/s, this rate > was converted to Mibit/s instead of the Mbit/s rate expected by DPDK resulting > in wrong link speed reporting. > > Fixes: 6fbd73709ee4be32 ("net/mlx5: support link update on Windows") > Cc

Re: [dpdk-dev] [PATCH v2 0/3] fix miss input validation

2021-04-06 Thread Ferruh Yigit
On 4/2/2021 3:58 AM, Min Hu (Connor) wrote: The validity verification of input parameters should be performed at API layer, not in the PMD. This set of patches fix miss input validation. --- v2: * Fixed mixes in ethdev header file and ethdev .c file. Chengchang Tang (3): ethdev: fix miss inp

Re: [dpdk-dev] [PATCH] cryptodev: formalize key wrap method in API

2021-04-06 Thread Akhil Goyal
> Hi Akhil > > From: Akhil Goyal > > Hi Matan, > > > > > The Key Wrap approach is used by applications in order to protect keys > > > located in untrusted storage or transmitted over untrusted > > > communications networks. The constructions are typically built from > > > standard primitives such

[dpdk-dev] [PATCH v1 1/1] test/power: fix several bugs in cpufreq autotest

2021-04-06 Thread Richael Zhuang
1. Sleep for 1s before checking the newly updated value from "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because for some systems it may not be effective immediately. 2. The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what we set. For example, we write "24

Re: [dpdk-dev] [PATCH v4 2/2] power: do not skip saving original pstate governor

2021-04-06 Thread Thomas Monjalon
02/04/2021 13:12, Pattan, Reshma: > > From: dev On Behalf Of Burakov, Anatoly > > On 02-Apr-21 10:26 AM, Anatoly Burakov wrote: > > > Currently, when we set the pstate governor to "performance", we check > > > if it is already set to this value, and if it is, we skip setting it. > > > > > > Howeve

Re: [dpdk-dev] [PATCH v2 0/2] pci: add rte prefix

2021-04-06 Thread David Marchand
On Mon, Apr 5, 2021 at 11:15 AM Thomas Monjalon wrote: > > Small namespace cleanups in PCI lib and bus driver. > > v2: >- mark old macro with RTE_DEPRECATED >- fix common/mlx5 > > Thomas Monjalon (2): > pci: rename catch-all ID > bus/pci: rename probe/remove operation types The first

Re: [dpdk-dev] [PATCH v1 1/1] test/power: fix several bugs in cpufreq autotest

2021-04-06 Thread Thomas Monjalon
Hi, When sending a new version, please upgrade the version number. Would be good to cleanup patchwork as well, by setting old versions as superseded. 06/04/2021 10:30, Richael Zhuang: > 1. Sleep for 1s before checking the newly updated value from > "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_c

Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs

2021-04-06 Thread Bing Zhao
Hi Andrew, Thanks for your comments. > -Original Message- > From: Andrew Rybchenko > Sent: Monday, March 22, 2021 11:00 PM > To: Bing Zhao ; NBU-Contact-Thomas Monjalon > > Cc: Ori Kam ; ferruh.yi...@intel.com; dev@dpdk.org > Subject: Re: [RFC] ethdev: introduce action context APIs > >

Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs

2021-04-06 Thread Bing Zhao
Hi Thomas and Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, March 22, 2021 10:55 PM > To: NBU-Contact-Thomas Monjalon ; Bing Zhao > > Cc: Ori Kam ; ferruh.yi...@intel.com; dev@dpdk.org > Subject: Re: [RFC] ethdev: introduce action context APIs > > External email:

Re: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests

2021-04-06 Thread Dybkowski, AdamX
The pmd is initialized in the setup function. This patch adds one extra step inside the teardown function: the call to the rte_cryptodev_close apart of the call to rte_cryptodev_stop function that existed before. I don't see any sense of calling the stop function inside the setup, in my opinion

Re: [dpdk-dev] [PATCH v2 1/3] log: choose EAL log type on registration failure

2021-04-06 Thread David Marchand
On Mon, Apr 5, 2021 at 12:03 PM Thomas Monjalon wrote: > > In the unlikely case where something goes wrong > while registering a log type, > the fallback is to use the log type 0, assigned to EAL. How about simply: the fallback is to use the EAL log type. > > Signed-off-by: Thomas Monjalon Revi

[dpdk-dev] [PATCH] eal: fix telemetry logtype registration

2021-04-06 Thread David Marchand
rte_log_register_type_and_pick_level() returns an int. Casting to a uin32_t will make us miss the -1 passed in case of failure. Fixes: 37b881a96194 ("telemetry: use log function from pointer") Signed-off-by: David Marchand --- lib/librte_eal/freebsd/eal.c | 4 +++- lib/librte_eal/linux/eal.c

Re: [dpdk-dev] [PATCH 1/6] net/mlx5: separate Rx function declarations to another file

2021-04-06 Thread Slava Ovsiienko
> -Original Message- > From: Michael Baum > Sent: Monday, April 5, 2021 17:01 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 1/6] net/mlx5: separate Rx function declarations to another > file > > The mlx5_rxtx.c file contains a lot of Tx bur

Re: [dpdk-dev] [PATCH 2/6] net/mlx5: separate Rx function implementations to new file

2021-04-06 Thread Slava Ovsiienko
> -Original Message- > From: Michael Baum > Sent: Monday, April 5, 2021 17:01 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 2/6] net/mlx5: separate Rx function implementations to > new file > > This patch separates Rx function implementatio

Re: [dpdk-dev] [PATCH 3/6] net/mlx5: separate Tx function declarations to another file

2021-04-06 Thread Slava Ovsiienko
> -Original Message- > From: Michael Baum > Sent: Monday, April 5, 2021 17:01 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 3/6] net/mlx5: separate Tx function declarations to another > file > > This patch separates Tx function declarations

Re: [dpdk-dev] [PATCH 5/6] net/mlx5: separate Tx function implementations to new file

2021-04-06 Thread Slava Ovsiienko
> -Original Message- > From: Michael Baum > Sent: Monday, April 5, 2021 17:01 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 5/6] net/mlx5: separate Tx function implementations to > new file > > This patch separates Tx function implementatio

Re: [dpdk-dev] [PATCH 6/6] net/mlx5: separate Tx burst functions to different files

2021-04-06 Thread Slava Ovsiienko
> -Original Message- > From: Michael Baum > Sent: Monday, April 5, 2021 17:01 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 6/6] net/mlx5: separate Tx burst functions to different files > > This patch separates Tx burst function implementat

[dpdk-dev] [PATCH v4 2/6] net/ngbe: add device IDs

2021-04-06 Thread Jiawen Wu
Add device IDs for Wangxun 1Gb NICs, and register rte_ngbe_pmd. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 18 +++ drivers/net/ngbe/base/ngbe_devids.h | 83 + drivers/net/ngbe/meson.build| 6 +++ drivers/net/ngbe/ngbe_ethdev.c

[dpdk-dev] [PATCH v4 1/6] net/ngbe: add build and doc infrastructure

2021-04-06 Thread Jiawen Wu
Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for ngbe PMD. Signed-off-by: Jiawen Wu --- MAINTAINERS| 6 ++ doc/guides/nics/features/ngbe.ini | 10 + doc/guides/nics/index.rst | 1 + doc/guide

[dpdk-dev] [PATCH v4 3/6] net/ngbe: support probe and remove

2021-04-06 Thread Jiawen Wu
Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/ngbe_ethdev.c| 77 +-- drivers/net/ngbe/ngbe_ethdev.h| 10 3 files changed, 85 insertions(+), 3 deletions(-) diff --git a/doc/

[dpdk-dev] [PATCH v4 0/6] net: ngbe PMD

2021-04-06 Thread Jiawen Wu
This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. v4: - Fix compile error. v3: - Use rte_ether functions to define marcos. v2: - Correct some clerical errors. - Use ethdev debug flags instead of driver own. Jiawen Wu (6): net/ngbe: add build and doc

[dpdk-dev] [PATCH v4 4/6] net/ngbe: add device init and uninit

2021-04-06 Thread Jiawen Wu
Add basic init and uninit function. Map device IDs and subsystem IDs to single ID for easy operation. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 4 +- drivers/net/ngbe/base/ngbe.h | 11 ++ drivers/net/ngbe/base/ngbe_hw.c| 59 ++ drivers/net/ngbe/base/

[dpdk-dev] [PATCH v4 5/6] net/ngbe: add log type and error type

2021-04-06 Thread Jiawen Wu
Add log type and error type to trace functions. Signed-off-by: Jiawen Wu --- doc/guides/nics/ngbe.rst| 20 + drivers/net/ngbe/base/ngbe_status.h | 124 drivers/net/ngbe/base/ngbe_type.h | 1 + drivers/net/ngbe/ngbe_ethdev.c | 16 drive

[dpdk-dev] [PATCH v4 6/6] net/ngbe: define registers

2021-04-06 Thread Jiawen Wu
Define all registers that will be used. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 1489 + drivers/net/ngbe/base/ngbe_type.h |2 + 2 files changed, 1491 insertions(+) create mode 100644 drivers/net/ngbe/base/ngbe_regs.h diff --git a/drivers

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-06 Thread Thomas Monjalon
Hi Rosen, You already gave your ack in previous version, no need to re-ack. Instead, please give your opinion and explanation as requested below. We want to replace pmd.afu.ipn3ke with pmd.net.ipn3ke. The use of AFU in the driver is not clear. Xiao, we need your opinion as well about ifcvf vs ifc

[dpdk-dev] How about public rte flow lock API

2021-04-06 Thread fengchengwen
Hi, Ori and Ferruh Currently, the rte flow API has the lock of flow_ops_mutx default which used when driver hasn't provided mutex protection, it's inner API which was not public, but in hns3 driver there maybe concurrent access driver's rte flow data when doing reset recovery (which occur in i

Re: [dpdk-dev] [PATCH v2 1/2] pci: rename catch-all ID

2021-04-06 Thread Thomas Monjalon
06/04/2021 08:23, Xueming(Steven) Li: > From: Thomas Monjalon > > struct rte_pci_id { > > uint32_t class_id;/**< Class ID or RTE_CLASS_ANY_ID. */ > >-uint16_t vendor_id; /**< Vendor ID or PCI_ANY_ID. */ > >-uint16_t device_id; /**< Device ID or PCI_ANY_ID

Re: [dpdk-dev] [PATCH 0/6] net/mlx5: reduce Tx datapath compile time

2021-04-06 Thread David Marchand
On Mon, Apr 5, 2021 at 4:01 PM Michael Baum wrote: > > The mlx5_rxtx.c file contains a lot of Tx burst functions, each of those is > performance-optimized for the specific set of requested offloads. > These ones are generated on the basis of the template function and it takes > significant time

Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types

2021-04-06 Thread Thomas Monjalon
06/04/2021 08:32, Xueming(Steven) Li: > From: Thomas Monjalon > > > >The names of the prototypes pci_probe_t and pci_remove_t are missing a > >prefix rte_. > >These function types are simply renamed. > > > >No compatibility break is expected for the applications because it is > >considered as an

Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs

2021-04-06 Thread Thomas Monjalon
06/04/2021 11:07, Bing Zhao: > Hi Thomas and Andrew, > > From: Andrew Rybchenko > > On 3/17/21 11:28 AM, Thomas Monjalon wrote: > > > 17/03/2021 08:59, Bing Zhao: > > >> The new functions rte_flow_action_ctx* that were added will > > replace > > >> the curret shared functions rte_flow_shared_acti

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-06 Thread Xu, Rosen
HI Thomas, I'm ok, if you replace pmd.afu.ipn3ke with pmd.net.ipn3ke. Thanks your reminder. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 06, 2021 17:31 > To: Xu, Rosen ; Wang, Xiao W > > Cc: dev@dpdk.org; Richardson, Bruce ; > Hemant Agrawal ; Ajit Khaparde > ; Gr

Re: [dpdk-dev] [PATCH v2 1/3] log: choose EAL log type on registration failure

2021-04-06 Thread Thomas Monjalon
06/04/2021 11:17, David Marchand: > On Mon, Apr 5, 2021 at 12:03 PM Thomas Monjalon wrote: > > > > In the unlikely case where something goes wrong > > while registering a log type, > > the fallback is to use the log type 0, assigned to EAL. > > How about simply: > the fallback is to use the EAL l

Re: [dpdk-dev] [PATCH 0/6] net/mlx5: reduce Tx datapath compile time

2021-04-06 Thread Slava Ovsiienko
> -Original Message- > From: David Marchand > Sent: Tuesday, April 6, 2021 12:34 > To: Michael Baum > Cc: dev ; Matan Azrad ; Raslan > Darawsheh ; Slava Ovsiienko > > Subject: Re: [dpdk-dev] [PATCH 0/6] net/mlx5: reduce Tx datapath compile > time > > On Mon, Apr 5, 2021 at 4:01 PM Micha

Re: [dpdk-dev] [PATCH 21.08] power: refactor pstate sysfs handling

2021-04-06 Thread Burakov, Anatoly
On 02-Apr-21 6:46 PM, Stephen Hemminger wrote: On Thu, 1 Apr 2021 15:05:17 + Anatoly Burakov wrote: + /* fgets puts null terminator in, but do this just in case */ + buf[BUFSIZ - 1] = '\0'; + + /* strip off any terminating newlines */ + if (strlen(buf)) +

Re: [dpdk-dev] [PATCH 21.08] power: refactor pstate sysfs handling

2021-04-06 Thread Burakov, Anatoly
On 02-Apr-21 6:45 PM, Stephen Hemminger wrote: On Thu, 1 Apr 2021 15:05:17 + Anatoly Burakov wrote: +#define FOPEN_OR_ERR_GOTO(f, label) do { \ + if ((f) == NULL) { \ + RTE_LOG(ERR, POWER, "File not opened\n"); \ + goto label; \

Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration

2021-04-06 Thread Bruce Richardson
On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > rte_log_register_type_and_pick_level() returns an int. > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > Fixes: 37b881a96194 ("telemetry: use log function from pointer") > > Signed-off-by: David Marchan

Re: [dpdk-dev] [PATCH] build: fix symlink of drivers for Windows

2021-04-06 Thread Nick Connolly
PDB (debuginfo) files can be quite large, do we want to install them? The script copies will only copy the .pdb files if they have already been installed into lib/dpdk/pmds-*/. If they haven't, we'll just skip the step. Whether they should be installed is a different question :-) Installing

[dpdk-dev] [PATCH v3 1/2] pci: rename catch-all ID

2021-04-06 Thread Thomas Monjalon
The name of the constant PCI_ANY_ID was missing RTE_ prefix. It is renamed, and the old name becomes a deprecated alias. While renaming, the duplicate definitions in rte_bus_pci.h are removed to keep only those in rte_pci.h. Note: rte_pci.h is included in rte_bus_pci.h Signed-off-by: Thomas Monja

[dpdk-dev] [PATCH v3 0/2] pci: add rte prefix

2021-04-06 Thread Thomas Monjalon
Small namespace cleanups in PCI lib and bus driver. v3: - add API change to release notes v2: - mark old macro with RTE_DEPRECATED - fix common/mlx5 Thomas Monjalon (2): pci: rename catch-all ID bus/pci: rename probe/remove operation types doc/guides/rel_notes/release_21_05.rst |

[dpdk-dev] [PATCH v3 2/2] bus/pci: rename probe/remove operation types

2021-04-06 Thread Thomas Monjalon
The names of the prototypes pci_probe_t and pci_remove_t are missing a prefix rte_. These function types are simply renamed. No compatibility break is expected for the applications because it is considered as an internal name in the driver interface. Signed-off-by: Thomas Monjalon Reviewed-by: X

Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration

2021-04-06 Thread Thomas Monjalon
06/04/2021 12:18, Bruce Richardson: > On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > > rte_log_register_type_and_pick_level() returns an int. > > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > > > Fixes: 37b881a96194 ("telemetry: use log function fr

Re: [dpdk-dev] [PATCH] cryptodev: formalize key wrap method in API

2021-04-06 Thread Matan Azrad
From: Akhil Goyal > > Hi Akhil > > > > From: Akhil Goyal > > > Hi Matan, > > > > > > > The Key Wrap approach is used by applications in order to protect > > > > keys located in untrusted storage or transmitted over untrusted > > > > communications networks. The constructions are typically built

Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types

2021-04-06 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 6, 2021 5:39 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation > types > > 06/04/2021 08:32, Xueming(Steven) Li: > > From: Thomas Monjalon

Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs

2021-04-06 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 6, 2021 5:48 PM > To: Bing Zhao > Cc: Andrew Rybchenko ; Ori Kam > ; ferruh.yi...@intel.com; dev@dpdk.org > Subject: Re: [RFC] ethdev: introduce action context APIs > > External email: Use caution opening lin

Re: [dpdk-dev] [PATCH v6 3/5] examples/l3fwd: add FIB infrastructure

2021-04-06 Thread Walsh, Conor
> > Acked-by: Anatoly Burako > > --- > > Burakov* Sorry about that! > > > break; > > > > case 'L': > > - l3fwd_lpm_on = 1; > > + if (lookup_mode != L3FWD_LOOKUP_DEFAULT) { > > + fprintf(stderr, "Onl

[dpdk-dev] [PATCH v7 0/5] examples/l3fwd: add FIB lookup method to l3fwd

2021-04-06 Thread Conor Walsh
Currently the l3fwd sample app supports LPM and EM lookup methods this patchset implements the FIB library as another lookup method for l3fwd. Instead of adding an individual flag for FIB, a new flag '--lookup' has been added that allows the user to select their desired lookup method. The flags '-E

[dpdk-dev] [PATCH v7 1/5] examples/l3fwd: fix LPM IPv6 subnets

2021-04-06 Thread Conor Walsh
The IPv6 subnets used were not within the 2001:200::/48 subnet Changed to 2001:200:0:{0-7}::/64 where 0-7 is the port ID Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses") Signed-off-by: Conor Walsh Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_lpm.c | 26 +++

[dpdk-dev] [PATCH v7 2/5] examples/l3fwd: move l3fwd routes to common header

2021-04-06 Thread Conor Walsh
To prevent code duplication from the addition of lookup methods the routes specified in lpm should be moved to a common header. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_common_route.h | 48 +++ examples/l3fwd/

[dpdk-dev] [PATCH v7 3/5] examples/l3fwd: add FIB infrastructure

2021-04-06 Thread Conor Walsh
The purpose of this commit is to add the necessary function calls and supporting infrastructure to allow the Forwarding Information Base (FIB) library to be integrated into the l3fwd sample app. Instead of adding an individual flag for FIB, a new flag '--lookup' has been added that allows the user

[dpdk-dev] [PATCH v7 4/5] examples/l3fwd: implement FIB lookup method

2021-04-06 Thread Conor Walsh
This patch implements the Forwarding Information Base (FIB) library in l3fwd using the function calls and infrastructure introduced in the previous patch. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_fib.c | 480 +

[dpdk-dev] [PATCH v7 5/5] doc/guides/l3_forward: update documentation for FIB

2021-04-06 Thread Conor Walsh
The purpose of this patch is to update the l3fwd user guide to include the changes proposed in this patchset. Signed-off-by: Conor Walsh Acked-by: John McNamara --- doc/guides/sample_app_ug/l3_forward.rst | 113 +--- 1 file changed, 100 insertions(+), 13 deletions(-) diff -

Re: [dpdk-dev] [PATCH] librte_eal: add APIs to speedup virt2iova/phys

2021-04-06 Thread David Marchand
On Tue, Apr 6, 2021 at 12:40 PM Feng Li wrote: > > On Thu, Apr 1, 2021 at 6:39 PM Burakov, Anatoly > wrote: > > > > On 25-Mar-21 1:32 PM, David Marchand wrote: > > > Hello, > > > > > > On Mon, Apr 20, 2020 at 4:13 PM Li Feng wrote: > > >> > > >> Cool, thank you, Anatoly and Kozlyuk. > > >> > > >

Re: [dpdk-dev] [PATCH v5 1/4] log: move private functions

2021-04-06 Thread David Marchand
On Mon, Apr 5, 2021 at 9:30 PM Thomas Monjalon wrote: > > Some private log functions had a wrong "rte_" prefix. > > All private log functions are moved from eal_private.h > to the new file eal_log.h: > rte_eal_log_init -> eal_log_init > rte_log_save_regexp -> eal_log_save_regexp >

[dpdk-dev] [PATCH v4 00/52] Add Marvell CNXK common driver

2021-04-06 Thread Nithin Dabilpuram
This patchset adds initial support for common code for Marvell CN10K SoC. Based on this common 'cnxk' driver, new PMD's such as 'net/cnxk', 'mempool/cnxk', 'event/cnxk' etc, will be added later on. Initially 'cnxk' drivers will only support Marvell CN106XX SoC. In future, when code is ready, CN9

[dpdk-dev] [PATCH v4 03/52] common/cnxk: add model init and IO handling API

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add routines for SoC model identification and HW IO handling routines specific to CN9K and CN10K Marvell SoC's. These are based on arm64 ISA and behaviour specific to Marvell SoC's. Signed-off-by: Jerin Jacob Signed-off-by: Srikanth Yalavarthi --- drivers/common/cnxk/meson.b

[dpdk-dev] [PATCH v4 04/52] common/cnxk: add roc plt init callback support

2021-04-06 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add support for registering callbacks for roc plt init. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_platform.c | 19 +++ drivers/common/cnxk/roc_platform.h | 4 drivers/common/cnxk/version.map| 1 + 3 files changed, 24 inserti

[dpdk-dev] [PATCH v4 05/52] common/cnxk: add interrupt helper API

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add interrupt helper API's in common code to register and unregister for specific interrupt vectors. These API's will be used by all cnxk drivers. Signed-off-by: Jerin Jacob --- drivers/common/cnxk/meson.build| 3 +- drivers/common/cnxk/roc_dev_priv.h | 14 +++ drivers

[dpdk-dev] [PATCH v4 06/52] common/cnxk: add mbox request and response definitions

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob The admin function driver sits in Linux kernel as mailbox server. The DPDK AF mailbox client, send the message to mailbox server to complete the administrative task such as get mac address. This patch adds mailbox request and response definition of existing mailbox defined betw

[dpdk-dev] [PATCH v4 07/52] common/cnxk: add mailbox base infra

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob This patch adds mailbox infra API's to communicate with Kernel AF driver. These API's will be used by all the other cnxk drivers for mbox init/fini, send/recv functionality. Signed-off-by: Jerin Jacob --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_de

[dpdk-dev] [PATCH v4 08/52] common/cnxk: add base device class

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Introduce 'dev' class to hold cnxk PCIe device specific information and operations. All PCIe drivers(ethdev, mempool, cryptodev and eventdev) of cnxk inherits this base object to avail the common functionalities such as mailbox creation, interrupt registration, LMT setup, VF me

[dpdk-dev] [PATCH v4 09/52] common/cnxk: add VF support to base device class

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add VF specific handling such as BAR4 setup, forwarding VF mbox messages to AF and vice-versa, VF FLR handling etc. Signed-off-by: Jerin Jacob --- drivers/common/cnxk/roc_dev.c | 857 - drivers/common/cnxk/roc_dev_priv.h | 42 ++ 2 fi

[dpdk-dev] [PATCH v4 10/52] common/cnxk: add base npa device support

2021-04-06 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add base NPA device support. NPA i.e Network Pool Allocator is HW block that provides HW mempool functionality on Marvell CN9K and CN10K SoC's. NPA by providing HW mempool support, also facilitates Rx and Tx packet alloc and packet free by HW without SW intervention. Sign

[dpdk-dev] [PATCH v4 11/52] common/cnxk: add npa irq support

2021-04-06 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add support for NPA IRQs. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_npa.c | 7 + drivers/common/cnxk/roc_npa_irq.c | 297 + drivers/common/cnxk/roc_npa_priv.h |

[dpdk-dev] [PATCH v4 12/52] common/cnxk: add npa debug support

2021-04-06 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add NPA debug APIs. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_npa.h | 4 + drivers/common/cnxk/roc_npa_debug.c | 184 drivers/common/cnxk/roc_npa_irq.c | 1 +

[dpdk-dev] [PATCH v4 13/52] common/cnxk: add npa pool HW ops

2021-04-06 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add APIs for creating, destroying, modifying NPA pools. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_npa.c | 421 drivers/common/cnxk/roc_npa.h | 146 ++ drivers/common/cnxk/version.map | 5 + 3

[dpdk-dev] [PATCH v4 14/52] common/cnxk: add npa bulk alloc/free support

2021-04-06 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add APIs to alloc/free in bulk from NPA pool. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_npa.h | 229 ++ 1 file changed, 229 insertions(+) diff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/cnxk/roc_npa

[dpdk-dev] [PATCH v4 15/52] common/cnxk: add npa performance counter support

2021-04-06 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add APIs to read NPA performance counters. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_npa.c | 50 + drivers/common/cnxk/roc_npa.h | 37 ++ drivers/common/cnxk/version.map | 1 + 3

[dpdk-dev] [PATCH v4 16/52] common/cnxk: add npa batch alloc/free support

2021-04-06 Thread Nithin Dabilpuram
From: Ashwin Sekhar T K Add APIs to do allocations/frees in batch from NPA pool. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_npa.h | 217 ++ 1 file changed, 217 insertions(+) diff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/c

[dpdk-dev] [PATCH v4 17/52] common/cnxk: add base nix support

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add base nix support as ROC(Rest of Chip) API which will be used by generic ETHDEV PMD(net/cnxk). This patch adds support to device init, fini, resource alloc and free API which sets up a ETHDEV PCI device of either CN9K or CN10K Marvell SoC. Signed-off-by: Jerin Jacob Signed

[dpdk-dev] [PATCH v4 18/52] common/cnxk: add nix irq support

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add support to register NIX error and completion queue IRQ's using base device class IRQ helper API's. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori Signed-off-by: Harman Kalra --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_nix.c |

[dpdk-dev] [PATCH v4 19/52] common/cnxk: add nix Rx queue management API

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add nix Rx queue management API to init/modify/fini RQ context and also setup CQ(completion queue) context. Current support is both for CN9K and CN10K devices. Signed-off-by: Jerin Jacob --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h | 5

[dpdk-dev] [PATCH v4 20/52] common/cnxk: add nix Tx queue management API

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob This patch adds support to init/modify/fini NIX SQ(send queue) for both CN9K and CN10K platforms. Signed-off-by: Jerin Jacob --- drivers/common/cnxk/roc_nix.h | 19 ++ drivers/common/cnxk/roc_nix_queue.c | 358 drivers/common/cnxk/v

[dpdk-dev] [PATCH v4 21/52] common/cnxk: add nix MAC operations support

2021-04-06 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add support to different MAC related operations such as MAC address set/get, link set/get, link status callback, etc. Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h | 41 ++ drivers/common/cnxk/roc_ni

[dpdk-dev] [PATCH v4 22/52] common/cnxk: add nix specific npc operations

2021-04-06 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add NIX specific NPC operations such as NPC mac address get/set, mcast entry add/delete, promiscuous mode enable/disable etc. Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build | 2 + drivers/common/cnxk/roc_nix.h | 25 + drivers/com

[dpdk-dev] [PATCH v4 23/52] common/cnxk: add nix inline IPsec config API

2021-04-06 Thread Nithin Dabilpuram
From: Vidya Sagar Velumuri Add API to configure NIX block for inline IPSec. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_nix.c | 28 drivers/common/cnxk/roc_nix.h | 10 ++ drivers/common/cnxk/version.map | 1 + 3 files changed, 39 in

[dpdk-dev] [PATCH v4 24/52] common/cnxk: add nix RSS support

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add API's for default/non-default reta table setup, key set/get, and flow algo setup for CN9K and CN10K. Signed-off-by: Jerin Jacob --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h | 17 +++ drivers/common/cnxk/roc_nix_rss.c | 220

[dpdk-dev] [PATCH v4 25/52] common/cnxk: add nix ptp support

2021-04-06 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add support to enable/disable Rx and Tx PTP timestamping support. Also provide API's to register ptp info callbacks to get config change update from Kernel. Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h |

[dpdk-dev] [PATCH v4 26/52] common/cnxk: add nix stats support

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add API to provide Rx and Tx stats for a given NIX. Signed-off-by: Jerin Jacob --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h | 53 drivers/common/cnxk/roc_nix_stats.c | 239 drivers/common/c

[dpdk-dev] [PATCH v4 27/52] common/cnxk: add support for nix extended stats

2021-04-06 Thread Nithin Dabilpuram
From: Satha Rao Add support for retrieving NIX extended stats that are per NIX LF and per LMAC. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix.h| 18 drivers/common/cnxk/roc_nix_stats.c | 172 + drivers/common/cnxk/roc_nix_xstats.h | 204 +++

[dpdk-dev] [PATCH v4 28/52] common/cnxk: add nix debug dump support

2021-04-06 Thread Nithin Dabilpuram
From: Jerin Jacob Add support to dump NIX RQ, SQ and CQ contexts apart from NIX LF registers. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h | 10 + drivers/common/cnxk/roc_nix_debug.c | 805

[dpdk-dev] [PATCH v4 29/52] common/cnxk: add VLAN filter support

2021-04-06 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add helper API to support VLAN filtering and stripping on Rx and VLAN insertion on Tx. Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_nix.h | 45 drivers/common/cnxk/roc_nix_vlan.c | 205

[dpdk-dev] [PATCH v4 30/52] common/cnxk: add nix flow control support

2021-04-06 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add support to enable/disable Rx/Tx flow control and pause frame configuration on NIX. Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_nix.h| 34 ++ drivers/common/cnxk/roc_nix_fc.c | 251

[dpdk-dev] [PATCH v4 31/52] common/cnxk: add nix LSO support and misc utils

2021-04-06 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Add support to create LSO formats for TCP segmentation offload for IPv4/IPv6, tunnel and non-tunnel protocols. Tunnel protocol support is for GRE and UDP based tunnel protocols. This patch also adds other helper API to retrieve eeprom info and configure Rx for different sw

[dpdk-dev] [PATCH v4 32/52] common/cnxk: add nix traffic management base support

2021-04-06 Thread Nithin Dabilpuram
Add nix traffic management base support to init/fini node, shaper profile and topology, setup SQ for a given user hierarchy or default internal hierarchy. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/meson.build| 3 + drivers/common/cnxk/roc_nix.c | 7 + drivers/

[dpdk-dev] [PATCH v4 33/52] common/cnxk: add nix tm support to add/delete node

2021-04-06 Thread Nithin Dabilpuram
Add support to add/delete nodes in a hierarchy. This patch also adds misc utils to get node name, walk through nodes etc. Signed-off-by: Nithin Dabilpuram Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix.h | 42 +++ drivers/common/cnxk/roc_nix_priv.h | 14 +++ drivers

[dpdk-dev] [PATCH v4 34/52] common/cnxk: add nix tm shaper profile add support

2021-04-06 Thread Nithin Dabilpuram
From: Satha Rao Add support to add/delete/update shaper profile for a given NIX. Also add support to walk through existing shaper profiles. Signed-off-by: Nithin Dabilpuram Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix.h | 25 + drivers/common/cnxk/roc_nix_priv.h

[dpdk-dev] [PATCH v4 35/52] common/cnxk: add nix tm helper to alloc and free resource

2021-04-06 Thread Nithin Dabilpuram
Add TM helper API to estimate, alloc, assign, and free resources for a NIX LF / ethdev. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h | 1 + drivers/common/cnxk/roc_nix_priv.h | 16 ++ drivers/common/cnxk/roc_nix_tm.c | 461 +

[dpdk-dev] [PATCH v4 36/52] common/cnxk: add nix tm hierarchy enable/disable

2021-04-06 Thread Nithin Dabilpuram
Add support to enable or disable hierarchy along with allocating node HW resources such as shapers and schedulers and configuring them to match the user created or default hierarchy. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h | 8 + drivers/common/cnxk/roc_nix_

[dpdk-dev] [PATCH v4 37/52] common/cnxk: add nix tm support for internal hierarchy

2021-04-06 Thread Nithin Dabilpuram
Add support to create internal TM default hierarchy and ratelimit hierarchy and API to ratelimit SQ to a given rate. This will be used by cnxk ethdev driver's tx queue ratelimit op. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h| 7 ++ drivers/common/cnxk/roc_nix_pr

[dpdk-dev] [PATCH v4 38/52] common/cnxk: add nix tm dynamic update support

2021-04-06 Thread Nithin Dabilpuram
Add support for dynamic node update of shaper profile, RR quantum and also support to suspend or resume an active TM node. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h| 10 ++ drivers/common/cnxk/roc_nix_tm_ops.c | 220 +++ drivers/c

[dpdk-dev] [PATCH v4 39/52] common/cnxk: add nix tm debug support and misc utils

2021-04-06 Thread Nithin Dabilpuram
Add support to dump TM HW registers and hierarchy on error. This patch also adds support for misc utils such as API to query TM HW resource availability, resource pre-allocation and static priority support on root node. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h

[dpdk-dev] [PATCH v4 40/52] common/cnxk: add npc support

2021-04-06 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding initial support for programming NPC. NPC is Network Parser and CAM unit that provides Rx and Tx packet parsing and packet manipulation functionality on Marvell CN9K and CN10K SoC's. It is mapped to RTE Flow in DPDK. Signed-off-by: Kiran Kumar K --- drivers/common/cnx

[dpdk-dev] [PATCH v4 41/52] common/cnxk: add npc helper API

2021-04-06 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding NPC helper APIs to manage MCAM like pre allocating the mcam, configuring the rules, shifting mcam rules and preparing the data for mcam based on KEX. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_npc_priv.h |

[dpdk-dev] [PATCH v4 42/52] common/cnxk: add mcam utility API

2021-04-06 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding mcam utility functions like reading KEX and reserving and writing mcam rules. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_npc_mcam.c | 708 + drivers/common/cnxk/roc_npc_priv

[dpdk-dev] [PATCH v4 43/52] common/cnxk: add npc parsing API

2021-04-06 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding npc parsing API support to parse different patterns and actions. Based on the pattern and actions ltype values will be chosen and mcam data will be configured at perticular offsets. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/meson.build | 1 + drivers

[dpdk-dev] [PATCH v4 44/52] common/cnxk: add npc init and fini support

2021-04-06 Thread Nithin Dabilpuram
From: Kiran Kumar K Adding support initialize and fini the npc. Further, adding APIs to create and destroy the npc rules. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_npc.c | 713 drivers/common/cnx

  1   2   3   >