PDB (debuginfo) files can be quite large, do we want to install them?
The script copies will only copy the .pdb files if they have already been installed into
lib/dpdk/pmds-*/. If they haven't, we'll just skip the step.

Whether they should be installed is a different question :-) Installing them seems to be a deliberate choice by meson (https://github.com/mesonbuild/meson/issues/1442).
In my opinion, it's probably best to have them there.

I looked at options apart from copying (including hard links) but in the end decided to keep it as simple as possible so it will 'just work' for cross builds from Linux, WSL-1,
WSL-2, Msys, Cygnus etc.

+meson.add_install_script(py3, '../buildtools/symlink-drivers-solibs.py',
+       get_option('libdir'), pmd_subdir_opt, get_option('bindir'))
# set the machine type and cflags for it
  if meson.is_cross_build()
As you may have seen, build fails because find_program() result cannot be
used in meson.add_install_script() until 0.55. Since your script has
Unix-specific part anyway and Windows recommends Meson 0.56, maybe Unices
should continue using shell variant and Python script can be Windows-only.

Yes, I 'd been thinking about the best way to handle this. Your suggestion of having both
scripts may well be the best option in the short term.

Thanks,
Nick

Reply via email to