> Subject: Re: [PATCH] net/mlx5/windows: fix link speed calculation > > External email: Use caution opening links or attachments > > > There is no previous commit with net/mlx5/windows as title prefix. > In general, there is "on Windows" at the end of the title. > This way we can have the same formatting when fixing the common code for a > Windows case. > > 05/04/2021 18:18, Tal Shnaiderman: > > In Windows DevX returns the value of the current link speed in bps > > rate, the conversion to the Mbps rate expected by DPDK is incorrect > > and fixed. > > "was" incorrect. > > I think you should explain the confusion between Mbit/s and Mibit/s. > > > - dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1024 * > > 1024); > > + dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1000 * > > + 1000); > >
Thanks Thomas for the review, will address the comments in v2.
