06/04/2021 12:18, Bruce Richardson: > On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > > rte_log_register_type_and_pick_level() returns an int. > > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > > > Fixes: 37b881a96194 ("telemetry: use log function from pointer") > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Good catch, I missed it when doing the patch "log: choose EAL log type on registration failure" https://patches.dpdk.org/project/dpdk/patch/20210405100301.657768-2-tho...@monjalon.net/ About the title, I would not say it fixes the registration. It is more about catching registration failure with a fallback.