Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

On Sun, Dec 06, 2020 at 04:49:40PM +0100, Thomas Monjalon wrote: > 05/12/2020 02:10, Pallavi Kadam: > > --- a/drivers/net/meson.build > > +++ b/drivers/net/meson.build > > @@ -1,9 +1,6 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2017 Intel Corporation > > > > -if is_window

Re: [dpdk-dev] [PATCH 0/5] add apistats function

04/12/2020 08:51, Hideyuki Yamashita: > In general, DPDK application consumes CPU usage because it polls > incoming packets using rx_burst API in infinite loop. > This makes difficult to estimate how much CPU usage is really > used to send/receive packets by the DPDK application. > > For example,

Re: [dpdk-dev] [PATCH 4/5] docs: add description of apistats parameter into proc-info

> -Original Message- > From: Varghese, Vipin > @Tahhan, Maryam and @Pattan, Reshma should not documentation and code > change of proc-info be in the same patch request? If code changes and doc changes are related, yes they should be combined in one patch. That is what the case here I

[dpdk-dev] Faulty VF initialization during DPDK startup when multiple DPDK instances use different VFs with the same PF

Hi DPDK devs, A while back I've submitted this bug: https://bugs.dpdk.org/show_bug.cgi?id=578 and now we have a pretty good idea where the issue stems from. TL;DL: it seems to be in either XL710 firmware or i40e driver, with downstream effects which we may need to address in DPDK. What is the

Re: [dpdk-dev] [PATCH 1/7] examples/fips_validation: enhance getopt_long usage

On Tue, Nov 24, 2020 at 1:33 PM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve reada

Re: [dpdk-dev] [PATCH 6/7] examples/vhost: enhance getopt_long usage

On Tue, Nov 24, 2020 at 1:35 PM Ibtisam Tariq wrote: > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index 8d8c3038b..ce8b64035 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -466,6 +466,33 @@ us_vhost_usage(const char *prgname) >prgname); >

Re: [dpdk-dev] Faulty VF initialization during DPDK startup when multiple DPDK instances use different VFs with the same PF

On Mon, Dec 7, 2020 at 11:49 AM Juraj Linkeš wrote: > > Hi DPDK devs, > > A while back I've submitted this bug: > https://bugs.dpdk.org/show_bug.cgi?id=578 and now we have a pretty good idea > where the issue stems from. TL;DL: it seems to be in either XL710 firmware or > i40e driver, with down

[dpdk-dev] [PATCH v4] eal: fix create user mem map repeatedly when it exists

From: Yunjian Wang Currently, user mem maps will check if the newly mapped area is adjacent to any existing mapping, but will not check if the mapping is identical because it assumes that the API will never get called with the same mapping twice. This will result in duplicate entries in the user

[dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush

From: Yunjian Wang The function rte_malloc() could return NULL, the return value need to be checked. Fixes: ce7ea764597e ("net/mvneta: support Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/mvneta/mvneta_rxtx.c | 10 ++ 1 file changed, 10 insertions(+) diff -

Re: [dpdk-dev] DPDK Release Status Meeting 3/12/2020

在 2020/12/3 19:51, Ferruh Yigit 写道: Meeting minutes of 3 December 2020 -- Agenda: * Release Dates * 20.11 retrospective * LTS * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * Nvidia * NXP * Red Hat Release Dates - * v20.11 is relea

Re: [dpdk-dev] [PATCH v3] ip_frag: recalculate data length of fragment

Hi, > In some situations, we would get several ip fragments, which total > data length is less than minimum frame(64) and padding with zeros. > Examples: Second Fragment "a0a1 a2a3 a4a5 a6a7 ..." > and Third Fragment "a8a9 aaab acad aeaf b0b1 b2b3 ...". > Finally, we would reassemble

Re: [dpdk-dev] DPDK Release Status Meeting 3/12/2020

On 12/7/2020 11:54 AM, oulijun wrote: 在 2020/12/3 19:51, Ferruh Yigit 写道: Meeting minutes of 3 December 2020 -- Agenda: * Release Dates * 20.11 retrospective * LTS * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * Nvidia * NXP * Red Hat Release

Re: [dpdk-dev] [EXT] [PATCH] net/mvneta: check allocation in rx queue flush

Hi, How about use 2 local arrays for descs & bufs instead of the malloc/free? Liron -Original Message- From: wangyunjian Sent: Monday, 7 December 2020 13:37 To: dev@dpdk.org Cc: Liron Himi ; z...@semihalf.com; jerry.lili...@huawei.com; xudin...@huawei.com; Yunjian Wang ; sta...@dpd

Re: [dpdk-dev] [PATCH 5/5] librte_ethdev: add to use apistats

Hi, > > This patch modifies to use apistats by librte_ethdev. > > Signed-off-by: Hideyuki Yamashita > --- > lib/librte_ethdev/meson.build| 6 ++- > lib/librte_ethdev/rte_apistats.c | 64 > lib/librte_ethdev/rte_apistats.h | 64 +

Re: [dpdk-dev] DPDK Release Status Meeting 3/12/2020

在 2020/12/7 20:31, Ferruh Yigit 写道: On 12/7/2020 11:54 AM, oulijun wrote: 在 2020/12/3 19:51, Ferruh Yigit 写道: Meeting minutes of 3 December 2020 -- Agenda: * Release Dates * 20.11 retrospective * LTS * OvS * Opens Participants: * Arm * Debian/Microsoft * I

Re: [dpdk-dev] [EXT] [PATCH] net/mvneta: check allocation in rx queue flush

> -Original Message- > From: Liron Himi [mailto:lir...@marvell.com] > Sent: Monday, December 7, 2020 8:38 PM > To: wangyunjian ; dev@dpdk.org > Cc: z...@semihalf.com; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org; Liron Himi > Subject: RE: [EXT] [dpdk-dev] [PATCH] net/mvneta: check alloca

Re: [dpdk-dev] [PATCH v1, 1/2] bonding: fix port id validity check on parsing

On 11/26/2020 2:45 AM, Min Hu (Connor) wrote: It looks good to me, thanks. Converting it to an explicit ack: Acked-by: Min Hu (Connor) Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH 2/2] pci/windows: fix build with MinGW-w64 8.0.0

01/12/2020 17:39, Dmitry Kozlyuk: > Fix redefinition of GUID, missing from previous versions. > > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > Cc: sta...@dpdk.org > Cc: Tal Shnaiderman > > Signed-off-by: Dmitry Kozlyuk For both patches: Tested-by: Thomas Monjalon

Re: [dpdk-dev] DPDK Release Status Meeting 3/12/2020

On 12/7/2020 1:03 PM, oulijun wrote: 在 2020/12/7 20:31, Ferruh Yigit 写道: On 12/7/2020 11:54 AM, oulijun wrote: 在 2020/12/3 19:51, Ferruh Yigit 写道: Meeting minutes of 3 December 2020 -- Agenda: * Release Dates * 20.11 retrospective * LTS * OvS * Opens Parti

[dpdk-dev] [Bug 595] PCAP PMD fails silently when a large amount of packets are loaded while "infinite_rx=1" is used

https://bugs.dpdk.org/show_bug.cgi?id=595 Bug ID: 595 Summary: PCAP PMD fails silently when a large amount of packets are loaded while "infinite_rx=1" is used Product: DPDK Version: unspecified Hardware: All

Re: [dpdk-dev] [v1, 2/2] bonding: fix PCI address comparison on non-pci ports

On 26/11/20 10:24 +0800, Min Hu (Connor) wrote: > what scenarios may cause bugs in old ways. > Could you give an example, thanks. Hello, For example in the following code: - RTE_ETH_FOREACH_DEV(i) { - pci_dev = RTE_ETH_DEV_TO_PCI(&rte_eth_devices[i]); - eth_pci_

[dpdk-dev] [Bug 596] TSO does not support split segment with TIMESTAMP option in the header (Intel Corporation 82599ES 10-Gigabit)

https://bugs.dpdk.org/show_bug.cgi?id=596 Bug ID: 596 Summary: TSO does not support split segment with TIMESTAMP option in the header (Intel Corporation 82599ES 10-Gigabit) Product: DPDK Version: 20.08 H

[dpdk-dev] [PATCH] net/mlx5: fix flow descriptor allocation in Direct Verbs mode.

Initialize flow descriptor tunnel member during flow creation. Prevent access to stale data and pointers when flow descriptor is reallocated after relase. Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- driv

[dpdk-dev] [Bug 597] PCAP PMD reports incorrect TX stats when sending jumbo frames

https://bugs.dpdk.org/show_bug.cgi?id=597 Bug ID: 597 Summary: PCAP PMD reports incorrect TX stats when sending jumbo frames Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCON

Re: [dpdk-dev] DPDK Release Status Meeting 3/12/2020

在 2020/12/7 21:59, Ferruh Yigit 写道: On 12/7/2020 1:03 PM, oulijun wrote: 在 2020/12/7 20:31, Ferruh Yigit 写道: On 12/7/2020 11:54 AM, oulijun wrote: 在 2020/12/3 19:51, Ferruh Yigit 写道: Meeting minutes of 3 December 2020 -- Agenda: * Release Dates * 20.11

Re: [dpdk-dev] [PATCH 4/4] net/hns3: fix FEC state query

在 2020/11/20 22:33, Ferruh Yigit 写道: On 11/20/2020 11:27 AM, Lijun Ou wrote: From: "Min Hu (Conor)" As FEC is not supported below 10 Gbps, CMD(0x031A) offered from Firmware read will return fail in 10 Gbps device. This patch will prevent read this CMD when below 10 Gbps, as this is non-sen

Re: [dpdk-dev] [PATCH 3/4] net/hns3: adjust printing MAC addresses in log

在 2020/11/20 22:25, Ferruh Yigit 写道: On 11/20/2020 11:27 AM, Lijun Ou wrote: Here the printing of MAC addresses is adjusted. After the modification, only some bytes of the MAC address are displayed. Why logging only some bytes of the MAC address? I understand that the entire MAC address in

Re: [dpdk-dev] [PATCH 0/4] hns3 fixes

在 2020/11/20 23:38, Ferruh Yigit 写道: On 11/20/2020 2:58 PM, oulijun wrote: < Moved to the bottom, please do not top post > 欧丽军 Mobile：+86-18899774289 Email：ouli...@huawei.com

Re: [dpdk-dev] [PATCH 0/4] hns3 fixes

On 12/7/2020 2:54 PM, oulijun wrote: 在 2020/11/20 23:38, Ferruh Yigit 写道: On 11/20/2020 2:58 PM, oulijun wrote: < Moved to the bottom, please do not top post > 欧丽军 Mobile：+86-18899774289 Email：ouli...@hua

Re: [dpdk-dev] [PATCH] net/ark: export ark timestamp dynfield offset

On Sun, Dec 6, 2020 at 10:53 AM Thomas Monjalon wrote: > > 04/12/2020 23:31, Stephen Hemminger: > > On Fri, 4 Dec 2020 15:27:45 -0500 > > Ed Czeck wrote: > > > > > Access to mbuf dynfields in application code requires variable > > > export through header and dynamic library. > > > > > > Fixes: a

Re: [dpdk-dev] [PATCH 2/2] pci/windows: fix build with MinGW-w64 8.0.0

07/12/2020 14:56, Thomas Monjalon: > 01/12/2020 17:39, Dmitry Kozlyuk: > > Fix redefinition of GUID, missing from previous versions. > > > > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > > Cc: sta...@dpdk.org > > Cc: Tal Shnaiderman > > > > Signed-off-by: Dmitry Kozl

[dpdk-dev] [PATCH 1/1] devtools: adjust verbosity of ABI check

The scripts gen-abi.sh and check-abi.sh are updated to print error messages to stderr so they are likely never ignored. When called from test-meson-builds.sh, the standard messages on stdout can be more quiet depending on the verbosity settings. The beginning of the ABI check is announced in verbo

[dpdk-dev] [PATCH 1/1] devtools: avoid installing static binaries

When testing compilation and checking ABI compatibility, there is no real need of static binaries eating disks. The static linkage of applications are tested with GCC and Clang, plus some examples are statically linked. The after-installation build test is limited to "helloworld" example. Note the

Re: [dpdk-dev] [PATCH 1/1] devtools: avoid installing static binaries

On Mon, Dec 07, 2020 at 06:33:19PM +0100, Thomas Monjalon wrote: > When testing compilation and checking ABI compatibility, > there is no real need of static binaries eating disks. > The static linkage of applications are tested with GCC and Clang, > plus some examples are statically linked. > The

Re: [dpdk-dev] [PATCH 1/1] devtools: avoid installing static binaries

07/12/2020 18:47, Bruce Richardson: > On Mon, Dec 07, 2020 at 06:33:19PM +0100, Thomas Monjalon wrote: > > When testing compilation and checking ABI compatibility, > > there is no real need of static binaries eating disks. > > The static linkage of applications are tested with GCC and Clang, > > pl

Re: [dpdk-dev] [dpdk-stable] [PATCH] windows: build error with mingw debug

27/11/2020 12:07, Nick Connolly: > Compiling with MinGW in --buildtype=debug produces a redefinition > error for strncasecmp. > > The root cause is that rte_os.h shouldn't be injecting POSIX definitions > into the environment. It is the applications responsibility to decide > how to handle missin

Re: [dpdk-dev] DPDK secondary process access to mbufs using rte_pktmbuf_attach_extbuf()

On Fri, 4 Dec 2020 13:07:01 + Pranab Das wrote: > Hi > > I am wondering if the secondary DPDK processes can access the mbufs that are > attached using rte_pktmbuf_attach_extbuf(). > The DPDK primary process allocates the buffer pool from the heap. Is there > any example application that

Re: [dpdk-dev] [PATCH v2] eal/windows: vfprintf build warning with clang

29/11/2020 14:42, Dmitry Kozlyuk: > On Sun, 29 Nov 2020 13:00:47 +, Nick Connolly wrote: > > When building with clang (11.0,--buildtype=debug), eal_lcore.c > > produces a -Wformat-nonliteral warning from the vfprintf call > > in log_early. > > > > Add __rte_format_printf annotation. > > > > F

Re: [dpdk-dev] [PATCH v2] windows: build warnings with clang

03/12/2020 01:02, Dmitry Kozlyuk: > On Sun, 29 Nov 2020 16:00:24 +, Nick Connolly wrote: > > Microsoft CRT defines Windows-specific secure alternatives to > > standard library functions and triggers warnings when "insecure" > > functions are used [1]. However, calling code already has all > > n

Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register

05/12/2020 01:56, Kadam, Pallavi: > Hi Tal, > > On 11/26/2020 12:06 AM, Tal Shnaiderman wrote: > > interrupt callback register is not implemented in Windows. > > Add stub with -ENOTSUP return value and export the function. > > > > Signed-off-by: Tal Shnaiderman > > --- > > lib/librte_eal/rte_ea

Re: [dpdk-dev] [PATCH v2] maintainers: update for testpmd

02/12/2020 07:33, beilei.x...@intel.com: > From: Beilei Xing > > Replace Beilei Xing with Xiaoyun Li. > > Signed-off-by: Beilei Xing > --- > Driver testing tool > M: Wenzhuo Lu > -M: Beilei Xing > +M: Xiaoyun Li > M: Bernard Iremonger Acks?

[dpdk-dev] [PATCH] doc: fix some statements for ice vector PMD

1. Add descriptions for how to select avx512 datapath. 2. Add explanation for "P" in ice.ini. Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") Fixes: 271cc8c5028a ("doc: update ice features list") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 5 - 1 file c

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow descriptor allocation in Direct Verbs mode.

Hi Gregory, >-Original Message- >From: Gregory Etelson >Sent: Monday, December 7, 2020 10:28 PM >To: dev@dpdk.org >Cc: Gregory Etelson ; Matan Azrad >; Raslan Darawsheh ; Slava >Ovsiienko ; Shahaf Shuler ; >Xueming(Steven) Li >Subject: [PATCH] net/mlx5: fix flow descriptor allocation in

Re: [dpdk-dev] [PATCH] Remove printf from signal handler.

Hi I don't object with all the removing of printf. Just one concern, I don't think you actually solved the problem in this patch. Take testpmd as an example, the signal_handler includes many complicated actions after that very first printf like force_quit() which includes stop port, close port,

Re: [dpdk-dev] Faulty VF initialization during DPDK startup when multiple DPDK instances use different VFs with the same PF

> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Monday, December 7, 2020 6:55 PM > To: Xing, Beilei ; Guo, Jia > Cc: dev@dpdk.org; Kinsella, Ray ; Andrew > Yourtchenko (ayourtch) ; Juraj Linkeš > ; Yigit, Ferruh > Subject: Re: [dpdk-dev] Faulty VF initialization du

[dpdk-dev] rte_pktmbuf_pool_create returns EINVAL

Hello All, We are using DDPDK 19.11 and when we call *rte_pktmbuf_pool_create() *API allocate memory, we could see the EINVAL ( EINVAL - cache size provided is too large, or priv_size is not aligned ) return from that above API. We are seeing the issue only when we pass the Priv_size value of 64 b

Re: [dpdk-dev] Importing DATA into the application

08/12/2020 08:03, Narcisa Ana Maria Vasile: > Hi, > > While using the DPDK libs as DLLs, I've ran into some access violation > errors. I believe they are caused by some incorrect imports. > In Windows, accessing an imported variable is done either by using > __declspec(dllimport), or by using an