Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

[Bruce Richardson]

On Sun, Dec 06, 2020 at 04:49:40PM +0100, Thomas Monjalon wrote:
> 05/12/2020 02:10, Pallavi Kadam:
> > --- a/drivers/net/meson.build
> > +++ b/drivers/net/meson.build
> > @@ -1,9 +1,6 @@
> >  # SPDX-License-Identifier: BSD-3-Clause
> >  # Copyright(c) 2017 Intel Corporation
> >  
> > -if is_windows
> > -   subdir_done()
> > -endif
> >  
> >  drivers = ['af_packet',
> >     'af_xdp',
> > @@ -56,6 +53,12 @@ drivers = ['af_packet',
> >     'virtio',
> >     'vmxnet3',
> >  ]
> > +
> > +if is_windows
> > +   drivers = ['i40e',
> > +   ]
> > +endif
> 
> Let's not add an alternative list please.
> I prefer disabling compilation in other drivers.
> 
+1 for this. It's more work, but it keeps the existing style where all info
about whether a driver should be built, and how it's built in a single file
for each driver.