Re: [dpdk-dev] [PATCH] testpmd: fix init mpls struct

2020-02-02 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, January 31, 2020 1:01 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > > Cc: dev@dpdk.org; Slava Ovsiienko ; > sta...@dpdk.org > Subject: Re: [PATCH] testpmd: fix init mpls struct > > On 1/30/2020 4:

Re: [dpdk-dev] [PATCH] net/ice: fix GTPU rule confliction

2020-02-02 Thread Ye Xiaolong
On 01/22, Qi Zhang wrote: >The patch distinguish fdir rules for GTPU with or without s/distinguish/distinguishes >extend header, so flow to match below patterns can be created >correctly. > >1. eth / ipv4 / udp / gtpu teid is 10 / ... >2. eth / ipv4 / udp / gtpu teid is 10 / gtp_psc / ... >3. eth

Re: [dpdk-dev] [PATCH] app/testpmd: fix uninitialized members of mpls

2020-02-02 Thread Ori Kam
Hi Ferruh, PSB, Thanks, Ori > -Original Message- > From: Ferruh Yigit > Sent: Friday, January 31, 2020 1:08 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > > Cc: dev@dpdk.org; Slava Ovsiienko ; > sta...@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix uninitialized m

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR gtp_psc without qfi pattern issue

2020-02-02 Thread Ye Xiaolong
On 01/21, Yahui Cao wrote: >If only gtpu teid is specified, FDIR will always match the gtpu teid no >matter there is gtp extension header appended or not. >So forbid pattern in which gtp_psc without qfi value follows gtpu with >teid value like: >pattern eth / ipv4 / udp / gtpu teid is XXX / gtp_psc

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix copying the name of the dynflag

2020-02-02 Thread Ori Kam
Hi Ferruh, Thanks for your comments. > -Original Message- > From: Ferruh Yigit > Sent: Friday, January 31, 2020 4:02 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > > Cc: dev@dpdk.org; Slava Ovsiienko > Subject: Re: [PATCH v3] app/testpmd: fix copying the name of the

[dpdk-dev] [PATCH] net/mlx5: fix vxlan-gpe item translation

2020-02-02 Thread Raslan Darawsheh
Currently, when using vxlan-gpe or vxlan item in the flow both are being treated the same with flags 0x8 in vxlan header. which mean the matching of the item vxlan-gpe will match any vxlan packet. This fix the translation of vxlan gpe item into pmd flow item. which will by default set the flags to

Re: [dpdk-dev] Big spike in DPDK VSZ

2020-02-02 Thread David Marchand
On Thu, Jan 30, 2020 at 8:48 AM siddarth rai wrote: > > Hi, > > I have been using DPDK 19.08 and I notice the process VSZ is huge. > > I tried running the test PMD. It takes 64G VSZ and if I use the > '--in-memory' option it takes up to 188G. > > Is there anyway to disable allocation of such huge

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Stephen Hemminger
On Fri, 31 Jan 2020 22:31:57 +0530 wrote: > + /* Create graph object */ > + graph = calloc(1, sizeof(*graph)); > + if (graph == NULL) > + set_err(ENOMEM, fail, "failed to calloc graph object"); T

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Stephen Hemminger
On Fri, 31 Jan 2020 22:31:57 +0530 wrote: > + /* Create graph object */ > + graph = calloc(1, sizeof(*graph)); > + if (graph == NULL) > + set_err(ENOMEM, fail, "failed to calloc graph object"); This won't be safe if used in primary/secondary process model. You would need

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Stephen Hemminger
On Fri, 31 Jan 2020 22:31:57 +0530 wrote: > + > +#define set_err(err, where, fmt, ...) do { \ > + graph_err(fmt, ##__VA_ARGS__); \ > + rte_errno = err; \ > +

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Jerin Jacob
On Sun, Feb 2, 2020 at 4:05 PM Stephen Hemminger wrote: > > On Fri, 31 Jan 2020 22:31:57 +0530 > wrote: > > > + /* Create graph object */ > > + graph = calloc(1, sizeof(*graph)); > > + if (graph == NULL) > > + set_err(ENOMEM, fail, "failed to calloc graph object"); > > Thi

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-02 Thread Jerin Jacob
On Sun, Feb 2, 2020 at 4:08 PM Stephen Hemminger wrote: > > On Fri, 31 Jan 2020 22:31:57 +0530 > wrote: > > > + > > +#define set_err(err, where, fmt, ...) do { > > \ > > + graph_err(fmt, ##__VA_ARGS__); > > \ > > +

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-02 Thread Thomas Monjalon
31/01/2020 15:16, Trahe, Fiona: > On 1/30/2020 8:18 PM, Thomas Monjalon wrote: > > 30/01/2020 17:09, Ferruh Yigit: > > > On 1/29/2020 8:13 PM, Akhil Goyal wrote: > > > > > > > > I believe these enums will be used only in case of ASYM case which is > > > > experimental. > > > > > > Independent fr

Re: [dpdk-dev] [PATCH] net/mlx5: fix vxlan-gpe item translation

2020-02-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Sunday, February 2, 2020 11:13 AM > To: sl...@monjalon.net; Matan Azrad > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix vxlan-gpe item translation > > Currently, when us

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-02 Thread Ananyev, Konstantin
> 31/01/2020 15:16, Trahe, Fiona: > > On 1/30/2020 8:18 PM, Thomas Monjalon wrote: > > > 30/01/2020 17:09, Ferruh Yigit: > > > > On 1/29/2020 8:13 PM, Akhil Goyal wrote: > > > > > > > > > > I believe these enums will be used only in case of ASYM case which is > > > > > experimental. > > > > > >

[dpdk-dev] [PATCH] common/mlx5: redefine Netlink include

2020-02-02 Thread Matan Azrad
The new RDMA-CORE versions may have the same sub-path to include the linux Netlink header file. It uses the pre-proccessor command #include_next what breaks the PMD gcc compilation of common/mlx5_netlink.h file in debug mode. Use specific include for linux/netlink.h to be taken from /usr/include/

[dpdk-dev] [PATCH v3 00/13] Introduce mlx5 vDPA driver

2020-02-02 Thread Matan Azrad
v2: - Reorder patches for 2 serieses - this is the seccond part of the previous series splitting. - Fix spelling and per patch complition issues. - moved to use claim_zero instead of pure asserts. v3: - Address Maxime C comments. - Adjust to the last MLX5_ASSERT introduction. Matan Azrad (13):

[dpdk-dev] [PATCH v3 01/13] drivers: introduce mlx5 vDPA driver

2020-02-02 Thread Matan Azrad
Add a new driver to support vDPA operations by Mellanox devices. The first Mellanox devices which support vDPA operations are ConnectX6DX and Bluefield1 HCA for their PF ports and VF ports. This driver is depending on rdma-core like the mlx5 PMD, also it is going to use mlx5 DevX to create HW obj

[dpdk-dev] [PATCH v3 02/13] vdpa/mlx5: support queues number operation

2020-02-02 Thread Matan Azrad
Support get_queue_num operation to get the maximum number of queues supported by the device. This number comes from the DevX capabilities. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko Reviewed-by: Maxime Coquelin --- drivers/vdpa/mlx5/mlx5_vdpa.c | 54

[dpdk-dev] [PATCH v3 05/13] vdpa/mlx5: prepare HW queues

2020-02-02 Thread Matan Azrad
As an arrangement to the vitrio queues creation, a 2 QPs and CQ may be created for the virtio queue. The design is to trigger an event for the guest and for the vdpa driver when a new CQE is posted by the HW after the packet transition. This patch add the basic operations to create and destroy th

[dpdk-dev] [PATCH v3 06/13] vdpa/mlx5: prepare virtio queues

2020-02-02 Thread Matan Azrad
The HW virtq object represents an emulated context for a VIRTIO_NET virtqueue which was created and managed by a VIRTIO_NET driver as defined in VIRTIO Specification. Add support to prepare and release all the basic HW resources needed the user virtqs emulation according to the rte_vhost configura

[dpdk-dev] [PATCH v3 03/13] vdpa/mlx5: support features get operations

2020-02-02 Thread Matan Azrad
Add support for get_features and get_protocol_features operations. Part of the features are reported by the DevX capabilities. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko Reviewed-by: Maxime Coquelin --- doc/guides/vdpadevs/features/mlx5.ini | 7 drivers/vdpa/mlx5/mlx5_vdp

[dpdk-dev] [PATCH v3 04/13] vdpa/mlx5: prepare memory regions

2020-02-02 Thread Matan Azrad
In order to map the guest physical addresses used by the virtio device guest side to the host physical addresses used by the HW as the host side, memory regions are created. By this way, for example, the HW can translate the addresses of the packets posted by the guest and to take the packets from

[dpdk-dev] [PATCH v3 08/13] vdpa/mlx5: add basic steering configurations

2020-02-02 Thread Matan Azrad
Add a steering object to be managed by a new file mlx5_vdpa_steer.c. Allow promiscuous flow to scatter the device Rx packets to the virtio queues using RSS action. In order to allow correct RSS in L3 and L4, split the flow to 7 flows as required by the device. Signed-off-by: Matan Azrad Acked-b

[dpdk-dev] [PATCH v3 07/13] vdpa/mlx5: support stateless offloads

2020-02-02 Thread Matan Azrad
Add support for the next features in virtq configuration: VIRTIO_F_RING_PACKED, VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_TSO6, VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, VIRTIO_F_VERSION_1, These features support depends in the DevX capabilities re

[dpdk-dev] [PATCH v3 10/13] vdpa/mlx5: map doorbell

2020-02-02 Thread Matan Azrad
The HW supports only 4 bytes doorbell writing detection. The virtio device set only 2 bytes when it rings the doorbell. Map the virtio doorbell detected by the virtio queue kickfd to the HW VAR space when it expects to get the virtio emulation doorbell. Use the EAL interrupt mechanism to get noti

[dpdk-dev] [PATCH v3 09/13] vdpa/mlx5: support queue state operation

2020-02-02 Thread Matan Azrad
Add support for set_vring_state operation. Using DevX API the virtq state can be changed as described in PRM: enable - move to ready state. disable - move to suspend state. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko Acked-by: Maxime Coquelin --- drivers/vdpa/mlx

[dpdk-dev] [PATCH v3 12/13] vdpa/mlx5: support close and config operations

2020-02-02 Thread Matan Azrad
Support dev_conf and dev_conf operations. These operations allow vdpa traffic. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko Acked-by: Maxime Coquelin --- drivers/vdpa/mlx5/mlx5_vdpa.c | 58 --- drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + 2 files c

[dpdk-dev] [PATCH v3 13/13] vdpa/mlx5: disable ROCE

2020-02-02 Thread Matan Azrad
In order to support virtio queue creation by the FW, ROCE mode should be disabled in the device. Do it by netlink which is like the devlink tool commands: 1. devlink dev param set pci/[pci] name enable_roce value false cmode driverinit 2. devlink dev reload pci/[pci] Or

[dpdk-dev] [PATCH v3 11/13] vdpa/mlx5: support live migration

2020-02-02 Thread Matan Azrad
Add support for live migration feature by the HW: Create a single Mkey that maps the memory address space of the VHOST live migration log file. Modify VIRTIO_NET_Q object and provide vhost_log_page, dirty_bitmap_mkey, dirty_bitmap_size, dirty_bitmap_a

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-02 Thread Neil Horman
On Wed, Jan 29, 2020 at 12:29:53PM +, Ferruh Yigit wrote: > Duplicated the existing symbol and versioned one as experimental and > other as stable. > > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > Updated the 'check-experimental-syms.sh' buildtool, which was > complaining that the sy

[dpdk-dev] Windows Support Plan

2020-02-02 Thread Dmitry Kozliuk
Hi everyone! Where do I find a high-level plan of comprehensive Windows support: design decisions, implementation order, etc? Information on the subject is very scarce, one may think it is abandoned. Googling for "site:dpdk.org/ml/archives/dev/ windows" yields only two pages of disjoint messages.

[dpdk-dev] [PATCH v4 0/3] add ABI checks

2020-02-02 Thread David Marchand
Here is the current state of the ABI checks. libabigail has some issues when mixing dump and so files compiled with clang [1], so for now, all checks are done on dumps only. libabigail 1.0-rc3 in Xenial reported issues that disappear with the version 1.2 in Bionic. To avoid getting warnings on in

[dpdk-dev] [PATCH v4 1/3] hash: fix meson headers packaging

2020-02-02 Thread David Marchand
Those headers are internal and should not be distributed. Fixes: 5b9656b157d3 ("lib: build with meson") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Luca Boccassi --- lib/librte_hash/meson.build | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/librte_h

[dpdk-dev] [PATCH v4 2/3] build: split build helper

2020-02-02 Thread David Marchand
No functional change intended, prepare for reusing this code. The config and compilation parts are separated in helpers. Unsetting CC is moved to the caller of the helper. Signed-off-by: David Marchand Acked-by: Luca Boccassi --- Changelog since v2: - changed indent in config(), - removed useles

[dpdk-dev] [PATCH v4 3/3] add ABI checks

2020-02-02 Thread David Marchand
For normal developers, those checks are disabled. Enabling them requires a configuration that will trigger the ABI dumps generation as part of the existing devtools/test-build.sh and devtools/test-meson-builds.sh scripts. Those checks are enabled in the CI for the default meson options on x86 and

Re: [dpdk-dev] [EXT] RE: [PATCH v2 09/12] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-02-02 Thread Lukas Bartosik
Hi Konstantin, On 31.01.2020 02:09, Lukasz Bartosik wrote: > Hi Konstantin, > > On 30.01.2020 23:21, Ananyev, Konstantin wrote: >> >> >>> -Original Message- >>> From: Ananyev, Konstantin >>> Sent: Thursday, January 30, 2020 11:13 AM >>> To: Lukas Bartosik ; Anoob Joseph >>> ; Akhil Goyal

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR gtp_psc without qfi pattern issue

2020-02-02 Thread Zhang, Qi Z
Hi Xiaolong: Please ignore this one, since it is covered by below patch already https://patches.dpdk.org/patch/65025/ Thanks Qi > -Original Message- > From: Ye, Xiaolong > Sent: Sunday, February 2, 2020 4:23 PM > To: Cao, Yahui > Cc: Yang, Qiming ; Lu, Wenzhuo > ; dev@d

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR gtp_psc without qfi pattern issue

2020-02-02 Thread Ye Xiaolong
Got it, thanks for the info. Thanks, Xiaolong On 02/03, Zhang, Qi Z wrote: >Hi Xiaolong: > Please ignore this one, since it is covered by below patch already > https://patches.dpdk.org/patch/65025/ >Thanks >Qi > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Sunday, F

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/axgbe: support flow control API

2020-02-02 Thread Somalapuram, Amaranath
Hi Kevin, I will resubmit the patches. Thanks. Regards, S.Amarnath -Original Message- From: Kevin Traynor Sent: Friday, January 31, 2020 11:20 PM To: Ferruh Yigit ; Somalapuram, Amaranath ; dev@dpdk.org Cc: sta...@dpdk.org; Kumar, Ravi1 ; Thomas Monjalon ; Luca Boccassi Subject: Re:

[dpdk-dev] [PATCH] l2fwd-event: fix lcore allocation in poll mode

2020-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Skip master lcore when assigning cores to rx_queues as it is only used to print stats. Fixes: 4ff457986f76 ("examples/l2fwd-event: add default poll mode routines") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_poll.c | 1 + 1 file chan

[dpdk-dev] [PATCH] app/eventdev: fix test pipeline meson build

2020-02-02 Thread pbhagavatula
From: Pavan Nikhilesh Add missing pipeline test to meson build. Fixes: 2ff67267b049 ("app/eventdev: build with meson") Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/meson.build b/app/t

[dpdk-dev] [PATCH v3 1/2] net/axgbe: support flow control API

2020-02-02 Thread asomalap
From: Amaranath Somalapuram Adding api for flow_ctrl_get and flow_ctrl_set. By default axgbe driver flow control is disabled. Adding dpdk flow control to set water high and low. Cc: sta...@dpdk.org Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_ethdev.c | 85

[dpdk-dev] [PATCH v3 2/2] net/axgbe: support priority flow control API

2020-02-02 Thread asomalap
From: Amaranath Somalapuram Adding API for priority_flow_ctrl_set. Priority flow control to set water high and low, pause_time and priority. Cc: sta...@dpdk.org Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_common.h | 17 ++ drivers/net/axgbe/axgbe_dev.c| 1 + dri

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: fix return value handling from API

2020-02-02 Thread Pavan Nikhilesh Bhagavatula
>Subject: [PATCH] examples/l2fwd-event: fix return value handling from >API > >Patch fixes coverity issues which handles return values from API >calling. > >Coverity issue: 350588 >Coverity issue: 350594 >Coverity issue: 350598 >Coverity issue: 350599 > >Fixes: 3b5476db4823 ("examples/l2fwd-event:

Re: [dpdk-dev] [PATCH v7] eal: add manual probing option

2020-02-02 Thread Pavan Nikhilesh Bhagavatula
@David Marchand @tho...@monjalon.net Ping? Are there any more changes required for this patch? It's been in queue since last October. >-Original Message- >From: dev On Behalf Of Gaetan Rivet >Sent: Thursday, January 23, 2020 3:28 PM >To: dev@dpdk.org >Cc: Vamsi Krishna Attunuru ; Jerin

Re: [dpdk-dev] [PATCH] net/octeontx2: configure RSS adder as tag lsb bits

2020-02-02 Thread Jerin Jacob
On Wed, Jan 29, 2020 at 10:54 PM wrote: > > From: Jerin Jacob > > Before C0 HW revision, The RSS adder was computed based the following > static formula. > > rss_adder<7:0> = flow_tag<7:0> ^ flow_tag<15:8> ^ > flow_tag<23:16> ^ flow_tag<31:24> > > The above scheme has the following drawbacks: > 1

Re: [dpdk-dev] [EXT] RE: [PATCH v2 09/12] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-02-02 Thread Ananyev, Konstantin
Hi Lukasz, > >> /* > >> * RX/TX HW offload capabilities to enable/use on ethernet ports. > >> @@ -1185,7 +1205,7 @@ main_loop(__attribute__((unused)) void *dummy) > >> } > >> > >> static int32_t > >> -check_params(void) > >> +check_params(struct eh_conf *eh_con