Here is the current state of the ABI checks. libabigail has some issues when mixing dump and so files compiled with clang [1], so for now, all checks are done on dumps only. libabigail 1.0-rc3 in Xenial reported issues that disappear with the version 1.2 in Bionic.
To avoid getting warnings on internal types like [2], the checks now make use of the public headers part of a dpdk installation (patch 2 and 3 to prepare for this). Some internal rte_hash headers were installed by meson, so patch 1 fixes this. The most important point, abidiff complains on the rc1 cryptodev changes: - Chacha20-Poly1305 AEAD support, - ECPM and ECDSA support A suppression rule has been put on the internal type rte_cryptodev_ops. But other changes are an ABI breakage afaiu. I put suppression rules on them so that we can run the checks, but some action must be taken for 20.02 if my analysis is confirmed. Special thanks to Dodji the libabigail maintainer for helping on this topic. 1: https://sourceware.org/bugzilla/show_bug.cgi?id=25409 2: http://inbox.dpdk.org/dev/cajfav8yfkodzrox9mkyp7pdmvxw3e7mhwxjfrcjd5zofb2t...@mail.gmail.com/ -- David Marchand Changelog since v3: - removed patch 3 based on Thomas feedback, - switched to fixed sources location for building ABI references, Changelog since v2: - incorporated offlist Thomas comments wrt to existing build envs (do not change --prefix, force builds with debug enabled) David Marchand (3): hash: fix meson headers packaging build: split build helper add ABI checks .ci/linux-build.sh | 24 ++++++++ .travis.yml | 20 +++++- MAINTAINERS | 3 + devtools/check-abi.sh | 59 ++++++++++++++++++ devtools/dpdk.abignore | 21 +++++++ devtools/gen-abi.sh | 26 ++++++++ devtools/test-build.sh | 52 ++++++++++++++-- devtools/test-meson-builds.sh | 96 ++++++++++++++++++++++++----- doc/guides/contributing/patches.rst | 15 +++++ lib/librte_hash/meson.build | 5 +- 10 files changed, 293 insertions(+), 28 deletions(-) create mode 100755 devtools/check-abi.sh create mode 100644 devtools/dpdk.abignore create mode 100755 devtools/gen-abi.sh -- 2.23.0
