Re: [dpdk-dev] [PATCH v3] vhost: fix vhost user virtqueue not accessible

On 11/1/19 8:16 AM, Liu, Yong wrote: > > >> -Original Message- >> From: Adrian Moreno [mailto:amore...@redhat.com] >> Sent: Friday, November 01, 2019 1:48 AM >> To: Liu, Yong ; Bie, Tiwei >> Cc: maxime.coque...@redhat.com; Wang, Zhihong ; >> dev@dpdk.org >> Subject: Re: [PATCH v3] vhost:

Re: [dpdk-dev] [PATCH v4] vhost: fix vhost user virtqueue not accessible

On 11/4/19 11:13 AM, Marvin Liu wrote: > Log feature is disabled in vhost user, so that log address was invalid > when checking. Check whether log address is valid can work around it. > Log address should also be translated in packed ring virtqueue. > > Fixes: 04cfc7fdbfca ("vhost: translate incom

[dpdk-dev] [PATCH v6] vhost: add vhost-user-blk example which support inflight

A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so it can show how these APIs work to support inflight feature. Signed-off-by: Jin Yu --- v1 - add the case. v2 - add the rte_vhost prefix. v3 - add packed ring support v4 - fix build,

[dpdk-dev] [PATCH] doc: support IPsec Multi-buffer lib v0.53

Updated AESNI MB and AESNI GCM PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_gcm.rst | 6 +++--- doc/guides/cryptodevs/aesni_mb.rst | 7 --- 2 files changed, 7 insertions(+)

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

On 03/11/2019 22:41, Thomas Monjalon wrote: > 03/11/2019 21:35, Ray Kinsella: >> On 29/10/2019 14:27, Ferruh Yigit wrote: >>> On 10/26/2019 5:23 PM, Thomas Monjalon wrote: 26/10/2019 11:23, Wang, Haiyue: > From: Thomas Monjalon [mailto:tho...@monjalon.net] >> 26/10/2019 06:40, Wang,

[dpdk-dev] [PATCH v2 0/5] bnxt patchset with bug fixes

From: Kalesh AP Please apply. Ajit Khaparde (1): net/bnxt: fix incorrect COS queue mapping Kalesh AP (2): net/bnxt: fix L4 checksum error indication in non-vector mode rx net/bnxt: fix a failure case during initialization Santoshkumar Karanappa Rastapur (1): net/bnxt: fix vnic allocati

[dpdk-dev] [PATCH v2 2/5] net/bnxt: fix redundant mac addr check

From: Venkat Duvvuru filter->mac_index is used to check, if a same mac is already programmed. Hence, filter->dflt member is not needed which is also used for mac addr redundancy check. This patch fixes it by moving mac_index based redundant check from bnxt_mac_addr_add_op to bnxt_add_mac_filter

[dpdk-dev] [PATCH v2 1/5] net/bnxt: fix L4 checksum error indication in non-vector mode rx

From: Kalesh AP Update "mbuf->ol_flags" correctly for inner and ourter ip checksum errors in case of tunnel and non-tunnel packets. Fixes: 65ee636872eb ("net/bnxt: fix Rx checksum flags") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxr.c

[dpdk-dev] [PATCH v2 4/5] net/bnxt: fix a failure case during initialization

From: Kalesh AP During initialization sequence in bnxt_alloc_mem() if bnxt_alloc_async_cp_ring() fails, driver invokes bnxt_free_mem() which in turn call bnxt_free_vnic_mem() which causes the error logs "bnxt_free_vnic_mem(): VNIC is not freed yet!". This is because vnic memory is allocated but n

[dpdk-dev] [PATCH v2 3/5] net/bnxt: fix vnic allocation failure on port toggle

From: Santoshkumar Karanappa Rastapur bnxt_init_chip called on port start keeps incrementing rx_cosq_cnt. Hence more vnics are allocated with less number of rings on each port stop/start operation. Eventually vnic allocation fails due to incorrect ring group as no ring gets allocated to the vnic.

[dpdk-dev] [PATCH v2 5/5] net/bnxt: fix incorrect COS queue mapping

From: Ajit Khaparde While issuing hwrm_queue_qportcfg command, we are setting the drv_qmap_cap bit which is causing the firmware to return incorrect COS queue mapping. This bit is not required when COS classification is enabled. Fixes: 698aa7e95325 ("net/bnxt: add code to determine the Tx COS qu

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

04/11/2019 10:49, Ray Kinsella: > On 03/11/2019 22:41, Thomas Monjalon wrote: > > 03/11/2019 21:35, Ray Kinsella: > >> On 29/10/2019 14:27, Ferruh Yigit wrote: > >>> On 10/26/2019 5:23 PM, Thomas Monjalon wrote: > 26/10/2019 11:23, Wang, Haiyue: > > From: Thomas Monjalon [mailto:tho...@mon

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

On 04/11/2019 09:54, Thomas Monjalon wrote: > 04/11/2019 10:49, Ray Kinsella: >> On 03/11/2019 22:41, Thomas Monjalon wrote: >>> 03/11/2019 21:35, Ray Kinsella: On 29/10/2019 14:27, Ferruh Yigit wrote: > On 10/26/2019 5:23 PM, Thomas Monjalon wrote: >> 26/10/2019 11:23, Wang, Haiyue

[dpdk-dev] [PATCH] test/mempool: fix false positive test result

The ret variable, initialized to -1, is changed to 0 during the test, making the test successful in some cases where it should return a failure. Fix this by always using the GOTO_ERR() macro that sets the ret variable before doing the goto. Fixes: 923ceaeac140 ("test/mempool: add unit test cases"

Re: [dpdk-dev] DPDK QoS scheduler changes, are we there yet?

> -Original Message- > From: David Marchand > Sent: Monday, November 4, 2019 7:48 AM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: Gladchun, Glenn ; dev@dpdk.org; Yigit, Ferruh > ; Thomas Monjalon > Subject: Re: [dpdk-dev] DPDK QoS scheduler changes, are we there yet? > > On T

Re: [dpdk-dev] [PATCH] lib/eal: resolve address conflicts

On 04-Nov-19 6:32 AM, Wangyu (Turing Solution Development Dep) wrote: Resolve address conflicts on 64K pagesize without base_virtaddr, which cause new address conflicts in eal_get_virtual_area(). Signed-off-by: Beard-627 Acked-by: Eric wang Acked-by: Wei Hu Acked-by: Min Hu --- lib/librt

Re: [dpdk-dev] [PATCH v1] examples/power: fix oob frequency oscillations

On 01-Nov-19 11:00 PM, Thomas Monjalon wrote: 29/10/2019 15:05, Hunt, David: On 27/10/2019 18:35, Thomas Monjalon wrote: 06/08/2019 13:18, Thomas Monjalon: 26/07/2019 12:15, Burakov, Anatoly: So it's biased towards scaling up quickly, but it's doing that over a period. Please correct me if i'

Re: [dpdk-dev] [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary

On 01-Nov-19 9:04 AM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of container

Re: [dpdk-dev] [EXT] [PATCH v3 1/1] test/compress: unit tests refactoring

Hi Shally, Please find my comments below. > -- > Core engine refactoring (test_deflate_comp_decomp function). > Smaller specialized functions created. > > Signed-off-by: Artur Trybula > --- > app/test/test_compressdev.c

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

On 30-Oct-19 7:50 PM, Rajesh Ravi wrote: Thanks Anatoly. Please find  inline below: [Anatoly] vfio_mem_event_callback() is called every time memory is added to a heap. That includes internal and external memory [Rajesh] malloc_heap_add_external_memory() does call eal_memalloc_mem_event_notif

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

On 03.11.2019 7:48, Shahaf Shuler wrote: Friday, November 1, 2019 11:33 AM, Ilya Maximets: Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host On 30.10.2019 22:42, Thomas Monjalon wrote: 30/10/2019 17:09, Ilya Maximets: On 30.10.2019 16:49, Thomas Monjalon wrote: 30/

Re: [dpdk-dev] [PATCH 1/3] sched: documentation update

> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, October 29, 2019 1:20 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Mcnamara, John > ; Kovacevic, Marko > > Subject: [PATCH 1/3] sched: documentation update > > Updates documentation to reflect the changes in the qos

Re: [dpdk-dev] [PATCH 2/3] examples/qos_sched: documentation update

> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, October 29, 2019 1:20 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Mcnamara, John > ; Kovacevic, Marko > > Subject: [PATCH 2/3] examples/qos_sched: documentation update > > Update documentation according to the chang

Re: [dpdk-dev] [PATCH 3/3] examples/ip_pipeline: documentation update

> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, October 29, 2019 1:20 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Mcnamara, John > ; Kovacevic, Marko > > Subject: [PATCH 3/3] examples/ip_pipeline: documentation update > > Updates documentation for traffic manager

[dpdk-dev] [PATCH v2] ethdev: enhance the API for getting burst mode information

Change the type of burst mode information from bit field to free string data, so that each PMD can describe the Rx/Tx busrt functions flexibly. Signed-off-by: Haiyue Wang --- v2: - Drop the bit field for burst mode information handling. v1: - http://patchwork.dpdk.org/patch/62289/ - http://

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

> -Original Message- > From: Ray Kinsella > Sent: Monday, November 4, 2019 18:03 > To: Thomas Monjalon > Cc: dev@dpdk.org; Yigit, Ferruh ; 'Damjan Marion' > ; Wang, > Haiyue ; Jerin Jacob Kollanukkaran > ; > viachesl...@mellanox.com; step...@networkplumber.org; > arybche...@solarflare.

Re: [dpdk-dev] [PATCH v6 11/15] net/hinic: add hinic PMD build and doc files

On Tue, Oct 29, 2019 at 07:27:52PM +0300, Andrew Rybchenko wrote: > On 10/29/19 6:50 PM, Stephen Hemminger wrote: > > On Thu, 27 Jun 2019 16:18:20 +0800 > > Ziyang Xuan wrote: > > > > > +# > > > +# Compile burst-oriented HINIC PMD driver > > > +# > > > +CONFIG_RTE_LIBRTE_HINIC_PMD=n > > The most

[dpdk-dev] [PATCH v6] net/memif: zero-copy slave

Zero-copy slave support for memif PMD. Slave interface exposes DPDK memory to master interface. Only single file segments are supported (EAL option --single-file-segments). Signed-off-by: Jakub Grajciar --- doc/guides/nics/memif.rst | 42 +- drivers/net/memif/Makefile

Re: [dpdk-dev] [PATCH v1 02/13] net/ppfe: introduce ppfe net poll mode driver

On Tue, Oct 29, 2019 at 09:27:22AM +, Ferruh Yigit wrote: > On 10/28/2019 5:18 PM, Stephen Hemminger wrote: > > On Mon, 26 Aug 2019 18:32:35 +0530 > > Gagandeep Singh wrote: > > > >> --- a/config/common_base > >> +++ b/config/common_base > >> @@ -224,6 +224,11 @@ CONFIG_RTE_LIBRTE_CXGBE_DEBUG

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

On Fri, Nov 01, 2019 at 11:54:45AM +, Luca Boccassi wrote: > For distros, out-of-tree kernel modules are painful. From my POV, it > would be preferable to try and find a solution upstream, even if it is > going to be difficult and require a lot of negotiation and work. > I don't think anyone

[dpdk-dev] [PATCH 2/2] doc: bump the supported SDK and firmware version

This patch bump the supported SDK and MC firmware version to the latest. Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa2_sec.rst | 4 ++-- doc/guides/eventdevs/dpaa2.rst | 4 ++-- doc/guides/nics/dpaa2.rst | 4 ++-- doc/guides/platform/dpaa2.rst | 7 +-- do

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

On Thu, Oct 31, 2019 at 05:03:09PM +, Ferruh Yigit wrote: > On 10/1/2019 7:05 PM, Rahul Shah wrote: > > Adding a new port type called eventdev to the > > rte_port library. > > > > Signed-off-by: Rahul Shah > > --- > > lib/librte_port/Makefile | 4 +- > > lib/librte_port/meson.b

[dpdk-dev] [PATCH 1/2] config: remove redundant dpaa2 build

dpaa and dpaa2 config have evolved to be same. The same binaray can now work across the platforms. So, there is no need to maintain two different build configs. The dpaa config shall work for both generation of dpaa platforms. Signed-off-by: Hemant Agrawal --- config/arm/arm64_dpaa2_linux_gcc

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

Hi Ferruh, I was checking the lib/Makefile for cryptodev example which is similar to eventdev patch I have added (i.e. there is a dependency on librte_cryptodev library) DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port DEPDIRS-librte_port := librte_eal librte_mempool librte_mbuf librte_ethdev DEPD

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: block xstats for hidden ports

> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Friday, November 1, 2019 8:13 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: block xstats for hidden ports > > All the other testpmd commands block access to devices th

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

04/11/2019 11:03, Ray Kinsella: > On 04/11/2019 09:54, Thomas Monjalon wrote: > > 04/11/2019 10:49, Ray Kinsella: > >> On 03/11/2019 22:41, Thomas Monjalon wrote: > >>> 03/11/2019 21:35, Ray Kinsella: > On 29/10/2019 14:27, Ferruh Yigit wrote: > > On 10/26/2019 5:23 PM, Thomas Monjalon wro

Re: [dpdk-dev] [PATCH v6 08/12] net/dpaa2: fix possible use of uninitialized vars

Hi Andrzej > -Original Message- > From: Andrzej Ostruszka > Sent: Tuesday, October 29, 2019 7:42 PM > To: dev@dpdk.org; Hemant Agrawal ; Sachin > Saxena > Cc: mattias.ronnb...@ericsson.com; step...@networkplumber.org > Subject: [PATCH v6 08/12] net/dpaa2: fix possible use of uninitialize

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

Thanks Bruce, I confirmed both points. 1. eventdev is listed before port 2. librte_port/meson.build file has this patch added already. Thanks, Rahul -Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Monday, November 4, 2019 4:54 PM To: Yigit, Ferruh

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

On 04/11/2019 11:30, Thomas Monjalon wrote: > 04/11/2019 11:03, Ray Kinsella: >> On 04/11/2019 09:54, Thomas Monjalon wrote: >>> 04/11/2019 10:49, Ray Kinsella: On 03/11/2019 22:41, Thomas Monjalon wrote: > 03/11/2019 21:35, Ray Kinsella: >> On 29/10/2019 14:27, Ferruh Yigit wrote:

Re: [dpdk-dev] [PATCH] test/mempool: fix false positive test result

On 11/4/19 1:06 PM, Olivier Matz wrote: > The ret variable, initialized to -1, is changed to 0 during the test, > making the test successful in some cases where it should return a > failure. > > Fix this by always using the GOTO_ERR() macro that sets the ret > variable before doing the goto. > > Fi

[dpdk-dev] [PATCH v2] net/mlx5: port id action must be after VLAN actions

Rdma-core needs the dst_vport (port_id) action be after push/pop VLAN and modify hdr actions otherwise it will reject to create rule. This pach validates the port_id is after push/pop VLAN and set VLAN VID/PCP otherwise PMD spits out errors. Fixes: 5f163d520cff ("net/mlx5: support modify VLAN ID

[dpdk-dev] Limiting packet buffers under 4GB

Hi Anatoly and All, Just wondering what would the side effect of lowering a _bit_ of static uint64_t baseaddr = 0x1 in lib/librte_eal/common/eal_common_memory.c for 64bit systems. Use case: If we _reserve_ VA address which less than 2^32 ONLY for packet buffers(mbuf), The use cases li

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

04/11/2019 13:07, Ray Kinsella: > > On 04/11/2019 11:30, Thomas Monjalon wrote: > > 04/11/2019 11:03, Ray Kinsella: > >> On 04/11/2019 09:54, Thomas Monjalon wrote: > >>> 04/11/2019 10:49, Ray Kinsella: > On 03/11/2019 22:41, Thomas Monjalon wrote: > > 03/11/2019 21:35, Ray Kinsella: > >>

[dpdk-dev] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers

This disables OCTEON TX2 for gcc 4.8.5 as the compiler is emitting "internal compiler error" for aarch64. Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure") Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani Acked-by: Jerin Jacob --- v2: Disabled configs PMD_OCTEONTX2_CRYPTO &

[dpdk-dev] [PATCH v2 1/2] mk: fix build on arm64

OcteonTx was disabled for causing an internal compiler error on old gcc versions. See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers"). The condition that was added later to apply disabling OcteonTx only on arm64 caused the condition to never be obeyed because it compares ["arm64"]

Re: [dpdk-dev] [PATCH v6 07/12] app/test: clean LTO build warnings (maybe-uninitialized)

Yipeng Thank you for your comment. See my reply below. On 11/1/19 6:15 PM, Wang, Yipeng1 wrote: >> -Original Message- [...] >> diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c >> index 4376b099b..615767fb6 100644 >> --- a/app/test/test_hash_readwrite.c >> +++

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

On 04/11/2019 13:09, Thomas Monjalon wrote: > 04/11/2019 13:07, Ray Kinsella: >> >> On 04/11/2019 11:30, Thomas Monjalon wrote: >>> 04/11/2019 11:03, Ray Kinsella: On 04/11/2019 09:54, Thomas Monjalon wrote: > 04/11/2019 10:49, Ray Kinsella: >> On 03/11/2019 22:41, Thomas Monjalon w

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

On 25 Oct 2019, at 15:02, Damjan Marion (damarion) mailto:damar...@cisco.com>> wrote: On 25 Oct 2019, at 14:23, Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 25-Oct-19 12:13 PM, Damjan Marion (damarion) wrote: On 25 Oct 2019, at 00:32, Thomas Monjalon mailto:tho...@monjalon

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

On 27 Oct 2019, at 08:00, Shahaf Shuler mailto:shah...@mellanox.com>> wrote: -Original Message- From: Damjan Marion (damarion) mailto:damar...@cisco.com>> Sent: Friday, October 25, 2019 2:14 PM To: Thomas Monjalon mailto:tho...@monjalon.net>> Cc: David Marchand mailto:david.march...@

Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx2: add Rx/Tx burst mode get callbacks

On Mon, Nov 4, 2019 at 11:37 AM Sunil Kumar Kori wrote: > > Retrieve burst mode options according to the selected Rx/Tx burst > function. > > Signed-off-by: Sunil Kumar Kori > --- > v2: > - Rebased the patch on latest commit. > - Update feature matrix for the support. Please rework this patch

Re: [dpdk-dev] [PATCH v6 10/12] net/i40e: clean LTO build warnings (maybe-uninitialized)

Beilei Thank you for the comment, please see below. On 11/1/19 3:05 AM, Xing, Beilei wrote: >> -Original Message- >> From: Andrzej Ostruszka [mailto:aostrus...@marvell.com] [...] >> Subject: [PATCH v6 10/12] net/i40e: clean LTO build warnings (maybe- >> uninitialized) >> >> During LTO bui

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

> -Original Message- > From: Ray Kinsella > Sent: Monday, November 4, 2019 21:49 > To: Thomas Monjalon > Cc: dev@dpdk.org; Yigit, Ferruh ; 'Damjan Marion' > ; Wang, > Haiyue ; Jerin Jacob Kollanukkaran > ; > viachesl...@mellanox.com; step...@networkplumber.org; > arybche...@solarflare.

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

Regards, Asaf Penso > -Original Message- > From: dev On Behalf Of Ilya Maximets > Sent: Monday, November 4, 2019 12:28 PM > To: Shahaf Shuler ; Ilya Maximets > ; Thomas Monjalon > Cc: dev@dpdk.org; Jerin Jacob ; Andrew > Rybchenko ; Ferruh Yigit > ; Stephen Hemminger > ; Roni Bar Yanai

Re: [dpdk-dev] [PATCH v6 08/12] net/dpaa2: fix possible use of uninitialized vars

On 11/4/19 12:46 PM, Hemant Agrawal wrote: > Hi Andrzej Hello Hemant, Thank you for your comments. >> -Original Message- >> From: Andrzej Ostruszka [...] >> a/drivers/net/dpaa2/mc/dpkg.c b/drivers/net/dpaa2/mc/dpkg.c index >> 80f94f40e..7aa63ea12 100644 >> --- a/drivers/net/dpaa2/mc/dpk

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

On 04.11.2019 15:30, Asaf Penso wrote: Regards, Asaf Penso -Original Message- From: dev On Behalf Of Ilya Maximets Sent: Monday, November 4, 2019 12:28 PM To: Shahaf Shuler ; Ilya Maximets ; Thomas Monjalon Cc: dev@dpdk.org; Jerin Jacob ; Andrew Rybchenko ; Ferruh Yigit ; Stephen He

Re: [dpdk-dev] [PATCH] net/ice: fix link status recovery

> -Original Message- > From: dev On Behalf Of Qiming Yang > Sent: Sunday, November 3, 2019 9:40 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: fix link status recovery > > This patch fix a kernel driver link status issue b

Re: [dpdk-dev] [PATCH v2] net/mlx5: port id action must be after VLAN actions

Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Monday, November 4, 2019 2:44 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [dpdk-dev] [PATCH v2] net/mlx5: port id action must be after VLAN > actions > > Rdma-

[dpdk-dev] [PATCH v3 1/7] mempool: allow unaligned addr/len in populate virt

rte_mempool_populate_virt() currently requires that both addr and length are page-aligned. Remove this uneeded constraint which can be annoying with big hugepages (ex: 1GB). Signed-off-by: Olivier Matz Reviewed-by: Andrew Rybchenko Acked-by: Nipun Gupta --- lib/librte_mempool/rte_mempool.c |

[dpdk-dev] [PATCH v3 4/7] mempool: introduce function to get mempool page size

In rte_mempool_populate_default(), we determine the page size, which is needed for calc_size and allocation of memory. Move this in a function and export it, it will be used in a next commit. Signed-off-by: Olivier Matz Reviewed-by: Andrew Rybchenko Acked-by: Nipun Gupta --- lib/librte_mempoo

[dpdk-dev] [PATCH v3 2/7] mempool: reduce wasted space on mempool populate

The size returned by rte_mempool_op_calc_mem_size_default() is aligned to the specified page size. Therefore, with big pages, the returned size can be much more that what we really need to populate the mempool. For instance, populating a mempool that requires 1.1GB of memory with 1GB hugepages can

[dpdk-dev] [PATCH v3 0/7] mempool: avoid objects allocations across pages

KNI supposes that mbufs are contiguous in kernel virtual memory. This may not be true when using the IOVA=VA mode. To fix this, a possibility is to ensure that objects do not cross page boundaries in mempool. This patchset implements this in the last patch (5/5). The previous patches prepare the j

[dpdk-dev] [PATCH v3 7/7] mempool: use the specific macro for object alignment

For consistency, RTE_MEMPOOL_ALIGN should be used in place of RTE_CACHE_LINE_SIZE. They have the same value, because the only arch that was defining a specific value for it has been removed from dpdk. Signed-off-by: Olivier Matz Reviewed-by: Andrew Rybchenko Acked-by: Nipun Gupta --- drivers/m

[dpdk-dev] [PATCH v3 6/7] mempool: prevent objects from being across pages

When populating a mempool, ensure that objects are not located across several pages, except if user did not request iova contiguous objects. Signed-off-by: Vamsi Krishna Attunuru Signed-off-by: Olivier Matz Acked-by: Nipun Gupta --- drivers/mempool/bucket/rte_mempool_bucket.c | 2 +- driver

[dpdk-dev] [PATCH v3 3/7] mempool: remove optimistic IOVA-contiguous allocation

The previous commit reduced the amount of required memory when populating the mempool with non iova-contiguous memory. Since there is no big advantage to have a fully iova-contiguous mempool if it is not explicitly asked, remove this code, it simplifies the populate function. Signed-off-by: Olivi

[dpdk-dev] [PATCH v3 5/7] mempool: introduce helpers for populate and calc mem size

Introduce new functions that can used by mempool drivers to calculate required memory size and to populate mempool. For now, these helpers just replace the *_default() functions without change. They will be enhanced in next commit. Signed-off-by: Olivier Matz Acked-by: Nipun Gupta --- drivers/

Re: [dpdk-dev] Limiting packet buffers under 4GB

Hi Jerin, On Mon, Nov 04, 2019 at 12:59:40PM +, Jerin Jacob Kollanukkaran wrote: > Hi Anatoly and All, > > Just wondering what would the side effect of lowering a _bit_ of static > uint64_t baseaddr = 0x1 in > lib/librte_eal/common/eal_common_memory.c for 64bit systems. > > Use ca

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

Hi Akhil, > > > > > > > > > > > > 11/10/2019 14:40, Akhil Goyal: > > > > > > > Hi All, > > > > > > > > > > > > > > This patchset would need ack from more vendors as it will impact > > > > > > > user > > > > > > experience > > > > > > > on a key example application which is normally demonstrated to

Re: [dpdk-dev] [EXT] [PATCH v3 1/1] test/compress: unit tests refactoring

> -Original Message- > From: Trybula, ArturX > Sent: Monday, November 4, 2019 3:55 PM > To: Shally Verma ; dev@dpdk.org; Trahe, Fiona > ; Dybkowski, AdamX > ; akhil.go...@nxp.com > Subject: RE: [EXT] [PATCH v3 1/1] test/compress: unit tests refactoring > > Hi Shally, > > Please find m

[dpdk-dev] [PATCH v12 0/5] use WFE for aarch64

V12: - remove the 'rte_' prefix from the arm specific functions (David Marchand) - use the __atomic_load_ex_xx functions in arm specific implementations of APIS (David Marchand) - remove the experimental warnings (David Marchand) - tweak the macros working scope (David Marchand) V11: -add rte_ pre

[dpdk-dev] [PATCH v12 4/5] net/thunderx: use new API to save cycles on aarch64

Use the new API to wait in low power state instead of continuous polling to save CPU cycles and power. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob --- drivers/net/thunderx/Makefile | 1 + drivers/net/thunderx/meson.build | 1 + drivers/net/thunderx/nicvf_rxtx.c

[dpdk-dev] [PATCH v12 2/5] eal: add the APIs to wait until equal

The rte_wait_until_equal_xx APIs abstract the functionality of 'polling for a memory location to become equal to a given value'. Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled by default. When it is enabled, the above APIs will call WFE instruction to save CPU cycles and power.

[dpdk-dev] [PATCH v12 3/5] ticketlock: use new API to reduce contention on aarch64

While using ticket lock, cores repeatedly poll the lock variable. This is replaced by rte_wait_until_equal API. Running ticketlock_autotest on ThunderX2, Ampere eMAG80, and Arm N1SDP[1], there were variances between runs, but no notable performance gain or degradation were seen with and without th

[dpdk-dev] [PATCH v12 5/5] event/opdl: use new API to save cycles on aarch64

Use the new API to wait in low power state instead of continuous polling to save CPU cycles and power. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Jerin Jacob --- drivers/event/opdl/Makefile| 1 + drivers/event/opdl/meson.build | 1 + drivers/event/opdl/opdl_ring.c | 5 +

[dpdk-dev] [PATCH v12 1/5] bus/fslmc: fix the conflicting dmb function

There are two definitions conflicting each other, for more details, refer to [1]. include/rte_atomic_64.h:19: error: "dmb" redefined [-Werror] drivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the previous definition #define dmb() {__asm__ __volatile__("" : : : "memory"); } The

[dpdk-dev] eRPC error

Hi, When using eRPC with DPDK the following error pops up: 69:828149 WARNG: Installing flow rule for Rpc 0. NUMA node = 0. Flow RX UDP port = 31882. 69:838908 WARNG: RawTransport created for Rpc ID 0. Device mlx5_0/enp175s0, port 1. IPv4 10.10.10.55, MAC 98:3:9b:63:e0:e0. Datapath UDP port 318

Re: [dpdk-dev] [PATCH v8 00/10] example/l2fwd-event: introduce l2fwd-event example

On Wed, Oct 30, 2019 at 11:47 PM Jerin Jacob wrote: > > On Wed, Oct 30, 2019 at 9:57 PM wrote: > > > > From: Pavan Nikhilesh > > > > This patchset adds a new application to demonstrate the usage of event > > mode. The poll mode is also available to help with the transition. > > > > The following

[dpdk-dev] [pull-request] next-eventdev 19.11 RC2

The following changes since commit 19397c7bf2545e6adab41b657a1f1da3c7344e7b: version: 19.11-rc1 (2019-10-27 22:46:22 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to c952045d4a81d16f745ee0080e6870fafd9a220a: doc: ad

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

On 04-Nov-19 1:57 PM, Damjan Marion (damarion) wrote: On 25 Oct 2019, at 15:02, Damjan Marion (damarion) > wrote: On 25 Oct 2019, at 14:23, Burakov, Anatoly > wrote: On 25-Oct-19 12:13 PM, Damjan Marion (damarion) wrote: On 25 O

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

> On 4 Nov 2019, at 18:27, Burakov, Anatoly wrote: > > On 04-Nov-19 1:57 PM, Damjan Marion (damarion) wrote: >>> On 25 Oct 2019, at 15:02, Damjan Marion (damarion) >> > wrote: >>> >>> >>> On 25 Oct 2019, at 14:23, Burakov, Anatoly >>>

[dpdk-dev] [PATCH] vfio: fix getting default container

When requesting DMA mapping to default container, we are meant to supply the RTE_VFIO_DEFAULT_CONTAINER_FD value, however this is not handled correctly by get_vfio_cfg_by_container_fd(), because it only looks at actual fd values and does not check for this special case. Fix it to return default co

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

On 04-Nov-19 5:34 PM, Damjan Marion (damarion) wrote: On 4 Nov 2019, at 18:27, Burakov, Anatoly wrote: On 04-Nov-19 1:57 PM, Damjan Marion (damarion) wrote: On 25 Oct 2019, at 15:02, Damjan Marion (damarion) mailto:damar...@cisco.com>> wrote: On 25 Oct 2019, at 14:23, Burakov, Anatoly m

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

On 4 Nov 2019, at 18:42, Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 04-Nov-19 5:34 PM, Damjan Marion (damarion) wrote: On 4 Nov 2019, at 18:27, Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 04-Nov-19 1:57 PM, Damjan Marion (damarion) wrote: On 25 Oct 2019, a

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, November 3, 2019 1:41 PM > To: Ori Kam ; Thomas Monjalon > > Cc: dev@dpdk.org; pbhagavat...@marvell.com; ferruh.yi...@intel.com; > jer...@marvell.com; John McNamara ; Marko > Kovacevic ; Adrien Mazarguil > ; david.march...@re

Re: [dpdk-dev] [PATCH] vfio: fix getting default container

On Mon, Nov 4, 2019 at 6:41 PM Anatoly Burakov wrote: > > When requesting DMA mapping to default container, we are meant to > supply the RTE_VFIO_DEFAULT_CONTAINER_FD value, however this is > not handled correctly by get_vfio_cfg_by_container_fd(), because > it only looks at actual fd values and d

[dpdk-dev] [PATCH 2/4] net/bnxt: keep consistent rxq start/stop state

Receive queue state needs to reflect "started" state when rebuilding the RSS table for Thor-based NICs. Move state update so that receive queues being started are included in the RSS table. Fixes: 38412304b50a ("net/bnxt: enable RSS for thor-based controllers") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH 3/4] net/bnxt: release hwrm lock before returning

The function bnxt_vnic_rss_configure_thor() returns early when all receive queues are stopped without releasing the hwrm spinlock, which causes subsequent HWRM operations to hang. Fix by ensuring that the lock is released before returning from this function. Fixes: 38412304b50a ("net/bnxt: enable

[dpdk-dev] [PATCH 4/4] net/bnxt: fix rxq start/stop for Thor based NICs

Controller-specific handling is required for Thor-based NICs when stopping or starting a receive queue, otherwise packet reception may not be reliably resumed when a stopped receive queue is restarted: - The VNIC default receive ring needs to be recomputed when a receive queue is stopped or s

[dpdk-dev] [PATCH 1/4] net/bnxt: fix RSS table update for start/stop rxq

A previous commit made updating of the RSS table when a receive queue is stopped/started conditional on vnic->rx_queue_cnt being nonzero. This count is only nonzero for dynamically created VNICs, so the RSS table was not being updated in the normal path. Fix by restoring the original logic. Also e

[dpdk-dev] [PATCH 0/4] net/bnxt: rxq stop/start fixes

This patch set fixes several problems involving stopping/starting receive queues in the bnxt PMD. Lance Richardson (4): net/bnxt: fix RSS table update for start/stop rxq net/bnxt: keep consistent rxq start/stop state net/bnxt: release hwrm lock before returning net/bnxt: fix rxq start/st

Re: [dpdk-dev] [PATCH 0/4] net/bnxt: rxq stop/start fixes

This patch set depends on the "bnxt patchset with bug fixes" series: http://patchwork.dpdk.org/project/dpdk/list/?series=7216 It is based on current dpdk-next-net-brcm. Lance On Mon, Nov 4, 2019 at 3:27 PM Lance Richardson wrote: > > > This patch set fixes several problems involving sto

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

Monday, November 4, 2019 12:28 PM, Ilya Maximets: > Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from > host > > On 03.11.2019 7:48, Shahaf Shuler wrote: > > Friday, November 1, 2019 11:33 AM, Ilya Maximets: > >> Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV

Re: [dpdk-dev] [PATCH 1/2] config: remove redundant dpaa2 build

On Mon, Nov 4, 2019 at 12:24 PM Hemant Agrawal wrote: > > dpaa and dpaa2 config have evolved to be same. The same binaray binary* > can now work across the platforms. So, there is no need to maintain > two different build configs. > The dpaa config shall work for both generation of dpaa platform

[dpdk-dev] [PATCH v3 4/5] net/bnxt: fix a failure case during initialization

From: Kalesh AP During initialization sequence in bnxt_alloc_mem() if bnxt_alloc_async_cp_ring() fails, driver invokes bnxt_free_mem() which in turn call bnxt_free_vnic_mem() which causes the error logs "bnxt_free_vnic_mem(): VNIC is not freed yet!". This is because vnic memory is allocated but n

[dpdk-dev] [PATCH v3 2/5] net/bnxt: fix redundant MAC address check

From: Venkat Duvvuru filter->mac_index is used to check, if a same mac is already programmed. Hence, filter->dflt member is not needed which is also used for mac addr redundancy check. This patch fixes it by moving mac_index based redundant check from bnxt_mac_addr_add_op to bnxt_add_mac_filter

[dpdk-dev] [PATCH v3 1/5] net/bnxt: fix L4 checksum indication in non-vector Rx

From: Kalesh AP Update "mbuf->ol_flags" correctly for inner and ourter ip checksum errors in case of tunnel and non-tunnel packets. Fixes: 65ee636872eb ("net/bnxt: fix Rx checksum flags") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde ---

[dpdk-dev] [PATCH v3 0/5] bnxt patchset with bug fixes

v2->v3: Sending with updated the commit logs for patch 1 & 2 Ajit Khaparde (1): net/bnxt: fix incorrect COS queue mapping Kalesh AP (2): net/bnxt: fix L4 checksum indication in non-vector Rx net/bnxt: fix a failure case during initialization Santoshkumar Karanappa Rastapur (1): net/bnxt

[dpdk-dev] [PATCH v3 3/5] net/bnxt: fix vnic allocation failure on port toggle

From: Santoshkumar Karanappa Rastapur bnxt_init_chip called on port start keeps incrementing rx_cosq_cnt. Hence more vnics are allocated with less number of rings on each port stop/start operation. Eventually vnic allocation fails due to incorrect ring group as no ring gets allocated to the vnic.

[dpdk-dev] [PATCH v3 5/5] net/bnxt: fix incorrect COS queue mapping

While issuing hwrm_queue_qportcfg command, we are setting the drv_qmap_cap bit which is causing the firmware to return incorrect COS queue mapping. This bit is not required when COS classification is enabled. Fixes: 698aa7e95325 ("net/bnxt: add code to determine the Tx COS queue") Signed-off-by:

[dpdk-dev] [PATCH v2 0/4] net/bnxt: rxq stop/start fixes

This patch set fixes several problems involving stopping/starting receive queues in the bnxt PMD. -- v1->v2: Updated commit logs for consistency. Lance Richardson (4): net/bnxt: fix RSS table update for start/stop rxq net/bnxt: keep consistent rxq start/stop state net/bnxt: release hwrm loc

[dpdk-dev] [PATCH v2 1/4] net/bnxt: fix RSS table update for start/stop rxq

From: Lance Richardson A previous commit made updating of the RSS table when a receive queue is stopped/started conditional on vnic->rx_queue_cnt being nonzero. This count is only nonzero for dynamically created VNICs, so the RSS table was not being updated in the normal path. Fix by restoring th

  1   2   >