On Tue, Oct 29, 2019 at 07:27:52PM +0300, Andrew Rybchenko wrote: > On 10/29/19 6:50 PM, Stephen Hemminger wrote: > > On Thu, 27 Jun 2019 16:18:20 +0800 > > Ziyang Xuan <xuanziya...@huawei.com> wrote: > > > > > +# > > > +# Compile burst-oriented HINIC PMD driver > > > +# > > > +CONFIG_RTE_LIBRTE_HINIC_PMD=n > > The most common naming convention for drivers is: > > CONFIG_RTE_LIBRTE_PMD_XXX > > > > so please use that. > > It looks like we really need some conventions for all future PMDs: > > $ git grep CONFIG_RTE_LIBRTE_PMD_ config/common_base | wc -l > 59 > $ git grep CONFIG_RTE_LIBRTE_.*_PMD= config/common_baseĀ | wc -l > 40 > Yes, it is very inconsistent. However, for meson builds these defines are automatically generated so follow only a single pattern. That pattern has the PMD part at the end, so I recommend using that. From drivers/net/meson.build:
config_flag_fmt = 'RTE_LIBRTE_@0@_PMD' /Bruce