Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On Thu, May 9, 2019 at 3:11 AM Stephen Hemminger wrote: > On Wed, 8 May 2019 17:48:06 -0500 > Erik Gabriel Carrillo wrote: > > > Due to an upcoming fix to allow the timer library to safely free its > > allocations during the finalize() call[1], an ABI change will be > > required. A new lock wil

[dpdk-dev] Shared library build is unable to parse device

Hi, Amazed by the reported processing speed of DPDK, I'm trying to use DPDK as a shared library. Running the rxtx_callbacks (and possibly other) example(s) it exits on `unable to parse device` when enabling CONFIG_RTE_BUILD_SHARED_LIB. If this behavior is as expected for some reason I'm curious

Re: [dpdk-dev] about IOVA and namespace in DPDK 19.05

Anatoly, Thank you very much for the detail elaboration on IOVA. Glad to know the memory allocation model is changed since 18.05 which knowledge is fresh to me. Thanks, Robert From: Burakov, Anatoly Sent: Tuesday, May 7, 2019 5:02 AM To: Robert Nie; dev@dpdk.or

Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs

On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon wrote: > Two public functions from EAL and metrics libraries need to return > some new error codes instead of calling rte_panic or rte_exit. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/deprecation.rst | 6 ++ > 1 file chang

Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs

09/05/2019 09:34, David Marchand: > On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon wrote: > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > +* eal: The function ``rte_eal_remote_launch`` will return new error codes > > + after read or write error o

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

09/05/2019 01:01, Carrillo, Erik G: > I like this idea; thanks for the suggestion. I went ahead and submitted a > new version > of this patch with this approach. It's dependent on one other new patch that > allows > secondary processes to reserve the memzone. I also submitted a deprecation >

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

09/05/2019 00:50, David Christensen: > > > It seems your emails are not threaded at all. > > It makes really hard to review them. > > All patches of a patchset must be in the same thread, > > ideally with a cover letter. > > All versions of a patchset must be in the same thread, > > ideally with t

[dpdk-dev] [PATCH] app/testpmd: remove port stop check for macsec

There is no need to do such a check when set macsec for ixgbe, reconfig_device_queueand is also useless. If ew do not delete this unnessarycode, users have to sotp port before enable macsec, then restart this port after make configuration. All these process is useless. As this cmdline is a private

[dpdk-dev] [PATCH] app/testpmd: fix offloads overwrite by default configuration

There is an error in function rxtx_port_config(), which may overwrite offloads configuration get from function launch_args_parse() when run testpmd app. So rxtx_port_config() should do "or" for port offloads. Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") cc: sta...@dpdk.org Sign

Re: [dpdk-dev] [RFC] eventdev: replace mbufs with events in Rx callback

> -Original Message- > From: Nikhil Rao > Sent: Thursday, May 9, 2019 5:27 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Nikhil Rao > Subject: [EXT] [RFC] eventdev: replace mbufs with events in Rx callback > > Replace the mbuf pointer array in the event eth Rx adapter callback

[dpdk-dev] [PATCH] net/virtio: remove useless check on mempool

This .rx_queue_setup devop is called after ethdev already dereferenced the mempool pointer. No need to check and we can remove this rte_exit. Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper place") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/virtio/vi

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] hash: fix bugs in 'free key with position'

09/05/2019 00:59, Dharmik Thakkar: > This patch fixes 2 bugs- > 1] Incorrect position returned to the free slots. > 2] Incorrect computation of total_entries Is it possible to split in 2 patches? How critical is this bug? It looks old. I'm afraid it will miss 19.05.

Re: [dpdk-dev] [PATCH v3] timer: fix resource leak in finalize

On 08-May-19 11:35 PM, Erik Gabriel Carrillo wrote: By using a lock added to the rte_mem_config (which lives in shared memory), we can synchronize multiple processes in init/finalize and safely free allocations made during init. Signed-off-by: Erik Gabriel Carrillo --- changes in v3: - The pr

[dpdk-dev] [RFC v6] /net: memory interface (memif)

Memory interface (memif), provides high performance packet transfer over shared memory. Signed-off-by: Jakub Grajciar --- MAINTAINERS |6 + app/test-pmd/testpmd.c |2 + config/common_base |5 + config/commo

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On 09-May-19 8:05 AM, David Marchand wrote: On Thu, May 9, 2019 at 3:11 AM Stephen Hemminger mailto:step...@networkplumber.org>> wrote: On Wed,  8 May 2019 17:48:06 -0500 Erik Gabriel Carrillo mailto:erik.g.carri...@intel.com>> wrote: > Due to an upcoming fix to allow the timer li

Re: [dpdk-dev] [PATCH v3] app/test: replace TEST_SKIPPED with -ENOTSUP

Hi Ayuj, Could you please address Thomas's comment? We need to close RC4 today, if it is not getting closed today, we may need to defer it for next release. Thanks, Akhil > -Original Message- > From: Thomas Monjalon > Sent: Sunday, May 5, 2019 2:25 AM > To: Ayuj Verma > Cc: dev@dpdk.o

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

Hi Fiona/Shally, Can we get a closure on this patch by today EOD(We are closing tree for RC4 today). Thomas will pick this patch directly on master. Thanks, Akhil > -Original Message- > From: Trahe, Fiona > Sent: Wednesday, May 8, 2019 7:31 PM > To: Shally Verma ; dev@dpdk.org > Cc: Ak

Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids

On 19/04/2019 10:22, Rahul Lakkireddy wrote: > Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards") > Cc: sta...@dpdk.org > Hi Rahul, Which stable release(s) is this change requested for? Have you tested these devices on those branches to ensure they work with the cxgbe pmd on

Re: [dpdk-dev] Shared library build is unable to parse device

On Wed, May 08, 2019 at 08:24:35AM +, Rik Huijzer wrote: > Hi, > > Amazed by the reported processing speed of DPDK, I'm trying to use DPDK as a > shared library. Running the rxtx_callbacks (and possibly other) example(s) it > exits on `unable to parse device` when enabling CONFIG_RTE_BUILD_S

Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice

> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, May 8, 2019 1:53 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Akhil Goyal ; Trahe, Fiona ; > Anoob Joseph > Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice > > > > > -Original Message---

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On Thu, May 09, 2019 at 09:33:32AM +0100, Burakov, Anatoly wrote: > On 09-May-19 8:05 AM, David Marchand wrote: > > On Thu, May 9, 2019 at 3:11 AM Stephen Hemminger > > mailto:step...@networkplumber.org>> wrote: > > > > On Wed,  8 May 2019 17:48:06 -0500 > > Erik Gabriel Carrillo >

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

09/05/2019 11:37, Burakov, Anatoly: > On 09-May-19 10:06 AM, Bruce Richardson wrote: > > On Thu, May 09, 2019 at 09:33:32AM +0100, Burakov, Anatoly wrote: > >> On 09-May-19 8:05 AM, David Marchand wrote: > >>> On Thu, May 9, 2019 at 3:11 AM Stephen Hemminger > >>> mailto:step...@networkplumber.org>

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On 09-May-19 10:06 AM, Bruce Richardson wrote: On Thu, May 09, 2019 at 09:33:32AM +0100, Burakov, Anatoly wrote: On 09-May-19 8:05 AM, David Marchand wrote: On Thu, May 9, 2019 at 3:11 AM Stephen Hemminger mailto:step...@networkplumber.org>> wrote: On Wed,  8 May 2019 17:48:06 -0500

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On 09/05/2019 10:38, Thomas Monjalon wrote: > 09/05/2019 11:37, Burakov, Anatoly: >> On 09-May-19 10:06 AM, Bruce Richardson wrote: >>> On Thu, May 09, 2019 at 09:33:32AM +0100, Burakov, Anatoly wrote: On 09-May-19 8:05 AM, David Marchand wrote: > On Thu, May 9, 2019 at 3:11 AM Stephen

Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids

On Thursday, May 05/09/19, 2019 at 14:29:05 +0530, Kevin Traynor wrote: > On 19/04/2019 10:22, Rahul Lakkireddy wrote: > > Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards") > > Cc: sta...@dpdk.org > > > > Hi Rahul, > > Which stable release(s) is this change requested for? Ha

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On 09-May-19 10:50 AM, Ray Kinsella wrote: On 09/05/2019 10:38, Thomas Monjalon wrote: 09/05/2019 11:37, Burakov, Anatoly: On 09-May-19 10:06 AM, Bruce Richardson wrote: On Thu, May 09, 2019 at 09:33:32AM +0100, Burakov, Anatoly wrote: On 09-May-19 8:05 AM, David Marchand wrote: On Thu, Ma

[dpdk-dev] DPDK Release Status Meeting 9/5/2019

Minutes 9 May 2019 -- Agenda: * Release Dates * RC3 status * Subtrees * OvS * Conferences * Opens Participants: * Arm * Debian/Microsoft * Intel * Mellanox * RedHat Release Dates - * v19.05 dates: * RC3 is released on Saturday, 4 May * RC4 date pushed to: *Thur

Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids

On 09/05/2019 11:03, Rahul Lakkireddy wrote: > On Thursday, May 05/09/19, 2019 at 14:29:05 +0530, Kevin Traynor wrote: >> On 19/04/2019 10:22, Rahul Lakkireddy wrote: >>> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards") >>> Cc: sta...@dpdk.org >>> >> >> Hi Rahul, >> >> Which s

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

HI Fiona > -Original Message- > From: Fiona Trahe > Sent: Tuesday, April 9, 2019 8:26 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; > lee.d...@intel.com; Sunila Sahu ; Shally Verma > ; Fiona Trahe ; > sta...@dpdk.org > Subject: [PATCH v2] doc/compress: clarify error hand

[dpdk-dev] [PATCH] eventdev: fix Rx adapter event flush logic

The Rx adapter flushes events only if it has BATCH_SIZE events buffered where BATCH_SIZE is set to 32, e.g., if a single packet is sent, it is never passed to eventdev. Fix this issue by adding an event buffer flush either when a Rx queue is found to be empty or the adapter service function has pro

[dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_19_05.rst | 188 + 1 file changed, 188 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index 5044ac7..25fe88d 100644 --- a/doc/guides/rel_n

Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids

On Thursday, May 05/09/19, 2019 at 16:08:05 +0530, Kevin Traynor wrote: > On 09/05/2019 11:03, Rahul Lakkireddy wrote: > > On Thursday, May 05/09/19, 2019 at 14:29:05 +0530, Kevin Traynor wrote: > >> On 19/04/2019 10:22, Rahul Lakkireddy wrote: > >>> Fixes: 04868e5bfddd ("net/cxgbe: add support to

[dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush logic

The Rx adapter flushes events only if it has BATCH_SIZE events buffered where BATCH_SIZE is set to 32, e.g., if a single packet is sent, it is never passed to eventdev. Fix this issue by adding an event buffer flush either when a Rx queue is found to be empty or the adapter service function has pro

Re: [dpdk-dev] [PATCH v3] app/test: replace TEST_SKIPPED with -ENOTSUP

Hi Akhil, Sorry for delay. I have sent v4 for this. Thanks for the heads up. Regards Ayuj Verma From: Akhil Goyal Sent: 09 May 2019 14:23:25 To: Ayuj Verma Cc: dev@dpdk.org; arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com; Shally Verma; Sunila Sahu; Ka

Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Elo, Matias (Nokia - > FI/Espoo) > Sent: Tuesday, May 7, 2019 5:33 PM > To: Mattias Rönnblom > Cc: Honnappa Nagarahalli ; > dev@dpdk.org; nd > Subject: Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] hash: fix bugs in 'free key with position'

09/05/2019 12:40, 胡林帆: > This bug makes 'lock free reader/writer concurrency hash' unusable. > There are two reasons: > 1] memory leak because we cannot free keys which indexes greater than the > number of total entries > > 2] the ring of free_slots may have unexpected key conflict with in use on

[dpdk-dev] [PATCH v4] app/test: replace TEST_SKIPPED with -ENOTSUP

Currently some tests return TEST_SKIPPED/-1 when tests or params are not supported for particular PMD because of which tests adds to FAILED test counter in place of Skipped/Unsupported counter. Since unsupported test is not a failure case, replace return value TEST_SKIPPED/-1 with -ENOTSUP - Retu

[dpdk-dev] [PATCH v4] fix return value for skipped tests

Currently some tests return TEST_SKIPPED/-1 when tests or params are not supported for particular PMD because of which tests adds to FAILED test counter in place of Skipped/Unsupported counter. Since unsupported test is not a failure case, replace return value TEST_SKIPPED/-1 with -ENOTSUP Change

Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice

> -Original Message- > From: dev On Behalf Of Arek Kusztal > Sent: Wednesday, April 17, 2019 1:11 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; > pablo.de.lara.gua...@intel.com; Arek Kusztal > > Subject: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation

Re: [dpdk-dev] [PATCH] timer: allow first subsystem init from secondary

On 08-May-19 11:17 PM, Erik Gabriel Carrillo wrote: Since memzones can be reserved from secondary processes as well as primary processes, if the first call to the timer subsystem init function occurs in a secondary process, we should allow it to succeed. Fixes: c0749f7096c7 ("timer: allow manage

Re: [dpdk-dev] [PATCH v2] ipc: unlock on failure

On 06-May-19 2:48 PM, Aaron Conole wrote: Reported by Coverity. Maybe have a more descriptive commit message? Fixes: a2a06860b8c4 ("ipc: fix memory leak on request failure") Cc: Herakliusz Lipiec Cc: sta...@dpdk.org Cc: Anatoly Burakov Signed-off-by: Aaron Conole --- Acked-by: Anatoly B

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On 08-May-19 11:48 PM, Erik Gabriel Carrillo wrote: Due to an upcoming fix to allow the timer library to safely free its allocations during the finalize() call[1], an ABI change will be required. A new lock will be added to the rte_mem_config structure, which will be used by the timer library to

Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids

On 09/05/2019 12:11, Rahul Lakkireddy wrote: > On Thursday, May 05/09/19, 2019 at 16:08:05 +0530, Kevin Traynor wrote: >> On 09/05/2019 11:03, Rahul Lakkireddy wrote: >>> On Thursday, May 05/09/19, 2019 at 14:29:05 +0530, Kevin Traynor wrote: On 19/04/2019 10:22, Rahul Lakkireddy wrote: >

Re: [dpdk-dev] [EXT] Re: [PATCH] ipsec: include high order bytes of esn in pkt len

> >> > >> When esn is used then high-order 32 bits are included in ICV > >> calculation however are not transmitted. Update packet length > >> to be consistent with auth data offset and length before crypto > >> operation. High-order 32 bits of esn will be removed from packet > >> length in crypt

Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances

On 08-May-19 12:15 PM, Thomas Monjalon wrote: 24/04/2018 08:41, Arnon Warshavsky: The purpose of this patch series is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly teardown or o

Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids

On Thursday, May 05/09/19, 2019 at 17:25:56 +0530, Kevin Traynor wrote: > On 09/05/2019 12:11, Rahul Lakkireddy wrote: > > On Thursday, May 05/09/19, 2019 at 16:08:05 +0530, Kevin Traynor wrote: > >> On 09/05/2019 11:03, Rahul Lakkireddy wrote: > >>> On Thursday, May 05/09/19, 2019 at 14:29:05 +053

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] hash: fix bugs in 'free key with position'

> On May 9, 2019, at 6:25 AM, Thomas Monjalon wrote: > > 09/05/2019 12:40, 胡林帆: >> This bug makes 'lock free reader/writer concurrency hash' unusable. >> There are two reasons: >> 1] memory leak because we cannot free keys which indexes greater than the >> number of total entries >> >> 2] the r

Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances

09/05/2019 14:05, Burakov, Anatoly: > On 08-May-19 12:15 PM, Thomas Monjalon wrote: > > 24/04/2018 08:41, Arnon Warshavsky: > >> The purpose of this patch series is to cleanup the library code > >> from paths that end up aborting the process, > >> and move to checking error values, in order to allo

Re: [dpdk-dev] [PATCH] ipsec: fix missing ipsec headers after install

08/05/2019 14:22, Bruce Richardson: > On Wed, May 08, 2019 at 02:12:12PM +0200, Marcin Smoczynski wrote: > > Invalid statement is used to indicate header files to install. > > > > Fixed the statement and reformatted recipe file. > > > > Signed-off-by: Marcin Smoczynski > > Acked-by: Bruce Richa

Re: [dpdk-dev] [PATCH] net/virtio: remove useless check on mempool

On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote: This .rx_queue_setup devop is called after ethdev already dereferenced the mempool pointer. No need to check and we can remove this rte_exit. Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper place") Cc: sta...@d

[dpdk-dev] [PATCH v3 0/3] hash: fix bugs in 'free key with position'

This patch series solves 2 bugs reported on Bugzilla (bug-261) within the function rte_hash_free_key_with_postion(). It also adds a test case to catch similar bugs in the future. https://bugs.dpdk.org/show_bug.cgi?id=261 --- v3: * Split the patch and update commit logs (Thomas) v2: * Add commen

[dpdk-dev] [PATCH v3 1/3] hash: fix position bug in 'free key with position'

Currently, in rte_hash_free_key_with_position(), the position returned to the ring of free_slots leads to an unexpected conflict with a key already in use. This patch fixes incorrect position returned to the ring of free_slots. Bugzilla ID: 261 Fixes: 9d033dac7d7c ("hash: support no free on delet

[dpdk-dev] [PATCH v3 2/3] hash: fix total entries in free key with position

In rte_hash, with current implementation, it is possible that keys are stored at indexes greater than the number of total entries. Currently, in rte_hash_free_key_with_position(), due to incorrect computation of total_entries, application cannot free keys with indexes greater than the number of to

[dpdk-dev] [PATCH v3 3/3] test/hash: add test for 'free key with position'

This patch adds a unit test for rte_hash_free_key_with_position(). Suggested-by: Linfan Signed-off-by: Dharmik Thakkar --- app/test/test_hash.c | 94 1 file changed, 94 insertions(+) diff --git a/app/test/test_hash.c b/app/test/test_hash.c index 390

Re: [dpdk-dev] [PATCH v4] app/test: replace TEST_SKIPPED with -ENOTSUP

09/05/2019 13:23, Ayuj Verma: > Currently some tests return TEST_SKIPPED/-1 when tests or params > are not supported for particular PMD because of which tests adds to > FAILED test counter in place of Skipped/Unsupported counter. It looks to be a bug that TEST_SKIPPED is not caught to increment "s

Re: [dpdk-dev] [PATCH v2] ipc: unlock on failure

09/05/2019 13:50, Burakov, Anatoly: > On 06-May-19 2:48 PM, Aaron Conole wrote: > > Reported by Coverity. > > Maybe have a more descriptive commit message? > > > > > Fixes: a2a06860b8c4 ("ipc: fix memory leak on request failure") > > Cc: Herakliusz Lipiec > > Cc: sta...@dpdk.org > > Cc: Anatoly

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] doc: fix typo in ipc doc

03/05/2019 13:50, Anatoly Burakov: > The word "syncrhonous" appears twice. Fix it. [...] > --- a/doc/guides/prog_guide/multi_proc_support.rst > +++ b/doc/guides/prog_guide/multi_proc_support.rst > -For synchronous synchronous requests, the ``rte_mp_reply`` descriptor must > also > -be created. Thi

Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs

On 5/8/2019 9:54 PM, Thomas Monjalon wrote: > Two public functions from EAL and metrics libraries need to return > some new error codes instead of calling rte_panic or rte_exit. > > Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] ipc: add warnings about correct API usage

03/05/2019 13:50, Anatoly Burakov: > When handling synchronous or asynchronous requests, the reply > must be sent explicitly even if the result of the operation is > an error, to avoid the other side timing out. Make note of this > in documentation explicitly. > > Cc: sta...@dpdk.org > > Signed-o

Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching

Thanks, I’ve tested this patch and can confirm that it fixes the problem. I didn’t do any performance comparison but at least with high packet rate rte_eth_rx_burst() should already return close to BATCH_SIZE packets, so the performance hit shouldn’t be that big. -Matias On 9 May 2019, at 14:

Re: [dpdk-dev] [PATCH v2] doc: add Mellanox BlueField platform guide

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh > Sent: Thursday, May 9, 2019 12:39 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; jer...@marvell.com; shah...@mellanox.com; > honnappa.nagaraha...@arm.com > Subject: [dpdk-dev] [PATCH v2] doc: add

Re: [dpdk-dev] [PATCH 1/2] doc: add tested Intel platforms with Intel NICs

> -Original Message- > From: Tu, Lijuan > Sent: Monday, May 6, 2019 5:37 PM > To: dev@dpdk.org > Cc: Kovacevic, Marko ; Mcnamara, John > ; Tu, Lijuan > Subject: [PATCH 1/2] doc: add tested Intel platforms with Intel NICs > > Add tested Intel platforms with Intel NICs to v19.05 release

Re: [dpdk-dev] [PATCH v2] doc: remove redundant information from the guide

> -Original Message- > From: Varghese, Vipin > Sent: Monday, May 6, 2019 10:00 AM > To: dev@dpdk.org; Kovacevic, Marko ; Mcnamara, > John > Cc: Padubidri, Sanjay A ; Varghese, Vipin > > Subject: [PATCH v2] doc: remove redundant information from the guide > > Remove redundant informati

Re: [dpdk-dev] [PATCH 1/3] doc: fix typo in ipc doc

> -Original Message- > From: Burakov, Anatoly > Sent: Friday, May 3, 2019 12:51 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Kovacevic, Marko > ; sta...@dpdk.org > Subject: [PATCH 1/3] doc: fix typo in ipc doc > > The word "syncrhonous" appears twice. Fix it. Acked-by: John McNamara

Re: [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe > Sent: Friday, May 3, 2019 5:16 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; akhil.go...@nxp.com; Jozwiak, TomaszX > ; Trahe, Fiona > Subject: [dpdk-dev] [PATCH v2] doc: update release notes for

Re: [dpdk-dev] [PATCH 2/2] doc: update recommended versions for i40e

> -Original Message- > From: Tu, Lijuan > Sent: Monday, May 6, 2019 5:37 PM > To: dev@dpdk.org > Cc: Kovacevic, Marko ; Mcnamara, John > ; Tu, Lijuan > Subject: [PATCH 2/2] doc: update recommended versions for i40e > > add recommended DPDK/kernel driver/firmware version matching list f

Re: [dpdk-dev] [PATCH v3 1/3] hash: fix position bug in 'free key with position'

> -Original Message- > From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] > Sent: Thursday, May 9, 2019 6:39 AM > To: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce ; > De Lara Guarch, Pablo > Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; > zhongdahulin...@163.com; Dharmik Thak

Re: [dpdk-dev] [PATCH 1/3] doc: fix typo in ipc doc

09/05/2019 17:25, Mcnamara, John: > From: Burakov, Anatoly > > The word "syncrhonous" appears twice. Fix it. "synchronous" ;) Fixes: e2229e86 ("doc: add IPC guide") > Acked-by: John McNamara Series applied, thanks

Re: [dpdk-dev] [PATCH] test: call timer subsystem finalize at exit

06/05/2019 23:03, Erik Gabriel Carrillo: > The eal_flags_autotest checks that no hugepage map files are left behind > after a process exits, which can only be the case if all allocations made > from DPDK heaps were freed back to the freelist, resulting in the > hugepage map files being unlinked aut

[dpdk-dev] [PATCH v4 2/3] hash: fix total entries in free key with position

In rte_hash, with current implementation, it is possible that keys are stored at indexes greater than the number of total entries. Currently, in rte_hash_free_key_with_position(), due to incorrect computation of total_entries, application cannot free keys with indexes greater than the number of to

[dpdk-dev] [PATCH v4 3/3] test/hash: add test for 'free key with position'

This patch adds a unit test for rte_hash_free_key_with_position(). Suggested-by: Linfan Signed-off-by: Dharmik Thakkar --- app/test/test_hash.c | 94 1 file changed, 94 insertions(+) diff --git a/app/test/test_hash.c b/app/test/test_hash.c index 390

[dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position'

This patch series solves 2 bugs reported on Bugzilla (bug-261) within the function rte_hash_free_key_with_postion(). It also adds a test case to catch similar bugs in the future. https://bugs.dpdk.org/show_bug.cgi?id=261 --- v4: * Fix compilation failure (Yipeng) v3: * Split the patch and updat

[dpdk-dev] [PATCH v4 1/3] hash: fix position bug in 'free key with position'

Currently, in rte_hash_free_key_with_position(), the position returned to the ring of free_slots leads to an unexpected conflict with a key already in use. This patch fixes incorrect position returned to the ring of free_slots. Bugzilla ID: 261 Fixes: 9d033dac7d7c ("hash: support no free on delet

Re: [dpdk-dev] [PATCH v3 1/3] hash: fix position bug in 'free key with position'

> On May 9, 2019, at 10:48 AM, Wang, Yipeng1 wrote: > >> -Original Message- >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >> Sent: Thursday, May 9, 2019 6:39 AM >> To: Wang, Yipeng1 ; Gobriel, Sameh >> ; Richardson, Bruce ; >> De Lara Guarch, Pablo >> Cc: dev@dpdk.org; hon

Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode

On 4/24/2019 4:26 PM, Anatoly Burakov wrote: > In no-shconf mode, there is no need to clean runtime directory > because it's not created in the first place. > > Fixes: 0a529578f162 ("eal: clean up unused files on initialization") > > Signed-off-by: Anatoly Burakov Is this for 18.11.x LTS? cc'ed

Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode

On 5/9/2019 6:50 PM, Ferruh Yigit wrote: > On 4/24/2019 4:26 PM, Anatoly Burakov wrote: >> In no-shconf mode, there is no need to clean runtime directory >> because it's not created in the first place. >> >> Fixes: 0a529578f162 ("eal: clean up unused files on initialization") >> >> Signed-off-by: A

Re: [dpdk-dev] [PATCH v3 3/4] test: change memory barrier variables to uint64_t

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Christensen > Sent: Wednesday, May 8, 2019 10:03 PM > To: dev@dpdk.org > Cc: David Christensen > Subject: [dpdk-dev] [PATCH v3 3/4] test: change memory barrier variables to > uint64_t > > Memory barrier

Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode

On 09/05/2019 18:50, Ferruh Yigit wrote: > On 5/9/2019 6:50 PM, Ferruh Yigit wrote: >> On 4/24/2019 4:26 PM, Anatoly Burakov wrote: >>> In no-shconf mode, there is no need to clean runtime directory >>> because it's not created in the first place. >>> >>> Fixes: 0a529578f162 ("eal: clean up unused

Re: [dpdk-dev] [PATCH v2] power: fix coverity issue

03/05/2019 11:26, Hunt, David: > On 8/4/2019 5:19 PM, Liang Ma wrote: > > Fix the resource leaking issue > > > > Coverity issue: 337668 > > > > Fixes: b60fd5f8b1ce8f0a2c ("power: add bit for high frequency cores") > > Confirmed that this issue is resolved by testing on our internel > Coverity ser

[dpdk-dev] [PATCH v2] doc: add deprecation notice on EAL mem config

It is planned to make the rte_mem_config struct of the EAL private to remove it from the visible ABI. Add a notice to announce the intention. Signed-off-by: Erik Gabriel Carrillo --- changes in v2: - Original deprecation notice announced a change to the rte_mem_config struct that would break

Re: [dpdk-dev] [PATCH] power: fix struct cache line-alignment issues

05/05/2019 20:12, Mattias Rönnblom: > The ACPI and PState CPU frequency scaling drivers used the > __rte_cache_aligned attribute without including rte_memory.h, which > turns what looks as the declaration of a cache line-aligned struct > into a non-aligned struct declaration and the definition of a

Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface

23/04/2019 00:30, Thomas Monjalon: > 29/03/2019 11:22, Lukasz Krakowiak: > > Updated doc for JSON sample code related to vm_power_manager > > fifo interface: "command": "destroy", "command": "power". > > Corrected typo in doc vm_power_management.rst: 'json' instead > > of 'jason'. > > > > --- > >

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on timer lib cleanup

On Thu, 9 May 2019 11:08:30 +0100 "Burakov, Anatoly" wrote: > >>> If the community agrees that primary/secondary processes should always > >>> use the same DPDK version (regardless of static/dynamic builds etc.), > >>> then this problem would probably be solved. > >> > >> +1 to document that pr

[dpdk-dev] [dpdk-announce] CFP OPEN: DPDK Userspace, Bordeaux, Sept 19-20th

*New Venue for DPDK Userspace, * *LA CITE DU VIN* *Bordeaux, France* *September 19 - 20, 2019* *Call for Proposal is now open.* https://events.linuxfoundation.jp/events/dpdk-userspace-2019-bordeaux/program/call-for-proposals-cfp/ Call For Paper submissions must be received by 11:59pm PST on *Fri

Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush logic

09/05/2019 06:50, Nikhil Rao: > The Rx adapter flushes events only if it has BATCH_SIZE > events buffered where BATCH_SIZE is set to 32, e.g., if a > single packet is sent, it is never passed to > eventdev. Fix this issue by adding an event buffer flush > either when a Rx queue is found to be empty

Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush logic

On 2019-05-09 06:50, Nikhil Rao wrote: The Rx adapter flushes events only if it has BATCH_SIZE events buffered where BATCH_SIZE is set to 32, e.g., if a single packet is sent, it is never passed to eventdev. Fix this issue by adding an event buffer flush either when a Rx queue is found to be empt

Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position'

09/05/2019 19:19, Dharmik Thakkar: > This patch series solves 2 bugs reported on Bugzilla (bug-261) within > the function rte_hash_free_key_with_postion(). It also adds a test case > to catch similar bugs in the future. > > https://bugs.dpdk.org/show_bug.cgi?id=261 Yipeng, Sameh, should it enter

Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush logic

On 2019-05-09 21:17, Thomas Monjalon wrote: 09/05/2019 06:50, Nikhil Rao: The Rx adapter flushes events only if it has BATCH_SIZE events buffered where BATCH_SIZE is set to 32, e.g., if a single packet is sent, it is never passed to eventdev. Fix this issue by adding an event buffer flush either

Re: [dpdk-dev] [PATCH v4 1/3] hash: fix position bug in 'free key with position'

>-Original Message- >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >Sent: Thursday, May 9, 2019 10:19 AM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; zhongdahulin...@163.com; >Dharmik Thak

Re: [dpdk-dev] [PATCH v4 2/3] hash: fix total entries in free key with position

>-Original Message- >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >Sent: Thursday, May 9, 2019 10:19 AM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; zhongdahulin...@163.com; >Dharmik Thakkar

Re: [dpdk-dev] [PATCH v4 3/3] test/hash: add test for 'free key with position'

>-Original Message- >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >Sent: Thursday, May 9, 2019 10:19 AM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; zhongdahulin...@163.com; >Dharmik Thakkar

Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position'

>-Original Message- >From: Thomas Monjalon [mailto:tho...@monjalon.net] >Sent: Thursday, May 9, 2019 12:24 PM >To: Wang, Yipeng1 ; Gobriel, Sameh > >Cc: dev@dpdk.org; Dharmik Thakkar ; >honnappa.nagaraha...@arm.com; zhongdahulin...@163.com >Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix

[dpdk-dev] [PATCH v2] timer: allow first subsystem init from secondary

Since memzones can be reserved from secondary processes as well as primary processes, if the first call to the timer subsystem init function occurs in a secondary process, we should allow it to succeed. Fixes: c0749f7096c7 ("timer: allow management in shared memory") Signed-off-by: Erik Gabriel C

Re: [dpdk-dev] [PATCH] timer: allow first subsystem init from secondary

<...snipped...> > > > > @@ -155,40 +156,41 @@ rte_timer_subsystem_init_v1905(void) > > struct rte_timer_data *data; > > int i, lcore_id; > > static const char *mz_name = "rte_timer_mz"; > > + const size_t data_arr_size = > > + RTE_MAX_DATA_ELS * > sizeof(*rt

Re: [dpdk-dev] [PATCH v2] timer: allow first subsystem init from secondary

09/05/2019 21:39, Erik Gabriel Carrillo: > Since memzones can be reserved from secondary processes as well as > primary processes, if the first call to the timer subsystem init > function occurs in a secondary process, we should allow it to succeed. > > Fixes: c0749f7096c7 ("timer: allow managemen

Re: [dpdk-dev] [PATCH v3 1/4] test: fix typo in print statement

09/05/2019 09:46, Thomas Monjalon: > 09/05/2019 00:50, David Christensen: > > > It seems your emails are not threaded at all. > > > It makes really hard to review them. > > > All patches of a patchset must be in the same thread, > > > ideally with a cover letter. > > > All versions of a patchset mu

[dpdk-dev] [dpdk-stable] [PATCH v2 1/2] hash: fix bugs in 'free key with position'

This bug makes 'lock free reader/writer concurrency hash' unusable. There are two reasons: 1] memory leak because we cannot free keys which indexes greater than the number of total entries 2] the ring of free_slots may have unexpected key conflict with in use one The patch fixes these 2 issue

Re: [dpdk-dev] [PATCH v2] timer: allow first subsystem init from secondary

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, May 9, 2019 2:52 PM > To: Carrillo, Erik G > Cc: Burakov, Anatoly ; rsanf...@akamai.com; > dev@dpdk.org > Subject: Re: [PATCH v2] timer: allow first subsystem init from secondary > > 09/05/2019 21:

Re: [dpdk-dev] [PATCH v2] timer: allow first subsystem init from secondary

09/05/2019 22:08, Carrillo, Erik G: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 09/05/2019 21:39, Erik Gabriel Carrillo: > > > Since memzones can be reserved from secondary processes as well as > > > primary processes, if the first call to the timer subsystem init > > > function occurs

Re: [dpdk-dev] [PATCH v4 1/3] hash: fix position bug in 'free key with position'

> On May 9, 2019, at 2:27 PM, Wang, Yipeng1 wrote: > > > >> -Original Message- >> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >> Sent: Thursday, May 9, 2019 10:19 AM >> To: Wang, Yipeng1 ; Gobriel, Sameh >> ; Richardson, Bruce >> ; De Lara Guarch, Pablo >> >> Cc: dev@dp

  1   2   >