There is no need to do such a check when set macsec for ixgbe, reconfig_device_queueand is also useless. If ew do not delete this unnessarycode, users have to sotp port before enable macsec, then restart this port after make configuration. All these process is useless. As this cmdline is a private API only use by ixgbe NIC, so remove it.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao <wei.zh...@intel.com> --- app/test-pmd/cmdline.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index c1042dd..b969745 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed( if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - if (!port_is_stopped(port_id)) { - printf("Please stop port %d first\n", port_id); - return; - } rte_eth_dev_info_get(port_id, &dev_info); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) { @@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed( case 0: ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MACSEC_INSERT; - cmd_reconfig_device_queue(port_id, 1, 1); break; case -ENODEV: printf("invalid port_id %d\n", port_id); -- 2.7.5