>-----Original Message----- >From: Thomas Monjalon [mailto:tho...@monjalon.net] >Sent: Thursday, May 9, 2019 12:24 PM >To: Wang, Yipeng1 <yipeng1.w...@intel.com>; Gobriel, Sameh ><sameh.gobr...@intel.com> >Cc: dev@dpdk.org; Dharmik Thakkar <dharmik.thak...@arm.com>; >honnappa.nagaraha...@arm.com; zhongdahulin...@163.com >Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with >position' > >09/05/2019 19:19, Dharmik Thakkar: >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within >> the function rte_hash_free_key_with_postion(). It also adds a test case >> to catch similar bugs in the future. >> >> https://bugs.dpdk.org/show_bug.cgi?id=261 > >Yipeng, Sameh, should it enter in 19.05-rc4? >Are you sure it does not break things more? >If yes, please give your ack. [Wang, Yipeng] Please go ahead Thomas, I reviewed the code and it will not break other things. The changes are refrained inside an experimental API function.
I haven't done the meson build test though.
