> -----Original Message----- > From: Nikhil Rao <nikhil....@intel.com> > Sent: Thursday, May 9, 2019 5:27 AM > To: Jerin Jacob Kollanukkaran <jer...@marvell.com> > Cc: dev@dpdk.org; Nikhil Rao <nikhil....@intel.com> > Subject: [EXT] [RFC] eventdev: replace mbufs with events in Rx callback > > Replace the mbuf pointer array in the event eth Rx adapter callback with an > event array instead of an mbuf array. Using an event array allows the > application to change attributes of the events enqueued by the SW adapter.
Looks good to me. If I understand it correctly, It is applicable only to SW adapter. If not, let us know. Please remove the EXPERIMENTAL tag after the change. > Signed-off-by: Nikhil Rao <nikhil....@intel.com> > --- > > Hi All, > > Please review the new interface proposed below. > > lib/librte_eventdev/rte_event_eth_rx_adapter.h | 57 +++++++++++++++-- > --------- > 1 file changed, 34 insertions(+), 23 deletions(-) > > > + * Packets dropped by callback. > * @return > - * Returns the number of mbufs should be enqueued to eventdev > + * - The number of events to be enqueued by the SW adapter. > */ > typedef uint16_t (*rte_event_eth_rx_adapter_cb_fn)(uint16_t > eth_dev_id, > uint16_t queue_id, > uint32_t enqueue_buf_size, > uint32_t > enqueue_buf_count, > - struct rte_mbuf **mbuf, > - uint16_t nb_mbuf, > + struct rte_event *ev, > + uint16_t nb_event, > void *cb_arg, > - struct rte_mbuf **enq_buf); > + uint16_t *nb_dropped); > > /** > * @warning > -- > 1.8.3.1
