Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL

2017-01-08 Thread Rosen, Rami
Hi, ... ... diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 2206277..2c223de 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c ... +/* Scan all the buses for registering devices */ int +rte_eal_bus_scan(void) +{ + int re

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-08 Thread Ananyev, Konstantin
Hi Adrien, > > Hi Konstantin, > > On Thu, Jan 05, 2017 at 11:32:38AM +, Ananyev, Konstantin wrote: > > Hi Adrien, > > > > > > > > On Thu, Jan 05, 2017 at 07:56:08AM +0800, Tiwei Bie wrote: > > > > On Thu, Jan 05, 2017 at 01:44:18AM +0800, Ananyev, Konstantin wrote: > > > > [...] > > > > > >

[dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-08 Thread george . dit
Hi, I have a simple setup with a machine that contains a dual port 10 GbE Intel 82599ES NIC and another dual port 100 GbE Mellanox ConnectX-4 NIC. The Intel ports are 0 and 1, while the Mellanox ones are 2 and 3. I properly compiled DPDK 16.11 and test-pmd works just fine for all 4 ports. Then, I

Re: [dpdk-dev] A question

2017-01-08 Thread Zhang, Helin
Hi Kanani Within around one year, we have implemented input set to reconfigure some registers to select which field to be used for hash calculation. So I think it should work quite better now with using X710 or XL710. What’s your issue here? Could you help to have a try and tell me the real issu

[dpdk-dev] [PATCH 1/5] net/mlx5: last WQE no room inline

2017-01-08 Thread Elad Persiko
Prior to this patch, when sending a packet and the following conditions were reached: 1. last working queue element is used. 2. inline was requested by the user 3. no room for inline packet. then the inline request was ignored and the packet was sent by pointer completely.

[dpdk-dev] [PATCH 5/5] doc: add tso capabilities feature for mlx5

2017-01-08 Thread Elad Persiko
Feature implemented at: b007e98ccda9 ("net/mlx5: implement TSO data path") 085c4137280a ("net/mlx5: support TSO in control plane") Signed-off-by: Elad Persiko --- doc/guides/nics/features/mlx4.ini | 1 + doc/guides/nics/features/mlx5.ini | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/

[dpdk-dev] [PATCH 2/5] net/mlx5: remove unessecary goto label

2017-01-08 Thread Elad Persiko
use_dseg label can be deleted as it happens without goto. Signed-off-by: Elad Persiko --- drivers/net/mlx5/mlx5_rxtx.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index be38aed..1560530

[dpdk-dev] [PATCH 3/5] net/mlx5: support TSO in control plane

2017-01-08 Thread Elad Persiko
Signed-off-by: Elad Persiko --- doc/guides/nics/mlx5.rst| 6 ++ drivers/net/mlx5/mlx5.c | 17 - drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_txq.c | 4 +++- 4 files changed, 26 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/gu

[dpdk-dev] [PATCH 4/5] net/mlx5: implement TSO data path

2017-01-08 Thread Elad Persiko
Signed-off-by: Elad Persiko --- drivers/net/mlx5/mlx5_ethdev.c | 2 + drivers/net/mlx5/mlx5_rxtx.c | 246 +++-- 2 files changed, 187 insertions(+), 61 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index fbb1b65..

[dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5

2017-01-08 Thread Elad Persiko
Feature implemented at: commit b007e98ccda9 ("net/mlx5: implement TSO data path") commit 085c4137280a ("net/mlx5: support TSO in control plane") Signed-off-by: Elad Persiko --- doc/guides/nics/features/mlx4.ini | 1 + doc/guides/nics/features/mlx5.ini | 1 + 2 files changed, 2 insertions(+) dif

Re: [dpdk-dev] [PATCH v5 2/5] net/e1000: add firmware version get

2017-01-08 Thread Stephen Hemminger
On Sun, 8 Jan 2017 12:11:32 +0800 Qiming Yang wrote: > + switch (hw->mac.type) { > + case e1000_i210: > + case e1000_i211: > + if (!(e1000_get_flash_presence_i210(hw))) { > + snprintf(fw_version, fw_length, > + "%2d.%2d-%d"

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-08 Thread Stephen Hemminger
On Sun, 8 Jan 2017 12:11:31 +0800 Qiming Yang wrote: > void > +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int fw_length) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_RET(port_id); > + dev = &rte_eth_devices[port_id]; > + > + RTE_FUNC_PTR_O

Re: [dpdk-dev] [PATCH v5 4/5] net/i40e: add firmware version get

2017-01-08 Thread Stephen Hemminger
On Sun, 8 Jan 2017 12:11:34 +0800 Qiming Yang wrote: > static void > +i40e_fw_version_get(struct rte_eth_dev *dev, char *fw_version, int fw_length) > +{ > + struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + > + snprintf(fw_version, fw_length, > + "%d.

Re: [dpdk-dev] [PATCH v5 5/5] ethtool: display firmware version

2017-01-08 Thread Stephen Hemminger
On Sun, 8 Jan 2017 12:11:35 +0800 Qiming Yang wrote: > --- a/examples/ethtool/lib/rte_ethtool.c > +++ b/examples/ethtool/lib/rte_ethtool.c > @@ -54,6 +54,9 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct > ethtool_drvinfo *drvinfo) > > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV

Re: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process

2017-01-08 Thread Stephen Hemminger
On Fri, 6 Jan 2017 18:16:16 +0800 Yuanhan Liu wrote: > If the primary enables the vector Rx/Tx path, the current code would > let the secondary always choose the non vector Rx/Tx path. This results > to a Rx/Tx method mismatch between primary and secondary process. Werid > errors then may happen

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: check vlan and mpls params

2017-01-08 Thread Stephen Hemminger
On Fri, 6 Jan 2017 17:21:46 + "Jyoti, Anand B" wrote: > + > + /* Max MPLS label value 20 bits */ > + for (i = 0; i < data->l2.mpls.n_labels; i++) What ever editor or mail system you are using is putting a unicode space in that statement, not visible

Re: [dpdk-dev] [PATCH v7 14/27] net/i40e: set VF VLAN insertion from PF

2017-01-08 Thread Lu, Wenzhuo
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Friday, January 6, 2017 7:29 PM > To: Lu, Wenzhuo; Wu, Jingjing; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v7 14/27] net/i40e: set VF VLAN insertion from > PF > > Hi Jinqjing, Wenzhuo, > > > -Original Message--

Re: [dpdk-dev] [PATCH v5 2/5] net/e1000: add firmware version get

2017-01-08 Thread Yang, Qiming
-Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Monday, January 9, 2017 7:04 AM To: Yang, Qiming Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Helin ; Horton, Remy Subject: Re: [dpdk-dev] [PATCH v5 2/5] net/e1000: add firmware version get On Sun, 8 Ja

Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.

2017-01-08 Thread nickcooper-zhangtonghao
> On Jan 6, 2017, at 8:01 AM, Yong Wang wrote: > > Can you add the exact steps to reproduce the vmxnet3 issues to help the > review and the verification. My guess is that you have stopped the device, > changed some ring parameters (to something larger than the previous settings) > and restart

Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.

2017-01-08 Thread nickcooper-zhangtonghao
Thanks for your reply. The patch you submitted is better. Thanks for your improvement. My legal name is “Nick Zhang”. So, Signed-off-by: Nick Zhang Thanks. Nick > On Jan 6, 2017, at 12:26 AM, Stephen Hemminger > wrote: > > It is good to see more checking for valid values. I suspect that

Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.

2017-01-08 Thread nickcooper-zhangtonghao
I submitted the patches for first time. The first one is an individual patch for eal, others is for vmxnet3 interdependently. Thanks. Nick > On Jan 5, 2017, at 10:23 PM, Ferruh Yigit wrote: > > Hi nickcooper-zhangtonghao, > > The patches in the patchset are individual patches, right? Is the

[dpdk-dev] [PATCH v3 1/4] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup.

2017-01-08 Thread Nick Zhang
This patch will check the "nb_desc" parameter for rx queue. Rx vmxnet rings length should be between 128-4096. The patch will release the rxq and re-allocation it soon for different "nb_desc". Signed-off-by: Nick Zhang --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 30 ++ 1

[dpdk-dev] [PATCH v3 2/4] vmxnet3: Avoid segfault caused by vmxnet3_dev_rx_queue_setup.

2017-01-08 Thread Nick Zhang
When we config RX queue with 2048 RX queue size, and stop the device, changed queue size to 4096 and then start the device, there will be segment fault. We should allocate RX ring for max possible number of hardware descriptors. Signed-off-by: Nick Zhang --- drivers/net/vmxnet3/vmxnet3_rxtx.c |

[dpdk-dev] [PATCH v3 4/4] vmxnet3: Avoid segfault caused by vmxnet3_dev_tx_queue_setup.

2017-01-08 Thread Nick Zhang
When we config TX queue with 2048 TX queue size, stop the device, changed queue size to 4096 and then start the device, there will be segment fault. We should allocate TX ring for max possible number of hardware descriptors. Signed-off-by: Nick Zhang --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 7 ++

[dpdk-dev] [PATCH v3 3/4] vmxnet3: Avoid memory leak in vmxnet3_dev_tx_queue_setup.

2017-01-08 Thread Nick Zhang
This patch will check the "nb_desc" parameter for tx queue. Tx vmxnet rings length should be between 512-4096. The patch will release the txq and re-allocation it soon for different "nb_desc". Signed-off-by: Nick Zhang --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 32 +++-

[dpdk-dev] [PATCH] net/i40e: fix segment num in reassemble process

2017-01-08 Thread Chenghu Yao
When freeing up last mbuf, start->nb_segs should be decremented by one. See also ixgbe process. Signed-off-by: Chenghu Yao --- drivers/net/i40e/i40e_rxtx_vec_common.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_com

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-08 Thread Tiwei Bie
On Sun, Jan 08, 2017 at 08:39:55PM +0800, Ananyev, Konstantin wrote: > Hi Adrien, > > > > > Hi Konstantin, > > > > On Thu, Jan 05, 2017 at 11:32:38AM +, Ananyev, Konstantin wrote: > > > Hi Adrien, > > > > > > > > > > > On Thu, Jan 05, 2017 at 07:56:08AM +0800, Tiwei Bie wrote: > > > > > On T

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-08 Thread Jason Wang
On 2016年12月23日 15:14, Jianfeng Tan wrote: This patch add support vhost kernel as the backend for virtio_user. Three main hook functions are added: - vhost_kernel_setup() to open char device, each vq pair needs one vhostfd; - vhost_kernel_ioctl() to communicate control messages with v

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-08 Thread Jason Wang
On 2017年01月04日 15:22, Tan, Jianfeng wrote: Sorry, I forget to reply this comment. On 12/26/2016 3:44 PM, Yuanhan Liu wrote: [...] + +/* Does not work when VIRTIO_F_IOMMU_PLATFORM now, why? */ Because this feature need the vhost IOTLB support from the device emulation. Patches for QEMU

[dpdk-dev] [PATCH v2] examples/ip_pipeline: check VLAN and MPLS params

2017-01-08 Thread Jyoti, Anand B
This commit add to CLI command check for the following errors 1. SVLAN and CVLAN IDs greater than 12 bits 2. MPLS ID greater than 20 bits 3. max number of supported MPLS labels to avoid array overflow It prevents running CLI commands with invalid parameters. Signed-off-by: Anand B Jyoti Acked-by

Re: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process

2017-01-08 Thread Yuanhan Liu
On Sun, Jan 08, 2017 at 03:15:00PM -0800, Stephen Hemminger wrote: > On Fri, 6 Jan 2017 18:16:16 +0800 > Yuanhan Liu wrote: > > > If the primary enables the vector Rx/Tx path, the current code would > > let the secondary always choose the non vector Rx/Tx path. This results > > to a Rx/Tx method

Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2017-01-08 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Tuesday, January 3, 2017 4:41 AM > To: Wang, Zhihong ; Ravi Kerur > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp > functions > > 2016-06-07 11:09, Wang, Zhiho

Re: [dpdk-dev] [PATCH v5 01/12] eal/bus: introduce bus abstraction

2017-01-08 Thread Shreyansh Jain
On Friday 06 January 2017 08:25 PM, Thomas Monjalon wrote: 2017-01-06 16:01, Shreyansh Jain: On Wednesday 04 January 2017 03:22 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: +/** + * A structure describing a generic bus. + */ +struct rte_bus { + TAILQ_ENTRY(rte_bus) next;

Re: [dpdk-dev] [PATCH v5 05/12] eal: add probe and remove support for rte_driver

2017-01-08 Thread Shreyansh Jain
On Friday 06 January 2017 08:56 PM, Thomas Monjalon wrote: 2017-01-06 17:14, Shreyansh Jain: On Wednesday 04 January 2017 03:35 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -152,6 +16

Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL

2017-01-08 Thread Shreyansh Jain
Hello, On Sunday 08 January 2017 05:51 PM, Rosen, Rami wrote: Hi, diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 2206277..2c223de 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c +/* Scan all the buses for

Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL

2017-01-08 Thread Shreyansh Jain
On Friday 06 January 2017 07:16 PM, Thomas Monjalon wrote: 2017-01-06 17:30, Shreyansh Jain: On Friday 06 January 2017 04:08 PM, Shreyansh Jain wrote: On Wednesday 04 January 2017 03:16 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/

Re: [dpdk-dev] [PATCH] doc: add known issue for uio_pci_generic in XL710

2017-01-08 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Friday, December 23, 2016 10:35 AM > To: Zhang, Helin ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH] doc: add known issue for uio_pci_generic in XL710 > > When bind with uio_pci_generic in XL710, the result is failed. > uio_

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-08 Thread Yang, Qiming
-Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Monday, January 9, 2017 7:05 AM To: Yang, Qiming Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Helin ; Horton, Remy Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get On Sun, 8 Jan 201

[dpdk-dev] [PATCH v4] ethdev: fix port data mismatched in multiple process model

2017-01-08 Thread Yuanhan Liu
Assume we have two virtio ports, 00:03.0 and 00:04.0. The first one is managed by the kernel driver, while the later one is managed by DPDK. Now we start the primary process. 00:03.0 will be skipped by DPDK virtio PMD driver (since it's being used by the kernel). 00:04.0 would be successfully init