-----Original Message-----
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Monday, January 9, 2017 7:04 AM
To: Yang, Qiming <qiming.y...@intel.com>
Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yi...@intel.com>; Zhang, Helin
<helin.zh...@intel.com>; Horton, Remy <remy.hor...@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 2/5] net/e1000: add firmware version get
On Sun, 8 Jan 2017 12:11:32 +0800
Qiming Yang <qiming.y...@intel.com> wrote:
> + switch (hw->mac.type) {
> + case e1000_i210:
> + case e1000_i211:
> + if (!(e1000_get_flash_presence_i210(hw))) {
> + snprintf(fw_version, fw_length,
> + "%2d.%2d-%d",
> + fw.invm_major, fw.invm_minor,
> + fw.invm_img_type);
> + break;
> + }
> + /* fall through */
> + default:
> + /* if option rom is valid, display its version too*/
> + if (fw.or_valid) {
> + snprintf(fw_version, fw_length,
> + "%d.%d, 0x%08x, %d.%d.%d",
> + fw.eep_major, fw.eep_minor, fw.etrack_id,
> + fw.or_major, fw.or_build, fw.or_patch);
> + /* no option rom */
> + } else {
> + if (fw.etrack_id != 0X0000) {
> + snprintf(fw_version, fw_length,
> + "%d.%d, 0x%08x",
> + fw.eep_major, fw.eep_minor, fw.etrack_id);
> + } else {
> + snprintf(fw_version, fw_length,
> + "%d.%d.%d",
> + fw.eep_major, fw.eep_minor, fw.eep_build);
Indentation is incorrect here.
Qiming: my mistake.
