Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL

[Shreyansh Jain]

Hello,

On Sunday 08 January 2017 05:51 PM, Rosen, Rami wrote:

Hi,
....
....

diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c 
index 2206277..2c223de 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
....

+/* Scan all the buses for registering devices */ int
+rte_eal_bus_scan(void)
+{
+       int ret;
+       struct rte_bus *bus = NULL;
+
+       TAILQ_FOREACH(bus, &rte_bus_list, next) {
+               ret = bus->scan(bus);
+               if (ret) {
+                       RTE_LOG(ERR, EAL, "Scan for (%s) bus failed.\n",
+                               bus->name);
+                       /* TODO: Should error on a particular bus block scan
+                        * for all others?
+                        */
+                       return ret;
+               }
+       }
+
+       return 0;
+}
+

Nitpick - the return type of rte_eal_bus_scan() is int and not void:

Thanks for review. I will fix this before sending v6.

* Scan all the buses attached to the framework.
+ *
+ * @param void
+ * @return void
+ */
+int rte_eal_bus_scan(void);


Rami Rosen

-
Shreyansh