On Sun,  8 Jan 2017 12:11:35 +0800
Qiming Yang <qiming.y...@intel.com> wrote:

> --- a/examples/ethtool/lib/rte_ethtool.c
> +++ b/examples/ethtool/lib/rte_ethtool.c
> @@ -54,6 +54,9 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct 
> ethtool_drvinfo *drvinfo)
>  
>       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>  
> +     rte_eth_dev_fw_version_get(port_id, drvinfo->fw_version,
> +                           sizeof(drvinfo->fw_version));
> +
>       memset(&dev_info, 0, sizeof(dev_info));
>       rte_eth_dev_info_get(port_id, &dev_info);

That memset is redundant since dev_info_get() does memset as first thing.

Reply via email to