Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: migration from MB library to ISA-L

2016-12-13 Thread Yang, GangX
Tested-by: Yang Gang < gangx.y...@intel.com > - Check patch: success - Apply patch: success - compilation: success OS: fedora21 GCC: gcc_x86-64, 4.8.3 Commit: dpdk-next-crypto( e6c7b6ec57f3527ce55fa3e0d2a8ed1533722253 ) x86_64-native-linuxapp-gcc: compile pass - dts validati

Re: [dpdk-dev] [PATCH] test: adding AES cipher-only tests on QAT PMD

2016-12-13 Thread Yang, GangX
Tested-by: Yang Gang < gangx.y...@intel.com > - Check patch: success - Apply patch: success - compilation: success OS: fedora21 GCC: gcc_x86-64, 4.8.3 Commit: dpdk-next-crypto( e6c7b6ec57f3527ce55fa3e0d2a8ed1533722253 ) x86_64-native-linuxapp-gcc: compile pass - dts validati

Re: [dpdk-dev] [PATCH v3 6/9] examples/ethtool: use ixgbe public function

2016-12-13 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, December 12, 2016 4:25 PM > To: Iremonger, Bernard ; > thomas.monja...@6wind.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 6/9] examples/ethtool: use ixgbe public > function > > On 12/12/2016 1:50 PM, Bernard Ir

Re: [dpdk-dev] [PATCH v3] vhost: allow for many vhost user ports

2016-12-13 Thread Yuanhan Liu
On Mon, Dec 12, 2016 at 05:50:34PM +0100, Jan Wickbom wrote: > Currently select() is used to monitor file descriptors for vhostuser > ports. This limits the number of ports possible to create since the > fd number is used as index in the fd_set and we have seen fds > 1023. > This patch changes sele

Re: [dpdk-dev] [PATCH] vhost: Introduce vhost-user's REPLY_ACK feature

2016-12-13 Thread Yuanhan Liu
On Mon, Dec 12, 2016 at 06:54:00PM +0100, Maxime Coquelin wrote: > REPLY_ACK features provide a generic way for QEMU to ensure both > completion and success of a request. > > As described in vhost-user spec in QEMU repository, QEMU sets > VHOST_USER_NEED_REPLY flag (bit 3) when expecting a reply_a

Re: [dpdk-dev] [PATCH] vhost: Introduce vhost-user's REPLY_ACK feature

2016-12-13 Thread Maxime Coquelin
On 12/13/2016 10:56 AM, Yuanhan Liu wrote: On Mon, Dec 12, 2016 at 06:54:00PM +0100, Maxime Coquelin wrote: REPLY_ACK features provide a generic way for QEMU to ensure both completion and success of a request. As described in vhost-user spec in QEMU repository, QEMU sets VHOST_USER_NEED_REPLY

Re: [dpdk-dev] [PATCH] vhost: Introduce vhost-user's REPLY_ACK feature

2016-12-13 Thread Yuanhan Liu
On Tue, Dec 13, 2016 at 10:57:10AM +0100, Maxime Coquelin wrote: > > > On 12/13/2016 10:56 AM, Yuanhan Liu wrote: > >On Mon, Dec 12, 2016 at 06:54:00PM +0100, Maxime Coquelin wrote: > >>REPLY_ACK features provide a generic way for QEMU to ensure both > >>completion and success of a request. > >>

[dpdk-dev] [PATCH] doc: fix required tools list layout

2016-12-13 Thread Baruch Siach
The Python requirement should appear in the bullet list. Signed-off-by: Baruch Siach --- doc/guides/linux_gsg/sys_reqs.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst index 3d743421595a..621cc9ddaef

Re: [dpdk-dev] [PATCH] vhost: Introduce vhost-user's REPLY_ACK feature

2016-12-13 Thread Maxime Coquelin
On 12/13/2016 11:03 AM, Yuanhan Liu wrote: On Tue, Dec 13, 2016 at 10:57:10AM +0100, Maxime Coquelin wrote: On 12/13/2016 10:56 AM, Yuanhan Liu wrote: On Mon, Dec 12, 2016 at 06:54:00PM +0100, Maxime Coquelin wrote: REPLY_ACK features provide a generic way for QEMU to ensure both completio

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Ananyev, Konstantin
Hi Michal, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > Sent: Tuesday, December 13, 2016 1:08 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict > > Signed-off-by: Michał Mirosław > --- > lib/librte_acl/rte_

Re: [dpdk-dev] [PATCH 05/13] acl: fix acl_flow_data comments

2016-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > Sent: Tuesday, December 13, 2016 1:08 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 05/13] acl: fix acl_flow_data comments > > Signed-off-by: Michał Mirosław > --- > lib/librte_acl/acl_ru

Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities

2016-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > Sent: Tuesday, December 13, 2016 1:08 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities > > From: Paweł Małachowski > > Thanks to that change we can use Nul

[dpdk-dev] [PATCH] doc: correct source extract command

2016-12-13 Thread Baruch Siach
DPDK source archives are .tar.xz or .tar.gz, not .zip. Use .tar.xz in the instructions, since that is what the main download page links to. Also, correct the archive file and directory name capitalization. Signed-off-by: Baruch Siach --- doc/guides/linux_gsg/build_dpdk.rst | 4 ++-- 1 file chan

[dpdk-dev] [PATCH v4 0/7] net/ixgbe: move set VF functions.

2016-12-13 Thread Bernard Iremonger
This patchset implements the following deprecation notice: [PATCH v1] doc: announce API and ABI change for librte_ether Changes in V4: Fixed compile issues when ixgbe PMD is not present. Removed duplicate testpmd commands. Added cleanup patch for testpmd. Updated release note. Changes in V3: Upd

[dpdk-dev] [PATCH v4 1/7] net/ixgbe: move set VF functions from the ethdev

2016-12-13 Thread Bernard Iremonger
Move the following functions from eth_dev_ops to the ixgbe PMD and rename: ixgbe_set_pool_rx_mode ixgbe_set_pool_rx ixgbe_set_pool_tx ixgbe_set_pool_vlan_filter ixgbe_set_vf_rate_limit Rename the functions to the following: rte_pmd_ixgbe_set_vf_rxmode rte_pmd_ixgbe_set_vf_rx rte_pmd_ixgbe_set_vf

[dpdk-dev] [PATCH v4 2/7] app/testpmd: use ixgbe public functions

2016-12-13 Thread Bernard Iremonger
Use the the following ixgbe public functions: rte_pmd_ixgbe_set_vf_rate_limit rte_pmd_ixgbe_set_vf_rx rte_pmd_ixgbe_set_vf_rxmode rte_pmd_ixgbe_set_vf_tx rte_pmd_ixgbe_set_vf_vlan_filter Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 18 +- app/test-pmd/config.c

[dpdk-dev] [PATCH v4 4/7] examples/ethtool: use ixgbe public function

2016-12-13 Thread Bernard Iremonger
Replace rte_eth_dev_set_vf_rxmode with rte_pmd_ixgbe_set_vf_rx_mode. Signed-off-by: Bernard Iremonger --- examples/ethtool/lib/rte_ethtool.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c i

[dpdk-dev] [PATCH v4 3/7] app/testpmd: cleanup parameter checking

2016-12-13 Thread Bernard Iremonger
Parameter checking is done in the rte_pmd_ixgbe_* functions. Remove parameter checking from before calls to the rte_pmd_ixgbe_* functions. Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/app/test-pmd/config.c b/ap

[dpdk-dev] [PATCH v4 5/7] net/ixgbe: remove static set VF functions

2016-12-13 Thread Bernard Iremonger
remove the following static functions: ixgbe_set_pool_rx_mode ixgbe_set_pool_rx ixgbe_set_pool_tx ixgbe_set_pool_vlan_filter ixgbe_set_vf_rate_limit Signed-off-by: Bernard Iremonger --- drivers/net/ixgbe/ixgbe_ethdev.c | 193 --- 1 file changed, 193 deletions

[dpdk-dev] [PATCH v4 6/7] librte_ether: remove the set VF API's

2016-12-13 Thread Bernard Iremonger
remove the following API's: rte_eth_dev_set_vf_rxmode rte_eth_dev_set_vf_rx rte_eth_dev_set_vf_tx rte_eth_dev_set_vf_vlan_filter rte_eth_dev_set_vf_rate_limit Increment LIBABIVER in Makefile Remove deprecation notice for removing rte_eth_dev_set_vf_* API's. Signed-off-by: Bernard Iremonger ---

[dpdk-dev] [PATCH v4 7/7] doc: update release notes

2016-12-13 Thread Bernard Iremonger
Add release note for removing set VF API's from the ethdev, renaming the API's and moving them to the ixgbe PMD. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_17_02.rst | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel

[dpdk-dev] [PATCH] gitignore: ignore top level build/ directory

2016-12-13 Thread Baruch Siach
RTE_OUTPUT defaults to build/. Signed-off-by: Baruch Siach --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index a722abea21fe..7b462d3a0455 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,2 @@ doc/guides/nics/overview_table.txt +/build/ -- 2.10.2

Re: [dpdk-dev] [PATCH] net/qede: fix resource leak

2016-12-13 Thread Ferruh Yigit
On 12/12/2016 7:32 PM, Harish Patil wrote: > >> On 11/30/2016 12:32 PM, Yong Wang wrote: >>> Current code does not close 'fd' on function exit, leaking resources. >>> >>> Signed-off-by: Yong Wang >>> --- >> >> Add new mail address of the maintainer. >> >> CC: Harish Patil >> >> <...> >> > > Ack

Re: [dpdk-dev] [PATCH] net/qede: fix resource leak

2016-12-13 Thread Ferruh Yigit
On 11/30/2016 12:32 PM, Yong Wang wrote: > Current code does not close 'fd' on function exit, leaking resources. > > Signed-off-by: Yong Wang CC: sta...@dpdk.org > --- > drivers/net/qede/qede_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/qede/qede_main.c b/dri

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-13 Thread Ferruh Yigit
On 12/6/2016 3:53 PM, Ferruh Yigit wrote: > On 11/28/2016 11:03 AM, Thomas Monjalon wrote: >> We need attention of every PMD developers on this thread. >> >> Reminder of what Konstantin suggested: >> " >> - if the PMD supports TX offloads AND >> - if to be able use any of these offloads the upper l

Re: [dpdk-dev] [PATCH] gitignore: ignore top level build/ directory

2016-12-13 Thread Ferruh Yigit
On 12/13/2016 11:48 AM, Baruch Siach wrote: > RTE_OUTPUT defaults to build/. > > Signed-off-by: Baruch Siach There is a similar patch: http://dpdk.org/dev/patchwork/patch/11637/ If you want you can review/comment that one too. > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [dpdk-dev] [PATCH v3] vhost: allow for many vhost user ports

2016-12-13 Thread Jan Wickbom
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: den 13 december 2016 10:15 > To: Jan Wickbom > Cc: dev@dpdk.org; Patrik Andersson R > Subject: Re: [PATCH v3] vhost: allow for many vhost user ports > > On Mon, Dec 12, 2016 at 05:50:34PM +0100, Jan W

[dpdk-dev] [PATCH v4] vhost: allow for many vhost user ports

2016-12-13 Thread Jan Wickbom
Currently select() is used to monitor file descriptors for vhostuser ports. This limits the number of ports possible to create since the fd number is used as index in the fd_set and we have seen fds > 1023. This patch changes select() to poll(). This way we can keep an packed (pollfd) array for the

[dpdk-dev] [PATCH v2 01/12] eal: define container_of macro

2016-12-13 Thread Shreyansh Jain
From: Jan Blunck This macro is based on Jan Viktorin's original patch but also checks the type of the passed pointer against the type of the member. Signed-off-by: Jan Viktorin [shreyansh.j...@nxp.com: Fix checkpatch error] Signed-off-by: Shreyansh Jain [jblu...@infradead.org: add type checkin

[dpdk-dev] [PATCH v2 00/12] Introducing EAL Bus-Device-Driver Model

2016-12-13 Thread Shreyansh Jain
Link to v1: [10] :: Introduction :: DPDK has been inherently a PCI inclined framework. Because of this, the design of device tree (or list) within DPDK is also PCI inclined. A non-PCI device doesn't have a way of being expressed without using hooks started from EAL to PMD. (Check 'Version Change

[dpdk-dev] [PATCH v2 02/12] eal/bus: introduce bus abstraction

2016-12-13 Thread Shreyansh Jain
This patch introduces the rte_bus abstraction for devices and drivers in EAL framework. The model is: - One or more buses are connected to a CPU (or core) - One or more devices are conneted to a Bus - Drivers are running instances which manage one or more devices - Bus is responsible for identi

[dpdk-dev] [PATCH v2 04/12] eal/bus: add scan, match and insert support

2016-12-13 Thread Shreyansh Jain
When a PMD is registred, it will associate itself with a bus. A bus is responsible for 'scan' of all the devices attached to it. All the scanned devices are attached to bus specific device_list. During the probe operation, 'match' of the drivers and devices would be done. Also, rather than adding

[dpdk-dev] [PATCH v2 03/12] test: add basic bus infrastructure tests

2016-12-13 Thread Shreyansh Jain
Verification of bus registration, driver registration on a bus. Signed-off-by: Shreyansh Jain --- app/test/Makefile | 2 +- app/test/test.h | 2 + app/test/test_bus.c | 423 3 files changed, 426 insertions(+), 1 deletion(-) create m

[dpdk-dev] [PATCH v2 05/12] eal: integrate bus scan and probe with EAL

2016-12-13 Thread Shreyansh Jain
Still a dummy implementation as no real bus driver exists. This adds calls from EAL to bus specific scan, match functions. Once driver->probe is in place, and a bus handler has been installed, the code would become effective. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c

[dpdk-dev] [PATCH v2 06/12] eal: add probe and remove support for rte_driver

2016-12-13 Thread Shreyansh Jain
rte_driver now supports probe and remove. These would be used for generic device type (PCI, etc) probe and remove. Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_dev.h | 12 1 file changed, 12 insertions(+) diff --git a/lib/librte_eal/common/include/rte_dev.h

[dpdk-dev] [PATCH v2 07/12] eal: enable probe from bus infrastructure

2016-12-13 Thread Shreyansh Jain
The model is: rte_eal_init `--> calls rte_eal_bus_probe() This iterates over all the drivers and devices and matches them. For matched bus specific device-driver and calls: `-> rte_driver->probe() for all matched device/drivers (rte_bus->match() successful) T

[dpdk-dev] [PATCH v2 08/12] pci: split match and probe function

2016-12-13 Thread Shreyansh Jain
Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitting the matching function into rte_eal_pci_match. Signed-off-by: Shreyansh Jain -- v2: - Change default return in ma

[dpdk-dev] [PATCH v2 09/12] eal/pci: generalize args of PCI scan/match towards RTE device/driver

2016-12-13 Thread Shreyansh Jain
PCI scan and match now work on rte_device/rte_driver rather than PCI specific objects. These functions can now be plugged to the generic bus callbacks for scanning and matching devices/drivers. Signed-off-by: Shreyansh Jain --- app/test/test_pci.c | 2 +- lib/librte_eal/bsda

[dpdk-dev] [PATCH v2 12/12] drivers: update PMDs to use rte_driver probe and remove

2016-12-13 Thread Shreyansh Jain
These callbacks now act as first layer of PCI interfaces from the Bus. Bus probe would enter the PMDs through the rte_driver->probe/remove callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the drivers are rte_pci_driver). Signed-off-by: Shreyansh Jain --- drivers/net/bnx2x/bnx2x

[dpdk-dev] [PATCH v2 11/12] eal: enable PCI bus

2016-12-13 Thread Shreyansh Jain
Register a PCI bus with Scan/match and probe callbacks. Necessary changes in EAL layer for enabling bus interfaces. PCI devices and drivers now reside within the Bus object. Now that PCI bus handles the scan/probe methods, independent calls to PCI scan and probe can be removed from the code. PCI d

[dpdk-dev] [PATCH v2 10/12] pci: Pass rte_pci_addr to functions instead of separate args

2016-12-13 Thread Shreyansh Jain
From: Ben Walker Instead of passing domain, bus, devid, func, just pass an rte_pci_addr. Signed-off-by: Ben Walker [Shreyansh: Checkpatch error fix] Signed-off-by: Shreyansh Jain --- lib/librte_eal/linuxapp/eal/eal_pci.c | 33 ++--- 1 file changed, 14 insertions(+)

Re: [dpdk-dev] [PATCH v4 0/7] net/ixgbe: move set VF functions.

2016-12-13 Thread Ferruh Yigit
On 12/13/2016 11:40 AM, Bernard Iremonger wrote: > This patchset implements the following deprecation notice: > [PATCH v1] doc: announce API and ABI change for librte_ether > > Changes in V4: > Fixed compile issues when ixgbe PMD is not present. > Removed duplicate testpmd commands. > Added clean

[dpdk-dev] [PATCH] doc: fix environment variable typo

2016-12-13 Thread Baruch Siach
Signed-off-by: Baruch Siach --- doc/guides/sample_app_ug/ethtool.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/sample_app_ug/ethtool.rst b/doc/guides/sample_app_ug/ethtool.rst index 4d1697e8a050..67797954d740 100644 --- a/doc/guides/sample_app_ug/ethtool.rst

Re: [dpdk-dev] [PATCH v2 25/32] app/testpmd: handle i40e in VF VLAN filter command

2016-12-13 Thread Ferruh Yigit
Hi Wenzhuo, On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > modify set_vf_rx_vlan function to handle the i40e PMD. > > Signed-off-by: Bernard Iremonger > --- Latest applied patches [1] conflict with some testpmd patches of this patchset. Can you please rebase this patchset on top of the latest next-

Re: [dpdk-dev] [PATCH v4 0/7] net/ixgbe: move set VF functions.

2016-12-13 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, December 13, 2016 1:37 PM > To: Iremonger, Bernard ; > thomas.monja...@6wind.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 0/7] net/ixgbe: move set VF functions. > > On 12/13/2016 11:40 AM, Bernard Iremonger w

[dpdk-dev] fm10k pmd limitations

2016-12-13 Thread Shaham Fridenberg
Hey guys, I'm using dpdk 16.4 and fm10k card. According to the code, there's no support for disabling vlan stripping and VLAN QinQ in pmd fm10k. Does anybody know why? If there's any way to work-around it, or when is a behavior change expected? I need my VF to receive the packets with the VLAN

Re: [dpdk-dev] [PATCH v2 12/12] drivers: update PMDs to use rte_driver probe and remove

2016-12-13 Thread Andrew Rybchenko
On 12/13/2016 04:37 PM, Shreyansh Jain wrote: These callbacks now act as first layer of PCI interfaces from the Bus. Bus probe would enter the PMDs through the rte_driver->probe/remove callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the drivers are rte_pci_driver). I think si

Re: [dpdk-dev] [PATCH v12] net/tap: new TUN/TAP device PMD

2016-12-13 Thread Ferruh Yigit
On 12/12/2016 2:38 PM, Keith Wiles wrote: > The PMD allows for DPDK and the host to communicate using a raw > device interface on the host and in the DPDK application. The device > created is a Tap device with a L2 packet header. > > v12- Fixup minor changes for driver_name and version number > v1

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Michal Miroslaw
On Tue, Dec 13, 2016 at 10:36:16AM +, Ananyev, Konstantin wrote: > Hi Michal, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > > Sent: Tuesday, December 13, 2016 1:08 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 04/13] acl: a

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > Sent: Tuesday, December 13, 2016 1:55 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict > > On Tue, Dec 13, 2016 at 10:36:16AM +, Ananyev, Ko

Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities

2016-12-13 Thread Michal Miroslaw
On Tue, Dec 13, 2016 at 10:48:32AM +, Ananyev, Konstantin wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > > Sent: Tuesday, December 13, 2016 1:08 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 06/13] null: fake PMD capabil

Re: [dpdk-dev] [PATCH v2 17/32] net/i40e: set VF broadcast mode from PF

2016-12-13 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 2:33 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v2 17/32] net/i40e: set VF broadcast mode > from PF > > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: >

Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities

2016-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > Sent: Tuesday, December 13, 2016 2:27 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities > > On Tue, Dec 13, 2016 at 10:48:32AM +, Ananyev

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Michal Miroslaw
On Tue, Dec 13, 2016 at 02:14:19PM +, Ananyev, Konstantin wrote: > > -Original Message- > > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > > Sent: Tuesday, December 13, 2016 1:55 PM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 04/13] acl

Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities

2016-12-13 Thread Michal Miroslaw
On Tue, Dec 13, 2016 at 02:37:34PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > > Sent: Tuesday, December 13, 2016 2:27 PM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 06/1

Re: [dpdk-dev] [PATCH v2 12/12] drivers: update PMDs to use rte_driver probe and remove

2016-12-13 Thread Ferruh Yigit
On 12/13/2016 1:52 PM, Andrew Rybchenko wrote: > On 12/13/2016 04:37 PM, Shreyansh Jain wrote: >> These callbacks now act as first layer of PCI interfaces from the Bus. >> Bus probe would enter the PMDs through the rte_driver->probe/remove >> callbacks, falling to rte_xxx_driver->probe/remove (Curr

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > Sent: Tuesday, December 13, 2016 2:53 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict > > On Tue, Dec 13, 2016 at 02:14:19PM +, Ananyev, Ko

Re: [dpdk-dev] [PATCH] SDK: Add scripts to initialize DPDK runtime

2016-12-13 Thread Christian Ehrhardt
Stefans mail got rejected by moderator (??!), reposting FYI as I'm subscribed and should autopass the moderation. On Tue, Dec 13, 2016 at 3:45 PM, Stefan Bader wrote: > On 13.12.2016 08:00, Christian Ehrhardt wrote: > > > > On Mon, Dec 12, 2016 at 10:58 PM, Luca Boccassi >

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Michal Miroslaw
On Tue, Dec 13, 2016 at 03:13:42PM +, Ananyev, Konstantin wrote: [...] > > > > > > Subject: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict > > > > > > > > > > > > Signed-off-by: Michał Mirosław > > > > > > --- > > > > > > lib/librte_acl/rte_acl.c | 3 +-- > > > > > > lib/librte_acl/

Re: [dpdk-dev] [PATCH v2 09/13] PMD/af_packet: guard against buffer overruns in TX path

2016-12-13 Thread John W. Linville
On Tue, Dec 13, 2016 at 02:28:34AM +0100, Michał Mirosław wrote: > Signed-off-by: Michał Mirosław Acked-by: John W. Linville > --- > drivers/net/af_packet/rte_eth_af_packet.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/af_packet/r

Re: [dpdk-dev] [PATCH v2 08/13] PMD/af_packet: guard against buffer overruns in RX path

2016-12-13 Thread John W. Linville
On Tue, Dec 13, 2016 at 02:28:34AM +0100, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław Acked-by: John W. Linville > --- > drivers/net/af_packet/rte_eth_af_packet.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/af_packet/rte_eth_

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Michal Miroslaw
On Tue, Dec 13, 2016 at 05:14:09PM +0100, Michal Miroslaw wrote: > On Tue, Dec 13, 2016 at 03:13:42PM +, Ananyev, Konstantin wrote: [...] > > > Dear Konstantin, > > > > > > Can you describe how the ACL code treats zero specially? I could not find > > > anything, really. The only thing I found

[dpdk-dev] [PATCH v2] SDK: Add scripts to initialize DPDK runtime

2016-12-13 Thread Luca Boccassi
From: Christian Ehrhardt A tools/init directory is added with dpdk-init, a script that can be used to initialize a DPDK runtime environment. 2 config files with default options, dpdk.conf and interfaces, are provided as well together with a SysV init script and a systemd service unit. v2: relice

Re: [dpdk-dev] [PATCH 20/31] app/testpmd: use VFD APIs on i40e

2016-12-13 Thread Ferruh Yigit
On 12/2/2016 12:12 AM, Wenzhuo Lu wrote: > The new VF Daemon (VFD) APIs is implemented on i40e. Change > testpmd code to use them, inlcuding VF MAC anti-spoofing, > VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN > insert. > > Signed-off-by: Wenzhuo Lu > Signed-off-by: Chen Jing D(Mark

Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities

2016-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > Sent: Tuesday, December 13, 2016 2:58 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities > > On Tue, Dec 13, 2016 at 02:37:34PM +, Ananyev

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > Sent: Tuesday, December 13, 2016 4:14 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict > > On Tue, Dec 13, 2016 at 03:13:42PM +, Ananyev, Ko

Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities

2016-12-13 Thread Ferruh Yigit
On 12/13/2016 5:12 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] >> Sent: Tuesday, December 13, 2016 2:58 PM >> To: Ananyev, Konstantin >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 06/13] null: fake PMD capabil

[dpdk-dev] [PATCH v13 0/7] add Tx preparation

2016-12-13 Thread Tomasz Kulasek
As discussed in that thread: http://dpdk.org/ml/archives/dev/2015-September/023603.html Different NIC models depending on HW offload requested might impose different requirements on packets to be TX-ed in terms of: - Max number of fragments per packet allowed - Max number of fragments per TSO

[dpdk-dev] [PATCH v13 1/7] ethdev: add Tx preparation

2016-12-13 Thread Tomasz Kulasek
Added API for `rte_eth_tx_prepare` uint16_t rte_eth_tx_prepare(uint8_t port_id, uint16_t queue_id, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) Added fields to the `struct rte_eth_desc_lim`: uint16_t nb_seg_max; /**< Max number of segments per whole packet. */

[dpdk-dev] [PATCH v13 2/7] e1000: add Tx preparation

2016-12-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/e1000/e1000_ethdev.h | 11 drivers/net/e1000/em_ethdev.c|5 +++- drivers/net/e1000/em_rxtx.c | 48 ++- drivers/net/e1000/igb_ethdev.c |4 +++ drivers/net/e10

[dpdk-dev] [PATCH v13 3/7] fm10k: add Tx preparation

2016-12-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/fm10k/fm10k.h|6 + drivers/net/fm10k/fm10k_ethdev.c |5 drivers/net/fm10k/fm10k_rxtx.c | 50 +- 3 files changed, 60 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v13 4/7] i40e: add Tx preparation

2016-12-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/i40e/i40e_ethdev.c |3 ++ drivers/net/i40e/i40e_rxtx.c | 74 +++- drivers/net/i40e/i40e_rxtx.h |8 + 3 files changed, 84 insertions(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH v13 5/7] ixgbe: add Tx preparation

2016-12-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c |3 ++ drivers/net/ixgbe/ixgbe_ethdev.h |5 +++- drivers/net/ixgbe/ixgbe_rxtx.c | 56 ++ drivers/net/ixgbe/ixgbe_rxtx.h |2 ++ 4 files changed, 65

[dpdk-dev] [PATCH v13 6/7] vmxnet3: add Tx preparation

2016-12-13 Thread Tomasz Kulasek
From: "Ananyev, Konstantin" Signed-off-by: Konstantin Ananyev --- drivers/net/vmxnet3/vmxnet3_ethdev.c |4 +++ drivers/net/vmxnet3/vmxnet3_ethdev.h |2 ++ drivers/net/vmxnet3/vmxnet3_rxtx.c | 57 ++ 3 files changed, 63 insertions(+) diff --git a/driv

[dpdk-dev] [PATCH v13 7/7] testpmd: use Tx preparation in csum engine

2016-12-13 Thread Tomasz Kulasek
Added "csum txprep (on|off)" command which allows to switch to the tx path using Tx preparation API. By default unchanged implementation is used. Using Tx preparation path, pseudo header calculation for udp/tcp/tso packets from application, and used Tx preparation API for packet preparation and v

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Michal Miroslaw
On Tue, Dec 13, 2016 at 05:27:31PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > > Sent: Tuesday, December 13, 2016 4:14 PM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 04/1

Re: [dpdk-dev] [PATCH v13 6/7] vmxnet3: add Tx preparation

2016-12-13 Thread Yong Wang
Looks good and two nits below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Tuesday, December 13, 2016 9:42 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH v13 6/7] vmxnet3: add Tx preparation > > From: "A

Re: [dpdk-dev] [PATCH 02/13] mbuf: rte_pktmbuf_free_bulk()

2016-12-13 Thread Stephen Hemminger
On Tue, 13 Dec 2016 02:08:15 +0100 (CET) Michał Mirosław wrote: > Signed-off-by: Michał Mirosław > > --- > lib/librte_mbuf/rte_mbuf.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index ead7c6e..a95d99f 1006

Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict

2016-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > Sent: Tuesday, December 13, 2016 6:03 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 04/13] acl: allow zero verdict > > On Tue, Dec 13, 2016 at 05:27:31PM +, Ananyev, Ko

Re: [dpdk-dev] [PATCH v2 01/12] eal: define container_of macro

2016-12-13 Thread Jan Blunck
On Tue, Dec 13, 2016 at 2:37 PM, Shreyansh Jain wrote: > From: Jan Blunck > > This macro is based on Jan Viktorin's original patch but also checks the > type of the passed pointer against the type of the member. > > Signed-off-by: Jan Viktorin > [shreyansh.j...@nxp.com: Fix checkpatch error] > S

Re: [dpdk-dev] [PATCH v2 25/32] app/testpmd: handle i40e in VF VLAN filter command

2016-12-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, December 13, 2016 9:41 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v2 25/32] app/testpmd: handle i40e in VF VLAN > filter command > > Hi Wenzhuo, > > On 12/7/2016 3:32

Re: [dpdk-dev] [PATCH 20/31] app/testpmd: use VFD APIs on i40e

2016-12-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 14, 2016 12:57 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Chen, Jing D; Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH 20/31] app/testpmd: use VFD APIs on i40e > > On 12/2/2016 12:12 AM, Wenzhuo Lu wrote

Re: [dpdk-dev] [PATCH] doc: fix environment variable typo

2016-12-13 Thread Remy Horton
On 13/12/2016 21:40, Baruch Siach wrote: Signed-off-by: Baruch Siach --- doc/guides/sample_app_ug/ethtool.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Missing fixline Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") Otherwise, well spotted.

[dpdk-dev] [PATCH 01/28] eal: introduce I/O device memory barriers

2016-12-13 Thread Jerin Jacob
This commit introduce rte_io_mb(), rte_io_wmb() and rte_io_rmb(), in order to enable memory barriers between I/O device and CPU. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/generic/rte_atomic.h | 27 ++ 1 file changed, 27 insertions(+) diff --git a/lib/librt

[dpdk-dev] [PATCH 00/28] introduce I/O device memory read/write operations

2016-12-13 Thread Jerin Jacob
Based on the disussion in the below-mentioned thread, http://dev.dpdk.narkive.com/DpIRqDuy/dpdk-dev-patch-v2-i40e-fix-eth-i40e-dev-init-sequence-on-thunderx This patchset introduces 8-bit, 16-bit, 32bit, 64bit I/O device memory read/write operations along with the relaxed versions. The weakly-ord

[dpdk-dev] [PATCH 02/28] eal/x86: define I/O device memory barriers for IA

2016-12-13 Thread Jerin Jacob
The patch does not provide any functional change for IA. I/O barriers are mapped to existing smp barriers. Signed-off-by: Jerin Jacob CC: Bruce Richardson CC: Konstantin Ananyev --- lib/librte_eal/common/include/arch/x86/rte_atomic.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/li

[dpdk-dev] [PATCH 05/28] eal/arm: separate smp barrier definition for ARMv7 and ARMv8

2016-12-13 Thread Jerin Jacob
Separate the smp barrier definition for arm and arm64 for fine control on smp barrier definition for each architecture. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_atomic.h| 6 -- lib/librte_eal/common/include/arch/arm/rte_atomic_32.h | 6 ++ lib/librte_

[dpdk-dev] [PATCH 03/28] eal/tile: define I/O device memory barriers for tile

2016-12-13 Thread Jerin Jacob
The patch does not provide any functional change for tile. I/O barriers are mapped to existing smp barriers. Signed-off-by: Jerin Jacob CC: Zhigang Lu --- lib/librte_eal/common/include/arch/tile/rte_atomic.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/common/include

[dpdk-dev] [PATCH 04/28] eal/ppc64: define I/O device memory barriers for ppc64

2016-12-13 Thread Jerin Jacob
The patch does not provide any functional change for ppc_64. I/O barriers are mapped to existing smp barriers. Signed-off-by: Jerin Jacob CC: Chao Zhu --- lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/common/inclu

[dpdk-dev] [PATCH 06/28] eal/armv7: define I/O device memory barriers for ARMv7

2016-12-13 Thread Jerin Jacob
The patch does not provide any functional change for ARMv7. I/O barriers are mapped to existing smp barriers. Signed-off-by: Jerin Jacob CC: Jan Viktorin CC: Jianbo Liu --- lib/librte_eal/common/include/arch/arm/rte_atomic_32.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/libr

[dpdk-dev] [PATCH 07/28] eal/arm64: fix memory barrier definition for arm64

2016-12-13 Thread Jerin Jacob
dsb instruction based barrier is used for non smp version of memory barrier. Fixes: d708f01b7102 ("eal/arm: add atomic operations for ARMv8") Signed-off-by: Jerin Jacob CC: Jianbo Liu CC: sta...@dpdk.org --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 9 + 1 file changed,

[dpdk-dev] [PATCH 09/28] eal/arm64: define I/O device memory barriers for arm64

2016-12-13 Thread Jerin Jacob
Signed-off-by: Jerin Jacob CC: Jianbo Liu --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h index 78ebea2..ef0efc7 1

[dpdk-dev] [PATCH 08/28] eal/arm64: define smp barrier definition for arm64

2016-12-13 Thread Jerin Jacob
dmb instruction based barrier is used for smp version of memory barrier. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/l

[dpdk-dev] [PATCH 10/28] eal: introduce I/O device memory read/write operations

2016-12-13 Thread Jerin Jacob
This commit introduces 8-bit, 16-bit, 32bit, 64bit I/O device memory read/write operations along with the relaxed versions. The weakly-ordered machine like ARM needs additional I/O barrier for device memory read/write access over PCI bus. By introducing the eal abstraction for I/O device memory re

[dpdk-dev] [PATCH 13/28] eal/arm64: override I/O device read/write access for arm64

2016-12-13 Thread Jerin Jacob
Override the generic I/O device memory read/write access and implement it using armv8 instructions for arm64. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_io.h| 4 + lib/librte_eal/common/include/arch/arm/rte_io_64.h | 183 + 2 files changed

[dpdk-dev] [PATCH 11/28] eal: generic implementation for I/O device read/write access

2016-12-13 Thread Jerin Jacob
This patch implements the generic version of rte_read[b/w/l/q]_[relaxed] and rte_write[b/w/l/q]_[relaxed] using rte_io_wmb() and rte_io_rmb() Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/generic/rte_io.h | 54 ++ 1 file changed, 54 insertions(+) diff --gi

[dpdk-dev] [PATCH 16/28] net/bnxt: use eal I/O device memory read/write API

2016-12-13 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob CC: Stephen Hurd CC: Ajit Khaparde --- dri

[dpdk-dev] [PATCH 15/28] net/bnx2x: use eal I/O device memory read/write API

2016-12-13 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob CC: Harish Patil CC: Rasesh Mody --- drive

[dpdk-dev] [PATCH 14/28] crypto/qat: use eal I/O device memory read/write API

2016-12-13 Thread Jerin Jacob
From: Santosh Shukla Replace the raw I/O device memory read/write access with eal abstraction for I/O device memory read/write access to fix portability issues across different architectures. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob CC: John Griffin CC: Fiona Trahe CC: Deepak

[dpdk-dev] [PATCH 12/28] eal: let all architectures use generic I/O implementation

2016-12-13 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_io.h| 47 ++ lib/librte_eal/common/include/arch/ppc_64/rte_io.h | 47 ++ lib/librte_eal/common/include/arch/tile/rte_io.h | 47 ++ lib/librte_eal/common/incl

  1   2   >